2008/6/16 Jerry Van Baren gerald.vanbaren@ge.com:
Michal Simek wrote:
Hi Antonio
I am not responsible for this part of U-BOOT but your patch contain coding style violation.
Regards, Michal Simek
Logic unit:
Purpose: Add support for bare partitions (no partition table) Author: Antnoio R. Costa <antonio.costa <at> atmel.com> Date : 11 Jun 2008
Status:
Some SD cards are not formatted with a partition table but with just a bare partition at the beginnig of the memory. I modified get_partition_info_extended to call test_block_type as done by print_partition_extended. In this way bare FAT partitions are recognised. Now we need a test for Ext2. Signed-off-by: Antonio R. Costa <antonio.costa@atmel.com> diff --git a/disk/part_dos.c b/disk/part_dos.c index 4d778ec..e5cc8aa 100644 --- a/disk/part_dos.c +++ b/disk/part_dos.c[snip]
+static inline int le16_to_int(unsigned char *le16)
+{
- return ((le16[1] << 8) + le16[0]);
+}
this should be in header file
Please use <asm/byteorder.h> rather than making Yet Another Define. Note that the subdirectory asm gets symlinked to the appropriate arch-specific subdirectory and then the right endian munching is selected and it Just Works[tm].
PowerPC example: < http://git.denx.de/?p=u-boot.git;a=blob;f=include/asm-ppc/byteorder.h;h=3f5b...
Telling the truth it seems that I've used this function during debug in fact at a deeper look it seems it disappeared from the code a part the definition. Ok I'm going to fix the problem and re-submit.
In these cases is there a special manner to format the subject to make an explicit reference to a patched patch :) ?
Regards, Antonio
[snip]
Regards,
Michal Simek
Thanks, gvb