November 2024 - U-Boot

[PATCH v2 0/6] efi_loader: run bootdev_hunt() to find ESP
by Heinrich Schuchardt 14 Jan '25

14 Jan '25

When initializing the EFI sub-system we need all block devices and the NIC to be probed. Extensions should have been applied to the device-tree. Our current implementation only guarantees that bound block devices are probed. But this misses out devices where binding requires specific routines to be executed, e.g. NVMe (nvme scan), SCSI (scsi start). Invoking bootdev_hunt() allows to find all block devices, probe the network nic, and enable extensions. Reviewers complained that PXE boot was executed unexpectedly with a patch that only added the bootdev_hunt() call to the EFI sub-system initialization. The EFI sub-system does not require the IP address to be set up. We can reduce the boottime by not executing dchp_run() in eth_bootdev_hunt(). Furthermore on the legacy network stack with autostart=yes dhcp_run() tries to download the boot file via TFTP and execute it which seems to be a problem with non-observance of autoload=no. To fix Gitlab CI issues the following changes are necessary: In test_extension.py do not assume that extensions have not been loaded by bootdev hunter in a previous test. Remove CONFIG_AMIGA_PARTITION from sandbox_deconfig to avoid a timeout. Remove CONFIG_USB_DWC3 on the CI from xilinx_versal_virt_defconfig to avoid a boot failure. Add a parameter '-e' to select if UEFI boot options shall be shown by the bootmenu command. v2: disable USB_DWC3 only in CI update commit message for eth_bootdev_hunt() change Heinrich Schuchardt (6): test: fix test_extension.py configs: sandbox_deconfig: remove CONFIG_AMIGA_PARTITION CI: xilinx_versal_virt: disable USB_DWC3 net: eth_bootdev_hunt() must not try to boot cmd: bootmenu: add parameter -e for UEFI boot options efi_loader: run bootdev_hunt() to find ESP .azure-pipelines.yml | 1 + .gitlab-ci.yml | 1 + cmd/bootmenu.c | 39 +++++++++++++++++++++++++-------- configs/sandbox_defconfig | 1 - doc/usage/cmd/bootmenu.rst | 13 ++++++++--- lib/efi_loader/efi_setup.c | 8 +++++++ net/eth_bootdev.c | 30 +++++++++++++++---------- test/py/tests/test_extension.py | 4 +++- 8 files changed, 71 insertions(+), 26 deletions(-) -- 2.45.2

5 23

[PATCH 00/18] x86: Improve operation under QEMU
by Simon Glass 10 Jan '25

10 Jan '25

U-Boot can start and boot an OS in both qemu-x86 and qemu-x86_64 but it is not perfect. With both builds, executing the VESA ROM causes an intermittent hang, at least on some AMD CPUs. With qemu-x86_64 kvm cannot be used since the move to long mode (64-bit) is done in a way that works on real hardware but not with QEMU. This means that performance is 4-5x slower than it could be, at least on my CPU. We can work around the first problem by using Bochs, which is anyway a better choice than VESA for QEMU. But this results in the Ubuntu installer failing to boot via EFI. It isn't clear whether this due to a problem with the UEFI GOP, or something else. It hangs before the Ubuntu logo appears. So this series is unfinished. I thought it best to post what is here in the hope that others can help work out the kinks. Simon Glass (18): scripts: Add a script for building and booting QEMU x86: Expand x86_64 early memory RFC: x86: qemu: Switch to bochs display x86: qemu: Enable dhrystone x86: qemu: Avoid accessing BSS too early x86: Drop mpspec from the SPL build x86: Add some log categories x86: Drop use of CONFIG_REALMODE_DEBUG x86: Avoid clearing the VESA display x86: Add 64-bit entries to the GDT x86: Use defines for the cache flags x86: spl: Drop duplicate CPU init x86: Drop the message about features missing in 64-bit x86: Include stdbool.h in interrupt header x86: Tidy up the GDT size in start/16.S x86: Disable paging before changing to long mode x86: Use the same GDT when jumping to long mode x86: Use a simple jump into long mode MAINTAINERS | 8 ++ arch/x86/cpu/i386/call64.S | 35 +++---- arch/x86/cpu/i386/cpu.c | 18 +++- arch/x86/cpu/qemu/qemu.c | 20 ++-- arch/x86/cpu/start.S | 4 +- arch/x86/cpu/start16.S | 3 +- arch/x86/include/asm/interrupt.h | 1 + arch/x86/include/asm/processor.h | 5 +- arch/x86/lib/Makefile | 2 + arch/x86/lib/bios.c | 27 +++-- arch/x86/lib/bios_interrupts.c | 8 +- arch/x86/lib/i8259.c | 2 + arch/x86/lib/spl.c | 4 +- configs/qemu-x86_64_defconfig | 10 +- configs/qemu-x86_defconfig | 6 +- doc/board/emulation/index.rst | 1 + doc/board/emulation/script.rst | 61 +++++++++++ scripts/build-qemu.sh | 175 +++++++++++++++++++++++++++++++ 18 files changed, 331 insertions(+), 59 deletions(-) create mode 100644 doc/board/emulation/script.rst create mode 100755 scripts/build-qemu.sh -- 2.34.1

3 31

[PATCH v3 0/3] rockchip: rk35xx: Implement checkboard() to print SoC variant
by Jonas Karlman 10 Jan '25

10 Jan '25

Information about what SoC model and variant can be found in OTP. This series use this information in checkboard() to print out the running SoC model and variant, should match what is printed on the SoC. There are some asumptions taken on how some of the OTP values are encoded, however for my boards this seem to match and something like one of the following is shown with this applied: SoC: RK3566 SoC: RK3566T SoC: RK3568 SoC: RK3568B2 SoC: RK3568J SoC: RK3582 SoC: RK3588 SoC: RK3588S SoC: RK3588S2 SoC: RK3308B SoC: RK3308B-S Changes in v3: - Fix build issue with MISC=n or ROCKCHIP_OTP=n - Remove use of cpu-version - Use log_debug() instead of debug() Changes in v2: - Drop changes in generic-rk35xx_defconfig - Update code comments - Add patch for rk3308 This can probably be converted into an sysinfo driver in a future series, once other pending changes to sysinfo core have settled. Jonas Karlman (3): rockchip: rk356x: Implement checkboard() to print SoC variant rockchip: rk3588: Implement checkboard() to print SoC variant rockchip: rk3308: Implement checkboard() to print SoC variant arch/arm/dts/rk356x-u-boot.dtsi | 4 ++ arch/arm/dts/rk3588s-u-boot.dtsi | 4 ++ arch/arm/mach-rockchip/rk3308/rk3308.c | 16 +++++++ arch/arm/mach-rockchip/rk3568/rk3568.c | 61 ++++++++++++++++++++++++++ arch/arm/mach-rockchip/rk3588/rk3588.c | 52 ++++++++++++++++++++++ 5 files changed, 137 insertions(+) -- 2.46.2

3 8

[PATCH v2 0/4] rockchip: rk3288: Include files from dts/upstream
by Jonas Karlman 10 Jan '25

10 Jan '25

This series remove common rk3288 related device tree files that instead can be included directly from dts/upstream. No functional change to board DTs is intended with these removals. Changes in v2: - Keep code for use of gmac internal clock source - Collect r-b tags Jonas Karlman (4): rockchip: rk3288: Use rk3288-power.h from dts/upstream rockchip: clk: rk3288: Drop use of SCLK_MAC_PLL rockchip: rk3288: Use rk3288-cru.h from dts/upstream rockchip: rk3288: Use rk3288.dtsi from dts/upstream arch/arm/dts/rk3288-u-boot.dtsi | 9 - arch/arm/dts/rk3288.dtsi | 2035 ----------------- .../clock/rockchip,rk3288-cru.txt | 61 - drivers/clk/rockchip/clk_rk3288.c | 8 +- include/dt-bindings/clock/rk3288-cru.h | 381 --- include/dt-bindings/power/rk3288-power.h | 32 - 6 files changed, 4 insertions(+), 2522 deletions(-) delete mode 100644 arch/arm/dts/rk3288.dtsi delete mode 100644 doc/device-tree-bindings/clock/rockchip,rk3288-cru.txt delete mode 100644 include/dt-bindings/clock/rk3288-cru.h delete mode 100644 include/dt-bindings/power/rk3288-power.h -- 2.46.2

2 5

[PATCH v1 0/6] Enable SYS_64BIT_LBA flag for STM32MP
by Patrice Chotard 08 Jan '25

08 Jan '25

Enable SYS_64BIT_LBA flag in order to fix issue when flashing big binary using stm32prog. Patrice Chotard (6): fastboot: Fix warning when CONFIG_SYS_64BIT_LBA is enable arm: stm32mp: stm32prog: fix warning when CONFIG_SYS_64BIT_LBA is enable arm: stm32mp: stm32prog: update multiplier is part-size is above SZ_1G configs: stm32mp13: enable CONFIG_SYS_64BIT_LBA configs: stm32mp15: enable CONFIG_SYS_64BIT_LBA configs: stm32mp25: enable CONFIG_SYS_64BIT_LBA arch/arm/mach-stm32mp/cmd_stm32prog/stm32prog.c | 9 ++++++--- configs/stm32mp13_defconfig | 1 + configs/stm32mp15_basic_defconfig | 1 + configs/stm32mp15_defconfig | 1 + configs/stm32mp15_trusted_defconfig | 1 + configs/stm32mp25_defconfig | 1 + drivers/fastboot/fb_mmc.c | 8 ++++---- 7 files changed, 15 insertions(+), 7 deletions(-) -- 2.25.1

4 14

[PATCH] ARM: dts: stm32mp13: Add support of ck_usbo_48m in pre-reloc stage
by Patrice Chotard 08 Jan '25

08 Jan '25

From: Patrick Delaunay <patrick.delaunay(a)foss.st.com> The clock ck_usbo_48m is a clock source for RCC, so the ck_usbo_48m clock provided by usbphyc need to be probed when RCC clock driver is required, in pre-reloc stage. This patch allow to remove the following warning: clk_register: failed to get ck_usbo_48m device (parent of usbo_k) Signed-off-by: Patrick Delaunay <patrick.delaunay(a)foss.st.com> Signed-off-by: Patrice Chotard <patrice.chotard(a)foss.st.com> --- arch/arm/dts/stm32mp13-u-boot.dtsi | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/arch/arm/dts/stm32mp13-u-boot.dtsi b/arch/arm/dts/stm32mp13-u-boot.dtsi index aa5cfc6e41d..af7edc7e2b2 100644 --- a/arch/arm/dts/stm32mp13-u-boot.dtsi +++ b/arch/arm/dts/stm32mp13-u-boot.dtsi @@ -111,3 +111,8 @@ &syscfg { bootph-all; }; + +&usbphyc { + /* stm32-usbphyc-clk = ck_usbo_48m is a source clock of RCC CCF */ + bootph-all; +}; -- 2.25.1

2 1

[PATCH 00/15] qcom: smem: modernize SMEM in U-Boot
by Caleb Connolly 08 Jan '25

08 Jan '25

Smem is currently implemented a uclass in U-Boot. This carries with it some implicit limitations about how and when we can actually talk with it, since its modelled as a device. The SMEM uclass is qualcomm specific and has no other users, while it was originally proposed as a platform agnostic abstraction it seems clear that UCLASS_MISC has served that purpose better. Let's drop the old smem code and replace it with a straight port from Linux, providing a familiar interface and enabling us to access it much earlier in the boot process that would be possible with a standard device. Additionally, this will be easier to maintain going forwards since any patches from Linux can be more easily ported over. With this new smem framework in place, we can now use SMEM to parse the memory map when it's not provided via some other mechanism. Additionally, we can use it to read the serial number of the board. Implement this functionality and split the snapdragon memory parsing off to its own file to try and organise things a bit better. This depends on a patch [1] making malloc available in fdtdec_setup() since malloc is required to initialise smem. [1]: https://lore.kernel.org/u-boot/20241124183832.2476928-1-caleb.connolly@lina… --- Caleb Connolly (15): Revert "dm: SMEM (Shared memory) uclass" smem: drop drivers/smem Revert "test: smem: add basic smem test" Revert "drivers: smem: sandbox" soc: qcom: import smem from Linux 6.11-rc2 soc: qcom: smem: adjust headers for U-Boot soc: qcom: smem: adjust for U-Boot soc: qcom: smem: get serial number from socinfo soc: qcom: smem: stub functions soc: qcom: smem: add build infra mach-snapdragon: increase pre-relocation malloc size for smem mach-snapdragon: move memory parsing to its own file mach-snapdragon: support parsing memory map from SMEM mach-snapdragon: fetch serial# from SMEM qcom_defconfig: enable QCOM_SMEM arch/arm/Kconfig | 2 - arch/arm/mach-snapdragon/Kconfig | 2 +- arch/arm/mach-snapdragon/Makefile | 2 +- arch/arm/mach-snapdragon/board.c | 107 +--- arch/arm/mach-snapdragon/dram.c | 214 ++++++++ arch/arm/mach-snapdragon/qcom-priv.h | 4 + arch/sandbox/dts/test.dts | 4 - configs/qcom_defconfig | 1 + configs/sandbox64_defconfig | 2 - configs/sandbox_defconfig | 2 - drivers/Kconfig | 2 - drivers/Makefile | 1 - drivers/smem/Kconfig | 24 - drivers/smem/Makefile | 7 - drivers/smem/sandbox_smem.c | 44 -- drivers/smem/smem-uclass.c | 46 -- drivers/soc/qcom/Kconfig | 8 + drivers/soc/qcom/Makefile | 1 + drivers/{smem/msm_smem.c => soc/qcom/smem.c} | 741 ++++++++++++++++----------- include/dm/uclass-id.h | 1 - include/smem.h | 90 ---- include/soc/qcom/smem.h | 36 ++ include/soc/qcom/socinfo.h | 111 ++++ test/dm/Makefile | 1 - test/dm/smem.c | 26 - 25 files changed, 842 insertions(+), 637 deletions(-) --- base-commit: 7aad7833323aa9260935d172744a50f56356d52a // Caleb (they/them)

3 34

[PATCH RFC 00/14] efi: implement EFISTUB support for ARM64 and Qualcomm
by Caleb Connolly 08 Jan '25

08 Jan '25

This series implements support for launching U-Boot as an EFI payload on ARM64 devices that already have an EFI capable bootloader. Patches 9 through 14 in tandem with another series [1] provide all the pieces necessary to build and run U-Boot on Snapdragon X Elite laptops. They're only here to demonstrate the usecase and either already have or will be sent separately, they should not be reviewed as part of this RFC. Initial support is provided for: * Building U-Boot with an EFI stub on ARM64 * Inheriting DRAM banks from the EFI memory map * Creating a framebuffer node in the OF tree based on EFI GOP info This allows for booting Linux on top of U-Boot's EFI implementation on Qualcomm Snapdragon X Elite platforms. The primary motivation for this is to provide a more standard EFI interface on devices like Qualcomm powered Windows laptops. While these devices ship an EFI capable bootloader, it has no understanding of devicetree, requiring distros (or more often, users) to handle devicetree selection and applying necessary fixups. Additionally, the EFI implementation on these devices is often very far from being systemready compliant, with a variety of bugs like broken keyboards, crashes in OS loaders like systemd-boot, and other small idiosyncrocies. As a result, simply running U-Boot as an EFI app isn't a suitable solution. [1]: 20241124-b4-modernise-smem-v1-0-b7852c11b67c(a)linaro.org --- Caleb Connolly (10): cmd: efi: avoid unitialized read efi: stub: support running U-Boot as an EFI payload on ARM64 efi: move efi_info_get() to a new header file efi: stub: add helpers to populate memory map and framebuffer efi: stub: add additional types of memory efi: stub: log EFI memory banks efi: stub: add known memory to U-Boot's EFI memory map mach-snapdragon: support booting with EFISTUB common/board_f: init malloc earlier configs: add x1e_defconfig Neil Armstrong (4): clk: qcom: Add X1E80100 clock driver qcom_defconfig: enable X1E80100 clock driver pinctrl: qcom: Add X1E80100 pinctrl driver qcom_defconfig: enable X1E80100 pinctrl driver Makefile | 15 +- arch/arm/cpu/armv8/config.mk | 11 + arch/arm/include/asm/global_data.h | 3 + arch/arm/lib/Makefile | 2 + arch/arm/mach-snapdragon/board.c | 15 ++ arch/arm/mach-snapdragon/dram.c | 15 +- arch/arm/mach-snapdragon/qcom-priv.h | 2 + arch/x86/cpu/efi/payload.c | 32 +-- board/qualcomm/efistub.env | 11 + cmd/efi.c | 3 +- common/board_f.c | 2 +- configs/qcom_defconfig | 2 + configs/x1e_defconfig | 17 ++ drivers/clk/qcom/Kconfig | 8 + drivers/clk/qcom/Makefile | 1 + drivers/clk/qcom/clock-x1e80100.c | 348 ++++++++++++++++++++++++++++++++ drivers/pinctrl/qcom/Kconfig | 7 + drivers/pinctrl/qcom/Makefile | 1 + drivers/pinctrl/qcom/pinctrl-x1e80100.c | 100 +++++++++ drivers/video/efi.c | 1 + include/efi.h | 27 +-- include/efi_stub.h | 67 ++++++ lib/efi/Kconfig | 9 +- lib/efi/Makefile | 28 ++- lib/efi/efi_app.c | 1 + lib/efi/efi_info.c | 165 +++++++++++++++ lib/efi/efi_stub_arm64.c | 237 ++++++++++++++++++++++ lib/efi/{efi_stub.c => efi_stub_x86.c} | 1 + lib/efi_loader/efi_memory.c | 5 + lib/of_live.c | 9 + 30 files changed, 1072 insertions(+), 73 deletions(-) --- base-commit: 1e327ec30e48902fff65fb58337b8f80cc526f08 // Caleb (they/them)

4 19

[PATCH] usb: dwc3-generic: Fix build errors when USB_DWC3_GADGET is disabled
by Jonas Karlman 07 Jan '25

07 Jan '25

Build fail with the following error when DM_USB_GADGET is enabled and USB_DWC3_GADGET is disabled: dwc3/dwc3-generic.o: in function `dm_usb_gadget_handle_interrupts': dwc3/dwc3-generic.c:201:(.text.dm_usb_gadget_handle_interrupts+0x10): undefined reference to `dwc3_gadget_uboot_handle_interrupt' Build also fail with the following error when USB_GADGET_DWC2_OTG + DM_USB_GADGET is enabled and USB_DWC3_GADGET is disabled: gadget/dwc2_udc_otg.o: in function `dm_usb_gadget_handle_interrupts': gadget/dwc2_udc_otg.c:947: multiple definition of `dm_usb_gadget_handle_interrupts'; dwc3/dwc3-generic.o:dwc3/dwc3-generic.c:197: first defined here Fix this by checking for USB_DWC3_GADGET in addition to DM_USB_GADGET. Signed-off-by: Jonas Karlman <jonas(a)kwiboo.se> --- drivers/usb/dwc3/dwc3-generic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/dwc3/dwc3-generic.c b/drivers/usb/dwc3/dwc3-generic.c index 6fb2de8a5ace..891d01957619 100644 --- a/drivers/usb/dwc3/dwc3-generic.c +++ b/drivers/usb/dwc3/dwc3-generic.c @@ -192,7 +192,7 @@ static int dwc3_generic_of_to_plat(struct udevice *dev) return 0; } -#if CONFIG_IS_ENABLED(DM_USB_GADGET) +#if IS_ENABLED(CONFIG_USB_DWC3_GADGET) && CONFIG_IS_ENABLED(DM_USB_GADGET) int dm_usb_gadget_handle_interrupts(struct udevice *dev) { struct dwc3_generic_priv *priv = dev_get_priv(dev); @@ -435,7 +435,7 @@ static int dwc3_glue_bind_common(struct udevice *parent, ofnode node) if (!dr_mode) dr_mode = usb_get_dr_mode(node); - if (CONFIG_IS_ENABLED(DM_USB_GADGET) && + if (IS_ENABLED(CONFIG_USB_DWC3_GADGET) && CONFIG_IS_ENABLED(DM_USB_GADGET) && (dr_mode == USB_DR_MODE_PERIPHERAL || dr_mode == USB_DR_MODE_OTG)) { debug("%s: dr_mode: OTG or Peripheral\n", __func__); driver = "dwc3-generic-peripheral"; -- 2.43.0

4 16

[PATCH] usb: dwc3-of-simple: Remove Amlogic and Rockchip compatible
by Jonas Karlman 07 Jan '25

07 Jan '25

Remove the rockchip,rk3399-dwc3 compatible from the dwc3-of-simple driver now that all boards have changed to use the dwc3-generic driver. Also remove the amlogic,meson-gxl-dwc3 compatible, it is no longer in use by any device tree in mainline linux or U-Boot. Signed-off-by: Jonas Karlman <jonas(a)kwiboo.se> --- drivers/usb/host/dwc3-of-simple.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/host/dwc3-of-simple.c b/drivers/usb/host/dwc3-of-simple.c index f9df59d2e5d7..de1797d02ec0 100644 --- a/drivers/usb/host/dwc3-of-simple.c +++ b/drivers/usb/host/dwc3-of-simple.c @@ -90,8 +90,6 @@ static int dwc3_of_simple_remove(struct udevice *dev) } static const struct udevice_id dwc3_of_simple_ids[] = { - { .compatible = "amlogic,meson-gxl-dwc3" }, - { .compatible = "rockchip,rk3399-dwc3" }, { .compatible = "ti,dwc3" }, { } }; -- 2.43.0

4 3