October 2022 - U-Boot

[PATCH] spi: zynqmp_qspi: Mark zynqmp_qspi_set_tapdelay() as static
by Venkatesh Yadav Abbarapu 07 Oct '22

07 Oct '22

Fix the following sparse and compile time warning triggered with W=1: drivers/spi/zynqmp_gqspi.c:286:6: warning: no previous prototype for 'zynqmp_qspi_set_tapdelay' [-Wmissing-prototypes] Signed-off-by: Venkatesh Yadav Abbarapu <venkatesh.abbarapu(a)amd.com> --- drivers/spi/zynqmp_gqspi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/zynqmp_gqspi.c b/drivers/spi/zynqmp_gqspi.c index c772bae3cc..ab8c551466 100644 --- a/drivers/spi/zynqmp_gqspi.c +++ b/drivers/spi/zynqmp_gqspi.c @@ -283,7 +283,7 @@ static void zynqmp_qspi_chipselect(struct zynqmp_qspi_priv *priv, int is_on) zynqmp_qspi_fill_gen_fifo(priv, gqspi_fifo_reg); } -void zynqmp_qspi_set_tapdelay(struct udevice *bus, u32 baudrateval) +static void zynqmp_qspi_set_tapdelay(struct udevice *bus, u32 baudrateval) { struct zynqmp_qspi_plat *plat = dev_get_plat(bus); struct zynqmp_qspi_priv *priv = dev_get_priv(bus); -- 2.17.1

2 1

[PATCH] arm64: zynqmp: Fix compiler warnings in mp.c
by Venkatesh Yadav Abbarapu 07 Oct '22

07 Oct '22

make W=1 generates the following warning in cpu_disable, cpu_status and cpu_release functions. arch/arm/mach-zynqmp/mp.c:166:16: warning: comparison of unsigned expression in '>= 0' is always true [-Wtype-limits] 166 | if (nr >= ZYNQMP_CORE_APU0 && nr <= ZYNQMP_CORE_APU3) { | ^~ Signed-off-by: Venkatesh Yadav Abbarapu <venkatesh.abbarapu(a)amd.com> --- arch/arm/mach-zynqmp/mp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-zynqmp/mp.c b/arch/arm/mach-zynqmp/mp.c index 4f1ed44afb..949456d530 100644 --- a/arch/arm/mach-zynqmp/mp.c +++ b/arch/arm/mach-zynqmp/mp.c @@ -163,7 +163,7 @@ static int check_r5_mode(void) int cpu_disable(u32 nr) { - if (nr >= ZYNQMP_CORE_APU0 && nr <= ZYNQMP_CORE_APU3) { + if (nr <= ZYNQMP_CORE_APU3) { u32 val = readl(&crfapb_base->rst_fpd_apu); val |= 1 << nr; writel(val, &crfapb_base->rst_fpd_apu); @@ -176,7 +176,7 @@ int cpu_disable(u32 nr) int cpu_status(u32 nr) { - if (nr >= ZYNQMP_CORE_APU0 && nr <= ZYNQMP_CORE_APU3) { + if (nr <= ZYNQMP_CORE_APU3) { u32 addr_low = readl(((u8 *)&apu_base->rvbar_addr0_l) + nr * 8); u32 addr_high = readl(((u8 *)&apu_base->rvbar_addr0_h) + nr * 8); @@ -252,7 +252,7 @@ void initialize_tcm(bool mode) int cpu_release(u32 nr, int argc, char *const argv[]) { - if (nr >= ZYNQMP_CORE_APU0 && nr <= ZYNQMP_CORE_APU3) { + if (nr <= ZYNQMP_CORE_APU3) { u64 boot_addr = simple_strtoull(argv[0], NULL, 16); /* HIGH */ writel((u32)(boot_addr >> 32), -- 2.17.1

2 1

[PATCH 1/1] efi_loader: reformat efi_disk_add_dev()
by Heinrich Schuchardt 07 Oct '22

07 Oct '22

Make it clearer why InstallMultipleProtocolInterfaces is invoked with two NULLs: * rename guid to esp_guid * put protocol GUIDs and the related interfaces on same lines * add comment Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt(a)canonical.com> --- lib/efi_loader/efi_disk.c | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/lib/efi_loader/efi_disk.c b/lib/efi_loader/efi_disk.c index e6a356b589..3e392a4b51 100644 --- a/lib/efi_loader/efi_disk.c +++ b/lib/efi_loader/efi_disk.c @@ -395,7 +395,7 @@ static efi_status_t efi_disk_add_dev( { struct efi_disk_obj *diskobj; struct efi_object *handle; - const efi_guid_t *guid = NULL; + const efi_guid_t *esp_guid = NULL; efi_status_t ret; /* Don't add empty devices */ @@ -439,7 +439,7 @@ static efi_status_t efi_disk_add_dev( efi_free_pool(node); diskobj->media.last_block = part_info->size - 1; if (part_info->bootable & PART_EFI_SYSTEM_PARTITION) - guid = &efi_system_partition_guid; + esp_guid = &efi_system_partition_guid; } else { diskobj->dp = efi_dp_from_part(desc, part); diskobj->media.last_block = desc->lba - 1; @@ -454,12 +454,16 @@ static efi_status_t efi_disk_add_dev( * in this case. */ handle = &diskobj->header; - ret = efi_install_multiple_protocol_interfaces(&handle, - &efi_guid_device_path, - diskobj->dp, - &efi_block_io_guid, - &diskobj->ops, guid, - NULL, NULL); + ret = efi_install_multiple_protocol_interfaces( + &handle, + &efi_guid_device_path, diskobj->dp, + &efi_block_io_guid, &diskobj->ops, + /* + * esp_guid must be last entry as it + * can be NULL. Its interface is NULL. + */ + esp_guid, NULL, + NULL); if (ret != EFI_SUCCESS) goto error; -- 2.37.2

1 0

Uboot support intel xeon gold
by fontaine garin Tham 07 Oct '22

07 Oct '22

Hi Developers, I would like to know if uboot supports intel xeon gold processors and if the is any samples for make menuconfig. I have check the board in intel it does not show Xeon processor. So I am abit hesitant. With Regards, Fontaine Sent from my iPhone

2 2

[PATCH 1/2] configs: mediatek: define default variables
by Julien STEPHAN 07 Oct '22

07 Oct '22

From: Jerome Brunet <jbrunet(a)baylibre.com> define some default addresses and variables to help distro boot Signed-off-by: Jerome Brunet <jbrunet(a)baylibre.com> Signed-off-by: Alexandre Mergnat <amergnat(a)baylibre.com> Signed-off-by: Julien STEPHAN <jstephan(a)baylibre.com> --- include/configs/mt8183.h | 5 +++++ include/configs/mt8516.h | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/include/configs/mt8183.h b/include/configs/mt8183.h index c93d70ddf1..f2a0d71556 100644 --- a/include/configs/mt8183.h +++ b/include/configs/mt8183.h @@ -26,6 +26,11 @@ #define CONFIG_EXTRA_ENV_SETTINGS \ "scriptaddr=0x40000000\0" \ + "fdt_addr_r=0x44000000\0" \ + "fdtoverlay_addr_r=0x44c00000\0" \ + "kernel_addr_r=0x45000000\0" \ + "ramdisk_addr_r=0x46000000\0" \ + "fdtfile=" CONFIG_DEFAULT_FDT_FILE ".dtb\0" \ BOOTENV #endif diff --git a/include/configs/mt8516.h b/include/configs/mt8516.h index 7228f3e428..a9041aed46 100644 --- a/include/configs/mt8516.h +++ b/include/configs/mt8516.h @@ -26,6 +26,11 @@ #define CONFIG_EXTRA_ENV_SETTINGS \ "scriptaddr=0x40000000\0" \ + "fdt_addr_r=0x44000000\0" \ + "fdtoverlay_addr_r=0x44c00000\0" \ + "kernel_addr_r=0x45000000\0" \ + "ramdisk_addr_r=0x46000000\0" \ + "fdtfile=" CONFIG_DEFAULT_FDT_FILE ".dtb\0" \ BOOTENV #endif -- 2.37.1

2 2

[PATCH 0/2 v2] Clean up protocol installation API
by Ilias Apalodimas 06 Oct '22

06 Oct '22

Hi! This is v2 of [0] trying to clean up the handle and protocol management APIs. [0] https://lore.kernel.org/u-boot/4766d2b2-7fd3-0206-37ee-709a6fe2b84f@gmx.de/… Changes since v1: patch 1/2: - remove (void*) since it's not needed when installing protocols - convert #ifdefs to if CONFIG_IS_ENABLED() Changes since RFC: patch 1/2: - Use ret instead of r as a return variable - Use goto for handling efi_va_end() patch 2/2: - Check the return value of efi_uninstall_multiple_protocol_interfaces Ilias Apalodimas (2): efi_loader: define internal implementations of install/uninstallmultiple cmd: replace efi_create_handle/add_protocol with InstallMultipleProtocol cmd/bootefi.c | 17 ++- include/efi.h | 2 + include/efi_loader.h | 6 +- lib/efi_loader/efi_boottime.c | 214 +++++++++++++++++++++++-------- lib/efi_loader/efi_capsule.c | 15 ++- lib/efi_loader/efi_console.c | 14 +- lib/efi_loader/efi_disk.c | 10 +- lib/efi_loader/efi_load_initrd.c | 15 +-- lib/efi_loader/efi_root_node.c | 48 +++---- 9 files changed, 226 insertions(+), 115 deletions(-) -- 2.34.1

1 2

Re: RFC: return value of event_register()
by Simon Glass 06 Oct '22

06 Oct '22

+U-Boot Mailing List On Wed, 5 Oct 2022 at 02:54, Heinrich Schuchardt <heinrich.schuchardt(a)canonical.com> wrote: > > Hello Simon, > > event_register() currently returns an integer to indicate success. > > If we ever want to implement an event_unregister() function ,it would be > preferable if the return value of event_register were of type struct > event_spy *. > > Such a pointer is guaranteed to be unique while the string spy_id may > not be unique or even NULL. > > What are your thoughts? > > Best regards > > Heinrich

1 0

[PATCH 7/7] net/tftp: make tftpput working with servers that do not use OACK
by mikhail.kshevetskiy＠iopsys.eu 06 Oct '22

06 Oct '22

From: Mikhail Kshevetskiy <mikhail.kshevetskiy(a)iopsys.eu> Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy(a)iopsys.eu> --- net/tftp.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/net/tftp.c b/net/tftp.c index dea9c25ffd..e120e4d766 100644 --- a/net/tftp.c +++ b/net/tftp.c @@ -483,8 +483,15 @@ static void tftp_handler(uchar *pkt, unsigned dest, struct in_addr sip, tftp_prev_block = tftp_cur_block; tftp_cur_block = (unsigned short)(block + 1); update_block_number(); - if (ack_ok) + if (ack_ok) { + if (block == 0 && + tftp_state == STATE_SEND_WRQ){ + /* connection's first ACK */ + tftp_state = STATE_DATA; + tftp_remote_port = src; + } tftp_send(); /* Send next data block */ + } } } #endif -- 2.35.1

2 1

Please pull u-boot-marvell/master
by Stefan Roese 06 Oct '22

06 Oct '22

Hi Tom, please pull this batch of mostly Marvell related patches: ---------------------------------------------------------------- - Kirkwood: remove km/keymile kirkwood boards (Holger) - mtd: nand: pxa3xx: simplify ECC hardware parameters (Chris) - tools: kwbimage: Verify maximal kwbimage header size (Pali) - mvebu: Add support for programming LD eFuse on Armada 385 (Pali) - mvebu: Misc timer improvements / cleanup (Stefan) ---------------------------------------------------------------- Here the Azure build, without any issues: https://dev.azure.com/sr0718/u-boot/_build/results?buildId=272&view=results Thanks, Stefan The following changes since commit 2d4591353452638132d711551fec3495b7644731: Merge branch 'next' (2022-10-03 15:39:46 -0400) are available in the Git repository at: git@source.denx.de:u-boot/custodians/u-boot-marvell.git for you to fetch changes up to 3bb0458fa0ef127718ed1c47c33279f9ef03238d: arm: mvebu: turris_omnia: Specify VHV gpio for eFUSE programming (2022-10-06 10:15:35 +0200) ---------------------------------------------------------------- Chris Packham (1): mtd: nand: pxa3xx: simplify ECC hardware parameters Holger Brunck (1): board/km: remove kirkwood boards Pali Rohár (4): tools: kwbimage: Verify maximal kwbimage header size arm: mvebu: Add support for programming LD0 and LD1 eFuse arm: mvebu: Add support for specifying VHV_Enable GPIO arm: mvebu: turris_omnia: Specify VHV gpio for eFUSE programming Stefan Roese (2): arm: mvebu: Remove timer.c timer: orion-timer: Only init timer once arch/arm/dts/Makefile | 1 - arch/arm/dts/kirkwood-km_common.dtsi | 48 --- arch/arm/dts/kirkwood-km_kirkwood.dts | 53 --- arch/arm/mach-mvebu/Kconfig | 15 + arch/arm/mach-mvebu/Makefile | 5 - arch/arm/mach-mvebu/efuse.c | 83 ++++- arch/arm/mach-mvebu/include/mach/efuse.h | 4 + arch/arm/mach-mvebu/spl.c | 2 - arch/arm/mach-mvebu/timer.c | 41 --- board/keymile/Kconfig | 1 - board/keymile/km_arm/Kconfig | 86 ----- board/keymile/km_arm/MAINTAINERS | 11 - board/keymile/km_arm/Makefile | 11 - board/keymile/km_arm/fpga_config.c | 255 -------------- board/keymile/km_arm/km_arm.c | 520 ----------------------------- board/keymile/km_arm/kwbimage-memphis.cfg | 179 ---------- board/keymile/km_arm/kwbimage.cfg | 161 --------- board/keymile/km_arm/kwbimage_128M16_1.cfg | 257 -------------- board/keymile/km_arm/kwbimage_256M8_1.cfg | 257 -------------- board/keymile/scripts/develop-common.txt | 2 +- configs/km_kirkwood_128m16_defconfig | 81 ----- configs/km_kirkwood_defconfig | 81 ----- configs/km_kirkwood_pci_defconfig | 81 ----- configs/kmcoge5un_defconfig | 84 ----- configs/kmnusa_defconfig | 85 ----- configs/kmsuse2_defconfig | 85 ----- configs/turris_omnia_defconfig | 2 + drivers/mtd/nand/raw/pxa3xx_nand.c | 247 ++++---------- drivers/timer/orion-timer.c | 10 +- include/configs/km/km_arm.h | 158 --------- include/configs/km_kirkwood.h | 118 ------- scripts/config_whitelist.txt | 1 - tools/kwbimage.c | 3 + 33 files changed, 179 insertions(+), 2849 deletions(-) delete mode 100644 arch/arm/dts/kirkwood-km_common.dtsi delete mode 100644 arch/arm/dts/kirkwood-km_kirkwood.dts delete mode 100644 arch/arm/mach-mvebu/timer.c delete mode 100644 board/keymile/km_arm/Kconfig delete mode 100644 board/keymile/km_arm/MAINTAINERS delete mode 100644 board/keymile/km_arm/Makefile delete mode 100644 board/keymile/km_arm/fpga_config.c delete mode 100644 board/keymile/km_arm/km_arm.c delete mode 100644 board/keymile/km_arm/kwbimage-memphis.cfg delete mode 100644 board/keymile/km_arm/kwbimage.cfg delete mode 100644 board/keymile/km_arm/kwbimage_128M16_1.cfg delete mode 100644 board/keymile/km_arm/kwbimage_256M8_1.cfg delete mode 100644 configs/km_kirkwood_128m16_defconfig delete mode 100644 configs/km_kirkwood_defconfig delete mode 100644 configs/km_kirkwood_pci_defconfig delete mode 100644 configs/kmcoge5un_defconfig delete mode 100644 configs/kmnusa_defconfig delete mode 100644 configs/kmsuse2_defconfig delete mode 100644 include/configs/km/km_arm.h delete mode 100644 include/configs/km_kirkwood.h

2 1

[PATCH 0/2] Clean up protocol installation API
by Ilias Apalodimas 06 Oct '22

06 Oct '22

Hi! This is v1 of [0] trying to clean up the handle and protocol management APIs. [0] https://lore.kernel.org/u-boot/4766d2b2-7fd3-0206-37ee-709a6fe2b84f@gmx.de/… Changes since RFC: patch [1/2]: - Use ret instead of r as a return variable - Use goto for handling efi_va_end() patch [2/2]: - Check the return value of efi_uninstall_multiple_protocol_interfaces Ilias Apalodimas (2): efi_loader: define internal implementations of install/uninstallmultiple cmd: replace efi_create_handle/add_protocol with InstallMultipleProtocol cmd/bootefi.c | 17 ++- include/efi.h | 2 + include/efi_loader.h | 6 +- lib/efi_loader/efi_boottime.c | 214 +++++++++++++++++++++++-------- lib/efi_loader/efi_capsule.c | 15 ++- lib/efi_loader/efi_console.c | 14 +- lib/efi_loader/efi_disk.c | 10 +- lib/efi_loader/efi_load_initrd.c | 15 +-- lib/efi_loader/efi_root_node.c | 44 +++---- 9 files changed, 224 insertions(+), 113 deletions(-) -- 2.34.1

2 6