October 2022 - U-Boot

[PATCH v3 0/2] automatically stip btool_ from btool names
by Quentin Schulz 30 Oct '22

30 Oct '22

From: Quentin Schulz <quentin.schulz(a)theobroma-systems.com> Commit daa2da754afe ("binman: btool: gzip: fix packer name so that binary can be found") introduced some sort of work-around to make the gzip binary found by bintool. However, this work-around would need to be applied to any btool whose name is prefixed with btool_ (usually to avoid conflict with other python modules). Instead, let's handle this specific case directly inside bintool so that the btools don't have to handle it themselves. This also reverts the now-unnecessary work-around for gzip btool. To: Simon Glass <sjg(a)chromium.org> To: Alper Nebi Yasak <alpernebiyasak(a)gmail.com> Cc: Quentin Schulz <foss+uboot(a)0leil.net> Cc: u-boot(a)lists.denx.de Signed-off-by: Quentin Schulz <quentin.schulz(a)theobroma-systems.com> --- Quentin Schulz (2): binman: bintool: remove btool_ prefix from btool names Revert "binman: btool: gzip: fix packer name so that binary can be found" tools/binman/bintool.py | 2 ++ tools/binman/btool/btool_gzip.py | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) --- base-commit: 97c0a9c5708dc60d82cad721a8b882f0ce37e83d change-id: 20220930-upstream-gzip-binman-v3-91b83bf16795 Best regards, -- Quentin Schulz <quentin.schulz(a)theobroma-systems.com>

3 7

i2c-gpio: condition is always false
by Sergei Antonov 30 Oct '22

30 Oct '22

Hello! Please look at this code from drivers/i2c/i2c-gpio.c: static int i2c_gpio_of_to_plat(struct udevice *dev) { struct i2c_gpio_bus *bus = dev_get_priv(dev); int ret; /* "gpios" is deprecated and replaced by "sda-gpios" + "scl-gpios". */ ret = gpio_request_list_by_name(dev, "gpios", bus->gpios, ARRAY_SIZE(bus->gpios), 0); if (ret == -ENOENT) { The condition is always false because in gpio_request_list_by_name_nodev(), if entry is not found, this code will work: if (ret == -ENOENT) break; and then return count; return zero.

2 1

mkimage regression: legacy images with Image Type IH_TYPE_FLATDT
by Marc Kleine-Budde 30 Oct '22

30 Oct '22

Hello! ld;dr: I want to create legacy images with Image Type IH_TYPE_FLATDT. Details: During the migration of an older system to recent yocto, we noticed that the u-boot's mkimage doesn't work anymore as expected. The system runs an older version of u-boot and requires the kernel's dtb wrapped in a legacy u-boot image. With the old u-boot (v2009.08) the following command was used to create the uimage containing the dtb: | mkimage -A arm -O linux -T flat_dt -C none -d <infile> <outfile> e.g.: | $ mkimage-v2009.08-144-g449609f5b11c -A arm -O linux -T flat_dt -C none -d ./vivavis-skalar-pro.dtb out-v2009.08-144-g449609f5b11c | Image Name: | Created: Wed Feb 2 22:22:22 2022 | Image Type: ARM Linux Flat Device Tree (uncompressed) | Data Size: 21726 Bytes = 21.22 kB = 0.02 MB | Load Address: 00000000 | Entry Point: 00000000 | | $ file out-v2009.08-144-g449609f5b11c | out-v2009.08-144-g449609f5b11c: u-boot legacy uImage, , Linux/ARM, | Binary Flat Device Tree BLOB (Not compressed), 21726 bytes, Wed Feb 2 | 21:22:22 2022, Load Address: 00000000, Entry Point: 00000000, Header | CRC: 0X945F44C9, Data CRC: 0XDCA9BDD With the new u-boot: | $ mkimage -A arm -O linux -T flat_dt -C none -d ./vivavis-skalar-pro.dtb out-upstream | mkimage: Can't set header for FIT Image support: Success | | echo $? | 1 The command fails. (...and prints the error message "Success". I'll send a patch to fix that). An image is (partially) generated, but it's neither a valid legacy image nor a FIT image: | $ file out-upstream | out-upstream: data | | $ hexdump -C out-upstream | head -10 | 00000000 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| | * | 00000040 d0 0d fe ed 00 00 54 de 00 00 00 38 00 00 50 9c |......T....8..P.| | 00000050 00 00 00 28 00 00 00 11 00 00 00 10 00 00 00 00 |...(............| | 00000060 00 00 04 42 00 00 50 64 00 00 00 00 00 00 00 00 |...B..Pd........| | 00000070 00 00 00 00 00 00 00 00 00 00 00 01 00 00 00 00 |................| | 00000080 00 00 00 03 00 00 00 04 00 00 00 00 00 00 00 01 |................| | 00000090 00 00 00 03 00 00 00 04 00 00 00 0f 00 00 00 01 |................| | 000000a0 00 00 00 03 00 00 00 13 00 00 00 1b 56 49 56 41 |............VIVA| | 000000b0 56 49 53 20 53 6b 61 6c 61 72 2e 70 72 6f 00 00 |VIS Skalar.pro..| The main difference between the old u-boot and recent u-boot, is that the old u-boot (obviously) always creates legacy images, with the struct legacy_img_hdr::ih_type in the header set to the type given with the '-T' command line argument. With new mkimage, it's a bit different. The type of the -T command line parameter is used to select the actual image type. This is done by iterating over all image types and calling the check_image_type callback to find a matching image provider. The FIT image ("fit_common.c") matches on types IH_TYPE_FLATDT (which corresponds to "-T flat_dt") while the legacy image ("tools/default_image.c") matches on the following image types: IH_TYPE_STANDALONE, /* Standalone Program */ IH_TYPE_KERNEL, /* OS Kernel Image */ IH_TYPE_RAMDISK, /* RAMDisk Image */ IH_TYPE_MULTI, /* Multi-File Image */ IH_TYPE_FIRMWARE, /* Firmware Image */ IH_TYPE_SCRIPT, /* Script file */ IH_TYPE_FILESYSTEM, /* Filesystem Image (any type) */ For work around the problem, I disabled FIT image support entirely and let the legacy image pick up IH_TYPE_FLATDT, too: diff --git a/tools/default_image.c b/tools/default_image.c index 4a067e65862e..ab145001e49d 100644 --- a/tools/default_image.c +++ b/tools/default_image.c @@ -26,7 +26,7 @@ static struct legacy_img_hdr header; static int image_check_image_types(uint8_t type) { - if (((type > IH_TYPE_INVALID) && (type < IH_TYPE_FLATDT)) || + if (((type > IH_TYPE_INVALID) && (type <= IH_TYPE_FLATDT)) || (type == IH_TYPE_KERNEL_NOLOAD) || (type == IH_TYPE_FIRMWARE_IVT)) return EXIT_SUCCESS; else diff --git a/tools/fit_common.c b/tools/fit_common.c index 01649760ac00..a967449103f0 100644 --- a/tools/fit_common.c +++ b/tools/fit_common.c @@ -43,9 +43,11 @@ int fit_verify_header(unsigned char *ptr, int image_size, int fit_check_image_types(uint8_t type) { +#if 0 if (type == IH_TYPE_FLATDT) return EXIT_SUCCESS; else +#endif return EXIT_FAILURE; } I though of adding a command line parameter to force legacy images, regardless of the -T value (which means passing the parsed command line parameters down into the check_image_type callback). Are the better options or am I using mkimage wrong? regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

2 1

Support for Banana Pi BPI-P2 Zero
by Martin Thomas 28 Oct '22

28 Oct '22

Hi Developers, I am struggling with the u-boot for the Banana Pi BPI-P2 Zero. I used this defconfig but it has problems with at least the mmc card: CONFIG_ARM=y CONFIG_ARCH_SUNXI=y CONFIG_DEFAULT_DEVICE_TREE="sun8i-h3-bananapi-m2-plus-v1.2" CONFIG_SPL=y CONFIG_MACH_SUN8I_H3=y CONFIG_DRAM_CLK=408 CONFIG_MMC0_CD_PIN="" CONFIG_MMC_SUNXI_SLOT_EXTRA=2 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set CONFIG_PREBOOT="" # CONFIG_SYS_DEVICE_NULLDEV is not set CONFIG_SPL_STACK=0x8000 CONFIG_SYS_PBSIZE=1024 CONFIG_SUN8I_EMAC=y CONFIG_USB_EHCI_HCD=y This is the output from serial: U-Boot SPL 2022.10 (Oct 28 2022 - 20:34:40 +0200) DRAM: 512 MiB Trying to boot from MMC1 U-Boot 2022.10 (Oct 28 2022 - 20:34:40 +0200) Allwinner Technology CPU: Allwinner H3 (SUN8I 1680) Model: Banana Pi BPI-M2-Plus v1.2 H3 DRAM: 512 MiB Core: 68 devices, 19 uclasses, devicetree: separate WDT: Not starting watchdog@1c20ca0 MMC: mmc@1c0f000: 0, mmc@1c10000: 2, mmc@1c11000: 1 Loading Environment from FAT... MMC: no card present ** Bad device specification mmc 0 ** In: serial Out: serial Err: serial Net: Could not get PHY for ethernet@1c30000: addr 1 No ethernet found. Hit any key to stop autoboot: 0 MMC: no card present Card did not respond to voltage select! : -110 starting USB... ... Thank you for your help! Regards Martin

1 1

[PATCH 1/1] doc: update sbi command example
by Heinrich Schuchardt 28 Oct '22

28 Oct '22

The output of the sbi command has been changed since the last release of the man-page. Update the example. Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt(a)canonical.com> --- doc/usage/cmd/sbi.rst | 28 +++++++++++++++++----------- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/doc/usage/cmd/sbi.rst b/doc/usage/cmd/sbi.rst index 96d8861057..627479a49f 100644 --- a/doc/usage/cmd/sbi.rst +++ b/doc/usage/cmd/sbi.rst @@ -21,23 +21,29 @@ The output may look like: :: => sbi - SBI 0.2 - OpenSBI + SBI 1.0 + OpenSBI 1.1 + Machine: + Vendor ID 0 + Architecture ID 0 + Implementation ID 0 Extensions: - sbi_set_timer - sbi_console_putchar - sbi_console_getchar - sbi_clear_ipi - sbi_send_ipi - sbi_remote_fence_i - sbi_remote_sfence_vma - sbi_remote_sfence_vma_asid - sbi_shutdown + Set Timer + Console Putchar + Console Getchar + Clear IPI + Send IPI + Remote FENCE.I + Remote SFENCE.VMA + Remote SFENCE.VMA with ASID + System Shutdown SBI Base Functionality Timer Extension IPI Extension RFENCE Extension Hart State Management Extension + System Reset Extension + Performance Monitoring Unit Extension The first line indicates the version of the RISC-V SBI specification. The second line indicates the implementation. -- 2.37.2

1 0

imx8 regression: cyclic_register for watchdog@30280000 failed
by Tim Harvey 28 Oct '22

28 Oct '22

Greetings, I've noticed a regression since the merge of the cyclic framework use for watchdog on my imx8m boards: cyclic_register for watchdog@30280000 failed WDT: Failed to start watchdog@30280000 A bisect lead me to the following 3 sequential patches: 29caf9305b6f cyclic: Use schedule() instead of WATCHDOG_RESET() ^^^ bad 881d4108257a cyclic: Introduce schedule() function ^^^ unbuildable c2fd0ca1a822 watchdog: Integrate watchdog triggering into the cyclic framework ^^^ unbootable Before I did in much deeper has anyone else run into and/or resolved this? I'm wondering if something is missing from defconfig? Best Regards, Tim

3 10

Re: Missing variable in *_defconfig of MT7628/MT7688
by Stefan Roese 28 Oct '22

28 Oct '22

Hi Tom, please find below a mail from Ruben, remarking that the Kconfig conversion of CONFIG_SPL_PAD_TO seems to have gone wrong. At least for MIPS MT7620/88. This was the commit from you: ca8a329a1b7f ("Convert CONFIG_SPL_PAD_TO et al to Kconfig") I just double checked this and Ruben is correct. Before the conversion SPL_PAD_TO was 0x0 and now its 0x10000. I can easily generate a patch changing these defconfig values for these MIPS boards. But there might be other boards that could be affected, so I wanted to put this issue to the list. Thanks, Stefan On 27.10.22 14:39, Ruben Winters wrote: > Hi guys, > > The CONFIG_SPL_PAD_TO=0 is missing from the defconf. > > After removing it from the .h file it was not placed in the _defconf file. > > If not placed it will default to 0x10000 e.g. equals to > CONFIG_SPL_MAX_SIZE, and you will get an error spl: failed to boot from > all boot devices. > > Met vriendelijke groet, > > Mit freundlichen Grüßen, > > Best regards, > > *Ruben Winters* > > *Research & Development Engineer*

2 1

Re: [PATCH] riscv: Rename Andes PLIC to PLICSW
by Rick Chen 28 Oct '22

28 Oct '22

> From: Peter Yu-Chien Lin(林宇謙) <peterlin(a)andestech.com> > Sent: Tuesday, October 25, 2022 11:04 PM > To: u-boot(a)lists.denx.de > Cc: Leo Yu-Chi Liang(梁育齊) <ycliang(a)andestech.com>; Rick Jian-Zhi Chen(陳建志) <rick(a)andestech.com>; Peter Yu-Chien Lin(林宇謙) <peterlin(a)andestech.com> > Subject: [PATCH] riscv: Rename Andes PLIC to PLICSW > > As PLICSW is used to trigger the software interrupt, we should rename Andes PLIC configuration and file name to reflect the usage. This patch also updates PLMT and PLICSW compatible strings to be consistent with OpenSBI fdt driver. > > Signed-off-by: Yu Chien Peter Lin <peterlin(a)andestech.com> > --- > arch/riscv/Kconfig | 6 ++--- > arch/riscv/cpu/ax25/Kconfig | 2 +- > arch/riscv/dts/ae350-u-boot.dtsi | 2 +- > arch/riscv/dts/ae350_32.dts | 6 ++--- > arch/riscv/dts/ae350_64.dts | 6 ++--- > arch/riscv/include/asm/global_data.h | 4 +-- > arch/riscv/include/asm/syscon.h | 2 +- > arch/riscv/lib/Makefile | 2 +- > .../lib/{andes_plic.c => andes_plicsw.c} | 26 +++++++++---------- > 9 files changed, 28 insertions(+), 28 deletions(-) rename arch/riscv/lib/{andes_plic.c => andes_plicsw.c} (76%) Reviewed-by: Rick Chen <rick(a)andestech.com>

1 0

[PATCH V2 00/13] IOT2050-related enhancements
by Jan Kiszka 28 Oct '22

28 Oct '22

(Almost) flushing our upstream queue for the IOT2050 device, this mostly brings board-specific changes such as: - updated build process and firmware layout for PG1 vs. PG2 devices - more watchdog preparations - preparations for verified boot on IOT2050 Advanced devices There are also some generic extensions in this series which are dependencies for the above: - env: Complete generic support for writable list - env: Couple networking-related variable flags to CONFIG_NET (repost) - tools: Add script for converting public key into device tree include Changes in v2: - rebased over latest master - reworked patch 1 to be less invasive to the code - added "iot2050: use the named gpio to control the user-button" Still in our backlog is support for a new variant that comes with M.2 slots. But that requires some more rework first. Jan CC: chao zeng <chao.zeng(a)siemens.com> CC: Joe Hershberger <joe.hershberger(a)ni.com> CC: Marek Vasut <marex(a)denx.de> CC: Su Baocheng <baocheng.su(a)siemens.com> Jan Kiszka (10): env: Complete generic support for writable list env: Couple networking-related variable flags to CONFIG_NET tools: Add script for converting public key into device tree include iot2050: Update firmware layout iot2050: Add watchdog start to bootcmd iot2050: Add CONFIG_ENV_FLAGS_LIST_STATIC arm: dts: iot2050: Allow verifying U-Boot proper by SPL iot2050: Add script for signing artifacts arm: dts: iot2050: Optionally embed OTP programming data into image doc: iot2050: Add a note about the watchdog firmware Su Baocheng (2): board: siemens: iot2050: Split the build for PG1 and PG2 arm: dts: iot2050: Use the auto generator nodes for fdt chao zeng (1): board: siemens: iot2050: use the named gpio to control the user-button arch/arm/dts/k3-am65-iot2050-boot-image.dtsi | 134 ++++++------------ board/siemens/iot2050/Kconfig | 35 ++++- board/siemens/iot2050/board.c | 17 +-- ...ot2050_defconfig => iot2050_pg1_defconfig} | 7 +- ...ot2050_defconfig => iot2050_pg2_defconfig} | 9 +- doc/board/siemens/iot2050.rst | 79 ++++++++++- env/Kconfig | 2 + env/env.c | 22 +++ env/flags.c | 10 +- include/configs/iot2050.h | 17 +++ include/env_flags.h | 4 +- tools/binman/missing-blob-help | 14 +- tools/iot2050-sign-fw.sh | 51 +++++++ tools/key2dtsi.py | 64 +++++++++ 14 files changed, 334 insertions(+), 131 deletions(-) copy configs/{iot2050_defconfig => iot2050_pg1_defconfig} (94%) rename configs/{iot2050_defconfig => iot2050_pg2_defconfig} (92%) create mode 100755 tools/iot2050-sign-fw.sh create mode 100755 tools/key2dtsi.py -- 2.35.3

5 25

Re: [PATCH v3 4/4] riscv: Update Microchip MPFS Icicle Kit support
by Rick Chen 28 Oct '22

28 Oct '22

> From: Padmarao Begari <padmarao.begari(a)microchip.com> > Sent: Thursday, October 27, 2022 2:02 PM > To: u-boot(a)lists.denx.de; jagan(a)amarulasolutions.com; Rick Jian-Zhi Chen(陳建志) <rick(a)andestech.com>; Leo Yu-Chi Liang(梁育齊) <ycliang(a)andestech.com>; bmeng.cn(a)gmail.com > Cc: cyril.jean(a)microchip.com; conor.dooley(a)microchip.com; valentina.fernandezalanis(a)microchip.com; nagasuresh.relli(a)microchip.com; Padmarao Begari <padmarao.begari(a)microchip.com> > Subject: [PATCH v3 4/4] riscv: Update Microchip MPFS Icicle Kit support > > This patch updates Microchip MPFS Icicle Kit support. For now, add Microchip QSPI driver and a small 4MB reservation is made at the end of 32-bit DDR to provide some memory for the HSS to use. > > Signed-off-by: Padmarao Begari <padmarao.begari(a)microchip.com> > Reviewed-by: Conor Dooley <conor.dooley(a)microchip.com> > --- > board/microchip/mpfs_icicle/Kconfig | 7 +++++++ > configs/microchip_mpfs_icicle_defconfig | 1 + > 2 files changed, 8 insertions(+) Reviewed-by: Rick Chen <rick(a)andestech.com>

1 0