February 2021 - U-Boot

[PATCH v3 0/2] x86: Minor improvements mostly for image loading
by Simon Glass 06 Feb '21

06 Feb '21

This series provides a few improvements for loading of images. It also provides a way to show more detailed model information as well as an of-platdata fix noticed recently. Note that this series depends on the GPIO series here: http://patchwork.ozlabs.org/project/uboot/list/?series=226118 Changes in v3: - Rebase to master - Rebase to master - Drop patches previously applied Changes in v2: - Fix two missing asterisks in comments Simon Glass (2): sysinfo: Allow showing model info from sysinfo x86: coral: Show memory config and SKU ID on startup arch/x86/dts/chromebook_coral.dts | 11 ++ board/google/chromebook_coral/coral.c | 143 +++++++++++++++++- board/google/chromebook_coral/variant_gpio.h | 6 - common/board_info.c | 37 ++++- .../sysinfo/google,coral.txt | 37 +++++ include/sysinfo.h | 17 ++- 6 files changed, 228 insertions(+), 23 deletions(-) create mode 100644 doc/device-tree-bindings/sysinfo/google,coral.txt -- 2.30.0.478.g8a0d178c01-goog

2 4

[PATCH v2 0/3] mmc: mmc_spi: Fix potential spec violation in receiving card response
by Bin Meng 06 Feb '21

06 Feb '21

After command is sent and before card response shows up on the line, there is a variable number of clock cycles in between called Ncr. The spec [1] says the minimum is 1 byte and the maximum is 8 bytes. Current logic in mmc_spi_sendcmd() has a flaw that it could only work with certain SD cards with their Ncr being just 1 byte. When resp_match is false, the codes try to receive only 1 byte from the SD card. On the other hand when resp_match is true, the logic happens to be no problem as it loops until timeout to receive as many bytes as possible to see a match of the expected resp_match_value. However not every call to mmc_spi_sendcmd() is made with resp_match being true hence this exposes a potential issue with SD cards that have a larger Ncr value. Given no issue was reported as of today, we can reasonably conclude that all cards being used on the supported boards happen to have a 1 byte Ncr timing requirement. But a broken case can be triggered by utilizing QEMU to emulate a larger value of Ncr (by default 1 byte Ncr is used on QEMU). This series fixes such potential spec violation to improve the card compatibility. [1] "Physical Layer Specification Version 8.00" chapter 7.5.1: Command / Response chapter 7.5.4: Timing Values Changes in v2: - move the check before the debug output Bin Meng (3): mmc: mmc_spi: Move argument check to the beginning of mmc_spi_sendcmd() mmc: mmc_spi: Fix potential spec violation in receiving card response mmc: mmc_spi: Document the 3 local functions drivers/mmc/mmc_spi.c | 74 ++++++++++++++++++++++++++++++++++++++------------- 1 file changed, 55 insertions(+), 19 deletions(-) -- 2.7.4

1 4

[PATCH v4 00/12] smbios: Enhancements for more flexibility
by Simon Glass 06 Feb '21

06 Feb '21

This series includes various patches to allow more flexibility as to where the data for SMBIOS tables comes from: - introduces some standard sysinfo options as a source, e.g. to read strapping pins to determine the board revision - allows the U-Boot version number to be included - allows the version number to be provided programmatically, e.g. to support the build system adding information after U-Boot is built Documentation is added for how to obtain version information. The code is also refactored a little to make it easier to maintain. Changes in v4: - Drop debugging change to doc/Makefile Changes in v3: - Move to doc/ and .rst format - Add examples for converting epoch values - Use .rst file instead of README - Fix comment for smbios_add_prop() - Rename set_eos() to smbios_set_eos() - Add missing DECLARE_GLOBAL_DATA_PTR - Expand commit to explain why operations are required - Use SMBIOS_STR_MAX for the max sysinfo string length Changes in v2: - Add a comment about dropping the century - Zero the context's dev pointer if not used - Correct documentation format - Add new patch to fix sysinfo with CONFIG_IS_ENABLED() - Add new patch to fix crash on coral Simon Glass (12): README: Add doumentation for version information Makefile: Provide numeric versions smbios: Move smbios_write_type to the C file smbios: Use char consistently for the eos member smbios: Set BIOS release version smbios: Use a struct to keep track of context smbios: Drop the eos parameter smbios: Track the end of the string table smbios: Add more options for the BIOS version string sysinfo: Move #ifdef so that operations are always defined x86: coral: Add sysinfo ops smbios: Allow a few values to come from sysinfo Makefile | 4 + board/google/chromebook_coral/coral.c | 5 + doc/develop/index.rst | 1 + doc/develop/version.rst | 101 +++++++++++ include/asm-generic/global_data.h | 6 + include/smbios.h | 26 +-- include/sysinfo.h | 13 +- lib/smbios.c | 248 +++++++++++++++++++------- 8 files changed, 328 insertions(+), 76 deletions(-) create mode 100644 doc/develop/version.rst -- 2.30.0.478.g8a0d178c01-goog

2 14

[PATCH] gpio-uclass: fix gpio flags save condition
by Kory Maincent 06 Feb '21

06 Feb '21

The commit cd2faeba1a moves the location where we save the flags to the gpio descriptor but it adds a "!" character. This breaks the condition we expect to save the flags. Signed-off-by: Kory Maincent <kory.maincent(a)bootlin.com> --- drivers/gpio/gpio-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-uclass.c b/drivers/gpio/gpio-uclass.c index 0c01413b58..39db89c004 100644 --- a/drivers/gpio/gpio-uclass.c +++ b/drivers/gpio/gpio-uclass.c @@ -650,7 +650,7 @@ static int _dm_gpio_set_dir_flags(struct gpio_desc *desc, ulong flags) } /* save the flags also in descriptor */ - if (!ret) + if (ret) desc->flags = flags; return ret; -- 2.17.1

3 5

[PATCH v2 0/4] doc: update Kernel documentation build system
by Heinrich Schuchardt 06 Feb '21

06 Feb '21

Update the documentation build system according to Linux v5.11-rc1. Deactive the automarkup.py extension module which on Gitlab CI is incompatible with Unicode. With this patch we can build the HTML documentation using either of Sphinx 2 and Sphinx 3. Fix two non-conformant documents. Heinrich Schuchardt (4): doc: board: fix Microchip MPFS Icicle Kit doc doc: fix doc/develop/logging.rst .gitlab-ci: install doc/sphinx/requirements.txt doc: update Kernel documentation build system .azure-pipelines.yml | 6 +- .gitlab-ci.yml | 3 + doc/api/index.rst | 1 + doc/api/logging.rst | 6 + doc/board/microchip/mpfs_icicle.rst | 51 ++-- doc/conf.py | 141 +++++++-- doc/develop/logging.rst | 13 +- doc/sphinx/automarkup.py | 290 ++++++++++++++++++ doc/sphinx/cdomain.py | 93 +++++- doc/sphinx/kernel_abi.py | 194 ++++++++++++ doc/sphinx/kernel_feat.py | 169 +++++++++++ doc/sphinx/kerneldoc.py | 15 +- doc/sphinx/kernellog.py | 6 +- doc/sphinx/kfigure.py | 6 +- doc/sphinx/load_config.py | 27 +- doc/sphinx/maintainers_include.py | 197 ++++++++++++ doc/sphinx/parallel-wrapper.sh | 33 ++ doc/sphinx/parse-headers.pl | 6 +- doc/sphinx/requirements.txt | 5 +- scripts/kernel-doc | 450 +++++++++++++++++++++------- 20 files changed, 1527 insertions(+), 185 deletions(-) create mode 100644 doc/api/logging.rst create mode 100644 doc/sphinx/automarkup.py create mode 100644 doc/sphinx/kernel_abi.py create mode 100644 doc/sphinx/kernel_feat.py create mode 100755 doc/sphinx/maintainers_include.py create mode 100644 doc/sphinx/parallel-wrapper.sh -- 2.29.2

3 11

[PATCH v1] test: Include /sbin to the PATH when creating ext4 disk image
by Andy Shevchenko 06 Feb '21

06 Feb '21

On some distributions the mkfs.ext4 is under /sbin and /sbin is not set for mere users. Include /sbin to the PATH when creating ext4 disk image, so that users won't get a scary traceback from Python. Signed-off-by: Andy Shevchenko <andriy.shevchenko(a)linux.intel.com> --- test/py/tests/test_env.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/py/tests/test_env.py b/test/py/tests/test_env.py index 940279651da0..536467320e06 100644 --- a/test/py/tests/test_env.py +++ b/test/py/tests/test_env.py @@ -414,6 +414,9 @@ def mk_env_ext4(state_test_env): if os.path.exists(persistent): c.log.action('Disk image file ' + persistent + ' already exists') else: + root_path = os.path.abspath('.').split(os.path.sep)[0] + os.path.sep + sbin_path = os.path.join(root_path, 'sbin') + os.environ["PATH"] += os.pathsep + sbin_path try: u_boot_utils.run_and_log(c, 'dd if=/dev/zero of=%s bs=1M count=16' % persistent) u_boot_utils.run_and_log(c, 'mkfs.ext4 %s' % persistent) -- 2.30.0

2 4

[PATCH v2 0/2] Console/stdio use after free
by Nicolas Saenz Julienne 05 Feb '21

05 Feb '21

With today's master, 70c2525c0d3c ('IOMUX: Stop dropped consoles') introduces a use after free in usb_kbd_remove(): - usbkbd's stdio device is de-registered with stdio_deregister_dev(), the struct stdio_dev is freed. - iomux_doenv() is called, usbkbd removed from the console list, and console_stop() is called on the struct stdio_dev pointer that no longer exists. This series mitigates this by making sure the pointer is really a stdio device prior performing the stop operation. It's not ideal, but I couldn't figure out a nicer way to fix this. Regards, Nicolas --- Changes since v1: - Comment new function - Add comment stating this needs a proper fix Nicolas Saenz Julienne (2): stdio: Introduce stdio_valid() console: Don't start/stop console if stdio device invalid common/console.c | 9 +++++++++ common/stdio.c | 11 +++++++++++ include/stdio_dev.h | 11 +++++++++++ 3 files changed, 31 insertions(+) -- 2.30.0

6 14

[PATCH V3] ARM: imx: Include u-boot.img in u-boot-with-spl.imx if OF_SEPARATE=y
by Marek Vasut 05 Feb '21

05 Feb '21

The u-boot-with-spl.imx is a concatenation of SPL and u-boot.uim. The u-boot.uim is u-boot.bin wrapped in uImage. In case OF_SEPARATE is enabled, the u-boot.bin does not contain control DT for U-Boot, and so u-boot.uim does not contain the DT, and so u-boot-with-spl.imx does not contain the DT, and a system where u-boot-with-spl.imx is written to offset 1024B to the start of storage no longer boots, as it is missing DT. In case OF_SEPARATE is enabled, u-boot.img contains both u-boot.bin and the necessary DTs. Therefore, use u-boot.img instead of u-boot.uim to generate u-boot-with-spl.imx when OF_SEPARATE is enabled. Signed-off-by: Marek Vasut <marex(a)denx.de> Cc: Christoph Niedermaier <cniedermaier(a)dh-electronics.de> Cc: Fabio Estevam <festevam(a)gmail.com> Cc: Peng Fan <peng.fan(a)nxp.com> Cc: Simon Glass <sjg(a)chromium.org> Cc: Stefano Babic <sbabic(a)denx.de> Cc: Ye Li <ye.li(a)nxp.com> Cc: uboot-imx <uboot-imx(a)nxp.com> --- V2: Swap the u-boot.uim <-> u-boot.img in the conditional so this would match the patch which Fabio originally tested V3: - Correct the u-boot.img/u-boot.uim dependency in top-level Makefile - Drop TB from Fabio, this needs to be retested --- Makefile | 2 +- arch/arm/mach-imx/Makefile | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index b4f1cbcf9bd..2b308a6aac0 100644 --- a/Makefile +++ b/Makefile @@ -1542,7 +1542,7 @@ flash.bin: spl/u-boot-spl.bin u-boot.itb FORCE endif endif -u-boot-with-spl.imx u-boot-with-nand-spl.imx: SPL u-boot.bin FORCE +u-boot-with-spl.imx u-boot-with-nand-spl.imx: SPL $(if $(CONFIG_OF_SEPARATE),u-boot.img,u-boot.uim) FORCE $(Q)$(MAKE) $(build)=arch/arm/mach-imx $@ MKIMAGEFLAGS_u-boot.ubl = -n $(UBL_CONFIG) -T ublimage -e $(CONFIG_SYS_TEXT_BASE) diff --git a/arch/arm/mach-imx/Makefile b/arch/arm/mach-imx/Makefile index 1aa26a50ad8..e6b4654cd35 100644 --- a/arch/arm/mach-imx/Makefile +++ b/arch/arm/mach-imx/Makefile @@ -202,10 +202,10 @@ append = cat $(filter-out $< $(PHONY), $^) >> $@ quiet_cmd_pad_cat = CAT $@ cmd_pad_cat = $(cmd_objcopy) && $(append) || rm -f $@ -u-boot-with-spl.imx: SPL u-boot.uim FORCE +u-boot-with-spl.imx: SPL $(if $(CONFIG_OF_SEPARATE),u-boot.img,u-boot.uim) FORCE $(call if_changed,pad_cat) -u-boot-with-nand-spl.imx: spl/u-boot-nand-spl.imx u-boot.uim FORCE +u-boot-with-nand-spl.imx: spl/u-boot-nand-spl.imx $(if $(CONFIG_OF_SEPARATE),u-boot.img,u-boot.uim) FORCE $(call if_changed,pad_cat) quiet_cmd_u-boot-nand-spl_imx = GEN $@ -- 2.29.2

2 1

[PATCH v2 00/12] Add support for pinmux status command on beaglebone
by Dario Binacchi 05 Feb '21

05 Feb '21

The series was born from the need to check the pinmux setting of a peripheral on a beaglebone board. I then ran the 'pinmux status -a' command but it failed because some operations (get_pin_muxing, get_pin_name and get_pins_count) were missing in the 'pinctrl-single' driver. The patch series can be cleanly applied to the HEAD of the master which at the time of release points to 8b195f4b71 ("Merge https://gitlab.denx.de/u-boot/custodians/u-boot-marvell") commit Changes in v2: - Added Simon Glass review tag. - Updated commit message. - Added Simon Glass review tag. - Added Pratyush Yadav review tag. - Updated commit message - Split in 2 commits - Check dev_read_addr_size return value - Updated commit message. - Added Simon Glass review tag. - Updated commit message. - Remove pointer to access functions. - Added Simon Glass review tag. - Added Simon Glass review tag. - Added Simon Glass review tag. - Added error checking when the 'width' property is missing. - Fix coding style. Dario Binacchi (12): pinctrl: single: fix format of structure documentation pinctrl: single: fix the loop counter variable type pinctrl: single: fix offset management pinctrl: single: fix debug messages formatting pinctrl: single: get register area size by device API pinctrl: single: check "register-width" DT property pinctrl: single: change function mask default value pinctrl: single: add register access functions pinctrl: single: add get_pins_count operation pinctrl: single: add get_pin_name operation pinctrl: single: add get_pin_muxing operation test: pinmux: add test for 'pinctrl-single' driver arch/sandbox/dts/test.dts | 72 +++++ configs/sandbox_defconfig | 1 + drivers/pinctrl/pinctrl-single.c | 474 +++++++++++++++++++++++++++---- test/dm/pinmux.c | 91 +++++- 4 files changed, 573 insertions(+), 65 deletions(-) -- 2.17.1

5 22

0a2aaab0b678fd1778ff2fc59d0770fc82995532 breaks Pinebook Pro.
by Jesper Schmitz Mouridsen 05 Feb '21

05 Feb '21

Hi list First post here. In my work to enable the display for pinebook-pro (for FreeBSD) I found that, by some bisecting and manual bisecting, 0a2aaab0b678fd1778ff2fc59d0770fc82995532, is a problem.. Check here for links to my patches https://github.com/jsm222/u-boot-pinebookpro/blob/main/README.md changing line https://gitlab.denx.de/u-boot/u-boot/-/commit/0a2aaab0b678fd1778ff2fc59d077… to if (IS_ENABLED(CONFIG_SPL_SEPARATE_BSS)) is a fix for me. I'm new to u-boot so was 0a2aaab0b678fd1778ff2fc59d0770fc82995532 wrong or is a config wrong? Thanks. /Jesper Schmitz Mouridsen

1 0