December 2020 - U-Boot

[u-boot, v1 0/1] mtd: spi-nor-ids: add STMICRO MT25QL01G flash
by Hongwei Zhang 10 Dec '20

10 Dec '20

Hello Reviewer, STMICRO MT25QL01G flash is used on AST2600 board, this patch add it in the table. Please add this update in v2019.04-aspeed-openbmc branch when it is accepted. If I need to submit a separate patch to that branch, please let me know. Thanks! Hongwei Zhang (1): mtd: spi-nor-ids: add STMICRO MT25QL01G flash drivers/mtd/spi/spi-nor-ids.c | 1 + 1 file changed, 1 insertion(+) -- 2.17.1

2 7

[PATCH 0/5] patman: Tidy up some hangovers from Python 2
by Simon Glass 10 Dec '20

10 Dec '20

Various functions were used to deal with the differences between Python 2 and 3. These can be removed now that Python 2 is not supported. Also tidy up the code style in dtb_platdata.py Simon Glass (5): fdt: Use an Enum for the data type patman: Drop unicode helper functions patman: Drop tools.ToByte() patman: Drop tools.ToChar() and ToChars() dtoc: Tidy up Python style in dtb_platdata tools/binman/elf.py | 6 +-- tools/binman/etype/fmap.py | 2 +- tools/binman/fdt_test.py | 14 +++--- tools/binman/fmap_util.py | 3 +- tools/dtoc/dtb_platdata.py | 96 ++++++++++++++++++++++---------------- tools/dtoc/fdt.py | 58 +++++++++++++++-------- tools/dtoc/test_dtoc.py | 10 ++-- tools/dtoc/test_fdt.py | 34 +++++++------- tools/patman/func_test.py | 16 +++---- tools/patman/gitutil.py | 3 +- tools/patman/series.py | 4 +- tools/patman/settings.py | 5 +- tools/patman/tools.py | 85 ++------------------------------- 13 files changed, 140 insertions(+), 196 deletions(-) -- 2.29.2.222.g5d2a92d10f8-goog

2 12

Re: [PATCH] string: Use memcpy() within memmove() when we can
by Patrick DELAUNAY 10 Dec '20

10 Dec '20

Hi Tom, On 12/10/20 12:57 PM, Patrick DELAUNAY wrote: > From: Tom Rini <trini(a)konsulko.com> > Sent: mardi 8 décembre 2020 17:11 > > On Wed, Nov 25, 2020 at 01:07:43PM +0100, Rasmus Villemoes wrote: >> On 25/11/2020 12.26, Patrick Delaunay wrote: >>> A common use of memmove() can be handled by memcpy(). Also memcpy() >>> includes an optimization for large sizes: it copies a word at a >>> time. So we can get a speed-up by calling memcpy() to handle our >>> move in this case. >>> >>> Update memmove() to call also memcpy() if the source don't overlap >>> the destination (src + count <= dest). >>> >>> Signed-off-by: Patrick Delaunay <patrick.delaunay(a)st.com> >>> --- >>> This patch allows to save 38ms for Kernel Image extraction (7327624 >>> Bytes) from FIT loaded at 0xC2000000 for ARMV7 board >>> STM32MP157C-EV1, and with kernel destination = Load Address: >>> 0xc4000000, located after the FIT without overlap, compared with >>> destination = Load Address: 0xc0008000. >>> >>> -> 14,332 us vs 52,239 in bootstage report >>> >>> In this case the memmove funtion is called in >>> common/image.c::memmove_wd() to handle overlap. >>> >>> >>> lib/string.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/lib/string.c b/lib/string.c index >>> ae7835f600..ef8ead976c 100644 >>> --- a/lib/string.c >>> +++ b/lib/string.c >>> @@ -567,7 +567,7 @@ void * memmove(void * dest,const void >>> *src,size_t count) { >>> char *tmp, *s; >>> - if (dest <= src) { >>> + if (dest <= src || (src + count) <= dest) { >>> memcpy(dest, src, count); >> Hm. So the condition you add (src + count <= dest) implies no overlap >> at all, so that's ok. So this doesn't really have anything to do with >> your patch per se. >> >> The existing condition relies on memcpy doing forward-copying. That's >> the case if the implementation from lib/string.c is in use, i.e. if >> __HAVE_ARCH_MEMCPY is not defined. And if an arch defines >> __HAVE_ARCH_MEMMOVE, this memmove() is not used. >> >> But AFAICT, there's a potential problem for the case where >> __HAVE_ARCH_MEMCPY is defined but __HAVE_ARCH_MEMMOVE is not, and e.g. >> arch/arm/include/asm/string.h does >> >> #if CONFIG_IS_ENABLED(USE_ARCH_MEMCPY) >> #define __HAVE_ARCH_MEMCPY >> #endif >> #undef __HAVE_ARCH_MEMMOVE >> >> Of course, the arch-specific implementation _may_ also do >> forward-copying (I haven't tried to decipher it), but that seems to be >> a rather fragile assumption. At the very least, some comments would be >> in order. > Looking at this deeper, today, ARM (non-64bit) can and usually but not > always does use the asm optimized memcpy / memset. No other optimized > functions were copied from Linux, and no other arches seem to use them > today either. I think in sum then, Patrick can you please do a v2 that > adds a comment here, in case we get more optimizations in the future? > And thanks for the review here Rasmus! I am preparing a V2 with added coment. Patrick.

1 0

Re: [PATCH v5 0/7] Microchip PolarFire SoC support
by Rick Chen 10 Dec '20

10 Dec '20

Hi Padmarao > From: Padmarao Begari [mailto:padmarao.begari@microchip.com] > Sent: Thursday, December 03, 2020 4:32 AM > To: u-boot(a)lists.denx.de; bmeng.cn(a)gmail.com; Rick Jian-Zhi Chen(陳建志); anup.patel(a)wdc.com; lukas.auer(a)aisec.fraunhofer.de; joe.hershberger(a)ni.com; lukma(a)denx.de; atish.patra(a)wdc.com > Cc: cyril.jean(a)microchip.com; lewis.hanly(a)microchip.com; ivan.griffin(a)emdalo.com; daire.mcnamara(a)emdalo.com; conor.dooley(a)microchip.com; Padmarao Begari > Subject: [PATCH v5 0/7] Microchip PolarFire SoC support > > This patch set adds Microchip PolarFire SoC Icicle Kit support > to RISC-V U-Boot. > > The patches are based upon latest U-Boot tree > (https://gitlab.denx.de/u-boot/u-boot.git) at commit id > 80cbd731df50b9ab646940ea862b70bcaff37225 > > All drivers namely: NS16550 Serial, Microchip clock, > Cadence eMMC and Cadence MACB Ethernet work fine on actual > Microchip PolarFire SoC Icicle Kit. > > Changes in v5: > - Replace compatible string "microchip,polarfire-soc" with > "microchip,mpfs-icicle-kit" in the device tree > - Use "mpfs" as identifier in place of "polarfire-soc", "pfsoc" > - Fix some typos in doc > - Rename the clock driver files clk_pfsoc_* to mpfs_clk_* > - Rename pfsoc-clock.h to mpfs-clock.h > > Changes in v4: > - Add dual-license GPL or MIT in the device tree > - Replace microsemi compatible strings with microchip > - Add MACB compatible string for Microchip PolarFire SoC ethernet > - Update MACB driver for 32-bit/64-bit DMA based on compatible string > > Changes in v3: > - Add 'default y if 64BIT' for config DMA_ADDR_T_64BIT > - Update MACB driver for 32-bit/64-bit DMA based on design config register > - Add phy-handle in MACB driver to read the phy address from device tree > - Fix checkpatch warnings in the clock driver > - Remove fu540 related compatible strings from soc device tree node > - Move refclk device tree node under /soc device tree node > - Use local-mac-address instead of mac-address in the device tree > - Rename device tree to microchip-mpfs-icicle-kit.dts > - Add U-Boot specific dts microchip-mpfs-icicle-kit-u-boot.dtsi file > - Drop the imply DMA_ADDR_T_64BIT from board config > - Fix some typos > - Update doc with Microchip and Custom boot-flow > > Changes in v2: > - Add clock frequency for the clint device tree node > - Move peripheral device tree nodes under /soc device tree node > - Device tree nodes are in order based on the address > - Enable UART0 for U-Boot logs > - Update doc for the U-Boot logs are on UART0 > - Move clock and reset index source into patch4 > - Remove "dma_addr_r" type in the macb driver > - Add lower_32_bits() for 32-bit address in the macb driver > - Add set_rate() returns the new clock rate in the clock driver > > Padmarao Begari (7): > riscv: Add DMA 64-bit address support > net: macb: Add DMA 64-bit address support for macb > net: macb: Add phy address to read it from device tree > clk: Add Microchip PolarFire SoC clock driver > riscv: dts: Add device tree for Microchip Icicle Kit > riscv: Add Microchip MPFS Icicle Kit support > doc: board: Add Microchip MPFS Icicle Kit doc > Please check about the CI failure item Job #95.59 https://travis-ci.org/github/rickchen36/u-boot-riscv/jobs/748298546 Thanks, Rick > arch/riscv/Kconfig | 4 + > arch/riscv/dts/Makefile | 1 + > .../dts/microchip-mpfs-icicle-kit-u-boot.dtsi | 14 + > arch/riscv/dts/microchip-mpfs-icicle-kit.dts | 421 +++++++++ > arch/riscv/include/asm/types.h | 4 + > board/microchip/mpfs_icicle/Kconfig | 24 + > board/microchip/mpfs_icicle/mpfs_icicle.c | 97 +- > configs/microchip_mpfs_icicle_defconfig | 9 +- > doc/board/index.rst | 1 + > doc/board/microchip/index.rst | 9 + > doc/board/microchip/mpfs_icicle.rst | 830 ++++++++++++++++++ > drivers/clk/Kconfig | 1 + > drivers/clk/Makefile | 1 + > drivers/clk/microchip/Kconfig | 5 + > drivers/clk/microchip/Makefile | 1 + > drivers/clk/microchip/mpfs_clk.c | 127 +++ > drivers/clk/microchip/mpfs_clk.h | 19 + > drivers/clk/microchip/mpfs_clk_cfg.c | 134 +++ > drivers/clk/microchip/mpfs_clk_periph.c | 173 ++++ > drivers/net/macb.c | 144 ++- > drivers/net/macb.h | 6 + > include/configs/microchip_mpfs_icicle.h | 60 +- > .../dt-bindings/clock/microchip,mpfs-clock.h | 45 + > 23 files changed, 2068 insertions(+), 62 deletions(-) > create mode 100644 arch/riscv/dts/microchip-mpfs-icicle-kit-u-boot.dtsi > create mode 100644 arch/riscv/dts/microchip-mpfs-icicle-kit.dts > create mode 100644 doc/board/microchip/index.rst > create mode 100644 doc/board/microchip/mpfs_icicle.rst > create mode 100644 drivers/clk/microchip/Kconfig > create mode 100644 drivers/clk/microchip/Makefile > create mode 100644 drivers/clk/microchip/mpfs_clk.c > create mode 100644 drivers/clk/microchip/mpfs_clk.h > create mode 100644 drivers/clk/microchip/mpfs_clk_cfg.c > create mode 100644 drivers/clk/microchip/mpfs_clk_periph.c > create mode 100644 include/dt-bindings/clock/microchip,mpfs-clock.h > > -- > 2.17.1 >

3 2

[v2] configs: ls1088aqds: add COMMON_ENV to fix distroboot
by Biwen Li 10 Dec '20

10 Dec '20

From: Biwen Li <biwen.li(a)nxp.com> Add COMMON_ENV(kernel_addr_r, fdt_addr_r and so on) to fix a bug that faild to boot to ubuntu, failed log as follows, ## Executing script at 80000000 load - load binary file from a filesystemUsage: load <interface> [<dev[:part]> [<addr> [<filename> [bytes [pos]]]]] - Load binary file filename from partition part on device type interface instance dev to address addr in memory. bytes gives the size to load in bytes. If bytes is 0 or omitted, the file is read until the end. pos gives the file byte position to start reading from. If pos is 0 or omitted, the file is read from the start. ... Bad Linux ARM64 Image magic! SCRIPT FAILED: continuing... Signed-off-by: Biwen Li <biwen.li(a)nxp.com> --- Change in v2: - update description include/configs/ls1088aqds.h | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/include/configs/ls1088aqds.h b/include/configs/ls1088aqds.h index 59757120fc..0dd6bb9f32 100644 --- a/include/configs/ls1088aqds.h +++ b/include/configs/ls1088aqds.h @@ -384,10 +384,18 @@ unsigned long get_board_ddr_clk(void); #define CONFIG_ESDHC_DETECT_QUIRK ((readb(QIXIS_BASE + QIXIS_STAT_PRES1) & \ QIXIS_SDID_MASK) != QIXIS_ESDHC_NO_ADAPTER) +#define COMMON_ENV \ + "kernelheader_addr_r=0x80200000\0" \ + "fdtheader_addr_r=0x80100000\0" \ + "kernel_addr_r=0x81000000\0" \ + "fdt_addr_r=0x90000000\0" \ + "load_addr=0xa0000000\0" + /* Initial environment variables */ #ifdef CONFIG_NXP_ESBC #undef CONFIG_EXTRA_ENV_SETTINGS #define CONFIG_EXTRA_ENV_SETTINGS \ + COMMON_ENV \ "hwconfig=fsl_ddr:bank_intlv=auto\0" \ "loadaddr=0x90100000\0" \ "kernel_addr=0x100000\0" \ @@ -419,6 +427,7 @@ unsigned long get_board_ddr_clk(void); #undef CONFIG_EXTRA_ENV_SETTINGS #define CONFIG_EXTRA_ENV_SETTINGS \ + COMMON_ENV \ "hwconfig=fsl_ddr:bank_intlv=auto\0" \ "loadaddr=0x90100000\0" \ "kernel_addr=0x100000\0" \ @@ -480,6 +489,7 @@ unsigned long get_board_ddr_clk(void); #if defined(CONFIG_QSPI_BOOT) #undef CONFIG_EXTRA_ENV_SETTINGS #define CONFIG_EXTRA_ENV_SETTINGS \ + COMMON_ENV \ "hwconfig=fsl_ddr:bank_intlv=auto\0" \ "loadaddr=0x90100000\0" \ "kernel_addr=0x100000\0" \ @@ -497,6 +507,7 @@ unsigned long get_board_ddr_clk(void); #elif defined(CONFIG_SD_BOOT) #undef CONFIG_EXTRA_ENV_SETTINGS #define CONFIG_EXTRA_ENV_SETTINGS \ + COMMON_ENV \ "hwconfig=fsl_ddr:bank_intlv=auto\0" \ "loadaddr=0x90100000\0" \ "kernel_addr=0x800\0" \ @@ -514,6 +525,7 @@ unsigned long get_board_ddr_clk(void); #else /* NOR BOOT */ #undef CONFIG_EXTRA_ENV_SETTINGS #define CONFIG_EXTRA_ENV_SETTINGS \ + COMMON_ENV \ "hwconfig=fsl_ddr:bank_intlv=auto\0" \ "loadaddr=0x90100000\0" \ "kernel_addr=0x100000\0" \ -- 2.17.1

1 0

[PATCH 1/1] riscv: qemu: enable distro boot from scsi
by Heinrich Schuchardt 10 Dec '20

10 Dec '20

Booting via distro boot fails for: qemu-system-riscv64 -drive if=none,file=sct-riscv64.img,format=raw,id=mydisk \ -device ich9-ahci,id=ahci -device ide-hd,drive=mydisk,bus=ahci.0 Enable distro booting from an attached SCSI disk. Signed-off-by: Heinrich Schuchardt <xypron.glpk(a)gmx.de> --- include/configs/qemu-riscv.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/configs/qemu-riscv.h b/include/configs/qemu-riscv.h index aed9a4ae99..a2f33587c2 100644 --- a/include/configs/qemu-riscv.h +++ b/include/configs/qemu-riscv.h @@ -35,6 +35,7 @@ #define BOOT_TARGET_DEVICES(func) \ func(QEMU, qemu, na) \ func(VIRTIO, virtio, 0) \ + func(SCSI, scsi, 0) \ func(DHCP, dhcp, na) #include <config_distro_bootcmd.h> -- 2.29.2

2 1

[PATCH 0/3] sandbox: Minor improvements to serial driver
by Simon Glass 10 Dec '20

10 Dec '20

This series updates the sandbox serial driver to clean up the code a little. Simon Glass (3): serial: sandbox: Drop unnecessary #ifdefs sandbox: serial: Convert to livetree sandbox: serial: Update to use membuff drivers/serial/sandbox.c | 63 ++++++++++++++-------------------------- 1 file changed, 22 insertions(+), 41 deletions(-) -- 2.29.2.222.g5d2a92d10f8-goog

1 4

[PATCH v2 0/4] sandbox: exception handling
by Heinrich Schuchardt 10 Dec '20

10 Dec '20

Currently if an exception SIGILL, SIGBUS, SIGSEGV occurs the sandbox stops execution. This does not match the behavior on other architectures. Instead print the current program counter and if any the involved UEFI binaries. Then depending on a customizing system either reset the system or exit to the OS. When testing UEFI binaries like the Self Certification Test exceptions may occur. Without information about the UEFI binary where the exception was caused it is difficult to analyze the cause. The exception command is implemented for the sandbox. This command allows to trigger SIGILL or SIGSEGV. v2: add a customizing switch set SA_NODEFER flag for sigaction provide a unit test for the exception command Heinrich Schuchardt (4): sandbox: add handler for exceptions cmd: sandbox: implement exception command efi_selftest: implement exception test for sandbox test: unit test for exception command arch/Kconfig | 1 + arch/sandbox/Kconfig | 9 ++++ arch/sandbox/cpu/os.c | 40 ++++++++++++++++++ arch/sandbox/cpu/start.c | 4 ++ arch/sandbox/lib/interrupts.c | 35 ++++++++++++++++ cmd/Kconfig | 2 +- cmd/Makefile | 1 + cmd/sandbox/Makefile | 3 ++ cmd/sandbox/exception.c | 41 +++++++++++++++++++ include/os.h | 17 ++++++++ .../efi_selftest_miniapp_exception.c | 2 + test/py/tests/test_sandbox_exit.py | 24 +++++++++++ 12 files changed, 178 insertions(+), 1 deletion(-) create mode 100644 cmd/sandbox/Makefile create mode 100644 cmd/sandbox/exception.c -- 2.28.0

3 12

[PULL] Pull request for u-boot master = u-boot-stm32-20201209
by Patrick DELAUNAY 09 Dec '20

09 Dec '20

Hi Tom, Please pull the STM32 related patches for u-boot/master, v2021.01: u-boot-stm32-20201209 - Manage CONFIG_ENV_EXT4_DEVICE_AND_PART in stm32mp1 board - Update ARM STI and ARM STM STM32MP Arch maintainers emails - Enable internal pull-ups for SDMMC1 on DHCOM SoM CI status: https://gitlab.denx.de/u-boot/custodians/u-boot-stm/-/pipelines/5518 Thanks, Patrick git request-pull origin/master https://gitlab.denx.de/u-boot/custodians/u-boot-stm.git u-boot-stm32-20201209 The following changes since commit ec79f5ce2202cf6c56e5eb1eb755604b534ae08b: Merge https://gitlab.denx.de/u-boot/custodians/u-boot-marvell (2020-12-07 11:46:12 -0500) are available in the Git repository at: https://gitlab.denx.de/u-boot/custodians/u-boot-stm.git tags/u-boot-stm32-20201209 for you to fetch changes up to 9b36b7dc96baedc0ed506246a9822c745cc65b45: ARM: dts: stm32: Add USB OTG ID pin on DH AV96 (2020-12-09 10:57:50 +0100) ---------------------------------------------------------------- - Manage CONFIG_ENV_EXT4_DEVICE_AND_PART in stm32mp1 board - Update ARM STI and ARM STM STM32MP Arch maintainers emails - Enable internal pull-ups for SDMMC1 on DHCOM SoM ---------------------------------------------------------------- Manuel Reis (1): add check for ignored CONFIG_ENV_EXT4_DEVICE_AND_PART definition Marek Vasut (4): ARM: dts: stm32: Enable internal pull-ups for SDMMC1 on DHCOM SoM ARM: dts: stm32: Disable SDMMC1 CKIN feedback clock ARM: dts: stm32: Enable SDMMC3 on DH DRC02 ARM: dts: stm32: Add USB OTG ID pin on DH AV96 Patrice Chotard (3): MAINTAINERS: Update ARM STI and ARM STM STM32MP Arch maintainers emails treewide: Update email address Patrick Delaunay and Patrice Chotard .mailmap: map Patrick Delaunay and my email address .mailmap | 2 ++ MAINTAINERS | 6 +++--- arch/arm/dts/stm32mp15xx-dhcom-drc02.dts | 13 +++++++++++-- arch/arm/dts/stm32mp15xx-dhcom.dtsi | 15 ++++++++++++++- arch/arm/dts/stm32mp15xx-dhcor-avenger96.dts | 3 ++- arch/arm/include/asm/arch-stih410/sdhci.h | 2 +- arch/arm/include/asm/arch-stih410/sys_proto.h | 2 +- arch/arm/include/asm/arch-stm32/stm32f.h | 2 +- arch/arm/include/asm/arch-stm32f4/stm32_pwr.h | 2 +- arch/arm/include/asm/arch-stm32f7/stm32_pwr.h | 2 +- arch/arm/include/asm/arch-stm32h7/gpio.h | 2 +- arch/arm/include/asm/arch-stm32h7/stm32.h | 2 +- arch/arm/mach-stm32/soc.c | 2 +- board/st/stih410-b2260/board.c | 2 +- board/st/stm32f429-evaluation/stm32f429-evaluation.c | 2 +- board/st/stm32f469-discovery/stm32f469-discovery.c | 2 +- board/st/stm32h743-disco/stm32h743-disco.c | 2 +- board/st/stm32h743-eval/stm32h743-eval.c | 2 +- board/st/stm32mp1/stm32mp1.c | 11 +++++++++++ drivers/clk/clk_stm32h7.c | 2 +- drivers/misc/stm32_rcc.c | 2 +- drivers/mmc/sti_sdhci.c | 2 +- drivers/mmc/stm32_sdmmc2.c | 2 +- drivers/phy/sti_usb_phy.c | 2 +- drivers/pinctrl/pinctrl-sti.c | 2 +- drivers/reset/sti-reset.c | 2 +- drivers/reset/stm32-reset.c | 2 +- drivers/serial/serial_sti_asc.c | 2 +- drivers/sysreset/sysreset_sti.c | 2 +- drivers/timer/sti-timer.c | 2 +- drivers/timer/stm32_timer.c | 2 +- drivers/usb/host/dwc3-sti-glue.c | 2 +- drivers/video/backlight_gpio.c | 2 +- include/configs/stih410-b2260.h | 2 +- include/configs/stm32f429-evaluation.h | 2 +- include/configs/stm32f469-discovery.h | 2 +- include/configs/stm32h743-disco.h | 2 +- include/configs/stm32h743-eval.h | 2 +- include/dwc3-sti-glue.h | 2 +- include/stm32_rcc.h | 2 +-

2 1

Re: [PATCH] usb: dwc2: add "u-boot,force-vbus-detection" for stm32
by Patrick DELAUNAY 09 Dec '20

09 Dec '20

Hi Marek, On 12/9/20 5:22 PM, Patrick DELAUNAY wrote: > -----Original Message----- > From: Marek Vasut <marex(a)denx.de> > Sent: mardi 20 octobre 2020 12:21 > > On 10/16/20 6:32 PM, Patrick DELAUNAY wrote: >> Hi Marek, > Hi, > > [...] > >>>>> On 10/15/20 2:49 PM, Patrick Delaunay wrote: >>>>>> On some board, the ID pin is not connected so the B session must >>>>>> be overridden with "u-boot,force_b_session_valid" but the VBus >>>>>> sensing must continue to be handle. >>>>>> >>>>>> To managed it, this patch adds a new DT field >>>>>> "u-boot,force-vbus-detection" to use with "u-boot,force_b_session_valid" >>>>> How is this solved in Linux ? >>>> It is managed by Linux DWC2 driver: it is a real OTG driver, with >>>> dual mode support and by usb framework >>>> >>>> Throught the properties >>>> &usbotg_hs { >>>> usb-role-switch; >>>> }; >>>> >>>> a glue treat the session and the sensing management see >>>> linux/drivers/usb/dwc2/drd.c in linux-next >>>> >>>> PS: activate_stm_id_vb_detection is also used in driver = hsotg->params. >>>> >>>> As ID pin / vbus is completly managed by the USB TYPE driver C >>>> (STUSB1600 for STMicroelectronics board) and DWC2 driver with dual >>>> role stack (host/gadget). >>>> >>>> I don't found a better solution than device tree property for this >>>> task in U-Boot as DWC2 driver don't support dual role and U-Boot >>>> don't have >>> framework for USB type C controller. >>>>> btw can you do something about that huge change in indent ? Is it necessary ? >>>> I move all this code under activate_stm_id_vb_detection (linked to >>>> compatible "st,stm32mp1-hsotg") to avoid impact on other platform as >>>> this "sensing" properties are only support for STM32MP15X (it is >>>> linked to USB block detection integrated in SOC) >>>> >>>> And after I need to check the >>>> 1/ The usb33d-supply is required of vbus or IDPIN sensing 2/ manage >>>> Vbus sensing or override (according dt) 3/ manage IDPIN or override >>>> (according dt) >>>> >>>> I add a new property to be backward compatible (even it the >>>> combinaison is less clear) I protect regulator function call to >>>> avoid compilation >>> issue for other platform. >>>> PS: after reading the refmanual, I also split VALOEN and VALOVAL bit >>>> update >>> as it is required. >>>> So yes I think it is needed but I can split the patch to simplify the review. >>> I presume you don't feel like implementing proper OTG support, right ? >> Yes, I am afraid of this task. > Can you take a look ? > > I will pick this patch into next for now. I check this topic, I think I don't need to support OTG in dwc2 but I need to support USB port and connector as it is done in linux kernel. and I think that I can propose a plan (6 month-1 year) - Add a new u-class for USB connector based on linux/drivers/usb/typec/class.c => Allow to detect cable connection and USB mode (device / host) - Add a new driver for USB type C connector (compatible "usb-c-connector") - Migrate stusb1600 driver to use this new driver - Update driver (dwc2 or usbphyc or directly in uclass ?) to use connector when present in device tree (devicetree/bindings/connector/usb-connector.yaml) With these modifcations, I hope to have the same hooks than Linux. And for future - Add a USB typeC connector driver based on UCSI (linux/drivers/usb/typec/ucsi) https://www.intel.com/content/dam/www/public/us/en/documents/technical-spec… - Adapt other driver to use USB connector..... (as DWC3 for example to manage dual role with type-c) Patrick

2 1