January 2020 - U-Boot

[PATCH] Makefile: Let mrproper remove flash.bin and flash.log
by Fabio Estevam 23 Jan '20

23 Jan '20

In order to generate a bootable U-Boot binary for i.MX8QXP MEK we need to run: $ make imx8qxp_mek_defconfig $ make flash.bin The resultant flash.bin and flash.log are not removed after running 'make mrproper'. Include these files into the CLEAN_FILES list entry so that they can be properly deleted after 'make mrproper'. Signed-off-by: Fabio Estevam <festevam(a)gmail.com> --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 1766f5ab18..306939bb4e 100644 --- a/Makefile +++ b/Makefile @@ -1928,7 +1928,7 @@ CLEAN_FILES += include/bmp_logo.h include/bmp_logo_data.h tools/version.h \ boot* u-boot* MLO* SPL System.map fit-dtb.blob* \ u-boot-ivt.img.log u-boot-dtb.imx.log SPL.log u-boot.imx.log \ lpc32xx-* bl31.c bl31.elf bl31_*.bin image.map tispl.bin* \ - idbloader.img + idbloader.img flash.bin flash.log # Directories & files removed with 'make mrproper' MRPROPER_DIRS += include/config include/generated spl tpl \ -- 2.17.1

2 1

[RFC PATCH 0/5] arm: Restore minimal support for ST-Ericsson U8500 SoC
by Stephan Gerhold 23 Jan '20

23 Jan '20

This patch series restores minimal U-Boot support for the ST-Ericsson NovaThor U8500 SoC. Previous support for U8500 was removed in commit 68282f55b846 ("arm: Remove unused ST-Ericsson u8500 arch") since none of the boards were converted to generic boards before the deadline. The motivation for adding the SoC and board is explained in - Patch 3 ("arm: Add support for ST-Ericsson U8500 SoC") and - Patch 5 ("board: Add new Samsung "stemmy" board based on ST-Ericsson U8500") I have additional patches for MMC, USB, display and the "stemmy" board, that configure it to provide an Android fastboot interface with similar functionality as the original Samsung bootloader. Some of the patches require some additional work, so I thought it is easier to start with some minimal changes first (only UART). I think this makes the patch series quite straightforward, with only ~225 new lines of C code, plus device tree and documentation. The only patch that stands out with ~1.8k lines is the device tree import, directly copied (without modification) from the Linux kernel. Stephan Gerhold (5): timer: Add driver for Nomadik Multi Timer Unit (MTU) arm: dts: Import device tree for ST-Ericsson Ux500 arm: Add support for ST-Ericsson U8500 SoC MAINTAINERS: Add ARM U8500 board: Add new Samsung "stemmy" board based on ST-Ericsson U8500 MAINTAINERS | 8 + arch/arm/Kconfig | 20 + arch/arm/Makefile | 1 + arch/arm/dts/Makefile | 2 + arch/arm/dts/ste-ab8500.dtsi | 328 ++++++ arch/arm/dts/ste-ab8505.dtsi | 275 +++++ arch/arm/dts/ste-dbx5x0-u-boot.dtsi | 29 + arch/arm/dts/ste-dbx5x0.dtsi | 1144 ++++++++++++++++++++ arch/arm/dts/ste-ux500-samsung-stemmy.dts | 20 + arch/arm/include/asm/gpio.h | 2 +- arch/arm/mach-u8500/Kconfig | 27 + arch/arm/mach-u8500/Makefile | 4 + arch/arm/mach-u8500/cache.c | 37 + arch/arm/mach-u8500/cpuinfo.c | 25 + board/ste/stemmy/Kconfig | 12 + board/ste/stemmy/MAINTAINERS | 6 + board/ste/stemmy/Makefile | 2 + board/ste/stemmy/README | 49 + board/ste/stemmy/stemmy.c | 18 + configs/stemmy_defconfig | 18 + drivers/timer/Kconfig | 9 + drivers/timer/Makefile | 1 + drivers/timer/nomadik-mtu-timer.c | 114 ++ include/configs/stemmy.h | 29 + include/dt-bindings/arm/ux500_pm_domains.h | 15 + include/dt-bindings/clock/ste-ab8500.h | 12 + include/dt-bindings/mfd/dbx500-prcmu.h | 84 ++ 27 files changed, 2290 insertions(+), 1 deletion(-) create mode 100644 arch/arm/dts/ste-ab8500.dtsi create mode 100644 arch/arm/dts/ste-ab8505.dtsi create mode 100644 arch/arm/dts/ste-dbx5x0-u-boot.dtsi create mode 100644 arch/arm/dts/ste-dbx5x0.dtsi create mode 100644 arch/arm/dts/ste-ux500-samsung-stemmy.dts create mode 100644 arch/arm/mach-u8500/Kconfig create mode 100644 arch/arm/mach-u8500/Makefile create mode 100644 arch/arm/mach-u8500/cache.c create mode 100644 arch/arm/mach-u8500/cpuinfo.c create mode 100644 board/ste/stemmy/Kconfig create mode 100644 board/ste/stemmy/MAINTAINERS create mode 100644 board/ste/stemmy/Makefile create mode 100644 board/ste/stemmy/README create mode 100644 board/ste/stemmy/stemmy.c create mode 100644 configs/stemmy_defconfig create mode 100644 drivers/timer/nomadik-mtu-timer.c create mode 100644 include/configs/stemmy.h create mode 100644 include/dt-bindings/arm/ux500_pm_domains.h create mode 100644 include/dt-bindings/clock/ste-ab8500.h create mode 100644 include/dt-bindings/mfd/dbx500-prcmu.h -- 2.24.1

3 18

[PATCH 1/1] trace: provide Sphinx style comments
by Heinrich Schuchardt 23 Jan '20

23 Jan '20

Correct some function comments. Convert to Sphinx style. Signed-off-by: Heinrich Schuchardt <xypron.glpk(a)gmx.de> --- lib/trace.c | 54 +++++++++++++++++++++++++++++++++++------------------ 1 file changed, 36 insertions(+), 18 deletions(-) diff --git a/lib/trace.c b/lib/trace.c index 6716c7c2f0..ea8c8e0d40 100644 --- a/lib/trace.c +++ b/lib/trace.c @@ -130,13 +130,13 @@ static void __attribute__((no_instrument_function)) add_textbase(void) } /** - * This is called on every function entry + * __cyg_profile_func_enter() - record function entry * * We add to our tally for this function and add to the list of called * functions. * - * @param func_ptr Pointer to function being entered - * @param caller Pointer to function which called this function + * @func_ptr: pointer to function being entered + * @caller: pointer to function which called this function */ void __attribute__((no_instrument_function)) __cyg_profile_func_enter( void *func_ptr, void *caller) @@ -161,12 +161,10 @@ void __attribute__((no_instrument_function)) __cyg_profile_func_enter( } /** - * This is called on every function exit + * __cyg_profile_func_exit() - record function exit * - * We do nothing here. - * - * @param func_ptr Pointer to function being entered - * @param caller Pointer to function which called this function + * @func_ptr: pointer to function being entered + * @caller: pointer to function which called this function */ void __attribute__((no_instrument_function)) __cyg_profile_func_exit( void *func_ptr, void *caller) @@ -180,16 +178,16 @@ void __attribute__((no_instrument_function)) __cyg_profile_func_exit( } /** - * Produce a list of called functions + * trace_list_functions() - produce a list of called functions * * The information is written into the supplied buffer - a header followed * by a list of function records. * - * @param buff Buffer to place list into - * @param buff_size Size of buffer - * @param needed Returns size of buffer needed, which may be - * greater than buff_size if we ran out of space. - * @return 0 if ok, -1 if space was exhausted + * @buff: buffer to place list into + * @buff_size: size of buffer + * @needed: returns size of buffer needed, which may be + * greater than buff_size if we ran out of space. + * Return: 0 if ok, -ENOSPC if space was exhausted */ int trace_list_functions(void *buff, size_t buff_size, size_t *needed) { @@ -236,6 +234,18 @@ int trace_list_functions(void *buff, size_t buff_size, size_t *needed) return 0; } +/** + * trace_list_functions() - produce a list of function calls + * + * The information is written into the supplied buffer - a header followed + * by a list of function records. + * + * @buff: buffer to place list into + * @buff_size: size of buffer + * @needed: returns size of buffer needed, which may be + * greater than buff_size if we ran out of space. + * Return: 0 if ok, -ENOSPC if space was exhausted + */ int trace_list_calls(void *buff, size_t buff_size, size_t *needed) { struct trace_output_hdr *output_hdr = NULL; @@ -281,7 +291,9 @@ int trace_list_calls(void *buff, size_t buff_size, size_t *needed) return 0; } -/* Print basic information about tracing */ +/** + * trace_print_stats() - print basic information about tracing + */ void trace_print_stats(void) { ulong count; @@ -320,10 +332,11 @@ void __attribute__((no_instrument_function)) trace_set_enabled(int enabled) } /** - * Init the tracing system ready for used, and enable it + * trace_init() - initialize the tracing system and enable it * - * @param buff Pointer to trace buffer - * @param buff_size Size of trace buffer + * @buff: Pointer to trace buffer + * @buff_size: Size of trace buffer + * Return: 0 if ok */ int __attribute__((no_instrument_function)) trace_init(void *buff, size_t buff_size) @@ -385,6 +398,11 @@ int __attribute__((no_instrument_function)) trace_init(void *buff, } #ifdef CONFIG_TRACE_EARLY +/** + * trace_early_init() - initialize the tracing system for early tracing + * + * Return: 0 if ok, -ENOSPC if not enough memory is available + */ int __attribute__((no_instrument_function)) trace_early_init(void) { ulong func_count = gd->mon_len / FUNC_SITE_SIZE; -- 2.24.1

3 2

[PATCH] lib: ignore oid_registry_data.c file
by Dario Binacchi 23 Jan '20

23 Jan '20

The file is generated by scripts/build_OID_registry based on the include/linux/oid_registry.h file. Signed-off-by: Dario Binacchi <dariobin(a)libero.it> --- lib/.gitignore | 1 + 1 file changed, 1 insertion(+) create mode 100644 lib/.gitignore diff --git a/lib/.gitignore b/lib/.gitignore new file mode 100644 index 0000000000..72ff0e993b --- /dev/null +++ b/lib/.gitignore @@ -0,0 +1 @@ +oid_registry_data.c -- 2.24.0

2 1

[PATCH] env: another attempt at fixing SPL build failures
by Rasmus Villemoes 23 Jan '20

23 Jan '20

I'm also seeing the build failure that commit 7d4776545b env: solve compilation error in SPL tried to fix, namely that the reference to env_flags_validate from env_htab cannot be satisfied when flags.o is not built in. However, that commit got reverted by d90fc9c3de Revert "env: solve compilation error in SPL" Necessary, but not sufficient conditions to see this are CONFIG_SPL=y (obviously) CONFIG_SPL_ENV_SUPPORT=n (so flags.o does not get compiled) CONFIG_SPL_LIBCOMMON_SUPPORT=y (so env/built-in.o is part of the SPL link) Now, these are satisfied for e.g. imx6q_logic_defconfig. But that builds just fine, and spl/u-boot-spl.map lists .data.env_htab among the discarded (garbage collected) sections. Yet, on our mpc8309-derived board, we do see the build failure, so perhaps the linker works a bit differently on ppc than on ARM, or there's yet some other configuration option needed to observe the break. This is another attempt at solving it, which also cleans up env/Makefile a bit: Introduce a def_bool y symbol CONFIG_ENV_SUPPORT which complements CONFIG_(SPL/TPL)_SUPPORT. Then use CONFIG_$(SPL_TPL_)ENV_SUPPORT to decide whether to include the five basic env/*.o files. For attr.o, flags.o and callback.o, this shouldn't change anything. Also, common.o and env.o still get unconditionally built for U-boot proper. But for TPL/SPL, those two are only included if CONFIG_(SPL/TPL)_SUPPORT is set. Having that symbol should also allow simplifying conditionals such as #if !defined(CONFIG_SPL_BUILD) || CONFIG_IS_ENABLED(ENV_SUPPORT) found in drivers/reset/reset-socfpga.c to just CONFIG_IS_ENABLED(ENV_SUPPORT). Signed-off-by: Rasmus Villemoes <rasmus.villemoes(a)prevas.dk> --- env/Kconfig | 3 +++ env/Makefile | 13 +++++-------- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/env/Kconfig b/env/Kconfig index ed12609f6a..4661082f0e 100644 --- a/env/Kconfig +++ b/env/Kconfig @@ -1,5 +1,8 @@ menu "Environment" +config ENV_SUPPORT + def_bool y + config ENV_IS_NOWHERE bool "Environment is not stored" default y if !ENV_IS_IN_EEPROM && !ENV_IS_IN_EXT4 && \ diff --git a/env/Makefile b/env/Makefile index 90144d6caf..e2a165b8f1 100644 --- a/env/Makefile +++ b/env/Makefile @@ -3,12 +3,13 @@ # (C) Copyright 2004-2006 # Wolfgang Denk, DENX Software Engineering, wd(a)denx.de. -obj-y += common.o env.o +obj-$(CONFIG_$(SPL_TPL_)ENV_SUPPORT) += common.o +obj-$(CONFIG_$(SPL_TPL_)ENV_SUPPORT) += env.o +obj-$(CONFIG_$(SPL_TPL_)ENV_SUPPORT) += attr.o +obj-$(CONFIG_$(SPL_TPL_)ENV_SUPPORT) += flags.o +obj-$(CONFIG_$(SPL_TPL_)ENV_SUPPORT) += callback.o ifndef CONFIG_SPL_BUILD -obj-y += attr.o -obj-y += callback.o -obj-y += flags.o obj-$(CONFIG_ENV_IS_IN_EEPROM) += eeprom.o extra-$(CONFIG_ENV_IS_EMBEDDED) += embedded.o obj-$(CONFIG_ENV_IS_IN_EEPROM) += embedded.o @@ -19,10 +20,6 @@ obj-$(CONFIG_ENV_IS_IN_ONENAND) += onenand.o obj-$(CONFIG_ENV_IS_IN_SATA) += sata.o obj-$(CONFIG_ENV_IS_IN_REMOTE) += remote.o obj-$(CONFIG_ENV_IS_IN_UBI) += ubi.o -else -obj-$(CONFIG_$(SPL_TPL_)ENV_SUPPORT) += attr.o -obj-$(CONFIG_$(SPL_TPL_)ENV_SUPPORT) += flags.o -obj-$(CONFIG_$(SPL_TPL_)ENV_SUPPORT) += callback.o endif obj-$(CONFIG_$(SPL_TPL_)ENV_IS_NOWHERE) += nowhere.o -- 2.23.0

2 6

[PATCH] spl_fit.c: enable loading compressed u-boot from fit image
by Rasmus Villemoes 23 Jan '20

23 Jan '20

From: "Klaus H. Sorensen" <khso(a)prevas.dk> Allow reading compressed content from fit image, even if CONFIG_SPL_OS_BOOT is not set. This allow booting compressed 2nd stage u-boot from fit image. Additionally, do not print warning message if compression node is not found, since it simply implies the content is uncompressed. Signed-off-by: Klaus H. Sorensen <khso(a)prevas.dk> Signed-off-by: Rasmus Villemoes <rasmus.villemoes(a)prevas.dk> --- common/spl/spl_fit.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/common/spl/spl_fit.c b/common/spl/spl_fit.c index b3e3ccd5a2..98271eb878 100644 --- a/common/spl/spl_fit.c +++ b/common/spl/spl_fit.c @@ -195,11 +195,9 @@ static int spl_load_fit_image(struct spl_load_info *info, ulong sector, debug("%s ", genimg_get_type_name(type)); } - if (IS_ENABLED(CONFIG_SPL_OS_BOOT) && IS_ENABLED(CONFIG_SPL_GZIP)) { - if (fit_image_get_comp(fit, node, &image_comp)) - puts("Cannot get image compression format.\n"); - else - debug("%s ", genimg_get_comp_name(image_comp)); + if (IS_ENABLED(CONFIG_SPL_GZIP)) { + fit_image_get_comp(fit, node, &image_comp); + debug("%s ", genimg_get_comp_name(image_comp)); } if (fit_image_get_load(fit, node, &load_addr)) -- 2.23.0

3 3

[U-Boot] [PATCH] cmd: pxe: execute the cls command only when supported
by Patrick Delaunay 23 Jan '20

23 Jan '20

Execute the command cls (for clear screen), when the "menu background" keyword is present in extlinux.conf file, only if the command is supported. This patch avoid the warning "Unknown command 'cls'" with "menu background" in extlinux.conf when CONFIG_CMD_BMP is activated and CONFIG_CMD_CLS not activated (default for CONFIG_DM_VIDEO). Signed-off-by: Patrick Delaunay <patrick.delaunay(a)st.com> --- cmd/pxe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cmd/pxe.c b/cmd/pxe.c index 2059975446..b62cb79b3a 100644 --- a/cmd/pxe.c +++ b/cmd/pxe.c @@ -1592,7 +1592,8 @@ static void handle_pxe_menu(cmd_tbl_t *cmdtp, struct pxe_menu *cfg) /* display BMP if available */ if (cfg->bmp) { if (get_relfile(cmdtp, cfg->bmp, load_addr)) { - run_command("cls", 0); + if (CONFIG_IS_ENABLED(CMD_CLS)) + run_command("cls", 0); bmp_display(load_addr, BMP_ALIGN_CENTER, BMP_ALIGN_CENTER); } else { -- 2.17.1

3 2

[U-Boot] [PATCH v2] spl: Allow cache drivers to be used in SPL
by Ley Foon Tan 23 Jan '20

23 Jan '20

Add an option for building cache drivers in SPL. Signed-off-by: Ley Foon Tan <ley.foon.tan(a)intel.com> --- v2: - Added "depends on CACHE" to SPL_CACHE. - Change to use $(CONFIG_$(SPL_TPL_)CACHE) to enable cache DM build. --- common/spl/Kconfig | 6 ++++++ drivers/Makefile | 1 + drivers/cache/Makefile | 2 +- 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/common/spl/Kconfig b/common/spl/Kconfig index 1f122833a7..ce119d1cc6 100644 --- a/common/spl/Kconfig +++ b/common/spl/Kconfig @@ -714,6 +714,12 @@ config SPL_UBI README.ubispl for more info. if SPL_DM +config SPL_CACHE + depends on CACHE + bool "Support cache drivers in SPL" + help + Enable support for cache drivers in SPL. + config SPL_DM_SPI bool "Support SPI DM drivers in SPL" help diff --git a/drivers/Makefile b/drivers/Makefile index 0befeddfcb..aed591c614 100644 --- a/drivers/Makefile +++ b/drivers/Makefile @@ -1,5 +1,6 @@ # SPDX-License-Identifier: GPL-2.0+ +obj-$(CONFIG_$(SPL_TPL_)CACHE) += cache/ obj-$(CONFIG_$(SPL_TPL_)CLK) += clk/ obj-$(CONFIG_$(SPL_TPL_)DM) += core/ obj-$(CONFIG_$(SPL_TPL_)DFU) += dfu/ diff --git a/drivers/cache/Makefile b/drivers/cache/Makefile index 4a6458c602..924217044a 100644 --- a/drivers/cache/Makefile +++ b/drivers/cache/Makefile @@ -1,5 +1,5 @@ -obj-$(CONFIG_CACHE) += cache-uclass.o +obj-$(CONFIG_$(SPL_TPL_)CACHE) += cache-uclass.o obj-$(CONFIG_SANDBOX) += sandbox_cache.o obj-$(CONFIG_L2X0_CACHE) += cache-l2x0.o obj-$(CONFIG_V5L2_CACHE) += cache-v5l2.o -- 2.19.0

3 3

[PATCH 00/11] rk3399: SPI boot support (fixes, updates)
by Jagan Teki 23 Jan '20

23 Jan '20

This series support SPI boot on rk3399 in ROC-PC-RK3399 as an example board. Series introduces rk_spi fixes, sf distroboot, SPI boot support on ROC-PC-RK3399 board. SPI Boot log: ------------ Channel 0: LPDDR4, 50MHz BW=32 Col=10 Bk=8 CS0 Row=15 CS1 Row=15 CS=2 Die BW=16 Size=2048MB Channel 1: LPDDR4, 50MHz BW=32 Col=10 Bk=8 CS0 Row=15 CS1 Row=15 CS=2 Die BW=16 Size=2048MB 256B stride 256B stride lpddr4_set_rate: change freq to 400000000 mhz 0, 1 lpddr4_set_rate: change freq to 800000000 mhz 1, 0 U-Boot SPL 2020.01-rc4-00241-g9c3e7e925f (Dec 18 2019 - 19:54:46 +0530) Trying to boot from SPI U-Boot 2020.01-rc4-00241-g9c3e7e925f (Dec 18 2019 - 19:54:46 +0530) Model: Firefly ROC-RK3399-PC Board DRAM: 3.9 GiB PMIC: RK808 MMC: dwmmc@fe320000: 1, sdhci@fe330000: 0 Loading Environment from SPI Flash... SF: Detected w25q128 with page size 256 Bytes, erase size 4 KiB, total 16 MiB *** Warning - bad CRC, using default environment In: serial@ff1a0000 Out: serial@ff1a0000 Err: serial@ff1a0000 Model: Firefly ROC-RK3399-PC Board rockchip_dnl_key_pressed: adc_channel_single_shot fail! Net: Error: ethernet@fe300000 address not set. No ethernet found. Hit any key to stop autoboot: 0 => Any inputs? Jagan. Jagan Teki (11): spi: rk: Limit transfers to (64K - 1) bytes distro_bootcmd: Add SF support rockchip: Include SF on distrocmd devices rk3399: Add boot flash script offet, size rk3399: Check MMC env while defining it env: kconfig: Restrict rockchip env for MMC env: Enable SPI flash env for rockchip rockchip: dts: Sync ROC-RK3399-PC changes from Linux roc-pc-rk3399: Enable SPI Flash rockpro-rk3399: Enable SPI Flash roc-rk3399-pc: Add SPI boot support arch/arm/dts/rk3399-roc-pc-u-boot.dtsi | 16 +- arch/arm/dts/rk3399-roc-pc.dts | 673 +----------------- arch/arm/dts/rk3399-roc-pc.dtsi | 813 ++++++++++++++++++++++ arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 4 + board/rockchip/evb_rk3399/MAINTAINERS | 2 + configs/roc-pc-rk3399-spi_defconfig | 62 ++ configs/roc-pc-rk3399_defconfig | 2 + configs/rockpro64-rk3399_defconfig | 2 + drivers/spi/rk_spi.c | 10 +- env/Kconfig | 8 +- include/config_distro_bootcmd.h | 35 + include/configs/evb_rk3399.h | 4 +- include/configs/rk3399_common.h | 2 + include/configs/rockchip-common.h | 7 + 14 files changed, 964 insertions(+), 676 deletions(-) create mode 100644 arch/arm/dts/rk3399-roc-pc.dtsi create mode 100644 configs/roc-pc-rk3399-spi_defconfig -- 2.18.0.321.gffc6fa0e3

6 44

[PATCH v2 4/4] clock_imx8mq: Make frac_pll_init() static
by Pedro Jardim 23 Jan '20

23 Jan '20

Since frac_pll_init() is only used in this file, change it to 'static'. This fixes the following sparse warning: arch/arm/mach-imx/imx8m/clock_imx8mq.c:662:5: warning: no previous prototype for ‘frac_pll_init’ [-Wmissing-prototypes] Signed-off-by: Pedro Jardim <jardim.c.pedro(a)gmail.com> --- Chages since v1: - Fixed patch corruption arch/arm/mach-imx/imx8m/clock_imx8mq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-imx/imx8m/clock_imx8mq.c b/arch/arm/mach-imx/imx8m/clock_imx8mq.c index 72a70d8c45..aad9cf13ef 100644 --- a/arch/arm/mach-imx/imx8m/clock_imx8mq.c +++ b/arch/arm/mach-imx/imx8m/clock_imx8mq.c @@ -636,7 +636,7 @@ void dram_pll_init(ulong pll_val) ; } -int frac_pll_init(u32 pll, enum frac_pll_out_val val) +static int frac_pll_init(u32 pll, enum frac_pll_out_val val) { void __iomem *pll_cfg0, __iomem *pll_cfg1; u32 val_cfg0, val_cfg1; -- 2.17.1

1 0