September 2019 - U-Boot

[U-Boot] [PATCH] ARM: mxs: spl_boot.c: make early_delay more robust
by Rasmus Villemoes 11 Sep '19

11 Sep '19

It's true that booting normally doesn't take long enough for the register to roll (which actually happens in a little over an hour, not just a few seconds). However, the counter starts at power-on, and if the board is held in reset to be booted over USB, one actually risks hitting wrap-around during boot, which can both result in too short delays (if the "st += delay" calculation makes st small) and theoretically also unbound delays (if st ends up being UINT_MAX and one just misses sampling digctl_microseconds at that point). It doesn't take more code to DTRT, and once bitten, twice shy. Signed-off-by: Rasmus Villemoes <rasmus.villemoes(a)prevas.dk> --- arch/arm/cpu/arm926ejs/mxs/spl_boot.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/arch/arm/cpu/arm926ejs/mxs/spl_boot.c b/arch/arm/cpu/arm926ejs/mxs/spl_boot.c index cb361ac65c..336266fe82 100644 --- a/arch/arm/cpu/arm926ejs/mxs/spl_boot.c +++ b/arch/arm/cpu/arm926ejs/mxs/spl_boot.c @@ -24,9 +24,7 @@ static bd_t bdata __section(".data"); /* * This delay function is intended to be used only in early stage of boot, where - * clock are not set up yet. The timer used here is reset on every boot and - * takes a few seconds to roll. The boot doesn't take that long, so to keep the - * code simple, it doesn't take rolling into consideration. + * clock are not set up yet. */ void early_delay(int delay) { @@ -34,8 +32,7 @@ void early_delay(int delay) (struct mxs_digctl_regs *)MXS_DIGCTL_BASE; uint32_t st = readl(&digctl_regs->hw_digctl_microseconds); - st += delay; - while (st > readl(&digctl_regs->hw_digctl_microseconds)) + while (readl(&digctl_regs->hw_digctl_microseconds) - st <= delay) ; } -- 2.20.1

2 1

[U-Boot] Please pull u-boot-x86
by Bin Meng 10 Sep '19

10 Sep '19

Hi Tom, This PR includes the following x86 changes for v2019.10: - Tangier ACPI table fixes - Support getting high memory size on QEMU x86 - Show UEFI images involved in crash for x86 - EFI loader conventional memory map fix The following changes since commit c705fc3b40b88bfbf465448643c91da71426df2f: arm: ti: Add missing "=" from previous fix (2019-09-09 10:55:45 -0400) are available in the git repository at: https://gitlab.denx.de/u-boot/custodians/u-boot-x86 for you to fetch changes up to dd4faa964f0741c314b4f1c09f27c07aedc5cdf0: x86: tangier: Use spaces over TABs in ASL code (2019-09-10 16:19:03 +0800) ---------------------------------------------------------------- Andy Shevchenko (6): tools: Add ifwitool to .gitignore x86: acpi: Slightly reduce binary size of ACPI tables for Tangier x86: acpi: Annotate struct acpi_table_header with __packed x86: tangier: Reserve PCI ECAM in motherboard resources x86: tangier: Fix off-by-one error when preparing CSRT x86: tangier: Use spaces over TABs in ASL code Bin Meng (4): x86: Drop weak version board_get_usable_ram_top() x86: qemu: Extract getting memory size to a separate routine x86: qemu: Support getting high memory size x86: qemu: Report high memory in the E820 table Heinrich Schuchardt (1): x86: show UEFI images involved in crash Park, Aiden (2): doc: slimbootloader: Update Linux booting steps on QEMU x86: efi_loader: Use efi_add_conventional_memory_map() arch/x86/cpu/i386/interrupt.c | 14 ++++++++++++++ arch/x86/cpu/qemu/dram.c | 36 ++++++++++++++++++++++++++++++++---- arch/x86/cpu/qemu/e820.c | 59 ++++++++++++++++++++++++++++++++++++++++------------------- arch/x86/cpu/tangier/acpi.c | 5 +++-- arch/x86/include/asm/acpi_table.h | 2 +- arch/x86/include/asm/arch-qemu/qemu.h | 18 ++++++++++++++++++ arch/x86/include/asm/arch-tangier/acpi/platform.asl | 3 ++- arch/x86/include/asm/arch-tangier/acpi/southcluster.asl | 47 ++++++++++++++++++++++++++++++++--------------- arch/x86/include/asm/arch-tangier/iomap.h | 10 ++++++++++ arch/x86/lib/e820.c | 17 ++++++++++++++--- arch/x86/lib/init_helpers.c | 6 ------ doc/board/intel/slimbootloader.rst | 22 ++++++++++++++++++++++ tools/.gitignore | 1 + 13 files changed, 189 insertions(+), 51 deletions(-) create mode 100644 arch/x86/include/asm/arch-tangier/iomap.h Regards, Bin

2 1

[U-Boot] [PULL u-boot] Please pull u-boot-amlogic-20190910
by Neil Armstrong 10 Sep '19

10 Sep '19

Hi Tom, This PR simply adds support for dis_u2_susphy_quirk in the xhci-dwc3 driver to fix boot when a device is plugged only in the OTG capable port for libretech-ac and libretech-cc. Bin acked me for pushing this fix through my tree. The CI job is at https://gitlab.denx.de/u-boot/custodians/u-boot-amlogic/pipelines/642 Thanks, Neil The following changes since commit c705fc3b40b88bfbf465448643c91da71426df2f: arm: ti: Add missing "=" from previous fix (2019-09-09 10:55:45 -0400) are available in the Git repository at: https://gitlab.denx.de/u-boot/custodians/u-boot-amlogic.git tags/u-boot-amlogic-20190910 for you to fetch changes up to b35b8076828d1059c1fcc648ed8c8210ebe6a3dd: usb: xhci-dwc3: Add support for dis_u2_susphy_quirk (2019-09-10 10:00:53 +0200) ---------------------------------------------------------------- - Add support for dis_u2_susphy_quirk in the xhci-dwc3 driver to fix boot when a device is plugged only in the OTG capable port for libretech-ac and libretech-cc ---------------------------------------------------------------- Neil Armstrong (1): usb: xhci-dwc3: Add support for dis_u2_susphy_quirk drivers/usb/host/xhci-dwc3.c | 3 +++ 1 file changed, 3 insertions(+)

2 1

[U-Boot] [PATCH v2 0/2] arm64: dts: sun50i: Add support for A64 OLinuXino (with eMMC)
by Sunil Mohan Adapa 10 Sep '19

10 Sep '19

This is a follow up a patch that didn't create a separate dts: https://lists.denx.de/pipermail/u-boot/2019-July/379109.html A64 OLinuXino board from Olimex has three variants with onboard eMMC: A64-OLinuXino-1Ge16GW, A64-OLinuXino-1Ge4GW and A64-OLinuXino-2Ge8G-IND. In addition, there are two variants without eMMC. One without eMMC and one with SPI flash. This suggests the need for separate device tree for the three eMMC variants. The Linux kernel upstream has chosen to create and use a separate device tree for the eMMC variants instead of adding eMMC support existing device tree. These changes to Linux kernel are queued for Linux 5.4. https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux.git/commit/?h=s… This patch has been tested on A64-OLinuXino-1Ge16GW and is based on Linux device-tree. Changes: v2: Separate device tree for emmc models. Sunil Mohan Adapa (2): arm64: dts: sun50i: Add support for A64 OLinuXino (with eMMC) configs: sun50i: Add support for Olimex A64-Olinuxino-eMMC arch/arm/dts/Makefile | 1 + arch/arm/dts/sun50i-a64-olinuxino-emmc.dts | 23 ++++++++++++++++++++++ board/sunxi/MAINTAINERS | 5 +++++ configs/a64-olinuxino-emmc_defconfig | 17 ++++++++++++++++ 4 files changed, 46 insertions(+) create mode 100644 arch/arm/dts/sun50i-a64-olinuxino-emmc.dts create mode 100644 configs/a64-olinuxino-emmc_defconfig -- 2.20.1

2 4

[U-Boot] U-Boot: Environment flags broken for U-Boot
by Heiko Schocher 10 Sep '19

10 Sep '19

Hello Patrick, I am just testing U-Boot Environment flags and they do not work anymore with current mainline U-Boot ... I should have made some tbot test for it, but did not found yet time for it ... Here log with current mainline: => printenv heiko heiko=changed => env flags Available variable type flags (position 0): Flag Variable Type Name ---- ------------------ s - string d - decimal x - hexadecimal b - boolean i - IP address m - MAC address Available variable access flags (position 1): Flag Variable Access Name ---- -------------------- a - any r - read-only o - write-once c - change-default Static flags: Variable Name Variable Type Variable Access ------------- ------------- --------------- eth\d*addr MAC address any ipaddr IP address any gatewayip IP address any netmask IP address any serverip IP address any nvlan decimal any vlan decimal any dnsip IP address any heiko string write-once Active flags: Variable Name Variable Type Variable Access ------------- ------------- --------------- .flags string write-once netmask IP address any serverip IP address any heiko string write-once ipaddr IP address any => setenv heiko foo => print heiko heiko=foo => setenv heiko bar => print heiko heiko=bar I can change Environment variable "heiko" but flag is write-once ! Ok, digging around and I found, that in env/common.c changed_ok is NULL which results in not checking U-Boot flags: 26 struct hsearch_data env_htab = { 27 #if CONFIG_IS_ENABLED(ENV_SUPPORT) 28 /* defined in flags.c, only compile with ENV_SUPPORT */ 29 .change_ok = env_flags_validate, 30 #endif 31 }; reason is your commit: commit 7d4776545b0f8a8827e5d061206faf61c9ba6ea9 Author: Patrick Delaunay <patrick.delaunay(a)st.com> Date: Thu Apr 18 17:32:49 2019 +0200 env: solve compilation error in SPL Solve compilation issue when cli_simple.o is used in SPL and CONFIG_SPL_ENV_SUPPORT is not defined. env/built-in.o:(.data.env_htab+0xc): undefined reference to `env_flags_validate' u-boot/scripts/Makefile.spl:384: recipe for target 'spl/u-boot-spl' failed make[2]: *** [spl/u-boot-spl] Error 1 u-boot/Makefile:1649: recipe for target 'spl/u-boot-spl' failed make[1]: *** [spl/u-boot-spl] Error 2 Signed-off-by: Patrick Delaunay <patrick.delaunay(a)st.com> ENV_SUPPORT is only defined for SPL and TPL not for U-Boot, which leads in change_ok always NULL in U-Boot ... :-( reverting this commit and it works again as expected ... Urgs ... since april 2019 nobody tested this feature :-( Nevertheless, reverting commit and I see: => print heiko heiko=test => setenv heiko foo ## Error inserting "heiko" variable, errno=1 => So we should find a solution for this. Any ideas? bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs(a)denx.de

5 13

[U-Boot] [PATCH] regulator: fixed: Modify enable-active-high behavior
by Patrice Chotard 10 Sep '19

10 Sep '19

Regulator should not be enabled at probe time if regulator-boot-on property is not in the dt node. "enable-active-high" property is only used to indicate the GPIO polarity. See kernel documentation : - Documentation/devicetree/bindings/regulator/fixed-regulator.yaml - Documentation/devicetree/bindings/regulator/gpio-regulator.yaml Signed-off-by: Christophe Kerello <christophe.kerello(a)st.com> Signed-off-by: Patrice Chotard <patrice.chotard(a)st.com> --- drivers/power/regulator/regulator_common.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/power/regulator/regulator_common.c b/drivers/power/regulator/regulator_common.c index 3dabbe2a85..2e8a083c75 100644 --- a/drivers/power/regulator/regulator_common.c +++ b/drivers/power/regulator/regulator_common.c @@ -15,7 +15,9 @@ int regulator_common_ofdata_to_platdata(struct udevice *dev, int flags = GPIOD_IS_OUT; int ret; - if (dev_read_bool(dev, "enable-active-high")) + if (!dev_read_bool(dev, "enable-active-high")) + flags |= GPIOD_ACTIVE_LOW; + if (uc_pdata->boot_on) flags |= GPIOD_IS_OUT_ACTIVE; /* Get optional enable GPIO desc */ -- 2.17.1

3 3

[U-Boot] [PATCH v2 0/8] power: pmic: support more PMIC
by Elaine Zhang 10 Sep '19

10 Sep '19

Support more PMIC and improve compatibility between pmics. Change in V2: [PATCH v2 1/8]: Add regulator suspend volatge and en/disable test. [PATCH v2 2/8]: Split the [PATCH v1 2/7], rk808 and rk818 updates. [PATCH v2 3/8]: Split the [PATCH v1 2/7], support rk816 pmic and update commit message. [PATCH v2 4/8]: Update commit message. [PATCH v2 5/8]: No change. [PATCH v2 6/8]: No change. [PATCH v2 7/8]: Remove rk809 keywords and update commit message. [PATCH v2 8/8]: Update commit message. Elaine Zhang (3): power: regulator: rk8xx: update the driver for rk808 and rk818 power: pmic: rk816: support rk816 pmic power: pmic: rk805: support rk805 pmic Joseph Chen (5): dm: regulator: support regulator more state dm: pmic: add pmic_shutdown() interface power: pmic: rk8xx: add pmic_shutdown() implement power: pmic: rk817: support rk817 pmic power: pmic: rk809: support rk809 pmic drivers/power/pmic/pmic-uclass.c | 11 + drivers/power/pmic/rk8xx.c | 135 ++++- drivers/power/regulator/regulator-uclass.c | 67 ++ drivers/power/regulator/rk8xx.c | 939 ++++++++++++++++++++++++++--- include/power/pmic.h | 9 + include/power/regulator.h | 42 ++ include/power/rk8xx_pmic.h | 42 ++ test/dm/regulator.c | 46 ++ 8 files changed, 1203 insertions(+), 88 deletions(-) -- 1.9.1

1 8

[U-Boot] [RFC][PATCH] bootcount: add support to customize bootcount variable name
by Philippe Reynes 10 Sep '19

10 Sep '19

This commit add an option to customize the bootcount variable name in the u-boot environment. To stay compatible with old config, the default name is bootcount. Signed-off-by: Philippe Reynes <philippe.reynes(a)softathome.com> --- drivers/bootcount/Kconfig | 8 ++++++++ drivers/bootcount/bootcount_env.c | 4 ++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/bootcount/Kconfig b/drivers/bootcount/Kconfig index b7c29f2..0088bf8 100644 --- a/drivers/bootcount/Kconfig +++ b/drivers/bootcount/Kconfig @@ -161,4 +161,12 @@ config SYS_BOOTCOUNT_MAGIC help Set the magic value used for the boot counter. +config SYS_BOOTCOUNT_NAME + string "Name of the bootcount variable in the env" + default "bootcount" + depends on BOOTCOUNT_ENV + help + Set the name of the variable that count the number of boot. + Usually this variable is named 'bootcount'. + endif diff --git a/drivers/bootcount/bootcount_env.c b/drivers/bootcount/bootcount_env.c index b75c900..d5a38c8 100644 --- a/drivers/bootcount/bootcount_env.c +++ b/drivers/bootcount/bootcount_env.c @@ -12,7 +12,7 @@ void bootcount_store(ulong a) int upgrade_available = env_get_ulong("upgrade_available", 10, 0); if (upgrade_available) { - env_set_ulong("bootcount", a); + env_set_ulong(CONFIG_SYS_BOOTCOUNT_NAME, a); env_save(); } } @@ -23,7 +23,7 @@ ulong bootcount_load(void) ulong val = 0; if (upgrade_available) - val = env_get_ulong("bootcount", 10, 0); + val = env_get_ulong(CONFIG_SYS_BOOTCOUNT_NAME, 10, 0); return val; } -- 2.7.4

3 3

[U-Boot] [PATCH v1 1/4] x86: acpi: Annotate struct acpi_table_header with __packed
by Andy Shevchenko 10 Sep '19

10 Sep '19

GCC starts complaining about possible pointer misalignment of pointers to the unpacked (alignment=4) structures in the packed (alignment=1) ones: CC arch/x86/cpu/tangier/acpi.o arch/x86/cpu/tangier/acpi.c: In function ‘acpi_create_fadt’: arch/x86/cpu/tangier/acpi.c:22:37: warning: taking address of packed member of ‘struct acpi_fadt’ may result in an unaligned pointer value [-Waddress-of-packed-member] 22 | struct acpi_table_header *header = &(fadt->header); CC arch/x86/lib/acpi_table.o arch/x86/lib/acpi_table.c: In function ‘acpi_create_spcr’: arch/x86/lib/acpi_table.c:366:37: warning: taking address of packed member of ‘struct acpi_spcr’ may result in an unaligned pointer value [-Waddress-of-packed-member] 366 | struct acpi_table_header *header = &(spcr->header); Fix the potential issues by annotating embedded structures with __packed even though they are packed naturally. Signed-off-by: Andy Shevchenko <andriy.shevchenko(a)linux.intel.com> --- arch/x86/include/asm/acpi_table.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/include/asm/acpi_table.h b/arch/x86/include/asm/acpi_table.h index 02aea127c1..7588913f93 100644 --- a/arch/x86/include/asm/acpi_table.h +++ b/arch/x86/include/asm/acpi_table.h @@ -34,7 +34,7 @@ struct acpi_rsdp { }; /* Generic ACPI header, provided by (almost) all tables */ -struct acpi_table_header { +struct __packed acpi_table_header { char signature[4]; /* ACPI signature (4 ASCII characters) */ u32 length; /* Table length in bytes (incl. header) */ u8 revision; /* Table version (not ACPI version!) */ -- 2.23.0.rc1

3 13

[U-Boot] [v2, 0/3] mmc: fsl_esdhc: clean up code
by Yangbo Lu 10 Sep '19

10 Sep '19

This patch-set is to clean up fsl_esdhc code. Changes for v2: - Involved esdhc_ops in non-DM conditional build. Yangbo Lu (3): mmc: fsl_esdhc: make BLK as hard requirement of DM_MMC mmc: fsl_esdhc: clean up code mmc: fsl_esdhc: rename fsl_esdhc_init to fsl_esdhc_get_cfg drivers/mmc/fsl_esdhc.c | 369 +++++++++++++++++++----------------------------- include/fsl_esdhc.h | 203 ++++++++++++-------------- 2 files changed, 240 insertions(+), 332 deletions(-) -- 2.7.4

2 4