September 2019 - U-Boot

[U-Boot] [PATCH] board: imx6dl_mamoj: set the value for CSF size
by Stefano Babic 20 Sep '19

20 Sep '19

Default value is too high and it covers the worst case. SPL for imx6dl_mamoj becomes too big and cannot fit into the OCRAM, but CSF size can be reduced. Signed-off-by: Stefano Babic <sbabic(a)denx.de> CC: Jagan Teki <jagan(a)amarulasolutions.com> CC: Breno Lima <breno.lima(a)nxp.com> --- configs/imx6dl_mamoj_defconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configs/imx6dl_mamoj_defconfig b/configs/imx6dl_mamoj_defconfig index 44486cbfa3..983d98536c 100644 --- a/configs/imx6dl_mamoj_defconfig +++ b/configs/imx6dl_mamoj_defconfig @@ -4,12 +4,13 @@ CONFIG_SYS_TEXT_BASE=0x17800000 CONFIG_SECURE_BOOT=y CONFIG_TARGET_MX6DL_MAMOJ=y CONFIG_NR_DRAM_BANKS=1 +CONFIG_CSF_SIZE=0x2060 # CONFIG_CMD_BMODE is not set +CONFIG_SPL_TEXT_BASE=0x00908000 CONFIG_DISTRO_DEFAULTS=y CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=arch/arm/mach-imx/spl_sd.cfg" CONFIG_BOOTDELAY=3 CONFIG_BOUNCE_BUFFER=y -CONFIG_SPL_TEXT_BASE=0x00908000 CONFIG_SPL_OS_BOOT=y CONFIG_CRC32_VERIFY=y CONFIG_CMD_MEMTEST=y -- 2.17.1

1 0

[U-Boot] Question about device tree usage and ranges
by Aaron Williams 20 Sep '19

20 Sep '19

Hi, In my device tree I need to translate some address via ranges but I'm running into some issues. If I use ofnode_get_addr_size() it is not using the #address-cells and #size-cells nor is it performing the ranges translation. It always assumes #address-cells and #size-cells is 2 and doesn't translate. Is this by design? If, on the other hand, I use ofnode_get_addr_size_index, it is having problems on ARM64. One problem I see is in of_translate_one in fdt_support.c. Shouldn't there be a fdt32_to_cpu or fdt64_to_cpu for the address after the memcpy in of_translate_one? I'm seeing the wrong endian address and size show up. OF: ** translation for device console@0 ** __of_translate_address: bus: default, address: 00000007fff46d7d OF: bus is default (na=1, ns=1) on pci-console@0x03000000 OF: translating address: 00000000 OF: parent bus is default (na=2, ns=2) on soc@0 OF: walking ranges... OF: default map, cp=0, s=1, da=0 OF: parent translation for: 80003000 80400000 <======= WRONG ENDIAN! OF: with offset: 0 OF: one level translation: 80003000 80400000 <======= WRONG ENDIAN! OF: parent bus is default (na=2, ns=2) on OF: no ranges, 1:1 translation -Aaron

2 3

[U-Boot] [BUG] FreeBSD cannot boot with U-Boot patch efi_loader: parameter checks BLOCK_IO_PROTOCOL
by Heinrich Schuchardt 19 Sep '19

19 Sep '19

Hello Emmanuel, booting current FreeBSD fails since patch f59f0825e8b9fdeb8abe43ffd10c5119ca1a032f efi_loader: parameter checks BLOCK_IO_PROTOCOL The reason is that the buffer used by FreeBSD to read is not block aligned. The UEFI spec requires that EFI_BLOCK_IO_PROTOCOL.ReadBlocks() returns EFI_INVALID_PARAMETER if the buffer is not properly aligned (i.e. is not a multiple of EFI_BLOCK_IO_MEDIA.IoAlign) FreeBSD does not guarantee this alignment, e.g. efi_disk_read_blocks() is called with buffer 00000000995b08d0 which is not aligned to a multiple of 512. FreeBSD function efipart_readwrite writes this error message: efipart_readwrite: rw=1, blk=62333952 size=1 status=2 The problem can be traced back to the FreeBSD line: stand/efi/libefi/efipart.c(1043) efipart_realstrategy(): blkbuf = malloc(blkio->Media->BlockSize); U-Boot does not yet implement the EFI_DISK_IO_PROTOCOL which is a wrapper for the EFI_BLOCK_IO_PROTOCOL allowing unaligned access. malloc() could be replaced in FreeBSD by AllocatePages() which returns a 4096 byte aligned memory block. Best regards Heinrich

1 1

[U-Boot] [PATCH] Revert "mx6sabresd: convert to DM_VIDEO"
by Fabio Estevam 19 Sep '19

19 Sep '19

The conversion to CONFIG_DM_VIDEO causes no output at all in the LVDS panel. Switch back to the non-DM video option until this is resolved, to avoid splashscreen functionality regression. This reverts commit f3592ceac9810b34801772b6d335d8f7cff4c287. Signed-off-by: Fabio Estevam <festevam(a)gmail.com> --- configs/mx6sabresd_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configs/mx6sabresd_defconfig b/configs/mx6sabresd_defconfig index e7e989df9c..b3853c544c 100644 --- a/configs/mx6sabresd_defconfig +++ b/configs/mx6sabresd_defconfig @@ -96,5 +96,5 @@ CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5 CONFIG_CI_UDC=y CONFIG_USB_HOST_ETHER=y CONFIG_USB_ETHER_ASIX=y -CONFIG_DM_VIDEO=y +CONFIG_VIDEO=y CONFIG_VIDEO_IPUV3=y -- 2.17.1

3 3

[U-Boot] [PATCH 1/2] mmc: add a driver callback for power-cycle
by Yann Gautier 19 Sep '19

19 Sep '19

Some MMC peripherals require specific power cycle sequence, where some registers need to be written between the regulator is turned off and then back on. This is the case for the MMC IP embedded in STM32MP1 SoC. In STM32MP157 reference manual [1], the power cycle sequence is: 1. Reset the SDMMC with the RCC.SDMMCxRST register bit. This will reset the SDMMC to the reset state and the CPSM and DPSM to the Idle state. 2. Disable the Vcc power to the card. 3. Set the SDMMC in power-cycle state. This will make that the SDMMC_D[7:0], SDMMC_CMD and SDMMC_CK are driven low, to prevent the card from being supplied through the signal lines. 4. After minimum 1ms enable the Vcc power to the card. 5. After the power ramp period set the SDMMC to the power-off state for minimum 1ms. The SDMMC_D[7:0], SDMMC_CMD and SDMMC_CK are set to drive “1”. 6. After the 1ms delay set the SDMMC to power-on state in which the SDMMC_CK clock will be enabled. 7. After 74 SDMMC_CK cycles the first command can be sent to the card. The step 3. cannot be handled by the current framework implementation. A new callback (host_power_cycle) is created, and called in mmc_power_cycle(), after mmc_power_off(). The incorrect power cycle sequence has shown some boot failures on STM32MP1 with some SD-cards, especially on cold boots when the input frequency is low (<= 25MHz). Those failures are no more seen with this correct power cycle sequence. [1] https://www.st.com/resource/en/reference_manual/DM00327659.pdf Signed-off-by: Yann Gautier <yann.gautier(a)st.com> --- drivers/mmc/mmc-uclass.c | 14 ++++++++++++++ drivers/mmc/mmc.c | 15 +++++++++++++++ include/mmc.h | 13 +++++++++++++ 3 files changed, 42 insertions(+) diff --git a/drivers/mmc/mmc-uclass.c b/drivers/mmc/mmc-uclass.c index 37c3843902..c7a832ca90 100644 --- a/drivers/mmc/mmc-uclass.c +++ b/drivers/mmc/mmc-uclass.c @@ -122,6 +122,20 @@ int mmc_set_enhanced_strobe(struct mmc *mmc) } #endif +int dm_mmc_host_power_cycle(struct udevice *dev) +{ + struct dm_mmc_ops *ops = mmc_get_ops(dev); + + if (ops->host_power_cycle) + return ops->host_power_cycle(dev); + return 0; +} + +int mmc_host_power_cycle(struct mmc *mmc) +{ + return dm_mmc_host_power_cycle(mmc->dev); +} + int mmc_of_parse(struct udevice *dev, struct mmc_config *cfg) { int val; diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c index c8f71cd0c1..2e68d21c51 100644 --- a/drivers/mmc/mmc.c +++ b/drivers/mmc/mmc.c @@ -1546,6 +1546,16 @@ static int mmc_set_ios(struct mmc *mmc) return ret; } + +static int mmc_host_power_cycle(struct mmc *mmc) +{ + int ret = 0; + + if (mmc->cfg->ops->host_power_cycle) + ret = mmc->cfg->ops->host_power_cycle(mmc); + + return ret; +} #endif int mmc_set_clock(struct mmc *mmc, uint clock, bool disable) @@ -2715,6 +2725,11 @@ static int mmc_power_cycle(struct mmc *mmc) ret = mmc_power_off(mmc); if (ret) return ret; + + ret = mmc_host_power_cycle(mmc); + if (ret) + return ret; + /* * SD spec recommends at least 1ms of delay. Let's wait for 2ms * to be on the safer side. diff --git a/include/mmc.h b/include/mmc.h index 686ba00656..54629bf45d 100644 --- a/include/mmc.h +++ b/include/mmc.h @@ -466,6 +466,16 @@ struct dm_mmc_ops { /* set_enhanced_strobe() - set HS400 enhanced strobe */ int (*set_enhanced_strobe)(struct udevice *dev); #endif + + /** + * host_power_cycle - host specific tasks in power cycle sequence + * Called between mmc_power_off() and + * mmc_power_on() + * + * @dev: Device to check + * @return 0 if not present, 1 if present, -ve on error + */ + int (*host_power_cycle)(struct udevice *dev); }; #define mmc_get_ops(dev) ((struct dm_mmc_ops *)(dev)->driver->ops) @@ -477,6 +487,7 @@ int dm_mmc_get_cd(struct udevice *dev); int dm_mmc_get_wp(struct udevice *dev); int dm_mmc_execute_tuning(struct udevice *dev, uint opcode); int dm_mmc_wait_dat0(struct udevice *dev, int state, int timeout_us); +int dm_mmc_host_power_cycle(struct udevice *dev); /* Transition functions for compatibility */ int mmc_set_ios(struct mmc *mmc); @@ -485,6 +496,7 @@ int mmc_getwp(struct mmc *mmc); int mmc_execute_tuning(struct mmc *mmc, uint opcode); int mmc_wait_dat0(struct mmc *mmc, int state, int timeout_us); int mmc_set_enhanced_strobe(struct mmc *mmc); +int mmc_host_power_cycle(struct mmc *mmc); #else struct mmc_ops { @@ -494,6 +506,7 @@ struct mmc_ops { int (*init)(struct mmc *mmc); int (*getcd)(struct mmc *mmc); int (*getwp)(struct mmc *mmc); + int (*host_power_cycle)(struct mmc *mmc); }; #endif -- 2.17.1

1 1

[U-Boot] [PATCH] arm64: zynqmp: Enable bind/unbind commands
by Michal Simek 19 Sep '19

19 Sep '19

These commands are useful in connection to usb and other devices that's why enable it by default. Signed-off-by: Michal Simek <michal.simek(a)xilinx.com> --- configs/xilinx_zynqmp_zcu102_revA_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/xilinx_zynqmp_zcu102_revA_defconfig b/configs/xilinx_zynqmp_zcu102_revA_defconfig index bdcd96d59947..f13a99d3521a 100644 --- a/configs/xilinx_zynqmp_zcu102_revA_defconfig +++ b/configs/xilinx_zynqmp_zcu102_revA_defconfig @@ -26,6 +26,7 @@ CONFIG_SYS_PROMPT="ZynqMP> " CONFIG_CMD_THOR_DOWNLOAD=y CONFIG_CMD_MEMTEST=y CONFIG_SYS_ALT_MEMTEST=y +CONFIG_CMD_BIND=y CONFIG_CMD_CLK=y CONFIG_CMD_DFU=y # CONFIG_CMD_FLASH is not set -- 2.17.1

1 0

[U-Boot] [PATCH 1/2] tools: imx8mimage: add SOC_TYPE
by Peng Fan 19 Sep '19

19 Sep '19

Add SOC_TYPE for i.MX8MN usage. i.MX8MN ivt_offset needs to be 0, and for flexspi, the rom_image_offset needs to be 4KB. Signed-off-by: Peng Fan <peng.fan(a)nxp.com> --- include/imximage.h | 1 + tools/imx8mimage.c | 20 ++++++++++++++++++-- 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/include/imximage.h b/include/imximage.h index 544babb53a..e8cc993f2b 100644 --- a/include/imximage.h +++ b/include/imximage.h @@ -79,6 +79,7 @@ enum imximage_cmd { CMD_LOADER, CMD_SECOND_LOADER, CMD_DDR_FW, + CMD_SOC_TYPE, }; enum imximage_fld_types { diff --git a/tools/imx8mimage.c b/tools/imx8mimage.c index 6c02337698..463bbb71a6 100644 --- a/tools/imx8mimage.c +++ b/tools/imx8mimage.c @@ -21,6 +21,10 @@ static uint32_t sld_header_off; static uint32_t ivt_offset; static uint32_t using_fit; +#define ROM_V1 1 /* V1 ROM for i.MX8MQ/MM */ +#define ROM_V2 2 /* V2 ROM for iMX8MN */ +static uint32_t version = ROM_V1; + #define CSF_SIZE 0x2000 #define HDMI_IVT_ID 0 #define IMAGE_IVT_ID 1 @@ -71,6 +75,7 @@ static table_entry_t imx8mimage_cmds[] = { {CMD_LOADER, "LOADER", "loader image", }, {CMD_SECOND_LOADER, "SECOND_LOADER", "2nd loader image", }, {CMD_DDR_FW, "DDR_FW", "ddr firmware", }, + {CMD_SOC_TYPE, "SOC_TYPE", "soc type", }, {-1, "", "", }, }; @@ -90,6 +95,15 @@ static void parse_cfg_cmd(int32_t cmd, char *token, char *name, int lineno) token); if (!strncmp(token, "sd", 2)) rom_image_offset = 0x8000; + if (version == ROM_V2) { + ivt_offset = 0; + if (!strncmp(token, "fspi", 4)) + rom_image_offset = 0x1000; + } + break; + case CMD_SOC_TYPE: + if (!strncmp(token, "IMX8MN", 6)) + version = ROM_V2; break; case CMD_LOADER: ap_img = token; @@ -491,8 +505,10 @@ void build_image(int ofd) * Record the second bootloader relative offset in * image's IVT reserved1 */ - imx_header[IMAGE_IVT_ID].fhdr.reserved1 = - sld_header_off - header_image_off; + if (version == ROM_V1) { + imx_header[IMAGE_IVT_ID].fhdr.reserved1 = + sld_header_off - header_image_off; + } sld_fd = open(sld_img, O_RDONLY | O_BINARY); if (sld_fd < 0) { fprintf(stderr, "%s: Can't open: %s\n", -- 2.16.4

1 1

[U-Boot] [PATCH 1/2] rockchip: evb-rk3288: Drop explicit SPL_TEXT
by Kever Yang 19 Sep '19

19 Sep '19

SPL_TEXT_BASE is 0x0 by default, based on the kconfig definition move in below commit. "configs: move CONFIG_SPL_TEXT_BASE to Kconfig" (sha1: f89d6133eef2e068f9c33853b6584d7fcbfa9d2e) So, don't define it explicitly. Signed-off-by: Kever Yang <kever.yang(a)rock-chips.com> --- configs/evb-rk3288_defconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/configs/evb-rk3288_defconfig b/configs/evb-rk3288_defconfig index 405fde0c80..8be66a600d 100644 --- a/configs/evb-rk3288_defconfig +++ b/configs/evb-rk3288_defconfig @@ -14,7 +14,6 @@ CONFIG_SILENT_CONSOLE=y CONFIG_DEFAULT_FDT_FILE="rk3288-evb-rk808.dtb" # CONFIG_DISPLAY_CPUINFO is not set CONFIG_DISPLAY_BOARDINFO_LATE=y -CONFIG_SPL_TEXT_BASE=0 CONFIG_CMD_GPIO=y CONFIG_CMD_GPT=y CONFIG_CMD_I2C=y -- 2.17.1

2 2

[U-Boot] [PATCH 0/7] rk3288: tinker/vyasa: Fixes for TPL/SPL boot
by Jagan Teki 19 Sep '19

19 Sep '19

These boot failure as encounter even from v2019.07 release, I have seen them now due to some requirement on feature additions. All these patches are fixing the respective TPL/SPL boot failures on tinker and vyasa rk3288 boards. patch 3/7 make dram init available for TPL build, if TPL/SPL bootchain boards, so it is better to test this for SPL-alone rk3288 board before merging. Any inputs? Jagan. Jagan Teki (6): rockchip: rk3288: vyasa: Drop ROCKCHIP_BROM_HELPER selection configs: vyasa-rk3288: Fix SPL_TEXT_BASE ram: rk3288: Initialize dram for TPL builds rockchip: spi-boot-order: Trival fix to newline missing configs: tinker: Drop explicit SPL_TEXT configs: tinker: Enable SDRAM, SPL stack Michael Trimarchi (1): rockchip: rk3288-tinker: Attach missing peripherals at SPL arch/arm/dts/rk3288-tinker-u-boot.dtsi | 26 ++++++++++++++++++------- arch/arm/mach-rockchip/rk3288/Kconfig | 1 - arch/arm/mach-rockchip/spl-boot-order.c | 2 +- configs/tinker-rk3288_defconfig | 9 ++++++++- configs/vyasa-rk3288_defconfig | 1 - drivers/ram/rockchip/sdram_rk3288.c | 15 +++++++++----- 6 files changed, 38 insertions(+), 16 deletions(-) -- 2.18.0.321.gffc6fa0e3

2 20

[U-Boot] [PATCH v2 0/2] Add sdhci dt caps & caps mask support
by Michal Simek 19 Sep '19

19 Sep '19

Hi, This patch series adds support for reading 64-bit dt properties & add support sdhci dt caps & caps mask. Thanks, Michal Changes in v2: - Moved newly added 64-bit funtion definations & prototypes below 32-bit functions. T Karthik Reddy (2): dm: core: Add functions to read 64-bit dt properties mmc: sdhci: Add support for dt caps & caps mask drivers/core/ofnode.c | 2 +- drivers/core/read.c | 10 ++++++++++ drivers/mmc/sdhci.c | 23 ++++++++++++++--------- include/dm/ofnode.h | 2 +- include/dm/read.h | 33 +++++++++++++++++++++++++++++++++ 5 files changed, 59 insertions(+), 11 deletions(-) -- 2.17.1

4 6