July 2019 - U-Boot

[U-Boot] [PATCH v3 00/18] Fixes for the DWC3 USB generic driver
by Jean-Jacques Hiblot 08 Aug '19

08 Aug '19

The original title was "Improvement for the DWC3 USB generic driver and fixes for the K2 platforms" but has been changed because using UCLASS_MISC actually breaks the driver The K2 platforms have shown boot issues after switching to the DWC3 generic driver. Those are due to the fact that the USB domains are not turned off before booting linux and the phy were not properly initialized. Fixing it by improving the DWC3-generic driver and handling the USB power domain in the PHY driver. At the same time this series introduce a new uclass (UCLASS_NOP) to replace usage of UCLASS_MISC in the USB wrapper because the MISC class now automatically binds all the child devices and that breaks the DWC3-generic driver. Improvements to the DWC3 generic driver are: - Fix it by switching to UCLASS_NOP - core: read quirks properties from DT and apply the fixes. - add a new host driver that uses the DWC3 core (more generic than xhci-dwc3). This should enable most platforms to drop their own version of the xhci-driver to use the generic one instead. This series also removes the now unused xhci-zynqmp driver and tries to better manage the Kconfig options related to DWC3 gadget/host mode selection. This has been tested with K2 and DRA7 platforms (host and device modes). Travis build: https://travis-ci.org/jjhiblot/u-boot/builds/515282720 v2 of this series has been tested by Siva Durga Prasad Paladugu <sivadur(a)xilinx.com> Changes in v3: - updated log message when defaulting to super speed Changes in v2: Add a test for the NOP uclass Update commit log Select USB_GADGET_DUALSPEED if USB_DWC3_GADGET is selected Jean-Jacques Hiblot (18): usb: dwc3-generic: remove dm_scan_fdt_dev() from the remove() callback usb: host: remove the xhci-zynqmp driver dm: Add a No-op uclass usb: dwc3: Use UCLASS_NOP instead of UCLASS_MISC for the DWC3 generic glue usb: dwc3: switch to peripheral mode when exiting usb: xhci: move xhci.h to include usb usb: dwc3: always use the inlined version of dwc3_host_init/dwc3_host_exit usb: dwc3-generic: use platdata usb: dwc3-generic: factorize code usb: dwc3-generic: add a new host driver that uses the dwc3 core usb: dwc3-generic: if no max speed is specified in DT, assume super speed usb: dwc3: Add dwc3_of_parse() to get quirks information from DT usb: dwc3: Kconfig: get rid of obsolete mode selection ARM: keystone: increase PSC timeout ARM: keystone: Do not enable the USB power domains at the board level phy: keystone-usb: handle the transition of the USB power domain configs: k2g_evm_defconfig: disable XHCI_DWC3 and enable KEYSTONE_USB_PHY ARM: DTS: keystone: complete the description of the USB PHY devices MAINTAINERS | 1 + arch/arm/dts/keystone-k2e-evm-u-boot.dtsi | 32 ++++ arch/arm/dts/keystone-k2g-evm-u-boot.dtsi | 28 ++++ arch/arm/dts/keystone-k2hk-evm-u-boot.dtsi | 14 ++ arch/arm/dts/keystone-k2l-evm-u-boot.dtsi | 18 +++ .../arm/mach-keystone/include/mach/psc_defs.h | 2 +- arch/sandbox/dts/test.dts | 12 ++ board/ti/ks2_evm/board.c | 13 -- configs/avnet_ultra96_rev1_defconfig | 1 - configs/evb-rk3328_defconfig | 1 + configs/k2g_evm_defconfig | 3 +- .../xilinx_zynqmp_zc1751_xm015_dc1_defconfig | 1 - .../xilinx_zynqmp_zc1751_xm016_dc2_defconfig | 1 - .../xilinx_zynqmp_zc1751_xm017_dc3_defconfig | 1 - configs/xilinx_zynqmp_zcu100_revC_defconfig | 1 - configs/xilinx_zynqmp_zcu102_rev1_0_defconfig | 1 - configs/xilinx_zynqmp_zcu102_revA_defconfig | 1 - configs/xilinx_zynqmp_zcu102_revB_defconfig | 1 - configs/xilinx_zynqmp_zcu104_revA_defconfig | 1 - configs/xilinx_zynqmp_zcu104_revC_defconfig | 1 - configs/xilinx_zynqmp_zcu106_revA_defconfig | 1 - configs/xilinx_zynqmp_zcu111_revA_defconfig | 1 - drivers/core/uclass.c | 5 + drivers/phy/keystone-usb-phy.c | 22 +++ drivers/usb/dwc3/Kconfig | 18 +-- drivers/usb/dwc3/core.c | 84 +++++++++- drivers/usb/dwc3/core.h | 6 +- drivers/usb/dwc3/dwc3-generic.c | 150 ++++++++++++++---- drivers/usb/host/Kconfig | 7 - drivers/usb/host/Makefile | 1 - drivers/usb/host/xhci-dwc3.c | 2 +- drivers/usb/host/xhci-exynos5.c | 2 +- drivers/usb/host/xhci-fsl.c | 2 +- drivers/usb/host/xhci-mem.c | 2 +- drivers/usb/host/xhci-mvebu.c | 2 +- drivers/usb/host/xhci-omap.c | 2 +- drivers/usb/host/xhci-pci.c | 2 +- drivers/usb/host/xhci-rcar.c | 2 +- drivers/usb/host/xhci-ring.c | 2 +- drivers/usb/host/xhci-rockchip.c | 2 +- drivers/usb/host/xhci-zynqmp.c | 146 ----------------- drivers/usb/host/xhci.c | 2 +- drivers/usb/phy/omap_usb_phy.c | 2 +- include/dm/uclass-id.h | 1 + {drivers/usb/host => include/usb}/xhci.h | 0 test/dm/Makefile | 1 + test/dm/nop.c | 73 +++++++++ 47 files changed, 421 insertions(+), 253 deletions(-) create mode 100644 arch/arm/dts/keystone-k2l-evm-u-boot.dtsi delete mode 100644 drivers/usb/host/xhci-zynqmp.c rename {drivers/usb/host => include/usb}/xhci.h (100%) create mode 100644 test/dm/nop.c -- 2.17.1

2 23

[U-Boot] [PATCH 0/4] Make some changes to SDP
by sherry sun 08 Aug '19

08 Aug '19

From: Sherry Sun <sherry.sun(a)nxp.com> This patchset adds: 1. Add usb_gadget_initialize() and usb_gadget_release() to initialize and release UDC during sdp download. 2. Add high speed endpoint descriptor for sdp. 3. Add a macro definition--CONFIG_SDP_LOADADDR as default sdp load address while SDP_WRITE and SDP_JUMP command addr is zero. Sherry Sun (4): imx: spl: Change USB boot device type SDP: use CONFIG_SDP_LOADADDR as default load address SDP: fix wrong usb request size and add high speed endpoint descriptor SDP: Call usb_gadget_initialize and usb_gadget_release to support UDC arch/arm/mach-imx/spl.c | 2 +- common/spl/spl_sdp.c | 4 ++++ drivers/usb/gadget/Kconfig | 4 ++++ drivers/usb/gadget/f_sdp.c | 39 +++++++++++++++++++++++++++++++++----- 4 files changed, 43 insertions(+), 6 deletions(-) -- 2.17.1

5 21

[U-Boot] [PATCH 0/3] USB: Add cadence USB3 gadget driver and host driver
by sherry sun 08 Aug '19

08 Aug '19

From: Sherry Sun <sherry.sun(a)nxp.com> These patches introduce new Cadence USBSS driver to U-Boot. The first patch is to add the Cadence USB3 IP(CDNS3) driver for the usb gadget, but the host mode is not supported now. The second patch introduce the xhci-imx8 usb host driver separately. The cdns3 usb gadget driver and xhci-imx8 host driver both use DM mode. The current driver has been validated on i.MX8 platform. Sherry Sun (3): USB: gadget: Add the cadence USB3 gadget driver USB: host: Add the USB3 host driver USB: gadget: core: introduce ->udc_set_speed() method Makefile | 1 + drivers/usb/Kconfig | 2 + drivers/usb/cdns3/Kconfig | 20 + drivers/usb/cdns3/Makefile | 5 + drivers/usb/cdns3/cdns3-generic.c | 176 ++ drivers/usb/cdns3/cdns3-nxp-reg-def.h | 158 ++ drivers/usb/cdns3/core.c | 408 +++++ drivers/usb/cdns3/core.h | 129 ++ drivers/usb/cdns3/dev-regs-macro.h | 116 ++ drivers/usb/cdns3/dev-regs-map.h | 117 ++ drivers/usb/cdns3/gadget-export.h | 26 + drivers/usb/cdns3/gadget.c | 2278 +++++++++++++++++++++++++ drivers/usb/cdns3/gadget.h | 238 +++ drivers/usb/cdns3/io.h | 30 + drivers/usb/cdns3/linux-compat.h | 16 + drivers/usb/gadget/epautoconf.c | 4 + drivers/usb/gadget/gadget_chips.h | 7 + drivers/usb/gadget/udc/Makefile | 1 + drivers/usb/gadget/udc/udc-core.c | 23 + drivers/usb/host/Kconfig | 9 + drivers/usb/host/Makefile | 1 + drivers/usb/host/xhci-imx8.c | 311 ++++ include/cdns3-uboot.h | 26 + include/linux/usb/gadget.h | 5 + include/usb/imx8_usb3_reg_def.h | 455 +++++ scripts/Makefile.spl | 1 + 26 files changed, 4563 insertions(+) create mode 100644 drivers/usb/cdns3/Kconfig create mode 100644 drivers/usb/cdns3/Makefile create mode 100644 drivers/usb/cdns3/cdns3-generic.c create mode 100644 drivers/usb/cdns3/cdns3-nxp-reg-def.h create mode 100644 drivers/usb/cdns3/core.c create mode 100644 drivers/usb/cdns3/core.h create mode 100644 drivers/usb/cdns3/dev-regs-macro.h create mode 100644 drivers/usb/cdns3/dev-regs-map.h create mode 100644 drivers/usb/cdns3/gadget-export.h create mode 100644 drivers/usb/cdns3/gadget.c create mode 100644 drivers/usb/cdns3/gadget.h create mode 100644 drivers/usb/cdns3/io.h create mode 100644 drivers/usb/cdns3/linux-compat.h create mode 100644 drivers/usb/host/xhci-imx8.c create mode 100644 include/cdns3-uboot.h create mode 100644 include/usb/imx8_usb3_reg_def.h -- 2.17.1

5 8

[U-Boot] [PATCH v3 0/5] dm: spi: Convert Freescale ESPI driver to driver
by Chuanhua Han 08 Aug '19

08 Aug '19

In order to convert the Freescale ESPI driver to the driver model, there are 5 related patches in the current patch set: 0001-spl-dm-disable-SPI-DM-flash-for-non-DM-SPL.patch 0002-dm-spi-Convert-Freescale-ESPI-driver-to-driver-model.patch 0003-powerpc-dts-t2080-add-espi-controller-node-support.patch 0004-powerpc-dts-t2080qds-add-espi-slave-nodes-support.patch 0005-configs-enable-espi-device-module-in-T2080QDS.patch The first patch is to solve the problem that spl can't work when spiboot, and this is required for SPI boot. The other four patches are supported by the driver model. This patchset already supports the full dm mode, and fsl_espi driver support both OF_CONTROL and PLATDATA. Chuanhua Han (5): spl: dm: disable SPI DM flash for non-DM SPL dm: spi: Convert Freescale ESPI driver to driver model powerpc: dts: t2080: add espi controller node support powerpc: dts: t2080qds: add espi slave nodes support configs: enable espi device module in T2080QDS arch/powerpc/dts/t2080.dtsi | 10 + arch/powerpc/dts/t2080qds.dts | 33 ++ configs/T2080QDS_NAND_defconfig | 2 + configs/T2080QDS_SDCARD_defconfig | 2 + configs/T2080QDS_SECURE_BOOT_defconfig | 2 + configs/T2080QDS_SPIFLASH_defconfig | 2 + configs/T2080QDS_SRIO_PCIE_BOOT_defconfig | 2 + configs/T2080QDS_defconfig | 2 + drivers/spi/fsl_espi.c | 454 +++++++++++++++------- include/config_uncmd_spl.h | 1 + 10 files changed, 376 insertions(+), 134 deletions(-) -- 2.17.1

2 7

[U-Boot] [PATCH] test/py: avb: Move AVB test to android dir
by Sam Protsenko 08 Aug '19

08 Aug '19

Signed-off-by: Sam Protsenko <semen.protsenko(a)linaro.org> --- test/py/tests/{ => test_android}/test_avb.py | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename test/py/tests/{ => test_android}/test_avb.py (100%) diff --git a/test/py/tests/test_avb.py b/test/py/tests/test_android/test_avb.py similarity index 100% rename from test/py/tests/test_avb.py rename to test/py/tests/test_android/test_avb.py -- 2.20.1

3 8

[U-Boot] [PATCH 1/2] avb: Fix build when CONFIG_OPTEE_TA_AVB is disabled
by Sam Protsenko 08 Aug '19

08 Aug '19

When having only these AVB related configs enabled: CONFIG_AVB_VERIFY=y CONFIG_CMD_AVB=y CONFIG_LIBAVB=y build fails with next errors: common/avb_verify.c: In function 'read_persistent_value': common/avb_verify.c:867:6: warning: implicit declaration of function 'get_open_session' common/avb_verify.c:870:45: error: 'struct AvbOpsData' has no member named 'tee' common/avb_verify.c:894:7: warning: implicit declaration of function 'invoke_func' common/avb_verify.c: In function 'write_persistent_value': common/avb_verify.c:931:45: error: 'struct AvbOpsData' has no member named 'tee' Guard read_persistent_value() and write_persistent_value() functions by checking if CONFIG_OPTEE_TA_AVB is enabled (as those are only used in that case) to fix the build with mentioned configuration. Signed-off-by: Sam Protsenko <semen.protsenko(a)linaro.org> --- common/avb_verify.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/common/avb_verify.c b/common/avb_verify.c index 32034d927c..36898a610f 100644 --- a/common/avb_verify.c +++ b/common/avb_verify.c @@ -851,6 +851,7 @@ static AvbIOResult get_size_of_partition(AvbOps *ops, return AVB_IO_RESULT_OK; } +#ifdef CONFIG_OPTEE_TA_AVB static AvbIOResult read_persistent_value(AvbOps *ops, const char *name, size_t buffer_size, @@ -968,6 +969,8 @@ free_name: return rc; } +#endif + /** * ============================================================================ * AVB2.0 AvbOps alloc/initialisation/free -- 2.20.1

3 6

[U-Boot] [PATCH] pci_ep: Fix Coverity warning
by Ramon Fried 08 Aug '19

08 Aug '19

Fix the following Coverity warning: CID 244086: Incorrect expression (BAD_COMPARE) Comparing pointer "ep_bar" against NULL using anything besides == or is likely to be incorrect. Fixes: 914026d25848 ("drivers: pci_ep: Introduce UCLASS_PCI_EP uclass") Signed-off-by: Ramon Fried <rfried.dev(a)gmail.com> --- drivers/pci_endpoint/pci_ep-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci_endpoint/pci_ep-uclass.c b/drivers/pci_endpoint/pci_ep-uclass.c index 2f9c70398d..9f53a9a9b9 100644 --- a/drivers/pci_endpoint/pci_ep-uclass.c +++ b/drivers/pci_endpoint/pci_ep-uclass.c @@ -43,7 +43,7 @@ int pci_ep_set_bar(struct udevice *dev, uint func_no, struct pci_bar *ep_bar) int flags = ep_bar->flags; /* Some basic bar validity checks */ - if (ep_bar->barno > BAR_5 || ep_bar < BAR_0) + if (ep_bar->barno > BAR_5 || ep_bar->barno < BAR_0) return -EINVAL; if ((ep_bar->barno == BAR_5 && -- 2.20.1

2 1

[U-Boot] [PATCH 1/3] MAINTAINERS: MediaTek: add MediaTek team in the entry
by Ryder Lee 08 Aug '19

08 Aug '19

Add MediaTek team as designated reviewer. Signed-off-by: Ryder Lee <ryder.lee(a)mediatek.com> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4285d56626..22adf6ade3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -195,6 +195,7 @@ F: arch/arm/include/asm/arch-pxa/ ARM MEDIATEK M: Ryder Lee <ryder.lee(a)mediatek.com> M: Weijie Gao <weijie.gao(a)mediatek.com> +R: GSS_MTK_Uboot_upstream <GSS_MTK_Uboot_upstream(a)mediatek.com> S: Maintained F: arch/arm/mach-mediatek/ F: arch/arm/include/asm/arch-mediatek/ -- 2.18.0

2 5

[U-Boot] [PATCH] autoboot: fix bug using with CAAM and AUTOBOOT_ENCRYPTION
by Heiko Schocher 08 Aug '19

08 Aug '19

if CONFIG_AUTOBOOT_KEYED, CONFIG_AUTOBOOT_ENCRYPTION and CONFIG_AUTOBOOT_STOP_STR_SHA256 are enabled in conjunction with CONFIG_SHA_HW_ACCEL and CONFIG_FSL_CAAM, we get the Error when pressing a key while waiting for bootdelay: Error: Address arguments are not aligned CAAM was not setup properly or it is faulty Reason is, that used variables are not cache aligned, so malloc this variables cache aligned. Probably this is also a bugfix for other hw accelerators than CAAM. Signed-off-by: Heiko Schocher <hs(a)denx.de> --- clean travis build: https://travis-ci.org/hsdenx/u-boot-test/builds/563021871 Unfortunately, another error in above scenario pops up, U-Boot crashes now, anybody used sha256 calculation with CAAM and SHA_HW_ACCEL ? Nevertheless, this fix is valid, and should be applied, to get rid of runtime error message. common/autoboot.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/common/autoboot.c b/common/autoboot.c index 94133eaeda..c69104e0e5 100644 --- a/common/autoboot.c +++ b/common/autoboot.c @@ -10,6 +10,7 @@ #include <cli.h> #include <console.h> #include <fdtdec.h> +#include <memalign.h> #include <menu.h> #include <post.h> #include <u-boot/sha256.h> @@ -52,8 +53,8 @@ static int passwd_abort(uint64_t etime) { const char *sha_env_str = env_get("bootstopkeysha256"); u8 sha_env[SHA256_SUM_LEN]; - u8 sha[SHA256_SUM_LEN]; - char presskey[MAX_DELAY_STOP_STR]; + u8 *sha; + char *presskey; const char *algo_name = "sha256"; u_int presskey_len = 0; int abort = 0; @@ -74,6 +75,9 @@ static int passwd_abort(uint64_t etime) return 0; } + presskey = malloc_cache_aligned(MAX_DELAY_STOP_STR); + sha = malloc_cache_aligned(SHA256_SUM_LEN); + size = SHA256_SUM_LEN; /* * We don't know how long the stop-string is, so we need to * generate the sha256 hash upon each input character and @@ -82,8 +86,11 @@ static int passwd_abort(uint64_t etime) do { if (tstc()) { /* Check for input string overflow */ - if (presskey_len >= MAX_DELAY_STOP_STR) + if (presskey_len >= MAX_DELAY_STOP_STR) { + free(presskey); + free(sha); return 0; + } presskey[presskey_len++] = getc(); @@ -97,6 +104,8 @@ static int passwd_abort(uint64_t etime) } } while (!abort && get_ticks() <= etime); + free(presskey); + free(sha); return abort; } #else -- 2.21.0

2 1

[U-Boot] [PATCH 1/1] log: document the assign() macro
by Heinrich Schuchardt 08 Aug '19

08 Aug '19

Provide a concise description of the assert() macro. Point out that the tested expression is always executed, irrespective of the value of _DEBUG. Signed-off-by: Heinrich Schuchardt <xypron.glpk(a)gmx.de> --- include/log.h | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/include/log.h b/include/log.h index 7566ba7f2d..6d15e955d7 100644 --- a/include/log.h +++ b/include/log.h @@ -183,6 +183,18 @@ int _log(enum log_category_t cat, enum log_level_t level, const char *file, */ void __assert_fail(const char *assertion, const char *file, unsigned int line, const char *function); + +/** + * assert() - assert expression is true + * + * If the expression x evaluates to false and _DEBUG evaluates to true, a panic + * message is written and the system stalls. The value of _DEBUG is set to true + * if DEBUG is defined before including common.h. + * + * The expression x is always executed irrespective of the value of _DEBUG. + * + * @x: expression to test + */ #define assert(x) \ ({ if (!(x) && _DEBUG) \ __assert_fail(#x, __FILE__, __LINE__, __func__); }) -- 2.20.1

2 1