April 2019 - U-Boot

[U-Boot] [PATCH] simple-bus: add DM_FLAG_PRE_RELOC flag to simple-bus driver
by Lukas Auer 06 May '19

06 May '19

Boards such as qemu-riscv, which receive their device tree at runtime, for example from QEMU or firmware, are unable to add the appropriate device tree properties to make devices available pre relocation. Instead, they must rely on the DM_FLAG_PRE_RELOC flag to be set for the required drivers. Add the DM_FLAG_PRE_RELOC flag to the simple-bus driver to make devices under it with drivers that have set the flag as well available pre relocation for these boards. Signed-off-by: Lukas Auer <lukas.auer(a)aisec.fraunhofer.de> --- drivers/core/simple-bus.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/core/simple-bus.c b/drivers/core/simple-bus.c index e16d8a9ff4..7fc23ef82d 100644 --- a/drivers/core/simple-bus.c +++ b/drivers/core/simple-bus.c @@ -60,4 +60,5 @@ U_BOOT_DRIVER(simple_bus_drv) = { .name = "generic_simple_bus", .id = UCLASS_SIMPLE_BUS, .of_match = generic_simple_bus_ids, + .flags = DM_FLAG_PRE_RELOC, }; -- 2.20.1

5 6

[U-Boot] [PATCH V2 0/2] Enable DA830 OHCI USB Controller with DM_USB
by Adam Ford 06 May '19

06 May '19

This patch enables the DA830 USB Host controller with DM_USB. Adam Ford (2): usb: ohci: ohci-da8xx: Enable da850-ohci driver with DM support ARM: da850evm: Enable da850-ohci USB host controller configs/da850evm_defconfig | 7 +- drivers/usb/host/Kconfig | 5 ++ drivers/usb/host/ohci-da8xx.c | 138 +++++++++++++++++++++++++++++++++- include/configs/da850evm.h | 8 ++ 4 files changed, 156 insertions(+), 2 deletions(-) -- 2.17.1

3 5

[U-Boot] [PATCH v2 0/3] fs: btrfs: Add zstd decompression support
by Marek Behún 06 May '19

06 May '19

Hi, this is v2. The previous cover letter said: zstd has been enabled in kernel btrfs driver for over a year, it is time we support this also in U-Boot. This xxhash and zstd library are imported from kernel with minimal changes. This was tested on ARM target (Turris Omnia). Marek Changes since v1: - changed xxhash and zstd sources to use SPDX license identifiers Marek Behún (3): lib: Add xxhash support lib: add Zstandard decompression support fs: btrfs: add zstd decompression support fs/btrfs/Kconfig | 1 + fs/btrfs/btrfs_tree.h | 5 +- fs/btrfs/compression.c | 59 + include/linux/xxhash.h | 229 ++++ include/linux/zstd.h | 1147 +++++++++++++++++ lib/Kconfig | 15 + lib/Makefile | 2 + lib/xxhash.c | 467 +++++++ lib/zstd/Makefile | 4 + lib/zstd/bitstream.h | 344 +++++ lib/zstd/decompress.c | 2515 +++++++++++++++++++++++++++++++++++++ lib/zstd/entropy_common.c | 213 ++++ lib/zstd/error_private.h | 43 + lib/zstd/fse.h | 545 ++++++++ lib/zstd/fse_decompress.c | 302 +++++ lib/zstd/huf.h | 182 +++ lib/zstd/huf_decompress.c | 930 ++++++++++++++ lib/zstd/mem.h | 142 +++ lib/zstd/zstd_common.c | 65 + lib/zstd/zstd_internal.h | 253 ++++ lib/zstd/zstd_opt.h | 1004 +++++++++++++++ 21 files changed, 8465 insertions(+), 2 deletions(-) create mode 100644 include/linux/xxhash.h create mode 100644 include/linux/zstd.h create mode 100644 lib/xxhash.c create mode 100644 lib/zstd/Makefile create mode 100644 lib/zstd/bitstream.h create mode 100644 lib/zstd/decompress.c create mode 100644 lib/zstd/entropy_common.c create mode 100644 lib/zstd/error_private.h create mode 100644 lib/zstd/fse.h create mode 100644 lib/zstd/fse_decompress.c create mode 100644 lib/zstd/huf.h create mode 100644 lib/zstd/huf_decompress.c create mode 100644 lib/zstd/mem.h create mode 100644 lib/zstd/zstd_common.c create mode 100644 lib/zstd/zstd_internal.h create mode 100644 lib/zstd/zstd_opt.h -- 2.21.0

2 6

[U-Boot] [PATCH v2 0/6] board: ti: am43xx: Enable hardware leveling
by Keerthy 06 May '19

06 May '19

The series adds the support for hardware leveling. This needs the kernel to be patched with hardware leveling support and the kernel support is already in linux-next: https://patchwork.kernel.org/project/linux-omap/list/?series=100273 Match recommended values from EMIF Tools app note: http://www.ti.com/lit/an/sprac70/sprac70.pdf The patch series is tested for AM437x-gp-evm DS0 and RTC+DRR mode on linux-next in kernel. Changes in v2: * Fixed am335x build issue. Tested on AM437x-gp-evm for rtc+ddr mode and DS0 Tested on am335x-evm and beaglebone black for DS0 and rtcwake from DS0 Compile tested omap3 and omap4 defconfigs as well. Brad Griffis (6): arm: mach-omap2: am33xx: ddr: programming of EXT_PHY_CTRL1 and EXT_PHY_CTRL1_SHADOW arm: mach-omap2: am33xx: ddr: Add 1ms delay to avoid L3 error arm: mach-omap2: am33xx: Enable HW Leveling in the rtc+ddr path arm: mach-omap2: am33xx: ddr: update value for ext_phy_ctrl_36 board: ti: am43xx: Enable hardware leveling arm: mach-omap2: am33xx: Disable EMIF_DEVOFF immediately before hw leveling arch/arm/mach-omap2/am33xx/board.c | 31 +++++++++++++++++++++++++--- arch/arm/mach-omap2/am33xx/ddr.c | 33 ++++++++++++++++++++++++++---- board/ti/am43xx/board.c | 2 +- 3 files changed, 58 insertions(+), 8 deletions(-) -- 2.17.1

2 12

[U-Boot] [PATCH 1/1] lib/display_options: avoid illegal memory access
by Heinrich Schuchardt 06 May '19

06 May '19

display_options_get_banner_priv() overwrites bytes before the start of the buffer if the buffer size is less then 3. This case occurs in the Sandbox when executing the `ut_print` command. Correctly handle small buffer sizes. Adjust the print unit test to catch when bytes before the buffer are overwritten. Signed-off-by: Heinrich Schuchardt <xypron.glpk(a)gmx.de> --- I will take the patch via the u-boot-efi repository. --- lib/display_options.c | 4 +++- test/print_ut.c | 20 ++++++++++++-------- 2 files changed, 15 insertions(+), 9 deletions(-) diff --git a/lib/display_options.c b/lib/display_options.c index af1802ef99..cff20f3755 100644 --- a/lib/display_options.c +++ b/lib/display_options.c @@ -23,7 +23,9 @@ char *display_options_get_banner_priv(bool newlines, const char *build_tag, build_tag); if (len > size - 3) len = size - 3; - strcpy(buf + len, "\n\n"); + if (len < 0) + len = 0; + snprintf(buf + len, size - len, "\n\n"); return buf; } diff --git a/test/print_ut.c b/test/print_ut.c index f0f1d6010a..0bc548dca8 100644 --- a/test/print_ut.c +++ b/test/print_ut.c @@ -79,14 +79,18 @@ static int do_ut_print(cmd_tbl_t *cmdtp, int flag, int argc, assert(s == str); assert(!strcmp("\n\nU-Boo\n\n", s)); - s = display_options_get_banner(true, str, 1); - assert(s == str); - assert(!strcmp("", s)); - - s = display_options_get_banner(true, str, 2); - assert(s == str); - assert(!strcmp("\n", s)); - + /* Assert that we do not overwrite memory before the buffer */ + str[0] = '`'; + s = display_options_get_banner(true, str + 1, 1); + assert(s == str + 1); + assert(!strcmp("`", str)); + + str[0] = '~'; + s = display_options_get_banner(true, str + 1, 2); + assert(s == str + 1); + assert(!strcmp("~\n", str)); + + /* The last two characters are set to \n\n for all buffer sizes > 2 */ s = display_options_get_banner(false, str, sizeof(str)); assert(s == str); assert(!strcmp("U-Boot \n\n", s)); -- 2.20.1

3 2

[U-Boot] [PATCH v1 0/2] Use SPL_FIT_IMAGE_TINY to reduce the size the SPL for the am335x_evm
by Jean-Jacques Hiblot 06 May '19

06 May '19

Patch #1 handles a corner case: SPL_FIT_IMAGE and SPL_OS_BOOT at the same time Patch #2 enables SPL_FIT_IMAGE_TINY for the am335x_evm platform Jean-Jacques Hiblot (2): spl: fit: Always enable tracking of os-type if SPL_OS_BOOT is enabled configs: am335x_evm: enable SPL_FIT_IMAGE_TINY common/spl/spl_fit.c | 2 +- configs/am335x_evm_defconfig | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) -- 2.17.1

3 6

[U-Boot] [PATCH v5 1/2] spl: fix linker size check off-by-one errors
by Simon Goldschmidt 06 May '19

06 May '19

This fixes SPL linker script size checks for 3 lds files where the size checks were implemented as "x < YYY_MAX_SIZE". Fix the size checks to be "x <= YYY_MAX_SIZE" instead. Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt(a)gmail.com> --- Changes in v5: - added patch to fix linker size checks off-by-one error arch/arm/cpu/u-boot-spl.lds | 6 +++--- arch/arm/mach-at91/arm926ejs/u-boot-spl.lds | 4 ++-- arch/microblaze/cpu/u-boot-spl.lds | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/arm/cpu/u-boot-spl.lds b/arch/arm/cpu/u-boot-spl.lds index a2aa93a735..97899a567f 100644 --- a/arch/arm/cpu/u-boot-spl.lds +++ b/arch/arm/cpu/u-boot-spl.lds @@ -79,16 +79,16 @@ SECTIONS } #if defined(IMAGE_MAX_SIZE) -ASSERT(__image_copy_end - __image_copy_start < (IMAGE_MAX_SIZE), \ +ASSERT(__image_copy_end - __image_copy_start <= (IMAGE_MAX_SIZE), \ "SPL image too big"); #endif #if defined(CONFIG_SPL_BSS_MAX_SIZE) -ASSERT(__bss_end - __bss_start < (CONFIG_SPL_BSS_MAX_SIZE), \ +ASSERT(__bss_end - __bss_start <= (CONFIG_SPL_BSS_MAX_SIZE), \ "SPL image BSS too big"); #endif #if defined(CONFIG_SPL_MAX_FOOTPRINT) -ASSERT(__bss_end - _start < (CONFIG_SPL_MAX_FOOTPRINT), \ +ASSERT(__bss_end - _start <= (CONFIG_SPL_MAX_FOOTPRINT), \ "SPL image plus BSS too big"); #endif diff --git a/arch/arm/mach-at91/arm926ejs/u-boot-spl.lds b/arch/arm/mach-at91/arm926ejs/u-boot-spl.lds index 3955bea23a..74f6355229 100644 --- a/arch/arm/mach-at91/arm926ejs/u-boot-spl.lds +++ b/arch/arm/mach-at91/arm926ejs/u-boot-spl.lds @@ -52,11 +52,11 @@ SECTIONS } #if defined(IMAGE_MAX_SIZE) -ASSERT(__image_copy_end - __start < (IMAGE_MAX_SIZE), \ +ASSERT(__image_copy_end - __start <= (IMAGE_MAX_SIZE), \ "SPL image too big"); #endif #if defined(CONFIG_SPL_BSS_MAX_SIZE) -ASSERT(__bss_end - __bss_start < (CONFIG_SPL_BSS_MAX_SIZE), \ +ASSERT(__bss_end - __bss_start <= (CONFIG_SPL_BSS_MAX_SIZE), \ "SPL image BSS too big"); #endif diff --git a/arch/microblaze/cpu/u-boot-spl.lds b/arch/microblaze/cpu/u-boot-spl.lds index 99c62b51a1..3387eb7189 100644 --- a/arch/microblaze/cpu/u-boot-spl.lds +++ b/arch/microblaze/cpu/u-boot-spl.lds @@ -57,6 +57,6 @@ SECTIONS } #if defined(CONFIG_SPL_MAX_FOOTPRINT) -ASSERT(__end - _start < (CONFIG_SPL_MAX_FOOTPRINT), \ +ASSERT(__end - _start <= (CONFIG_SPL_MAX_FOOTPRINT), \ "SPL image plus BSS too big"); #endif -- 2.17.1

3 14

[U-Boot] [PATCHv5 0/6] dm: cache: add dm cache driver
by Dinh Nguyen 06 May '19

06 May '19

Hi, This is V4 of the series to add a UCLASS_CACHE dm driver to handling the configuration of cache settings. Place this new driver under /drivers/cache. In this initial revision, the driver is only configuring what I think are essential cache settings. The more comprehensive cache settings can be done in the OS. Diffs from v4: - Fix compile error found in sandbox_cache.c Dinh Nguyen (6): Documentation: dts: Add pl310 cache controller dts documentation ARM: pl310: Add macro's for handling tag and data latency mask dm: cache: Create a uclass for cache dm: cache: add the pl310 cache controller driver ARM: socfpga: use the pl310 driver to configure the cache configs: socfpga: add imply pl310 cache controller .../devicetree/bindings/arm/l2c2x0.txt | 114 ++++++++++++++++++ arch/arm/Kconfig | 1 + arch/arm/include/asm/pl310.h | 3 + arch/arm/mach-socfpga/misc.c | 16 +-- drivers/Kconfig | 2 + drivers/Makefile | 1 + drivers/cache/Kconfig | 25 ++++ drivers/cache/Makefile | 4 + drivers/cache/cache-l2x0.c | 76 ++++++++++++ drivers/cache/cache-uclass.c | 24 ++++ drivers/cache/sandbox_cache.c | 34 ++++++ include/cache.h | 38 ++++++ include/dm/uclass-id.h | 1 + test/dm/cache.c | 20 +++ 14 files changed, 346 insertions(+), 13 deletions(-) create mode 100644 Documentation/devicetree/bindings/arm/l2c2x0.txt create mode 100644 drivers/cache/Kconfig create mode 100644 drivers/cache/Makefile create mode 100644 drivers/cache/cache-l2x0.c create mode 100644 drivers/cache/cache-uclass.c create mode 100644 drivers/cache/sandbox_cache.c create mode 100644 include/cache.h create mode 100644 test/dm/cache.c -- 2.20.0

2 17

[U-Boot] [PATCH v2 0/2] Add Kconfig to disable cache ops
by Vignesh Raghavendra 06 May '19

06 May '19

This series adds a Kconfig to disable cache maintenance operations on a coherent architectures. And disable cache flush/invalidate ops for SPL/U-Boot code running on A53 core of AM654 SoC(which is IO coherent) v2: Allow flush_dcache_all() and invalidate_dcache_all() that are used before enabling/disabling dcache by U-Boot and are special case. Vignesh Raghavendra (2): arch: armv8: Provide a way to disable cache maintenance ops board: ti: am654: select SYS_DISABLE_DCACHE_OPS for arm64 build arch/Kconfig | 9 +++++++++ arch/arm/cpu/armv8/cache_v8.c | 10 ++++++++++ board/ti/am65x/Kconfig | 1 + 3 files changed, 20 insertions(+) -- 2.21.0

2 4

[U-Boot] [PATCH] Refactor IMAGE_ENABLE_VERIFY to handle builds without SPL verification
by Alex Kiernan 06 May '19

06 May '19

If building with SPL_LOAD_FIT_FULL and FIT_SIGNATURE, but without SPL_FIT_SIGNATURE then the build fails with: common/built-in.o: In function `fit_image_verify_with_data': common/image-fit.c:1220: undefined reference to `fit_image_verify_required_sigs' common/image-fit.c:1244: undefined reference to `fit_image_check_sig' common/built-in.o: In function `fit_image_load': common/image-fit.c:1857: undefined reference to `fit_config_verify' Refactor so that host builds still depend on FIT_SIGNATURE, but target builds check FIT_SIGNATURE/SPL_FIT_SIGNATURE dependent on the build. Signed-off-by: Alex Kiernan <alex.kiernan(a)gmail.com> --- Green travis build: https://travis-ci.org/akiernan/u-boot/builds/521570862 include/image.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/include/image.h b/include/image.h index 765ffecee0a7..c8522189ebab 100644 --- a/include/image.h +++ b/include/image.h @@ -1071,18 +1071,18 @@ int calculate_hash(const void *data, int data_len, const char *algo, * At present we only support signing on the host, and verification on the * device */ -#if defined(CONFIG_FIT_SIGNATURE) -# ifdef USE_HOSTCC +#if defined(USE_HOSTCC) +# if defined(CONFIG_FIT_SIGNATURE) # define IMAGE_ENABLE_SIGN 1 # define IMAGE_ENABLE_VERIFY 1 -# include <openssl/evp.h> -#else +# include <openssl/evp.h> +# else # define IMAGE_ENABLE_SIGN 0 -# define IMAGE_ENABLE_VERIFY 1 +# define IMAGE_ENABLE_VERIFY 0 # endif #else # define IMAGE_ENABLE_SIGN 0 -# define IMAGE_ENABLE_VERIFY 0 +# define IMAGE_ENABLE_VERIFY CONFIG_IS_ENABLED(FIT_SIGNATURE) #endif #ifdef USE_HOSTCC -- 2.17.1

3 2