September 2018 - U-Boot

[U-Boot] [PATCH 0/6] driver: net: fsl-mc: Add support of multiple phys for dpmac
by Pankaj Bansal 22 Oct '18

22 Oct '18

This patch set adds support of multiple phys for one dpmac Till now we have had cases where we had one phy device per dpmac. Now, with the upcoming products (LX2160AQDS), we have cases, where there are sometimes two phy devices for one dpmac. One phy for TX lanes and one phy for RX lanes. To handle such cases, add the support for multiple phys in ethernet driver. The ethernet link is up if all the phy devices connected to one dpmac report link up. also the link capabilities are limited by the weakest phy device. i.e. say if there are two phys for one dpmac. one operates at 10G without autoneg and other operate at 1G with autoneg. Then the ethernet interface will operate at 1G without autoneg. Pankaj Bansal (6): driver: net: fsl-mc: modify the label name driver: net: fsl-mc: remove unused strcture elements driver: net: fsl-mc: fix error handing in init_phy driver: net: fsl-mc: Modify the dpmac link detection method driver: net: fsl-mc: initialize dpmac irrespective of phy driver: net: fsl-mc: Add support of multiple phys for dpmac board/freescale/ls1088a/eth_ls1088aqds.c | 18 +-- board/freescale/ls1088a/eth_ls1088ardb.c | 21 +-- board/freescale/ls2080aqds/eth.c | 26 +-- board/freescale/ls2080ardb/eth_ls2080rdb.c | 24 +-- drivers/net/fsl-mc/mc.c | 6 +- drivers/net/ldpaa_eth/ldpaa_eth.c | 180 +++++++++++++-------- drivers/net/ldpaa_eth/ldpaa_eth.h | 1 - drivers/net/ldpaa_eth/ldpaa_wriop.c | 49 ++++-- include/fsl-mc/ldpaa_wriop.h | 22 +-- 9 files changed, 209 insertions(+), 138 deletions(-) -- 2.17.1

3 53

[U-Boot] [RFC PATCH 0/3] sunxi: extend SPL header to propagate DRAM size
by Andre Przywara 22 Oct '18

22 Oct '18

This series tries to solve three issues we currently have on Allwinner boards: - The DRAM sizing routine can only cope with power-of-two sized DRAM. - The DRAM sizing routine steps through all DRAM, possibly hitting secure memory. - The SPL header versioning is quite strict and tends to break every time we need to update it. So I thought about introducing something along the lines of semantic versioning[1], where we can add backwards-compatible changes to the SPL header without breaking every tool. This is introduced in the first patch. The second patch does some refactoring, so that the third patch can use the newly gained freedom to store the DRAM size. The SPL knows the DRAM size very well, so we store this in the SPL header, so that U-Boot proper can pick it up from there. This saves the call to get_ram_size() with its deficiencies. More information in the respective commit messages. I understand that this versioning solution is not fully future-proof, but we have only one byte for the version, and I just wanted to start discussion on this. There is a corresponding patch for sunxi-tools as well I am posting shortly. [1] https://semver.org Cheers, Andre. Andre Przywara (3): sunxi: Extend SPL header versioning sunxi: board.c: refactor SPL header checks sunxi: store DRAM size in SPL header arch/arm/include/asm/arch-sunxi/spl.h | 22 ++++++++---- board/sunxi/board.c | 66 ++++++++++++++++++++++++++++------- 2 files changed, 70 insertions(+), 18 deletions(-) -- 2.14.1

6 12

[U-Boot] [PATCH] arm: lpc32xx: remove phantom CONFIG_LPC32XX_SDRAM_ config option
by Vladimir Zapolskiy 20 Oct '18

20 Oct '18

The option has never existed and config whitelist script accumulates it from a comment block, wipe it out from the source code. Signed-off-by: Vladimir Zapolskiy <vz(a)mleia.com> --- The change has a trivial merge conflict with another config symbol removal from https://patchwork.ozlabs.org/patch/970788/ , this change depends on it, so please apply work_92105 clean-up firstly. arch/arm/cpu/arm926ejs/lpc32xx/dram.c | 3 --- scripts/config_whitelist.txt | 1 - 2 files changed, 4 deletions(-) diff --git a/arch/arm/cpu/arm926ejs/lpc32xx/dram.c b/arch/arm/cpu/arm926ejs/lpc32xx/dram.c index 2dce00234330..4f975694fd69 100644 --- a/arch/arm/cpu/arm926ejs/lpc32xx/dram.c +++ b/arch/arm/cpu/arm926ejs/lpc32xx/dram.c @@ -8,9 +8,6 @@ * This is called by SPL to gain access to the SDR DRAM. * * This code runs from SRAM. - * - * Actual CONFIG_LPC32XX_SDRAM_* parameters must be provided - * by the board configuration file. */ #include <common.h> diff --git a/scripts/config_whitelist.txt b/scripts/config_whitelist.txt index 68780ac87f8e..30d54e7634b3 100644 --- a/scripts/config_whitelist.txt +++ b/scripts/config_whitelist.txt @@ -1179,7 +1179,6 @@ CONFIG_LPC32XX_NAND_SLC_WDR_CLKS CONFIG_LPC32XX_NAND_SLC_WHOLD CONFIG_LPC32XX_NAND_SLC_WSETUP CONFIG_LPC32XX_NAND_SLC_WWIDTH -CONFIG_LPC32XX_SDRAM_ CONFIG_LPC32XX_SSP_TIMEOUT CONFIG_LPC_BASE CONFIG_LPC_IO_BASE -- 2.17.1

2 1

[U-Boot] [PATCH 0/2] work_92105: remove a couple of unused config options
by Vladimir Zapolskiy 20 Oct '18

20 Oct '18

The series contains a couple of trivial changes, which remove unused legacy defines found in work_92105 board file. Vladimir Zapolskiy (2): work_92105: remove unused CONFIG_LPC32XX_SPL configuration option work_92105: remove unused CONFIG_SPL_NAND_BOOT configuration option include/configs/work_92105.h | 4 ---- scripts/config_whitelist.txt | 1 - 2 files changed, 5 deletions(-) -- 2.17.1

2 4

[U-Boot] [PATCH 0/2] arm: lpc32xx: create platform specific Kconfig file
by Vladimir Zapolskiy 20 Oct '18

20 Oct '18

There is a need to introduce ARCH_LPC32XX build config symbol to improve selection of build options for drivers, which are specific to NXP LPC32xx platform only. At the same time the new Kconfig file and sections can be used to describe common SoC properties and collect entries of all LPC32xx boards. The presented two patches are the initial ones in the series of LPC32xx device driver changes, which move LPC32xx board specific options from include/configs/* to build system and board configs. Vladimir Zapolskiy (2): arm: lpc32xx: add CONFIG_ARCH_LPC32XX build option Makefile: add LPC32xx precondition for building platform images Makefile | 2 ++ arch/arm/Kconfig | 24 ++++++++++++------------ arch/arm/cpu/arm926ejs/lpc32xx/Kconfig | 20 ++++++++++++++++++++ board/timll/devkit3250/Kconfig | 3 --- board/work-microwave/work_92105/Kconfig | 3 --- configs/devkit3250_defconfig | 6 +----- configs/work_92105_defconfig | 11 ++++------- 7 files changed, 39 insertions(+), 30 deletions(-) create mode 100644 arch/arm/cpu/arm926ejs/lpc32xx/Kconfig -- 2.17.1

2 5

[U-Boot] [PATCH 00/41] imx: add i.MX8QXP support
by Peng Fan 18 Oct '18

18 Oct '18

This patchset is to upstream i.MX8QXP and mek board support, with some drivers update to support i.MX8QXP. The information about the processor could be found https://www.nxp.com/products/processors-and-microcontrollers/applications-p… The architecture of i.MX8QXP is different from i.MX6/7/8M, inside i.MX8QXP, there is a dedicated processor(SCU) used for power/clock/pin/ pad/resource management/thermal and etc. The ACore need to communicate with SCU using SCFW API. The SCFW API is exported by SCFW, so we directly import it into U-Boot source code. Gao Pan (1): imx: lpi2c: fix clock issue when NACK detected Peng Fan (32): imx: import SCFW API imx: add Kconfig entry for i.MX8 arm: build mach-imx for i.MX8 imx8: add IPC communication support between ACore and SCU arm: global_data: introduce ipc_channel_handle imx: boot_mode: Add FLEXSPI boot entry imx8: add imx-regs header file imx8: pins: include i.MX8QXP pin header when CONFIG_IMX8QXP defined imx: add i.MX8 cpu type imx8: add basic cpu support imx8: add boot device detection imx8: implement mmc_get_env_dev imx8: implement imx_get_mac_from_fuse imx8: implement get_board_serial imx8: add mmu and dram related functiions imx8: add bootaux support imx8: add arch_cpu_init imx8: add clock driver imx8: add iomux configuration code serial_lpuart: Update lpuart driver to support i.MX8 net: fec: do not access reserved register for i.MX8 gpio: mxc_gpio: add support for i.MX8 pinctrl: Add pinctrl driver for i.MX8 power: Add power domain driver for i.MX8 power: Add PD device lookup interface to power domain uclass power-domain: add dummy functions when CONFIG_POWER_DOMAIN not defined dm: core: device: enable power domain in probe drivers: regulator: fixed: add off-on-delay-us log: include command header file i2c-mux: pca954x: support pca9646 i2c switch dts: imx8qxp: Add DTS and binding header files imx: 8qxp_mek: Add i.MX8QXP MEK board support Ye Li (8): fsl_esdhc: Update usdhc driver to support i.MX8 serial: lpuart: Enable RX and TX FIFO imx_lpi2c: Update lpi2c driver to support imx8 lpi2c: Fix bus stop problem in xfer lpi2c: Add bus busy error handling net: fec_mxc: Add the init_clk_fec function sata: Add i.MX8 SATA support mmc: fsl_esdhc: fix sd/mmc ddr mode clock setting issue arch/arm/Kconfig | 8 + arch/arm/Makefile | 2 +- arch/arm/dts/Makefile | 2 + arch/arm/dts/fsl-imx8qxp-mek.dts | 416 +++++ arch/arm/dts/fsl-imx8qxp.dtsi | 1593 ++++++++++++++++++++ arch/arm/include/asm/arch-imx/cpu.h | 5 + arch/arm/include/asm/arch-imx8/clock.h | 36 + arch/arm/include/asm/arch-imx8/cpu.h | 26 + arch/arm/include/asm/arch-imx8/fsl_mu_hal.h | 54 + arch/arm/include/asm/arch-imx8/gpio.h | 22 + arch/arm/include/asm/arch-imx8/i2c.h | 34 + arch/arm/include/asm/arch-imx8/imx-regs.h | 119 ++ arch/arm/include/asm/arch-imx8/imx8-pins.h | 15 + arch/arm/include/asm/arch-imx8/imx8qm_pads.h | 295 ++++ arch/arm/include/asm/arch-imx8/imx8qxp_pads.h | 200 +++ arch/arm/include/asm/arch-imx8/iomux.h | 40 + arch/arm/include/asm/arch-imx8/power-domain.h | 15 + arch/arm/include/asm/arch-imx8/sci/ipc.h | 67 + arch/arm/include/asm/arch-imx8/sci/rpc.h | 131 ++ arch/arm/include/asm/arch-imx8/sci/sci.h | 39 + arch/arm/include/asm/arch-imx8/sci/svc/irq/api.h | 160 ++ arch/arm/include/asm/arch-imx8/sci/svc/misc/api.h | 523 +++++++ arch/arm/include/asm/arch-imx8/sci/svc/pad/api.h | 568 +++++++ arch/arm/include/asm/arch-imx8/sci/svc/pm/api.h | 686 +++++++++ arch/arm/include/asm/arch-imx8/sci/svc/rm/api.h | 759 ++++++++++ arch/arm/include/asm/arch-imx8/sci/svc/timer/api.h | 306 ++++ arch/arm/include/asm/arch-imx8/sci/types.h | 862 +++++++++++ arch/arm/include/asm/arch-imx8/sys_proto.h | 19 + arch/arm/include/asm/global_data.h | 4 + arch/arm/include/asm/mach-imx/boot_mode.h | 1 + arch/arm/include/asm/mach-imx/sys_proto.h | 3 + arch/arm/mach-imx/Makefile | 1 + arch/arm/mach-imx/imx8/Kconfig | 26 + arch/arm/mach-imx/imx8/Makefile | 13 + arch/arm/mach-imx/imx8/clock.c | 361 +++++ arch/arm/mach-imx/imx8/cpu.c | 783 ++++++++++ arch/arm/mach-imx/imx8/fsl_mu_hal.c | 28 + arch/arm/mach-imx/imx8/iomux.c | 47 + arch/arm/mach-imx/imx8/sci/ipc.c | 100 ++ arch/arm/mach-imx/imx8/sci/svc/irq/rpc.h | 54 + arch/arm/mach-imx/imx8/sci/svc/irq/rpc_clnt.c | 76 + arch/arm/mach-imx/imx8/sci/svc/misc/rpc.h | 76 + arch/arm/mach-imx/imx8/sci/svc/misc/rpc_clnt.c | 515 +++++++ arch/arm/mach-imx/imx8/sci/svc/pad/rpc.h | 68 + arch/arm/mach-imx/imx8/sci/svc/pad/rpc_clnt.c | 475 ++++++ arch/arm/mach-imx/imx8/sci/svc/pm/rpc.h | 73 + arch/arm/mach-imx/imx8/sci/svc/pm/rpc_clnt.c | 460 ++++++ arch/arm/mach-imx/imx8/sci/svc/rm/rpc.h | 83 + arch/arm/mach-imx/imx8/sci/svc/rm/rpc_clnt.c | 645 ++++++++ arch/arm/mach-imx/imx8/sci/svc/timer/rpc.h | 67 + arch/arm/mach-imx/imx8/sci/svc/timer/rpc_clnt.c | 365 +++++ board/freescale/imx8qxp_mek/Kconfig | 14 + board/freescale/imx8qxp_mek/MAINTAINERS | 6 + board/freescale/imx8qxp_mek/Makefile | 7 + board/freescale/imx8qxp_mek/imx8qxp_mek.c | 159 ++ configs/imx8qxp_mek_defconfig | 47 + drivers/ata/Kconfig | 6 + drivers/ata/Makefile | 1 + drivers/ata/ahci.c | 25 + drivers/ata/sata_imx.c | 64 + drivers/core/device.c | 7 + drivers/gpio/mxc_gpio.c | 30 +- drivers/i2c/imx_lpi2c.c | 82 +- drivers/i2c/muxes/pca954x.c | 9 +- drivers/mmc/fsl_esdhc.c | 32 +- drivers/net/fec_mxc.c | 9 +- drivers/pinctrl/nxp/Kconfig | 18 + drivers/pinctrl/nxp/Makefile | 2 + drivers/pinctrl/nxp/pinctrl-imx.c | 209 +-- drivers/pinctrl/nxp/pinctrl-imx.h | 16 + drivers/pinctrl/nxp/pinctrl-imx8.c | 42 + drivers/pinctrl/nxp/pinctrl-scu.c | 72 + drivers/power/domain/Kconfig | 6 + drivers/power/domain/Makefile | 1 + drivers/power/domain/imx8-power-domain.c | 315 ++++ drivers/power/domain/power-domain-uclass.c | 42 + drivers/power/regulator/fixed.c | 6 + drivers/serial/serial_lpuart.c | 48 +- include/configs/imx8qxp_mek.h | 157 ++ include/dt-bindings/clock/imx8qxp-clock.h | 533 +++++++ include/dt-bindings/pinctrl/pads-imx8qm.h | 975 ++++++++++++ include/dt-bindings/pinctrl/pads-imx8qxp.h | 770 ++++++++++ include/dt-bindings/soc/imx8_pd.h | 197 +++ include/dt-bindings/soc/imx_rsrc.h | 560 +++++++ include/fsl_lpuart.h | 2 +- .../asm/arch-mx7ulp => include}/imx_lpi2c.h | 0 include/log.h | 1 + include/power-domain.h | 52 + 88 files changed, 15691 insertions(+), 157 deletions(-) create mode 100644 arch/arm/dts/fsl-imx8qxp-mek.dts create mode 100644 arch/arm/dts/fsl-imx8qxp.dtsi create mode 100644 arch/arm/include/asm/arch-imx8/clock.h create mode 100644 arch/arm/include/asm/arch-imx8/cpu.h create mode 100644 arch/arm/include/asm/arch-imx8/fsl_mu_hal.h create mode 100644 arch/arm/include/asm/arch-imx8/gpio.h create mode 100644 arch/arm/include/asm/arch-imx8/i2c.h create mode 100644 arch/arm/include/asm/arch-imx8/imx-regs.h create mode 100644 arch/arm/include/asm/arch-imx8/imx8-pins.h create mode 100644 arch/arm/include/asm/arch-imx8/imx8qm_pads.h create mode 100644 arch/arm/include/asm/arch-imx8/imx8qxp_pads.h create mode 100644 arch/arm/include/asm/arch-imx8/iomux.h create mode 100644 arch/arm/include/asm/arch-imx8/power-domain.h create mode 100755 arch/arm/include/asm/arch-imx8/sci/ipc.h create mode 100755 arch/arm/include/asm/arch-imx8/sci/rpc.h create mode 100644 arch/arm/include/asm/arch-imx8/sci/sci.h create mode 100755 arch/arm/include/asm/arch-imx8/sci/svc/irq/api.h create mode 100755 arch/arm/include/asm/arch-imx8/sci/svc/misc/api.h create mode 100755 arch/arm/include/asm/arch-imx8/sci/svc/pad/api.h create mode 100755 arch/arm/include/asm/arch-imx8/sci/svc/pm/api.h create mode 100755 arch/arm/include/asm/arch-imx8/sci/svc/rm/api.h create mode 100755 arch/arm/include/asm/arch-imx8/sci/svc/timer/api.h create mode 100755 arch/arm/include/asm/arch-imx8/sci/types.h create mode 100644 arch/arm/include/asm/arch-imx8/sys_proto.h create mode 100644 arch/arm/mach-imx/imx8/Kconfig create mode 100644 arch/arm/mach-imx/imx8/Makefile create mode 100644 arch/arm/mach-imx/imx8/clock.c create mode 100644 arch/arm/mach-imx/imx8/cpu.c create mode 100644 arch/arm/mach-imx/imx8/fsl_mu_hal.c create mode 100644 arch/arm/mach-imx/imx8/iomux.c create mode 100644 arch/arm/mach-imx/imx8/sci/ipc.c create mode 100644 arch/arm/mach-imx/imx8/sci/svc/irq/rpc.h create mode 100644 arch/arm/mach-imx/imx8/sci/svc/irq/rpc_clnt.c create mode 100644 arch/arm/mach-imx/imx8/sci/svc/misc/rpc.h create mode 100644 arch/arm/mach-imx/imx8/sci/svc/misc/rpc_clnt.c create mode 100644 arch/arm/mach-imx/imx8/sci/svc/pad/rpc.h create mode 100644 arch/arm/mach-imx/imx8/sci/svc/pad/rpc_clnt.c create mode 100644 arch/arm/mach-imx/imx8/sci/svc/pm/rpc.h create mode 100644 arch/arm/mach-imx/imx8/sci/svc/pm/rpc_clnt.c create mode 100644 arch/arm/mach-imx/imx8/sci/svc/rm/rpc.h create mode 100644 arch/arm/mach-imx/imx8/sci/svc/rm/rpc_clnt.c create mode 100644 arch/arm/mach-imx/imx8/sci/svc/timer/rpc.h create mode 100644 arch/arm/mach-imx/imx8/sci/svc/timer/rpc_clnt.c create mode 100644 board/freescale/imx8qxp_mek/Kconfig create mode 100644 board/freescale/imx8qxp_mek/MAINTAINERS create mode 100644 board/freescale/imx8qxp_mek/Makefile create mode 100644 board/freescale/imx8qxp_mek/imx8qxp_mek.c create mode 100644 configs/imx8qxp_mek_defconfig create mode 100644 drivers/ata/sata_imx.c create mode 100644 drivers/pinctrl/nxp/pinctrl-imx8.c create mode 100644 drivers/pinctrl/nxp/pinctrl-scu.c create mode 100644 drivers/power/domain/imx8-power-domain.c create mode 100644 include/configs/imx8qxp_mek.h create mode 100644 include/dt-bindings/clock/imx8qxp-clock.h create mode 100644 include/dt-bindings/pinctrl/pads-imx8qm.h create mode 100644 include/dt-bindings/pinctrl/pads-imx8qxp.h create mode 100644 include/dt-bindings/soc/imx8_pd.h create mode 100644 include/dt-bindings/soc/imx_rsrc.h rename {arch/arm/include/asm/arch-mx7ulp => include}/imx_lpi2c.h (100%) -- 2.14.1

8 68

[U-Boot] [PATCH 00/15] test: Various test refinements and improvements
by Simon Glass 17 Oct '18

17 Oct '18

This series includes a number of small changes designed to make tests run more smoothly. The overall goal is that 'make check' runs cleanly without unnecessary output and all temporary files aare cleaned up. Simon Glass (15): sandbox: Unprotect DATA regions in bus tests patman: Handle unicode in _ProjectConfigParser tests test/py: Fix unicode handling for log filtering buildman: Make the toolchain test more forgiving binman: Reorder tests to put helper functions first Makefile: Add a 'check' target for make test: Simplify the PATH setup test: Print the name of each test before running it test: Tidy up comments and variable name binman: Add a default path to libfdt.py binman: Fix up removal of temporary directories binman: Separate out testSplBssPad() buildman: dtoc: Suppress unwanted output from test tools: Set an initial value for indir patman: Don't clear progress in tout unless it was used Makefile | 6 +- arch/sandbox/cpu/os.c | 11 ++ include/os.h | 11 ++ test/dm/bus.c | 12 ++ test/py/multiplexed_log.py | 7 +- test/run | 50 ++++--- tools/binman/binman.py | 2 + tools/binman/elf_test.py | 5 + tools/binman/entry_test.py | 8 +- tools/binman/fdt_test.py | 4 + tools/binman/ftest.py | 261 ++++++++++++++++++------------------- tools/buildman/test.py | 8 +- tools/dtoc/dtoc.py | 5 + tools/dtoc/test_dtoc.py | 6 +- tools/dtoc/test_fdt.py | 10 +- tools/patman/settings.py | 27 +++- tools/patman/tools.py | 3 + tools/patman/tout.py | 8 +- 18 files changed, 273 insertions(+), 171 deletions(-) -- 2.19.0.444.g18242da7ef-goog

3 21

[U-Boot] [PATCH 1/1] efi_selftest: fix typos
by Heinrich Schuchardt 16 Oct '18

16 Oct '18

fix typos correct the header comment of efi_selftest_variables.c Signed-off-by: Heinrich Schuchardt <xypron.glpk(a)gmx.de> --- lib/efi_selftest/efi_selftest_config_table.c | 12 ++++++------ lib/efi_selftest/efi_selftest_controllers.c | 2 +- lib/efi_selftest/efi_selftest_crc32.c | 4 ++-- lib/efi_selftest/efi_selftest_event_groups.c | 4 ++-- lib/efi_selftest/efi_selftest_events.c | 2 +- lib/efi_selftest/efi_selftest_exception.c | 4 ++-- lib/efi_selftest/efi_selftest_fdt.c | 2 +- lib/efi_selftest/efi_selftest_textinput.c | 2 +- lib/efi_selftest/efi_selftest_tpl.c | 2 +- lib/efi_selftest/efi_selftest_variables.c | 6 ++---- lib/efi_selftest/efi_selftest_watchdog.c | 2 +- 11 files changed, 20 insertions(+), 22 deletions(-) diff --git a/lib/efi_selftest/efi_selftest_config_table.c b/lib/efi_selftest/efi_selftest_config_table.c index 2aa3fc7284..0bc5da6b0c 100644 --- a/lib/efi_selftest/efi_selftest_config_table.c +++ b/lib/efi_selftest/efi_selftest_config_table.c @@ -18,7 +18,7 @@ static efi_guid_t table_guid = 0x17, 0x2e, 0x51, 0x6b, 0x49, 0x75); /* - * Notification function, increments the notfication count if parameter + * Notification function, increments the notification count if parameter * context is provided. * * @event notified event @@ -33,23 +33,23 @@ static void EFIAPI notify(struct efi_event *event, void *context) } /* - * Check crc32 of a table. + * Check CRC32 of a table. */ static int check_table(const void *table) { efi_status_t ret; u32 crc32, res; - /* Casting from const to not const */ + /* Casting from constant to not constant */ struct efi_table_hdr *hdr = (struct efi_table_hdr *)table; crc32 = hdr->crc32; /* - * Setting the crc32 of the 'const' table to zero is easier than + * Setting the CRC32 of the 'const' table to zero is easier than * copying */ hdr->crc32 = 0; ret = boottime->calculate_crc32(table, hdr->headersize, &res); - /* Reset table crc32 so it stays constant */ + /* Reset table CRC32 so it stays constant */ hdr->crc32 = crc32; if (ret != EFI_ST_SUCCESS) { efi_st_error("CalculateCrc32 failed\n"); @@ -203,7 +203,7 @@ static int execute(void) return EFI_ST_FAILURE; } if (tabcnt > 1) { - efi_st_error("Duplicate table guid\n"); + efi_st_error("Duplicate table GUID\n"); return EFI_ST_FAILURE; } if (table != &tables[1]) { diff --git a/lib/efi_selftest/efi_selftest_controllers.c b/lib/efi_selftest/efi_selftest_controllers.c index ceefa03444..e8a80d778d 100644 --- a/lib/efi_selftest/efi_selftest_controllers.c +++ b/lib/efi_selftest/efi_selftest_controllers.c @@ -33,7 +33,7 @@ static efi_handle_t handle_driver; * Count child controllers * * @handle handle on which child controllers are installed - * @protocol protocol for which the child controlles where installed + * @protocol protocol for which the child controllers were installed * @count number of child controllers * @return status code */ diff --git a/lib/efi_selftest/efi_selftest_crc32.c b/lib/efi_selftest/efi_selftest_crc32.c index 8555b8f114..4881e8ac6f 100644 --- a/lib/efi_selftest/efi_selftest_crc32.c +++ b/lib/efi_selftest/efi_selftest_crc32.c @@ -5,7 +5,7 @@ * Copyright (c) 2018 Heinrich Schuchardt <xypron.glpk(a)gmx.de> * * This unit test checks the CalculateCrc32 bootservice and checks the - * headers of the system table, the boot services tablle, and the runtime + * headers of the system table, the boot services table, and the runtime * services table before and after ExitBootServices(). */ @@ -19,7 +19,7 @@ static int check_table(const void *table) { efi_status_t ret; u32 crc32, res; - /* Casting from const to not const */ + /* Casting from constant to not constant */ struct efi_table_hdr *hdr = (struct efi_table_hdr *)table; if (!hdr->signature) { diff --git a/lib/efi_selftest/efi_selftest_event_groups.c b/lib/efi_selftest/efi_selftest_event_groups.c index 9b3c5132ef..5a7980c5d0 100644 --- a/lib/efi_selftest/efi_selftest_event_groups.c +++ b/lib/efi_selftest/efi_selftest_event_groups.c @@ -19,7 +19,7 @@ static efi_guid_t event_group = 0x0e, 0x5b, 0x45, 0xc0, 0x56, 0x91); /* - * Notification function, increments the notfication count if parameter + * Notification function, increments the notification count if parameter * context is provided. * * @event notified event @@ -114,7 +114,7 @@ static int execute(void) (unsigned int)i, (unsigned int)j, (unsigned int)counter[j]); efi_st_error( - "Nofification function not called\n"); + "Notification function not called\n"); return EFI_ST_FAILURE; } } diff --git a/lib/efi_selftest/efi_selftest_events.c b/lib/efi_selftest/efi_selftest_events.c index 47f9f99318..ed99a53804 100644 --- a/lib/efi_selftest/efi_selftest_events.c +++ b/lib/efi_selftest/efi_selftest_events.c @@ -17,7 +17,7 @@ static unsigned int timer_ticks; static struct efi_boot_services *boottime; /* - * Notification function, increments the notfication count if parameter + * Notification function, increments the notification count if parameter * context is provided. * * @event notified event diff --git a/lib/efi_selftest/efi_selftest_exception.c b/lib/efi_selftest/efi_selftest_exception.c index 2ac1796c3b..76cfb88d7c 100644 --- a/lib/efi_selftest/efi_selftest_exception.c +++ b/lib/efi_selftest/efi_selftest_exception.c @@ -4,7 +4,7 @@ * * Copyright (c) 2018 Heinrich Schuchardt <xypron.glpk(a)gmx.de> * - * Test the handling of execptions by trying to execute an undefined + * Test the handling of exceptions by trying to execute an undefined * instruction. */ @@ -37,7 +37,7 @@ static int execute(void) { undefined_instruction(); - efi_st_error("An undefined instruction exeption was not raised\n"); + efi_st_error("An undefined instruction exception was not raised\n"); return EFI_ST_FAILURE; } diff --git a/lib/efi_selftest/efi_selftest_fdt.c b/lib/efi_selftest/efi_selftest_fdt.c index c7bc242b5c..d545d51812 100644 --- a/lib/efi_selftest/efi_selftest_fdt.c +++ b/lib/efi_selftest/efi_selftest_fdt.c @@ -16,7 +16,7 @@ static struct efi_boot_services *boottime; static const char *fdt; -/* This should be sufficent for */ +/* This should be sufficient for */ #define BUFFERSIZE 0x100000 static efi_guid_t fdt_guid = EFI_FDT_GUID; diff --git a/lib/efi_selftest/efi_selftest_textinput.c b/lib/efi_selftest/efi_selftest_textinput.c index 164fbffe6c..b90671cdd2 100644 --- a/lib/efi_selftest/efi_selftest_textinput.c +++ b/lib/efi_selftest/efi_selftest_textinput.c @@ -5,7 +5,7 @@ * Copyright (c) 2018 Heinrich Schuchardt <xypron.glpk(a)gmx.de> * * Provides a unit test for the EFI_SIMPLE_TEXT_INPUT_PROTOCOL. - * The unicode character and the scan code are printed for text + * The Unicode character and the scan code are printed for text * input. To run the test: * * setenv efi_selftest text input diff --git a/lib/efi_selftest/efi_selftest_tpl.c b/lib/efi_selftest/efi_selftest_tpl.c index 61ae46b797..97d256abe4 100644 --- a/lib/efi_selftest/efi_selftest_tpl.c +++ b/lib/efi_selftest/efi_selftest_tpl.c @@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0+ /* - * efi_selftest_events + * efi_selftest_tpl * * Copyright (c) 2017 Heinrich Schuchardt <xypron.glpk(a)gmx.de> * diff --git a/lib/efi_selftest/efi_selftest_variables.c b/lib/efi_selftest/efi_selftest_variables.c index 146378fb9a..e4c389a872 100644 --- a/lib/efi_selftest/efi_selftest_variables.c +++ b/lib/efi_selftest/efi_selftest_variables.c @@ -4,10 +4,8 @@ * * Copyright (c) 2018 Heinrich Schuchardt <xypron.glpk(a)gmx.de> * - * This unit test checks the following protocol services: - * ConnectController, DisconnectController, - * InstallProtocol, ReinstallProtocol, UninstallProtocol, - * OpenProtocol, CloseProtcol, OpenProtocolInformation + * This unit test checks the runtime services for variables: + * GetVariable, GetNextVariableName, SetVariable, QueryVariableInfo. */ #include <efi_selftest.h> diff --git a/lib/efi_selftest/efi_selftest_watchdog.c b/lib/efi_selftest/efi_selftest_watchdog.c index bff2330918..cbc6761721 100644 --- a/lib/efi_selftest/efi_selftest_watchdog.c +++ b/lib/efi_selftest/efi_selftest_watchdog.c @@ -35,7 +35,7 @@ static struct notify_context notification_context; static bool watchdog_reset; /* - * Notification function, increments the notfication count if parameter + * Notification function, increments the notification count if parameter * context is provided. * * @event notified event -- 2.19.0

2 1

[U-Boot] [PATCH] efi_loader: Fix warning in efi_load_image()
by Tom Rini 16 Oct '18

16 Oct '18

As observed with clang: lib/efi_loader/efi_boottime.c:1624:7: warning: variable 'info' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] if (ret != EFI_SUCCESS) ^~~~~~~~~~~~~~~~~~ lib/efi_loader/efi_boottime.c:1653:7: note: uninitialized use occurs here free(info); ^~~~ lib/efi_loader/efi_boottime.c:1624:3: note: remove the 'if' if its condition is always false if (ret != EFI_SUCCESS) ^~~~~~~~~~~~~~~~~~~~~~~ lib/efi_loader/efi_boottime.c:1602:31: note: initialize the variable 'info' to silence this warning struct efi_loaded_image *info; ^ = NULL Rather than change how we unwind the function it makes the most sense to initialize info to NULL so that we can continue to pass it to free(). Fixes: c982874e930d ("efi_loader: refactor efi_setup_loaded_image()") Cc: Heinrich Schuchardt <xypron.glpk(a)gmx.de> Cc: Alexander Graf <agraf(a)suse.de> Signed-off-by: Tom Rini <trini(a)konsulko.com> --- lib/efi_loader/efi_boottime.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c index 97eb19cd14d2..ddf857ff267d 100644 --- a/lib/efi_loader/efi_boottime.c +++ b/lib/efi_loader/efi_boottime.c @@ -1599,7 +1599,7 @@ static efi_status_t EFIAPI efi_load_image(bool boot_policy, efi_uintn_t source_size, efi_handle_t *image_handle) { - struct efi_loaded_image *info; + struct efi_loaded_image *info = NULL; struct efi_loaded_image_obj **image_obj = (struct efi_loaded_image_obj **)image_handle; efi_status_t ret; -- 2.7.4

3 2

[U-Boot] [PATCH] fs: fat: Fix warning in normalize_longname()
by Tom Rini 16 Oct '18

16 Oct '18

As observed with clang: fs/fat/fat_write.c:1024:13: warning: comparison of constant 128 with expression of type 'char' is always false [-Wtautological-constant-out-of-range-compare] if ((0x80 <= c) && (c <= 0xff)) ~~~~ ^ ~ fs/fat/fat_write.c:1024:25: warning: comparison of constant 255 with expression of type 'char' is always true [-Wtautological-constant-out-of-range-compare] if ((0x80 <= c) && (c <= 0xff)) ~ ^ ~~~~ Fixes: 25bb9dab14f4 ("fs: fat: check and normalize file name") Cc: AKASHI Takahiro <takahiro.akashi(a)linaro.org> Cc: Alexander Graf <agraf(a)suse.de> Signed-off-by: Tom Rini <trini(a)konsulko.com> --- fs/fat/fat_write.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/fat/fat_write.c b/fs/fat/fat_write.c index fc211e74bc69..98fe6b2b4ecc 100644 --- a/fs/fat/fat_write.c +++ b/fs/fat/fat_write.c @@ -1005,7 +1005,7 @@ again: static int normalize_longname(char *l_filename, const char *filename) { const char *p, legal[] = "!#$%&\'()-.@^`_{}~"; - char c; + unsigned char c; int name_len; /* Check that the filename is valid */ -- 2.7.4

2 1