September 2018 - U-Boot

Re: [U-Boot] [PATCH 03/12] riscv: bootm: Correct the 1st kernel argument to hart id
by Rick Chen 03 Sep '18

03 Sep '18

> From: Bin Meng [mailto:bmeng.cn@gmail.com] > Sent: Thursday, August 30, 2018 3:54 PM > To: Rick Jian-Zhi Chen(陳建志); U-Boot Mailing List > Subject: [PATCH 03/12] riscv: bootm: Correct the 1st kernel argument to hart id > > The first argument of Linux kernel is the risc-v core hart id, from which the kernel > is booted from. It is not the mach_id, which seems to be copied from arm. > > Signed-off-by: Bin Meng <bmeng.cn(a)gmail.com> > --- > > arch/riscv/lib/bootm.c | 18 +++++------------- > 1 file changed, 5 insertions(+), 13 deletions(-) > > diff --git a/arch/riscv/lib/bootm.c b/arch/riscv/lib/bootm.c index 6662aff..754bbff > 100644 > --- a/arch/riscv/lib/bootm.c > +++ b/arch/riscv/lib/bootm.c > @@ -25,10 +25,7 @@ int arch_fixup_fdt(void *blob) > > int do_bootm_linux(int flag, int argc, char *argv[], bootm_headers_t *images) > { > - bd_t *bd = gd->bd; > - char *s; > - int machid = bd->bi_arch_number; > - void (*theKernel)(int arch, uint params); > + void (*kernel)(int hart, uint dtb); > > /* > * allow the PREP bootm subcommand, it is required for bootm to work > @@ -39,18 +36,12 @@ int do_bootm_linux(int flag, int argc, char *argv[], > bootm_headers_t *images) > if ((flag != 0) && (flag != BOOTM_STATE_OS_GO)) > return 1; > > - theKernel = (void (*)(int, uint))images->ep; > - > - s = env_get("machid"); Hi Bin Actually I have check this earlier. It was changed to hartid and pass to kernel when execute enter_supervisor_mode( ) by bbl enter_supervisor_mode(entry, hartid, dtb_output()); But I have no time to solve it. I was trapped and busy about linux drivers porting currently. And planed to fix it when I switch back to u-boot jobs later. Thank you for fix it. Rick > - if (s) { > - machid = simple_strtoul(s, NULL, 16); > - printf("Using machid 0x%x from environment\n", machid); > - } > + kernel = (void (*)(int, uint))images->ep; > > bootstage_mark(BOOTSTAGE_ID_RUN_OS); > > debug("## Transferring control to Linux (at address %08lx) ...\n", > - (ulong)theKernel); > + (ulong)kernel); > > if (IMAGE_ENABLE_OF_LIBFDT && images->ft_len) { #ifdef > CONFIG_OF_LIBFDT @@ -66,8 +57,9 @@ int do_bootm_linux(int flag, int argc, > char *argv[], bootm_headers_t *images) > printf("\nStarting kernel ...\n\n"); > > cleanup_before_linux(); > + /* TODO: hardcode the hart id to zero for now */ > if (IMAGE_ENABLE_OF_LIBFDT && images->ft_len) > - theKernel(machid, (unsigned long)images->ft_addr); > + kernel(0, (unsigned long)images->ft_addr); > > /* does not return */ > > -- > 2.7.4

1 0

Re: [U-Boot] [PATCH 00/12] riscv: Add QEMU virt board support
by Rick Chen 03 Sep '18

03 Sep '18

> From: Bin Meng [mailto:bmeng.cn@gmail.com] > Sent: Thursday, August 30, 2018 3:54 PM > To: Rick Jian-Zhi Chen(陳建志); U-Boot Mailing List > Subject: [PATCH 00/12] riscv: Add QEMU virt board support > > This series adds QEMU RISC-V 'virt' board target support, with the hope of > helping people easily test U-Boot on RISC-V. > > Some existing RISC-V codes have been changed to make it easily to support new > targets. Some spotted coding style issues are fixed. > > This series is available at u-boot-x86/riscv-working for testing. > > > Bin Meng (12): > riscv: kconfig: Normalize architecture name spelling > riscv: Remove setup.h > riscv: bootm: Correct the 1st kernel argument to hart id > riscv: Remove mach type > riscv: Move the linker script to the CPU root directory > riscv: Fix coding style issues in the linker script > riscv: Explicitly pass -march and -mabi to the compiler > riscv: Add a helper routine to print CPU information > riscv: Make start.S available for all targets > riscv: ae350: Clean up mixed tabs and spaces in the dts > riscv: kconfig: Select DM and OF_CONTROL > riscv: Add QEMU virt board support > > arch/Kconfig | 5 +- > arch/riscv/Kconfig | 10 +- > arch/riscv/Makefile | 3 +- > arch/riscv/config.mk | 9 +- > arch/riscv/cpu/Makefile | 7 ++ > arch/riscv/cpu/ax25/Makefile | 2 - > arch/riscv/cpu/cpu.c | 49 ++++++++ > arch/riscv/cpu/qemu/Makefile | 6 + > arch/riscv/cpu/qemu/cpu.c | 29 +++++ > arch/riscv/cpu/qemu/dram.c | 17 +++ > arch/riscv/cpu/{ax25 => }/start.S | 0 > arch/riscv/cpu/{ax25 => }/u-boot.lds | 60 +++++----- > arch/riscv/dts/ae350.dts | 177 +++++++++++++++-------------- > arch/riscv/include/asm/bootm.h | 13 --- > arch/riscv/include/asm/csr.h | 124 ++++++++++++++++++++ > arch/riscv/include/asm/mach-types.h | 29 ----- > arch/riscv/include/asm/setup.h | 194 -------------------------------- > arch/riscv/include/asm/u-boot.h | 1 - > arch/riscv/lib/bootm.c | 19 +--- > board/AndesTech/ax25-ae350/ax25-ae350.c | 2 - > board/emulation/qemu-riscv/Kconfig | 21 ++++ > board/emulation/qemu-riscv/MAINTAINERS | 7 ++ > board/emulation/qemu-riscv/Makefile | 5 + > board/emulation/qemu-riscv/qemu-riscv.c | 23 ++++ > cmd/bdinfo.c | 1 - > configs/ax25-ae350_defconfig | 2 - > configs/qemu-riscv32_defconfig | 10 ++ > configs/qemu-riscv64_defconfig | 11 ++ > doc/README.qemu-riscv | 46 ++++++++ > include/configs/qemu-riscv.h | 21 ++++ > 30 files changed, 520 insertions(+), 383 deletions(-) create mode 100644 > arch/riscv/cpu/Makefile create mode 100644 arch/riscv/cpu/cpu.c create > mode 100644 arch/riscv/cpu/qemu/Makefile create mode 100644 > arch/riscv/cpu/qemu/cpu.c create mode 100644 arch/riscv/cpu/qemu/dram.c > rename arch/riscv/cpu/{ax25 => }/start.S (100%) rename arch/riscv/cpu/{ax25 > => }/u-boot.lds (54%) delete mode 100644 arch/riscv/include/asm/bootm.h > create mode 100644 arch/riscv/include/asm/csr.h delete mode 100644 > arch/riscv/include/asm/mach-types.h > delete mode 100644 arch/riscv/include/asm/setup.h create mode 100644 > board/emulation/qemu-riscv/Kconfig > create mode 100644 board/emulation/qemu-riscv/MAINTAINERS > create mode 100644 board/emulation/qemu-riscv/Makefile > create mode 100644 board/emulation/qemu-riscv/qemu-riscv.c > create mode 100644 configs/qemu-riscv32_defconfig create mode 100644 > configs/qemu-riscv64_defconfig create mode 100644 doc/README.qemu-riscv > create mode 100644 include/configs/qemu-riscv.h > > -- > 2.7.4 > Hi Bin Thanks for your reviewing for code clean and make it easier to support new targets. I will merge this series to u-boot-riscv when next merge window open. :) B.R Rick

1 0

[U-Boot] [PATCH 1/1] efi_loader: use correct documentation style
by Heinrich Schuchardt 03 Sep '18

03 Sep '18

We have moved generating html documentation with Sphinx. %s/Return Value/Return/g Signed-off-by: Heinrich Schuchardt <xypron.glpk(a)gmx.de> --- lib/efi_loader/efi_boottime.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c index ef4495ea46..cd5fdb7aa8 100644 --- a/lib/efi_loader/efi_boottime.c +++ b/lib/efi_loader/efi_boottime.c @@ -3125,7 +3125,7 @@ struct efi_system_table __efi_runtime_data systab = { /** * efi_initialize_system_table() - Initialize system table * - * Return Value: status code + * Return: status code */ efi_status_t efi_initialize_system_table(void) { -- 2.18.0

1 0

[U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes
by Marek Vasut 03 Sep '18

03 Sep '18

The PCI controller can have DT subnodes describing extra properties of particular PCI devices, ie. a PHY attached to an EHCI controller on a PCI bus. This patch parses those DT subnodes and assigns a node to the PCI device instance, so that the driver can extract details from that node and ie. configure the PHY using the PHY subsystem. Signed-off-by: Marek Vasut <marek.vasut+renesas(a)gmail.com> Cc: Simon Glass <sjg(a)chromium.org> --- drivers/pci/pci-uclass.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/pci/pci-uclass.c b/drivers/pci/pci-uclass.c index 46e9c71bdf..306bea0dbf 100644 --- a/drivers/pci/pci-uclass.c +++ b/drivers/pci/pci-uclass.c @@ -662,6 +662,8 @@ static int pci_find_and_bind_driver(struct udevice *parent, for (id = entry->match; id->vendor || id->subvendor || id->class_mask; id++) { + ofnode node; + if (!pci_match_one_id(id, find_id)) continue; @@ -691,6 +693,18 @@ static int pci_find_and_bind_driver(struct udevice *parent, goto error; debug("%s: Match found: %s\n", __func__, drv->name); dev->driver_data = find_id->driver_data; + + dev_for_each_subnode(node, parent) { + phys_addr_t df, size; + df = ofnode_get_addr_size(node, "reg", &size); + + if (PCI_FUNC(df) == PCI_FUNC(bdf) && + PCI_DEV(df) == PCI_DEV(bdf)) { + dev->node = node; + break; + } + } + *devp = dev; return 0; } -- 2.16.2

4 72

[U-Boot] [PATCH v2 0/8] Device tree support for Powerpc in u-boot
by Jagdish Gediya 01 Sep '18

01 Sep '18

In current implementation, Powerpc does not support device tree in u-boot. This patch enables device tree support for PowerPC platform . T2080AQDS board used as first platform. Dtb is embedded in the u-boot following below steps using binmam tool. 1. Remove bootpg and resetvec section if required 2. Append dtb using binman 3. Append bootpg and resetvec section back if removed in 1st step. To enable binman tool, 'binman' node has been added in the device tree. Jagdish Gediya (8): powerpc/dts: Define '_end' symbol in mpc85xx u-boot lds files powerpc/dts: Makefile changes to clean and build dts binman: Add a new "skip-at-start" property in Section class binman: Add support for Powerpc mpc85xx 'bootpg + resetvec' entry powerpc: mpc85xx: Select BINMAN by default powerpc: mpc85xx: Use binman to embed dtb inside u-boot powerpc: dts: Add u-boot.dtsi to use binman for MPC85xx boards powerpc: dts: Enable device tree support for T2080QDS Makefile | 23 +++++++- arch/powerpc/Kconfig | 1 + arch/powerpc/cpu/mpc85xx/Kconfig | 4 ++ arch/powerpc/cpu/mpc85xx/u-boot-nand.lds | 1 + arch/powerpc/cpu/mpc85xx/u-boot.lds | 1 + arch/powerpc/dts/Makefile | 14 +++++ arch/powerpc/dts/e6500_power_isa.dtsi | 39 ++++++++++++++ arch/powerpc/dts/t2080.dtsi | 62 ++++++++++++++++++++++ arch/powerpc/dts/t2080qds.dts | 17 ++++++ arch/powerpc/dts/u-boot.dtsi | 32 +++++++++++ board/freescale/t208xqds/README | 19 +++++++ configs/T2080QDS_NAND_defconfig | 3 +- configs/T2080QDS_SDCARD_defconfig | 3 +- configs/T2080QDS_SPIFLASH_defconfig | 3 +- configs/T2080QDS_defconfig | 4 +- dts/Makefile | 2 +- tools/binman/README | 9 ++++ tools/binman/README.entries | 14 ++++- tools/binman/bsection.py | 1 + .../etype/powerpc_mpc85xx_bootpg_resetvec.py | 25 +++++++++ tools/binman/ftest.py | 8 +++ .../test/80_powerpc_mpc85xx_bootpg_resetvec.dts | 16 ++++++ 22 files changed, 294 insertions(+), 7 deletions(-) create mode 100644 arch/powerpc/dts/Makefile create mode 100644 arch/powerpc/dts/e6500_power_isa.dtsi create mode 100644 arch/powerpc/dts/t2080.dtsi create mode 100644 arch/powerpc/dts/t2080qds.dts create mode 100644 arch/powerpc/dts/u-boot.dtsi create mode 100644 tools/binman/etype/powerpc_mpc85xx_bootpg_resetvec.py create mode 100644 tools/binman/test/80_powerpc_mpc85xx_bootpg_resetvec.dts -- 2.7.4

3 23

[U-Boot] [PATCH] mx7dsabresd: Add the qspi target to the list of supported defconfigs
by Fabio Estevam 01 Sep '18

01 Sep '18

From: Fabio Estevam <fabio.estevam(a)nxp.com> Add an entry for mx7dsabresd_qspi_defconfig to avoid the following warnings: WARNING: no status info for 'mx7dsabresd_qspi' WARNING: no maintainers for 'mx7dsabresd_qspi' Reported-by: Tom Rini <trini(a)konsulko.com> Signed-off-by: Fabio Estevam <fabio.estevam(a)nxp.com> --- board/freescale/mx7dsabresd/MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/board/freescale/mx7dsabresd/MAINTAINERS b/board/freescale/mx7dsabresd/MAINTAINERS index b96642a..5f805af 100644 --- a/board/freescale/mx7dsabresd/MAINTAINERS +++ b/board/freescale/mx7dsabresd/MAINTAINERS @@ -4,3 +4,4 @@ S: Maintained F: board/freescale/mx7dsabresd F: include/configs/mx7dsabresd.h F: configs/mx7dsabresd_defconfig +F: configs/mx7dsabresd_qspi_defconfig -- 2.7.4

1 0

[U-Boot] [PATCH v2 00/17][RESENT] efi_loader: EFI_UNICODE_COLLATION_PROTOCOL
by Heinrich Schuchardt 01 Sep '18

01 Sep '18

This patchset implements the EFI_UNICODE_COLLATION_PROTOCOL and provides unit tests. Additionally some errors when handling Unicode strings are fixed. * possible stack overflow * incorrect handling of precision attribute in printf() * incorrect limit on variable length Some old Unicode functions are replaced. An error in Unicode handling in the FAT file system shall be fixed after merging Takahiro's FAT patches. Until then some redundancy between old and new Unicode functions remains. v2: use CONFIG_IS_ENABLED(EFI_LOADER) instead of defined(CONFIG_EFI_LOADER) && !defined(CONFIG_SPL_BUILD) add configuration option EFI_UNICODE_CAPITALIZATION use ut_assert*() for testing test illegal Unicode sequences add more comments Heinrich Schuchardt (17): vsprintf.c: use #if CONFIG_IS_ENABLED(EFI_LOADER) test: print_ut.c use #if CONFIG_IS_ENABLED(EFI_LOADER) lib: build charset.o only if needed efi_loader: rename utf16_strlen, utf16_strnlen lib: charset: utility functions for Unicode test: unit tests for Unicode functions lib: vsprintf: correct printing of Unicode strings test: test printing Unicode efi_loader: remove limit on variable length efi_loader: don't use unlimited stack as buffer efi_loader: buffer size for load options lib: charset: remove obsolete functions efi_loader: capitalization table lib: charset: upper/lower case conversion test: tests for utf_to_lower() utf_to_upper(). efi_loader: EFI_UNICODE_COLLATION_PROTOCOL efi_selftest: EFI_UNICODE_COLLATION_PROTOCOL MAINTAINERS | 4 + cmd/bootefi.c | 6 +- include/capitalization.h | 2028 +++++++++++++++++ include/charset.h | 187 +- include/cp1250.h | 40 + include/cp437.h | 40 + include/efi_api.h | 21 + include/efi_loader.h | 5 + include/test/suites.h | 3 +- lib/Makefile | 5 + lib/charset.c | 359 ++- lib/efi_loader/Kconfig | 10 + lib/efi_loader/Makefile | 18 +- lib/efi_loader/efi_bootmgr.c | 2 +- lib/efi_loader/efi_boottime.c | 6 + lib/efi_loader/efi_console.c | 20 +- lib/efi_loader/efi_file.c | 2 +- lib/efi_loader/efi_unicode_collation.c | 329 +++ lib/efi_loader/efi_variable.c | 52 +- lib/efi_selftest/Makefile | 1 + .../efi_selftest_unicode_collation.c | 260 +++ lib/vsprintf.c | 29 +- test/Kconfig | 8 + test/Makefile | 1 + test/cmd_ut.c | 13 +- test/print_ut.c | 6 +- test/unicode_ut.c | 539 +++++ 27 files changed, 3824 insertions(+), 170 deletions(-) create mode 100644 include/capitalization.h create mode 100644 include/cp1250.h create mode 100644 include/cp437.h create mode 100644 lib/efi_loader/efi_unicode_collation.c create mode 100644 lib/efi_selftest/efi_selftest_unicode_collation.c create mode 100644 test/unicode_ut.c -- 2.18.0

2 21