July 2018 - U-Boot

[U-Boot] [PATCH v2 1/2] net: mvgbe: prepare for conversion to driver model
by Chris Packham 09 Jul '18

09 Jul '18

Extract some function bodies to helper functions that can be reused in the DM/non-DM implementations. Signed-off-by: Chris Packham <judge.packham(a)gmail.com> Acked-by: Joe Hershberger <joe.hershberger(a)ni.com> --- Changes in v2: None drivers/net/mvgbe.c | 109 ++++++++++++++++++++++++++++++++------------ 1 file changed, 80 insertions(+), 29 deletions(-) diff --git a/drivers/net/mvgbe.c b/drivers/net/mvgbe.c index e6585ef8b3e7..96ca35512f01 100644 --- a/drivers/net/mvgbe.c +++ b/drivers/net/mvgbe.c @@ -55,20 +55,13 @@ static int smi_wait_ready(struct mvgbe_device *dmvgbe) return 0; } -/* - * smi_reg_read - miiphy_read callback function. - * - * Returns 16bit phy register value, or -EFAULT on error - */ -static int smi_reg_read(struct mii_dev *bus, int phy_adr, int devad, - int reg_ofs) +static int __mvgbe_mdio_read(struct mvgbe_device *dmvgbe, int phy_adr, + int devad, int reg_ofs) { - u16 data = 0; - struct eth_device *dev = eth_get_dev_by_name(bus->name); - struct mvgbe_device *dmvgbe = to_mvgbe(dev); struct mvgbe_registers *regs = dmvgbe->regs; u32 smi_reg; u32 timeout; + u16 data = 0; /* Phyadr read request */ if (phy_adr == MV_PHY_ADR_REQUEST && @@ -127,15 +120,22 @@ static int smi_reg_read(struct mii_dev *bus, int phy_adr, int devad, } /* - * smi_reg_write - miiphy_write callback function. + * smi_reg_read - miiphy_read callback function. * - * Returns 0 if write succeed, -EFAULT on error + * Returns 16bit phy register value, or -EFAULT on error */ -static int smi_reg_write(struct mii_dev *bus, int phy_adr, int devad, - int reg_ofs, u16 data) +static int smi_reg_read(struct mii_dev *bus, int phy_adr, int devad, + int reg_ofs) { struct eth_device *dev = eth_get_dev_by_name(bus->name); struct mvgbe_device *dmvgbe = to_mvgbe(dev); + + return __mvgbe_mdio_read(dmvgbe, phy_adr, devad, reg_ofs); +} + +static int __mvgbe_mdio_write(struct mvgbe_device *dmvgbe, int phy_adr, + int devad, int reg_ofs, u16 data) +{ struct mvgbe_registers *regs = dmvgbe->regs; u32 smi_reg; @@ -171,6 +171,20 @@ static int smi_reg_write(struct mii_dev *bus, int phy_adr, int devad, return 0; } + +/* + * smi_reg_write - miiphy_write callback function. + * + * Returns 0 if write succeed, -EFAULT on error + */ +static int smi_reg_write(struct mii_dev *bus, int phy_adr, int devad, + int reg_ofs, u16 data) +{ + struct eth_device *dev = eth_get_dev_by_name(bus->name); + struct mvgbe_device *dmvgbe = to_mvgbe(dev); + + return __mvgbe_mdio_write(dmvgbe, phy_adr, devad, reg_ofs, data); +} #endif /* Stop and checks all queues */ @@ -357,8 +371,9 @@ static int port_uc_addr(struct mvgbe_registers *regs, u8 uc_nibble, /* * port_uc_addr_set - This function Set the port Unicast address. */ -static void port_uc_addr_set(struct mvgbe_registers *regs, u8 * p_addr) +static void port_uc_addr_set(struct mvgbe_device *dmvgbe, u8 *p_addr) { + struct mvgbe_registers *regs = dmvgbe->regs; u32 mac_h; u32 mac_l; @@ -400,9 +415,8 @@ static void mvgbe_init_rx_desc_ring(struct mvgbe_device *dmvgbe) dmvgbe->p_rxdesc_curr = dmvgbe->p_rxdesc; } -static int mvgbe_init(struct eth_device *dev) +static int __mvgbe_init(struct mvgbe_device *dmvgbe) { - struct mvgbe_device *dmvgbe = to_mvgbe(dev); struct mvgbe_registers *regs = dmvgbe->regs; #if (defined(CONFIG_MII) || defined(CONFIG_CMD_MII)) && \ !defined(CONFIG_PHYLIB) && \ @@ -422,7 +436,7 @@ static int mvgbe_init(struct eth_device *dev) set_dram_access(regs); port_init_mac_tables(regs); - port_uc_addr_set(regs, dmvgbe->dev.enetaddr); + port_uc_addr_set(dmvgbe, dmvgbe->dev.enetaddr); /* Assign port configuration and command. */ MVGBE_REG_WR(regs->pxc, PRT_CFG_VAL); @@ -478,9 +492,15 @@ static int mvgbe_init(struct eth_device *dev) return 0; } -static int mvgbe_halt(struct eth_device *dev) +static int mvgbe_init(struct eth_device *dev) { struct mvgbe_device *dmvgbe = to_mvgbe(dev); + + return __mvgbe_init(dmvgbe); +} + +static void __mvgbe_halt(struct mvgbe_device *dmvgbe) +{ struct mvgbe_registers *regs = dmvgbe->regs; /* Disable all gigE address decoder */ @@ -502,6 +522,13 @@ static int mvgbe_halt(struct eth_device *dev) MVGBE_REG_WR(regs->ice, 0); MVGBE_REG_WR(regs->pim, 0); MVGBE_REG_WR(regs->peim, 0); +} + +static int mvgbe_halt(struct eth_device *dev) +{ + struct mvgbe_device *dmvgbe = to_mvgbe(dev); + + __mvgbe_halt(dmvgbe); return 0; } @@ -509,16 +536,15 @@ static int mvgbe_halt(struct eth_device *dev) static int mvgbe_write_hwaddr(struct eth_device *dev) { struct mvgbe_device *dmvgbe = to_mvgbe(dev); - struct mvgbe_registers *regs = dmvgbe->regs; /* Programs net device MAC address after initialization */ - port_uc_addr_set(regs, dmvgbe->dev.enetaddr); + port_uc_addr_set(dmvgbe, dmvgbe->dev.enetaddr); return 0; } -static int mvgbe_send(struct eth_device *dev, void *dataptr, int datasize) +static int __mvgbe_send(struct mvgbe_device *dmvgbe, void *dataptr, + int datasize) { - struct mvgbe_device *dmvgbe = to_mvgbe(dev); struct mvgbe_registers *regs = dmvgbe->regs; struct mvgbe_txdesc *p_txdesc = dmvgbe->p_txdesc; void *p = (void *)dataptr; @@ -571,13 +597,23 @@ static int mvgbe_send(struct eth_device *dev, void *dataptr, int datasize) return 0; } -static int mvgbe_recv(struct eth_device *dev) +static int mvgbe_send(struct eth_device *dev, void *dataptr, int datasize) { struct mvgbe_device *dmvgbe = to_mvgbe(dev); + + return __mvgbe_send(dmvgbe, dataptr, datasize); +} + +static int __mvgbe_recv(struct mvgbe_device *dmvgbe, uchar **packetp) +{ struct mvgbe_rxdesc *p_rxdesc_curr = dmvgbe->p_rxdesc_curr; u32 cmd_sts; u32 timeout = 0; u32 rxdesc_curr_addr; + unsigned char *data; + int rx_bytes = 0; + + *packetp = NULL; /* wait untill rx packet available or timeout */ do { @@ -621,11 +657,11 @@ static int mvgbe_recv(struct eth_device *dev) " upper layer (net_process_received_packet)\n", __func__); - /* let the upper layer handle the packet */ - net_process_received_packet((p_rxdesc_curr->buf_ptr + - RX_BUF_OFFSET), - (int)(p_rxdesc_curr->byte_cnt - - RX_BUF_OFFSET)); + data = (p_rxdesc_curr->buf_ptr + RX_BUF_OFFSET); + rx_bytes = (int)(p_rxdesc_curr->byte_cnt - + RX_BUF_OFFSET); + + *packetp = data; } /* * free these descriptors and point next in the ring @@ -638,6 +674,21 @@ static int mvgbe_recv(struct eth_device *dev) rxdesc_curr_addr = (u32)&dmvgbe->p_rxdesc_curr; writel((unsigned)p_rxdesc_curr->nxtdesc_p, rxdesc_curr_addr); + return rx_bytes; +} + +static int mvgbe_recv(struct eth_device *dev) +{ + struct mvgbe_device *dmvgbe = to_mvgbe(dev); + uchar *packet; + int ret; + + ret = __mvgbe_recv(dmvgbe, &packet); + if (ret < 0) + return ret; + + net_process_received_packet(packet, ret); + return 0; } -- 2.18.0

2 3

[U-Boot] [PATCH v3 0/3] Generic file system firmware loader DM
by tien.fong.chee＠intel.com 09 Jul '18

09 Jul '18

From: Tien Fong Chee <tien.fong.chee(a)intel.com> This patchset contains generic file system loader DM which is very close to Linux firmware loader but for U-Boot framework. Generic file system firmware loader can be used load whatever into target location, and then consumer driver would use it to program whatever, ie. the FPGA. This version mainly resolved comments from Simon and Marek in [v2]. Patch set for sandbox will be sent out separately. This series is working on top of u-boot-socfpga.git - http://git.denx.de/u-boot.git . [v2]: https://www.mail-archive.com/u-boot@lists.denx.de/msg286979.html [v1]: https://www.mail-archive.com/u-boot@lists.denx.de/msg286294.html v2 -> v3 changes ---------------- - Node for this driver go in /chosen - Update firmware doc and device tree binding doc. Tien Fong Chee (3): doc: Add new doc for file system firmware loader driver model doc: dtbinding: Add file system firmware loader binding document common: Generic loader for file system doc/device-tree-bindings/chosen.txt | 22 +++ doc/device-tree-bindings/misc/fs_loader.txt | 52 ++++++ doc/driver-model/fs_firmware_loader.txt | 129 +++++++++++++++ drivers/misc/Kconfig | 10 ++ drivers/misc/Makefile | 1 + drivers/misc/fs_loader.c | 238 ++++++++++++++++++++++++++++ include/dm/uclass-id.h | 1 + include/fs_loader.h | 28 ++++ 8 files changed, 481 insertions(+) create mode 100644 doc/device-tree-bindings/misc/fs_loader.txt create mode 100644 doc/driver-model/fs_firmware_loader.txt create mode 100644 drivers/misc/fs_loader.c create mode 100644 include/fs_loader.h -- 2.2.0

5 19

[U-Boot] [PATCH v3 0/2] efi_loader: allow writing to FAT
by Heinrich Schuchardt 09 Jul '18

09 Jul '18

Running UEFI Self-Certifcation Test (SCT) will require to support writing to a FAT file system. Writing to the FAT root directory from EFI fails because the leading slash of the file path is interpreted as part of the filename. With the 1st patch we can write to the root directory. A unit test for writing a new file to the FAT root directory is supplied. We still cannot write to subdirectories. v3: Do not throw an error in the unit test if CONFIG_FAT_WRITE is not not set. Drop accepted patch implying CONFIG_FAT_WRITE from patch set. Heinrich Schuchardt (2): fs: fat: cannot write to subdirectories efi_selftest: test writing to file fs/fat/fat_write.c | 16 ++++- lib/efi_selftest/efi_selftest_block_device.c | 70 ++++++++++++++++++++ 2 files changed, 85 insertions(+), 1 deletion(-) -- 2.18.0

2 4

[U-Boot] [PATCH 1/1] efi_loader: rename utf16_strlen, utf16_strnlen
by Heinrich Schuchardt 09 Jul '18

09 Jul '18

The function names utf16_strlen() and utf16_strnlen() are misnomers. The functions do not count utf-16 characters but non-zero words. So let's rename them to u16_strlen and u16_strnlen(). In utf16_dup() avoid assignment in if clause. Signed-off-by: Heinrich Schuchardt <xypron.glpk(a)gmx.de> --- include/charset.h | 29 ++++++++++++----------------- lib/charset.c | 10 +++++++--- lib/efi_loader/efi_bootmgr.c | 2 +- lib/efi_loader/efi_console.c | 2 +- lib/efi_loader/efi_file.c | 2 +- lib/efi_loader/efi_variable.c | 2 +- lib/vsprintf.c | 2 +- 7 files changed, 24 insertions(+), 25 deletions(-) diff --git a/include/charset.h b/include/charset.h index 11832cbd12..be6e6fe2c7 100644 --- a/include/charset.h +++ b/include/charset.h @@ -12,30 +12,25 @@ #define MAX_UTF8_PER_UTF16 3 +size_t u16_strlen(const u16 *in); /** - * utf16_strlen() - Get the length of an utf16 string + * u16_strlen - count non-zero words * - * Returns the number of 16 bit characters in an utf16 string, not - * including the terminating NULL character. - * - * @in the string to measure - * @return the string length + * @in: utf-16 string + * ReturnValue: number of non-zero words. + * This is not the number of utf-16 letters! */ -size_t utf16_strlen(const uint16_t *in); +size_t u16_strlen(const u16 *in); /** - * utf16_strnlen() - Get the length of a fixed-size utf16 string. - * - * Returns the number of 16 bit characters in an utf16 string, - * not including the terminating NULL character, but at most - * 'count' number of characters. In doing this, utf16_strnlen() - * looks at only the first 'count' characters. + * u16_strlen - count non-zero words * - * @in the string to measure - * @count the maximum number of characters to count - * @return the string length, up to a maximum of 'count' + * @in: utf-16 string + * @count: maximum number of words to count + * ReturnValue: number of non-zero words. + * This is not the number of utf-16 letters! */ -size_t utf16_strnlen(const uint16_t *in, size_t count); +size_t u16_strnlen(const u16 *in, size_t count); /** * utf16_strcpy() - UTF16 equivalent of strcpy() diff --git a/lib/charset.c b/lib/charset.c index cd186a5a5a..8ff8d59957 100644 --- a/lib/charset.c +++ b/lib/charset.c @@ -12,14 +12,14 @@ * utf8/utf16 conversion mostly lifted from grub */ -size_t utf16_strlen(const uint16_t *in) +size_t u16_strlen(const u16 *in) { size_t i; for (i = 0; in[i]; i++); return i; } -size_t utf16_strnlen(const uint16_t *in, size_t count) +size_t u16_strnlen(const u16 *in, size_t count) { size_t i; for (i = 0; count-- && in[i]; i++); @@ -39,7 +39,11 @@ uint16_t *utf16_strcpy(uint16_t *dest, const uint16_t *src) uint16_t *utf16_strdup(const uint16_t *s) { uint16_t *new; - if (!s || !(new = malloc((utf16_strlen(s) + 1) * 2))) + + if (!s) + return NULL; + new = malloc((u16_strlen(s) + 1) * 2); + if (!new) return NULL; utf16_strcpy(new, s); return new; diff --git a/lib/efi_loader/efi_bootmgr.c b/lib/efi_loader/efi_bootmgr.c index 853358ab93..0c5764db12 100644 --- a/lib/efi_loader/efi_bootmgr.c +++ b/lib/efi_loader/efi_bootmgr.c @@ -60,7 +60,7 @@ static void parse_load_option(struct load_option *lo, void *ptr) ptr += sizeof(u16); lo->label = ptr; - ptr += (utf16_strlen(lo->label) + 1) * 2; + ptr += (u16_strlen(lo->label) + 1) * 2; lo->file_path = ptr; ptr += lo->file_path_length; diff --git a/lib/efi_loader/efi_console.c b/lib/efi_loader/efi_console.c index 3fd0d2fd51..47fe54d79e 100644 --- a/lib/efi_loader/efi_console.c +++ b/lib/efi_loader/efi_console.c @@ -122,7 +122,7 @@ static efi_status_t EFIAPI efi_cout_output_string( EFI_ENTRY("%p, %p", this, string); - unsigned int n16 = utf16_strlen(string); + unsigned int n16 = u16_strlen(string); char buf[MAX_UTF8_PER_UTF16 * n16 + 1]; u16 *p; diff --git a/lib/efi_loader/efi_file.c b/lib/efi_loader/efi_file.c index e6a15bcb52..c21881b32c 100644 --- a/lib/efi_loader/efi_file.c +++ b/lib/efi_loader/efi_file.c @@ -139,7 +139,7 @@ static struct efi_file_handle *file_open(struct file_system *fs, if (file_name) { utf16_to_utf8((u8 *)f0, (u16 *)file_name, 1); - flen = utf16_strlen((u16 *)file_name); + flen = u16_strlen((u16 *)file_name); } /* we could have a parent, but also an absolute path: */ diff --git a/lib/efi_loader/efi_variable.c b/lib/efi_loader/efi_variable.c index 90b637215e..770c67abb9 100644 --- a/lib/efi_loader/efi_variable.c +++ b/lib/efi_loader/efi_variable.c @@ -106,7 +106,7 @@ static efi_status_t efi_to_native(char *native, u16 *variable_name, { size_t len; - len = utf16_strlen((u16 *)variable_name); + len = u16_strlen((u16 *)variable_name); if (len >= MAX_VAR_NAME) return EFI_DEVICE_ERROR; diff --git a/lib/vsprintf.c b/lib/vsprintf.c index 914fbd30cb..c805b998f9 100644 --- a/lib/vsprintf.c +++ b/lib/vsprintf.c @@ -278,7 +278,7 @@ static char *string16(char *buf, char *end, u16 *s, int field_width, int precision, int flags) { u16 *str = s ? s : L"<NULL>"; - int utf16_len = utf16_strnlen(str, precision); + int utf16_len = u16_strnlen(str, precision); u8 utf8[utf16_len * MAX_UTF8_PER_UTF16]; int utf8_len, i; -- 2.18.0

2 1

[U-Boot] Please pull u-boot-video/master
by Anatolij Gustschin 09 Jul '18

09 Jul '18

Hi Tom, The following changes since commit 2121bbe49c27b2b2d865fac4e4071c5a90ae90b2: lib: div64: fix typeo in include/div64.h (2018-06-29 11:30:39 -0400) are available in the git repository at: git://git.denx.de/u-boot-video.git master for you to fetch changes up to 425daac481c1374313f8eae6c159368e12dc4043: video: arm: rpi: Add brcm,bcm2708-fb compatible (2018-07-02 15:23:50 +0200) ---------------------------------------------------------------- Emmanuel Vadot (1): video: arm: rpi: Add brcm,bcm2708-fb compatible drivers/video/bcm2835.c | 1 + 1 file changed, 1 insertion(+) Please pull. Thanks! Anatolij

2 1

[U-Boot] [PATCH] mmc: dw_mmc: Handle pin voltage configuration
by Carlo Caione 09 Jul '18

09 Jul '18

From: Carlo Caione <carlo(a)endlessm.com> Add support for pin voltage configuration. Besides to support UHS mode this is useful when the IO lines are connected to a configurable regulator not enabled at boot or always on. Signed-off-by: Carlo Caione <carlo(a)endlessm.com> --- drivers/mmc/dw_mmc.c | 34 ++++++++++++++++++++++++++++++++++ include/dwmmc.h | 26 ++++++++++++++------------ 2 files changed, 48 insertions(+), 12 deletions(-) diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c index 13180fc0d6..0841d516d2 100644 --- a/drivers/mmc/dw_mmc.c +++ b/drivers/mmc/dw_mmc.c @@ -12,6 +12,7 @@ #include <memalign.h> #include <mmc.h> #include <dwmmc.h> +#include <power/regulator.h> #define PAGE_SIZE 4096 @@ -382,6 +383,34 @@ static int dwmci_setup_bus(struct dwmci_host *host, u32 freq) return 0; } +#if CONFIG_IS_ENABLED(MMC_IO_VOLTAGE) && CONFIG_IS_ENABLED(DM_REGULATOR) +static int dwmci_set_io_regulators(struct mmc *mmc) +{ + struct dwmci_host *host = (struct dwmci_host *)mmc->priv; + int uv = mmc_voltage_to_mv(mmc->signal_voltage) * 1000; + int ret = 0; + + if (!mmc->vqmmc_supply) + return 0; + + host->signal_voltage = mmc->signal_voltage; + + ret = regulator_set_enable(mmc->vqmmc_supply, false); + if (ret && ret != -ENOSYS) + return ret; + + ret = regulator_set_value(mmc->vqmmc_supply, uv); + if (ret) + return ret; + + ret = regulator_set_enable(mmc->vqmmc_supply, true); + if (ret && ret != -ENOSYS) + return ret; + + return 0; +} +#endif + #ifdef CONFIG_DM_MMC static int dwmci_set_ios(struct udevice *dev) { @@ -421,6 +450,11 @@ static int dwmci_set_ios(struct mmc *mmc) if (host->clksel) host->clksel(host); +#if CONFIG_IS_ENABLED(MMC_IO_VOLTAGE) && CONFIG_IS_ENABLED(DM_REGULATOR) + if (host->signal_voltage != mmc->signal_voltage) + return dwmci_set_io_regulators(mmc); +#endif + return 0; } diff --git a/include/dwmmc.h b/include/dwmmc.h index bc1d6e3abb..461141af54 100644 --- a/include/dwmmc.h +++ b/include/dwmmc.h @@ -133,18 +133,19 @@ /** * struct dwmci_host - Information about a designware MMC host * - * @name: Device name - * @ioaddr: Base I/O address of controller - * @quirks: Quick flags - see DWMCI_QUIRK_... - * @caps: Capabilities - see MMC_MODE_... - * @bus_hz: Bus speed in Hz, if @get_mmc_clk() is NULL - * @div: Arbitrary clock divider value for use by controller - * @dev_index: Arbitrary device index for use by controller - * @dev_id: Arbitrary device ID for use by controller - * @buswidth: Bus width in bits (8 or 4) - * @fifoth_val: Value for FIFOTH register (or 0 to leave unset) - * @mmc: Pointer to generic MMC structure for this device - * @priv: Private pointer for use by controller + * @name: Device name + * @ioaddr: Base I/O address of controller + * @quirks: Quick flags - see DWMCI_QUIRK_... + * @caps: Capabilities - see MMC_MODE_... + * @bus_hz: Bus speed in Hz, if @get_mmc_clk() is NULL + * @div: Arbitrary clock divider value for use by controller + * @signal_voltage: Current voltage for the IO lines + * @dev_index: Arbitrary device index for use by controller + * @dev_id: Arbitrary device ID for use by controller + * @buswidth: Bus width in bits (8 or 4) + * @fifoth_val: Value for FIFOTH register (or 0 to leave unset) + * @mmc: Pointer to generic MMC structure for this device + * @priv: Private pointer for use by controller */ struct dwmci_host { const char *name; @@ -155,6 +156,7 @@ struct dwmci_host { unsigned int clock; unsigned int bus_hz; unsigned int div; + unsigned int signal_voltage; int dev_index; int dev_id; int buswidth; -- 2.17.1

3 2

[U-Boot] [PATCH v3 0/6] efi_loader: correctly initialize system table crc32
by Heinrich Schuchardt 08 Jul '18

08 Jul '18

The crc32 of the system table has to be recalculated when InstallConfigurationTable() changes the number of tables. Adjust the signature of CalculateCrc32(). Provide a unit test that checks the crc32 of the system table, the runtime services table, and the boot sevices table before and after ExitBootServices(). Enhance the unit test for InstallConfigurationTable() to check the crc32. Update the crc32 of the runtime services table when detaching. Tested with Tracis CI: https://travis-ci.org/xypron2/u-boot/builds/401158750 v3: Update the crc32 of the runtime services table when detaching. Adjust the signature of CalculateCrc32(). Recalculate crc32 in InstallConfigurationTable() and unit test. v2: avoid a warning in a debug statement *** BLURB HERE *** Heinrich Schuchardt (6): efi_loader: correct signature of CalculateCrc32() efi_loader: update crc32 in InstallConfigurationTable efi_selftest: check crc32 for InstallConfigurationTable efi_selftest: unit test for CalculateCrc32() lib: crc32: mark function crc32() as __efi_runtime efi_loader: update runtime services table crc32 include/efi_api.h | 5 +- include/efi_loader.h | 3 + lib/crc32.c | 14 +- lib/efi_loader/efi_boottime.c | 23 +-- lib/efi_loader/efi_runtime.c | 15 ++ lib/efi_selftest/Makefile | 1 + lib/efi_selftest/efi_selftest_config_table.c | 43 ++++++ lib/efi_selftest/efi_selftest_crc32.c | 141 +++++++++++++++++++ 8 files changed, 222 insertions(+), 23 deletions(-) create mode 100644 lib/efi_selftest/efi_selftest_crc32.c -- 2.18.0

2 8

Re: [U-Boot] [U-Boot, v2, 1/3] efi_loader: correctly initialize system table crc32
by Heinrich Schuchardt 08 Jul '18

08 Jul '18

On 07/06/2018 07:22 AM, Alexander Graf wrote: >> We should calculate the crc32 after initalizing all fields of the system >> table. >> >> Signed-off-by: Heinrich Schuchardt <xypron.glpk(a)gmx.de> > > Thanks, applied to efi-next > > Alex > > Hello Alex, this patch series causes a Travis error. Please, remove it from efi-next. I will send a new version - after Travis testing. Best regards Heinrich

2 1

[U-Boot] [PATCH 1/3] spl: Fix compilation issue when you want to use SPL from enviroment
by Michael Trimarchi 08 Jul '18

08 Jul '18

Change-Id: I8b4af0b27591b6a9d85fb4ecb17e8ca86765b2c0 Signed-off-by: Michael Trimarchi <michael(a)amarulasolutions.com> --- configs/imx6ull_isiot_nand_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/imx6ull_isiot_nand_defconfig b/configs/imx6ull_isiot_nand_defconfig index 5d02186..e02bbc9 100644 --- a/configs/imx6ull_isiot_nand_defconfig +++ b/configs/imx6ull_isiot_nand_defconfig @@ -4,6 +4,7 @@ CONFIG_SYS_TEXT_BASE=0x87800000 CONFIG_SPL_GPIO_SUPPORT=y CONFIG_SPL_LIBCOMMON_SUPPORT=y CONFIG_SPL_LIBGENERIC_SUPPORT=y +CONFIG_SPL_ENV_SUPPORT=y CONFIG_TARGET_MX6ULL_ISIOT=y CONFIG_SPL_SERIAL_SUPPORT=y CONFIG_SPL=y -- 2.7.4

2 1

[U-Boot] [PATCH 1/1] drivers: rtc: correct week day for mc146818
by Heinrich Schuchardt 07 Jul '18

07 Jul '18

For qemu-x86 the date command produces wrong days of the week: Date: 2018-07-06 (Saturday) Time: 18:02:03 Date: 2018-07-07 (unknown day) Time: 21:02:06 According to a comment in the Linux driver the mc146818 only updates the day of the week if the register value is non-zero. Sunday is 1, saturday is 7 unlike in U-Boot (see data sheet https://www.nxp.com/docs/en/data-sheet/MC146818.pdf). So let's use our library function to determine the day of the week. Signed-off-by: Heinrich Schuchardt <xypron.glpk(a)gmx.de> --- drivers/rtc/mc146818.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/mc146818.c b/drivers/rtc/mc146818.c index 444d4baf0b..1d25c03559 100644 --- a/drivers/rtc/mc146818.c +++ b/drivers/rtc/mc146818.c @@ -109,7 +109,11 @@ static int mc146818_get(struct rtc_time *tmp) tmp->tm_mday = bcd2bin(mday & 0x3f); tmp->tm_mon = bcd2bin(mon & 0x1f); tmp->tm_year = bcd2bin(year); - tmp->tm_wday = bcd2bin(wday & 0x07); + /* + * The mc146818 only updates wday if it is non-zero, sunday is 1 + * saturday is 7. So let's use our library routine. + */ + tmp->tm->wday = rtc_calc_weekday(struct rtc_time *tm); if (tmp->tm_year < 70) tmp->tm_year += 2000; -- 2.18.0

1 0