April 2016 - U-Boot

[U-Boot] [PATCH] cmd: disk: Fix unused variable warning
by Marek Vasut 30 May '16

30 May '16

If serial support is not compiled into U-Boot, which may be the case for some SPL builds, the following warning will be generated in disk.c: cmd/disk.c: In function 'common_diskboot': cmd/disk.c:16:6: warning: variable 'dev' set but not used [-Wunused-but-set-variable] int dev, part; ^ The warning is a result of printf() calls being optimized away, and thus the whole dev variable becomes indeed unused. Mark the variable as __maybe_unused . Signed-off-by: Marek Vasut <marex(a)denx.de> Cc: Simon Glass <sjg(a)chromium.org> Cc: Tom Rini <trini(a)konsulko.com> --- cmd/disk.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cmd/disk.c b/cmd/disk.c index 2fd1717..4c88554 100644 --- a/cmd/disk.c +++ b/cmd/disk.c @@ -13,7 +13,8 @@ int common_diskboot(cmd_tbl_t *cmdtp, const char *intf, int argc, char *const argv[]) { - int dev, part; + __maybe_unused int dev; + int part; ulong addr = CONFIG_SYS_LOAD_ADDR; ulong cnt; disk_partition_t info; -- 2.7.0

3 3

[U-Boot] [PATCH] dm: gpio: pca953x: Support PCA953X with 40 GPIOs
by Mario Six 30 May '16

30 May '16

A DM driver for PCA953x was recently introduced by Peng Fan, which lacked support for the 40 GPIO versions. This patch adds support for these chips. Signed-off-by: Mario Six <mario.six(a)gdsys.cc> --- drivers/gpio/pca953x_gpio.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/pca953x_gpio.c b/drivers/gpio/pca953x_gpio.c index 987d10e..065b181 100644 --- a/drivers/gpio/pca953x_gpio.c +++ b/drivers/gpio/pca953x_gpio.c @@ -16,8 +16,8 @@ * * TODO: * 1. Support PCA957X_TYPE - * 2. Support max 40 gpio pins - * 3. Support Plolarity Inversion + * 2. Support 24 gpio pins + * 3. Support Polarity Inversion */ #include <common.h> @@ -47,7 +47,7 @@ enum { PCA953X_DIRECTION_OUT, }; -#define MAX_BANK 3 +#define MAX_BANK 5 #define BANK_SZ 8 DECLARE_GLOBAL_DATA_PTR; @@ -121,6 +121,9 @@ static int pca953x_read_regs(struct udevice *dev, int reg, u8 *val) ret = dm_i2c_read(dev, reg, val, 1); } else if (info->gpio_count <= 16) { ret = dm_i2c_read(dev, reg << 1, val, info->bank_count); + } else if (info->gpio_count == 40) { + /* Auto increment */ + ret = dm_i2c_read(dev, (reg << 3) | 0x80, val, info->bank_count); } else { dev_err(dev, "Unsupported now\n"); return -EINVAL; -- 2.7.0.GIT

4 3

[U-Boot] [PATCH v2 0/5] tools/env: pass arguments as parameters not global structure
by Andreas Fenkart 30 May '16

30 May '16

u-boot tools can be built as a library (libubootenv.a). Passing arguments to the library using global structures is a bad interface. v2: - fix env_aes_cbc_crypt prototype - check opts pointer for not NULL Andreas Fenkart (5): tools/env: pass key as argument to env_aes_cbc_crypt tools/env: remove 'extern' from function prototype in fw_env.h tools/env: fw_printenv pass value_only as argument tools/env: compute size of usable area only once tools/env: replace global variables by parameter passing tools/env/fw_env.c | 111 ++++++++++++++++++++++++++++-------------------- tools/env/fw_env.h | 31 +++++--------- tools/env/fw_env_main.c | 28 +++++++----- 3 files changed, 94 insertions(+), 76 deletions(-) -- 2.8.0.rc3

2 8

[U-Boot] [verified-boot] Multiple levels of signing keys
by Teddy Reed 30 May '16

30 May '16

Hello all, I'm looking to support "multiple levels" of keys within u-boot's verified boot. I need something similar to UEFI's key enrollment key (KEK) and db/dbx model such that I can support on-line signing of new kernels/rootfs/configurations. To make this work we need a KEK that is not online (kept in a safe), that can be used to sign expirations (revocations) of on-line signing keys in the case of compromise or private key reveals. I know Chrome's Coreboot verified boot model supports this, wondering if there's any staged / WIP for u-boot? Off the top of my head I'd imagine this requires extending the FIT to include sets of public keys and a blacklist of keys and expired or bad kernel/rootfs/etc hashes. Then either extending the boot code to inspect multiple FITs or extending mkimage to combine multiple sources to amalgamate a FIT containing the PK-signed set of keys + hashes and the on-line key-signed kernels/rootfs/configurations. P.S. This may be strongly linked to the need for a TPM to prevent rollbacks. But as far as I can tell, the two features are distinct and a TPM is not completely required for a multi-level key approach to signing FITs. Thanks! -- Teddy Reed V

2 4

[U-Boot] u-boot hangs after enabling secured boot : gumstix-overo
by Arun Kuttiyara Varghese 29 May '16

29 May '16

Hi All, I was trying to enable the secured boot in u-boot for gumstix overo storm. based on http://www.denx-cs.de/doku/?q=m28verifiedboot After I prepared by SD cards, u-boot is not able to boot and gives the below error message. U-Boot SPL 2015.07 (Apr 28 2016 - 13:53:06) SPL: Please implement spl_start_uboot() for your board SPL: Direct Linux boot not active! reading u-boot.img spl_load_image_fat: error reading image u-boot.img, err - -1 SPL: Please implement spl_start_uboot() for your board SPL: Direct Linux boot not active! Failed to mount ext2 filesystem... spl_load_image_ext: ext4fs mount err - 0 ================ This is the u-boot.dts file that I am using. /dts-v1/; / { model = "Keys"; signature { key-dev { required = "conf"; algo = "sha1,rsa2048"; key-name-hint = "my_key"; }; }; }; compilation using : dtc -p 0x1000 /work/u-boot.dts -O dtb -o /work/u-boot.dtb And these are the conf that I have added to include/configs/omap3_overo.h #define CONFIG_OF_CONTROL #define CONFIG_OF_SEPARATE #define CONFIG_FIT #define CONFIG_FIT_SIGNATURE #define CONFIG_RSA #define CONFIG_FIT_VERBOSE and I am compiling u-boot by using below line : make ARCH=arm CROSS_COMPILE=arm-linux-gnueabi- EXT_DTB=/work/u-boot.dtb all -j4 Please let me know if you have any ideas on how to debug this issue. Thanks & Regards, Arun

2 5

[U-Boot] Unaligned flush_dcache_range in axs101.c
by Alexander Graf 27 May '16

27 May '16

Hi Alexey, Marek just pointed out to me the fact that flush_dcache_range on arm expects cache line aligned arguments. However, it seems like in axs101.c we have an unaligned cache flush: flush_dcache_range(RESET_VECTOR_ADDR, RESET_VECTOR_ADDR + sizeof(int)); Could you please verify whether this is correct and if not just send a quick patch to fix it? Thanks! Alex

4 9

[U-Boot] [PATCH v2] armv8/ls2080ardb: Update DDR timing to support more UDIMMs
by Shengzhou Liu 27 May '16

27 May '16

Optimize DDR timing for good margins to support new Transcend and Apacer DDR4 UDIMM besides current Micron UDIMM. Verified 1333MT/s, 1600MT/s, 1866MT/s, 2133MT/s rate with following UDIMM on LS2080ARDB. - Micron UDIMM: MTA18ASF1G72AZ-2G1A1Z - Apacer UDIMM: 78.C1GM4.AF10B - Transcend UDIMM: TS1GLH72V1H Signed-off-by: Shengzhou Liu <Shengzhou.Liu(a)nxp.com> --- v2: verified lower rate, for 1333MT/s no changes are necessary. board/freescale/ls2080ardb/ddr.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/board/freescale/ls2080ardb/ddr.h b/board/freescale/ls2080ardb/ddr.h index bda9d4a..b3c6306 100644 --- a/board/freescale/ls2080ardb/ddr.h +++ b/board/freescale/ls2080ardb/ddr.h @@ -29,9 +29,9 @@ static const struct board_specific_parameters udimm0[] = { * ranks| mhz| GB |adjst| start | ctl2 | ctl3 */ {2, 1350, 0, 4, 6, 0x0708090B, 0x0C0D0E09,}, - {2, 1666, 0, 4, 8, 0x08090B0D, 0x0E10100C,}, - {2, 1900, 0, 4, 8, 0x090A0C0E, 0x1012120D,}, - {2, 2300, 0, 4, 9, 0x0A0B0C10, 0x1114140E,}, + {2, 1666, 0, 5, 9, 0x090A0B0E, 0x0F11110C,}, + {2, 1900, 0, 6, 0xA, 0x0B0C0E11, 0x1214140F,}, + {2, 2300, 0, 6, 0xB, 0x0C0D0F12, 0x14161610,}, {} }; -- 2.1.0.27.g96db324

3 5

[U-Boot] [PATCH 1/2] ARM: exynos: Fix build error if SERIAL is disabled in SPL
by Marek Vasut 26 May '16

26 May '16

If CONFIG_SPL_SERIAL_SUPPORT is not defined in include/configs/exynos5-common.h the following error is produced during the build of the SPL: arch/arm/mach-exynos/built-in.o: In function `do_lowlevel_init': ...u-boot/arch/arm/mach-exynos/lowlevel_init.c:221: undefined reference to `debug_uart_init' Add additional condition to check if SPL build is in progress and in that case check if CONFIG_SPL_SERIAL_SUPPORT is also set before enabling the debug UART. Signed-off-by: Marek Vasut <marex(a)denx.de> Cc: Simon Glass <sjg(a)chromium.org> Cc: Tom Rini <trini(a)konsulko.com> --- arch/arm/mach-exynos/lowlevel_init.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/mach-exynos/lowlevel_init.c b/arch/arm/mach-exynos/lowlevel_init.c index 6c39cb2..1e090fd 100644 --- a/arch/arm/mach-exynos/lowlevel_init.c +++ b/arch/arm/mach-exynos/lowlevel_init.c @@ -216,9 +216,12 @@ int do_lowlevel_init(void) if (actions & DO_CLOCKS) { system_clock_init(); #ifdef CONFIG_DEBUG_UART +#if (defined(CONFIG_SPL_BUILD) && defined(CONFIG_SPL_SERIAL_SUPPORT)) || \ + !defined(CONFIG_SPL_BUILD) exynos_pinmux_config(PERIPH_ID_UART3, PINMUX_FLAG_NONE); debug_uart_init(); #endif +#endif mem_ctrl_init(actions & DO_MEM_RESET); tzpc_init(); } -- 2.7.0

4 7

[U-Boot] [PATCH v2 00/25] exynos: video: Convert exynos LCD driver to use driver model
by Simon Glass 26 May '16

26 May '16

This series converts the exynos LCD driver to work with driver model. Only the eDP display is converted - the MIPI display is left mostly alone as I do not have a device to test with. The conversion involves some refactoring to simplify the code, reduce the amount of global/static data and allow boards to be built without LCD support. The series is tested with snow, spring, pit and pi. It disables LCD on other exynos boards so that they will still build with these changes. Further work will be needed (by someone with a board) to convert the others. I am not sure when this series can be applied. The series also brings in device tree features from Linux v4.4. It would be useful to do a full sync with the kernel on these files, but this is really a job for the Samsung maintainer :-) The series is available at u-boot-dm/rkg-working. Changes in v2: - Rebase to master - Rebase to master Simon Glass (25): exynos: video: Move driver files into their own directory exynos: video: Drop dead code exynos: video: Remove use of vidinfo_t typedef exynos: video: Drop the static lcd_base_addr variable exynos: video: Drop static variables in exynos_fimd.c exynos: video: Drop static variables in exynos_fb.c exynos: video: Drop static variables in exynos_dp_lowlevel.c exynos: video: Move dsim_config_dt into a function exynos: video: Move struct exynos_platform_mipi_dsim into vidinfo exynos: video: Move mipi_lcd_device_dt into a function exynos: video: Combine LCD driver into one file exynos: pwm: Add a driver for the exynos5 PWM video: Add an enum for active low/high exynos: dts: Add pwm device tree node exynos: Allow tizen to be built without an LCD exynos: Allow CONFIG_MISC_COMMON to be build without an LCD exynos: Disable LCD display for boards we can't convert dts: Add clock and regulator binding files for max77802 exynos: Allow PWM0 pinmux to be set up exynos: Simplify calling of exynos_dp_phy_ctrl() exynos: dts: Add display-related device tree fragments exynos: video: Rename edp_device_info to exynos_dp_priv exynos: video: Rename variables for driver model exynos: video: Convert several boards to driver model for video exynos: video: Drop old unused code arch/arm/cpu/armv7/s5p-common/timer.c | 3 + arch/arm/dts/exynos5.dtsi | 3 +- arch/arm/dts/exynos5250-snow.dts | 44 ++ arch/arm/dts/exynos5250-spring.dts | 53 ++ arch/arm/dts/exynos5250.dtsi | 7 + arch/arm/dts/exynos5420-peach-pit.dts | 55 ++ arch/arm/dts/exynos54xx.dtsi | 11 +- arch/arm/dts/exynos5800-peach-pi.dts | 40 ++ arch/arm/mach-exynos/include/mach/cpu.h | 2 - arch/arm/mach-exynos/include/mach/dp_info.h | 5 +- arch/arm/mach-exynos/include/mach/mipi_dsim.h | 10 +- arch/arm/mach-exynos/include/mach/power.h | 2 +- arch/arm/mach-exynos/pinmux.c | 6 + arch/arm/mach-exynos/power.c | 2 +- board/samsung/common/board.c | 15 - board/samsung/common/exynos5-dt.c | 158 ----- board/samsung/common/misc.c | 10 + board/samsung/trats/trats.c | 2 + board/samsung/universal_c210/universal.c | 2 + configs/peach-pi_defconfig | 4 + configs/peach-pit_defconfig | 4 + configs/snow_defconfig | 4 + configs/spring_defconfig | 4 + drivers/pwm/Kconfig | 9 + drivers/pwm/Makefile | 1 + drivers/pwm/exynos_pwm.c | 120 ++++ drivers/video/Makefile | 6 +- drivers/video/exynos/Makefile | 12 + drivers/video/{ => exynos}/exynos_dp.c | 599 ++++++++++------- drivers/video/{ => exynos}/exynos_dp_lowlevel.c | 268 ++++---- drivers/video/exynos/exynos_dp_lowlevel.h | 89 +++ drivers/video/exynos/exynos_fb.c | 720 +++++++++++++++++++++ drivers/video/{ => exynos}/exynos_mipi_dsi.c | 71 +- .../video/{ => exynos}/exynos_mipi_dsi_common.c | 6 +- .../video/{ => exynos}/exynos_mipi_dsi_common.h | 0 .../video/{ => exynos}/exynos_mipi_dsi_lowlevel.c | 0 .../video/{ => exynos}/exynos_mipi_dsi_lowlevel.h | 0 drivers/video/{ => exynos}/exynos_pwm_bl.c | 0 drivers/video/exynos_dp_lowlevel.h | 68 -- drivers/video/exynos_fb.c | 330 ---------- drivers/video/exynos_fb.h | 41 -- drivers/video/exynos_fimd.c | 409 ------------ drivers/video/s6e8ax0.c | 4 +- drivers/video/simple_panel.c | 2 + include/configs/exynos5-common.h | 1 - include/configs/exynos5-dt-common.h | 5 +- include/configs/s5pc210_universal.h | 3 - include/configs/smdk5250.h | 3 + include/configs/smdk5420.h | 4 + include/configs/trats.h | 4 - include/configs/trats2.h | 4 - include/dt-bindings/clock/maxim,max77802.h | 22 + include/dt-bindings/regulator/maxim,max77802.h | 18 + include/exynos_lcd.h | 4 +- include/libtizen.h | 2 + include/video.h | 5 + lib/tizen/tizen.c | 2 + 57 files changed, 1804 insertions(+), 1474 deletions(-) create mode 100644 drivers/pwm/exynos_pwm.c create mode 100644 drivers/video/exynos/Makefile rename drivers/video/{ => exynos}/exynos_dp.c (50%) rename drivers/video/{ => exynos}/exynos_dp_lowlevel.c (77%) create mode 100644 drivers/video/exynos/exynos_dp_lowlevel.h create mode 100644 drivers/video/exynos/exynos_fb.c rename drivers/video/{ => exynos}/exynos_mipi_dsi.c (80%) rename drivers/video/{ => exynos}/exynos_mipi_dsi_common.c (99%) rename drivers/video/{ => exynos}/exynos_mipi_dsi_common.h (100%) rename drivers/video/{ => exynos}/exynos_mipi_dsi_lowlevel.c (100%) rename drivers/video/{ => exynos}/exynos_mipi_dsi_lowlevel.h (100%) rename drivers/video/{ => exynos}/exynos_pwm_bl.c (100%) delete mode 100644 drivers/video/exynos_dp_lowlevel.h delete mode 100644 drivers/video/exynos_fb.c delete mode 100644 drivers/video/exynos_fb.h delete mode 100644 drivers/video/exynos_fimd.c create mode 100644 include/dt-bindings/clock/maxim,max77802.h create mode 100644 include/dt-bindings/regulator/maxim,max77802.h -- 2.7.0.rc3.207.g0ac5344

4 57

[U-Boot] [PATCH v3 0/8] Add support for Espresso7420 board
by Thomas Abraham 26 May '16

26 May '16

Changes since v2: - changes based on comments from Simon Glass and Minkyu Kang. This patch series add support for Espresso7420 board. This board is the development/evaluation platform for Exynos7420 SoC. The SoC is composed of quad Cortex-A57 block, a quad Cortex-A53 block and various other peripherals. The board includes multiple components such as the EMMC/Codec and support multiple interconnect interfaces including HDMI and USB. The first two patches add Exynos7420 pinctrl driver support which was initially posted seperatly but now included in this series. Thanks to Simon Glass and Minkyu Kang for their review. The rest of the patches add Exynos7420 clock driver support, minor changes in the S5P serial driver, Exynos7420 SoC support and Espresso7420 board support. Thomas Abraham (8): pinctrl: add the DM_UC_FLAG_SEQ_ALIAS flag for numbering the devices pinctrl: Add pinctrl driver support for Exynos7420 SoC clk: exynos: add clock driver for Exynos7420 Soc serial: s5p: get the port id number from the alias of the device node serial: s5p: use clock api to get clock rate arm: exynos: realign the code to allow support for newer 64-bit platforms arm: exynos: add support for Exynos7420 SoC board: samsung: add initial Espresso7420 board support arch/arm/Kconfig | 1 - arch/arm/dts/Makefile | 1 + arch/arm/dts/exynos7420-espresso7420.dts | 24 +++ arch/arm/dts/exynos7420.dtsi | 83 ++++++++++ arch/arm/mach-exynos/Kconfig | 61 +++++++- arch/arm/mach-exynos/Makefile | 6 +- arch/arm/mach-exynos/include/mach/cpu.h | 2 +- arch/arm/mach-exynos/include/mach/gpio.h | 2 +- arch/arm/mach-exynos/mmu-arm64.c | 35 ++++ arch/arm/mach-exynos/soc.c | 10 + board/samsung/common/board.c | 10 +- board/samsung/espresso7420/Kconfig | 16 ++ board/samsung/espresso7420/MAINTAINERS | 5 + board/samsung/espresso7420/Makefile | 10 + board/samsung/espresso7420/espresso7420.c | 16 ++ configs/arndale_defconfig | 1 + configs/espresso7420_defconfig | 9 + configs/odroid-xu3_defconfig | 1 + configs/odroid_defconfig | 1 + configs/origen_defconfig | 1 + configs/peach-pi_defconfig | 1 + configs/peach-pit_defconfig | 1 + configs/s5pc210_universal_defconfig | 1 + configs/smdk5250_defconfig | 1 + configs/smdk5420_defconfig | 1 + configs/smdkv310_defconfig | 1 + configs/snow_defconfig | 1 + configs/spring_defconfig | 1 + configs/trats2_defconfig | 1 + configs/trats_defconfig | 1 + drivers/clk/Kconfig | 1 + drivers/clk/Makefile | 1 + drivers/clk/exynos/Kconfig | 18 ++ drivers/clk/exynos/Makefile | 9 + drivers/clk/exynos/clk-exynos7420.c | 236 +++++++++++++++++++++++++++ drivers/clk/exynos/clk-pll.c | 33 ++++ drivers/clk/exynos/clk-pll.h | 9 + drivers/pinctrl/Kconfig | 1 + drivers/pinctrl/Makefile | 1 + drivers/pinctrl/exynos/Kconfig | 10 + drivers/pinctrl/exynos/Makefile | 9 + drivers/pinctrl/exynos/pinctrl-exynos.c | 141 ++++++++++++++++ drivers/pinctrl/exynos/pinctrl-exynos.h | 77 +++++++++ drivers/pinctrl/exynos/pinctrl-exynos7420.c | 120 ++++++++++++++ drivers/pinctrl/pinctrl-uclass.c | 1 + drivers/serial/serial_s5p.c | 19 ++- include/configs/espresso7420.h | 34 ++++ include/configs/exynos7420-common.h | 113 +++++++++++++ include/dt-bindings/clock/exynos7420-clk.h | 207 +++++++++++++++++++++++ 49 files changed, 1334 insertions(+), 11 deletions(-) create mode 100644 arch/arm/dts/exynos7420-espresso7420.dts create mode 100644 arch/arm/dts/exynos7420.dtsi create mode 100644 arch/arm/mach-exynos/mmu-arm64.c create mode 100644 board/samsung/espresso7420/Kconfig create mode 100644 board/samsung/espresso7420/MAINTAINERS create mode 100644 board/samsung/espresso7420/Makefile create mode 100644 board/samsung/espresso7420/espresso7420.c create mode 100644 configs/espresso7420_defconfig create mode 100644 drivers/clk/exynos/Kconfig create mode 100644 drivers/clk/exynos/Makefile create mode 100644 drivers/clk/exynos/clk-exynos7420.c create mode 100644 drivers/clk/exynos/clk-pll.c create mode 100644 drivers/clk/exynos/clk-pll.h create mode 100644 drivers/pinctrl/exynos/Kconfig create mode 100644 drivers/pinctrl/exynos/Makefile create mode 100644 drivers/pinctrl/exynos/pinctrl-exynos.c create mode 100644 drivers/pinctrl/exynos/pinctrl-exynos.h create mode 100644 drivers/pinctrl/exynos/pinctrl-exynos7420.c create mode 100644 include/configs/espresso7420.h create mode 100644 include/configs/exynos7420-common.h create mode 100644 include/dt-bindings/clock/exynos7420-clk.h

5 14