February 2015 - U-Boot

[U-Boot] [PATCH 1/3] dm: Prevent "demo hello" and "demo status" segfaults
by Peter Tyser 06 Feb '15

06 Feb '15

Segfaults can occur when a mandatory argument is not provided to "demo hello" and "demo status". Eg: => demo hello Segmentation fault (core dumped) Add a check to ensure all required arguments are provided. Signed-off-by: Peter Tyser <ptyser(a)xes-inc.com> --- common/cmd_demo.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/common/cmd_demo.c b/common/cmd_demo.c index 652c61c..b8b8578 100644 --- a/common/cmd_demo.c +++ b/common/cmd_demo.c @@ -76,7 +76,9 @@ static int do_demo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) ARRAY_SIZE(demo_commands)); argc -= 2; argv += 2; - if (!demo_cmd || argc > demo_cmd->maxargs) + + if ((!demo_cmd || argc > demo_cmd->maxargs) || + ((demo_cmd->name[0] != 'l') && (argc < 1))) return CMD_RET_USAGE; if (argc) { -- 1.9.1

2 3

[U-Boot] [PATCH] RSA depends on DM
by Chris Kuethe 06 Feb '15

06 Feb '15

Discovered while experimenting with signature checking on vexpress which doesn't typically use DM. Rather than complaining about unmet dependencies it might be better to enable those them. --- lib/rsa/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/rsa/Kconfig b/lib/rsa/Kconfig index 1268a1b..4db5da4 100644 --- a/lib/rsa/Kconfig +++ b/lib/rsa/Kconfig @@ -2,6 +2,7 @@ config RSA bool "Use RSA Library" select RSA_FREESCALE_EXP if FSL_CAAM select RSA_SOFTWARE_EXP if !RSA_FREESCALE_EXP + select DM help RSA support. This enables the RSA algorithm used for FIT image verification in U-Boot. -- 2.1.0 -- GDB has a 'break' feature; why doesn't it have 'fix' too?

4 10

[U-Boot] [PATCH 1/2] bootstage: Fix typos in the comment
by Bin Meng 06 Feb '15

06 Feb '15

There are two typos in the comment block in bootstage.h, fix them. Signed-off-by: Bin Meng <bmeng.cn(a)gmail.com> --- include/bootstage.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/bootstage.h b/include/bootstage.h index 6b7588d..0276cb3 100644 --- a/include/bootstage.h +++ b/include/bootstage.h @@ -86,9 +86,9 @@ enum bootstage_id { BOOTSTAGE_ID_POST_FAIL_R, /* Post failure reported after reloc */ /* - * This set is reported ony by x86, and the meaning is different. In + * This set is reported only by x86, and the meaning is different. In * this case we are reporting completion of a particular stage. - * This should probably change in he x86 code (which doesn't report + * This should probably change in the x86 code (which doesn't report * errors in any case), but discussion this can perhaps wait until we * have a generic board implementation. */ -- 1.8.2.1

2 6

[U-Boot] [PATCH 0/6] x86: Add some peripherals support to Intel Galileo
by Bin Meng 06 Feb '15

06 Feb '15

This series adds GPIO, SPI and SD/MMC support to Intel Galileo board. Intel's chipset controllers are normally compatible so that we can easily add peripherals support via existing drivers with minor modification. Note this series depends on previous two series: series#1: http://patchwork.ozlabs.org/patch/435526/ series#2: http://patchwork.ozlabs.org/patch/435816/ With this patch series, the only left interfaces on Galileo board to be enabled are USB, 10/100M Ethernet and mini-PCIe. Bin Meng (6): x86: quark: Initialize non-standard BARs x86: galileo: Add GPIO support x86: pci: Add pci ids for Quark SoC x86: Add SPI support to quark/galileo x86: Add SD/MMC support to quark/galileo x86: Add Intel Galileo instructions in README.x86 arch/x86/cpu/quark/quark.c | 74 +++++++++++++++++++++++++++++++++ arch/x86/dts/galileo.dts | 27 ++++++++++++ arch/x86/include/asm/arch-quark/quark.h | 32 ++++++++++++++ doc/README.x86 | 24 +++++++++-- drivers/spi/ich.c | 3 +- include/configs/galileo.h | 7 ++++ include/pci_ids.h | 4 ++ 7 files changed, 166 insertions(+), 5 deletions(-) -- 1.8.2.1

2 18

[U-Boot] [RFC PATCH v2 0/9] x86: Add Intel Quark Memory Reference Code (MRC) support
by Bin Meng 06 Feb '15

06 Feb '15

This series adds the 2nd step of bare support for the Intel Quark SoC support which can be validated on Intel Galileo board. It adds Intel Quark Memory Reference Code (MRC) which is ported from Intel released UEFI BIOS for Quark, which per its name does the memory initialization for Quark based board. Now with this patch series, U-Boot boots to the command shell on Intel Galileo gen2 board. The MRC port work was mainly replacing all UEFI BIOS APIs with corresponding U-Boot ones, like register access, timer, debug output etc, however the majority of the time was spent to converting Intel coding convention to U-Boot's, like comment block //, space to indent, camel cases, struct typedefs, etc. It took me almost 4 days to finish the work, but I have not managed to fix all checkpatch warnings given the code complexity and black magics in the codes. See commit notes inside patch#3, #4, #5 about the checkpatch warning details. Currently only the cold boot path is taken by MRC and it takes about 10 seconds from power-up to U-Boot shell. Future work will be done to support a fast boot path (MRC cache) which is supposed to boot much faster. With previous Quark patch series, we have a basic support for Intel Quark SoC in good shape which more additional feature work can be based upon in the following weeks. Changes in v2: - Fixed issues per review comments. See the following link for details. http://lists.denx.de/pipermail/u-boot/2015-February/204023.html - Fixed issues per review comments. See the following link for details. http://lists.denx.de/pipermail/u-boot/2015-February/204044.html - Write out the values instead of BIT in smc.h - Removing the ending / in the file header comment block - Update comment for calling mrc_init() - Check return status of mrc_init() Bin Meng (9): x86: Allow overriding TSC_FREQ_IN_MHZ x86: quark: Bypass TSC calibration x86: quark: Add Memory Reference Code (MRC) main routines x86: quark: Add utility codes needed for MRC x86: quark: Add System Memory Controller support x86: quark: Enable the Memory Reference Code build fdtdec: Add compatible id and string for Intel Quark MRC dt-bindings: Add Intel Quark MRC bindings x86: quark: Call MRC in dram_init() arch/x86/Kconfig | 40 +- arch/x86/cpu/quark/Kconfig | 5 + arch/x86/cpu/quark/Makefile | 1 + arch/x86/cpu/quark/dram.c | 99 +- arch/x86/cpu/quark/hte.c | 396 +++++ arch/x86/cpu/quark/hte.h | 44 + arch/x86/cpu/quark/mrc.c | 204 +++ arch/x86/cpu/quark/mrc_util.c | 1475 ++++++++++++++++++ arch/x86/cpu/quark/mrc_util.h | 153 ++ arch/x86/cpu/quark/smc.c | 2764 +++++++++++++++++++++++++++++++++ arch/x86/cpu/quark/smc.h | 446 ++++++ arch/x86/dts/galileo.dts | 25 + arch/x86/include/asm/arch-quark/mrc.h | 187 +++ include/dt-bindings/mrc/quark.h | 83 + include/fdtdec.h | 1 + lib/fdtdec.c | 1 + 16 files changed, 5902 insertions(+), 22 deletions(-) create mode 100644 arch/x86/cpu/quark/hte.c create mode 100644 arch/x86/cpu/quark/hte.h create mode 100644 arch/x86/cpu/quark/mrc.c create mode 100644 arch/x86/cpu/quark/mrc_util.c create mode 100644 arch/x86/cpu/quark/mrc_util.h create mode 100644 arch/x86/cpu/quark/smc.c create mode 100644 arch/x86/cpu/quark/smc.h create mode 100644 arch/x86/include/asm/arch-quark/mrc.h create mode 100644 include/dt-bindings/mrc/quark.h -- 1.8.2.1

2 21

[U-Boot] [RFC PATCH 0/9] x86: Add Intel Quark Memory Reference Code (MRC) support
by Bin Meng 06 Feb '15

06 Feb '15

This series adds the 2nd step of bare support for the Intel Quark SoC support which can be validated on Intel Galileo board. It adds Intel Quark Memory Reference Code (MRC) which is ported from Intel released UEFI BIOS for Quark, which per its name does the memory initialization for Quark based board. Now with this patch series, U-Boot boots to the command shell on Intel Galileo gen2 board. The MRC port work was mainly replacing all UEFI BIOS APIs with corresponding U-Boot ones, like register access, timer, debug output etc, however the majority of the time was spent to converting Intel coding convention to U-Boot's, like comment block //, space to indent, camel cases, struct typedefs, etc. It took me almost 4 days to finish the work, but I have not managed to fix all checkpatch warnings given the code complexity and black magics in the codes. See commit notes inside patch#3, #4, #5 about the checkpatch warning details. Currently only the cold boot path is taken by MRC and it takes about 10 seconds from power-up to U-Boot shell. Future work will be done to support a fast boot path (MRC cache) which is supposed to boot much faster. With previous Quark patch series, we have a basic support for Intel Quark SoC in good shape which more additional feature work can be based upon in the following weeks. Bin Meng (9): x86: Allow overriding TSC_FREQ_IN_MHZ x86: quark: Bypass TSC calibration x86: quark: Add Memory Reference Code (MRC) main routines x86: quark: Add utility codes needed for MRC x86: quark: Add System Memory Controller support x86: quark: Enable the Memory Reference Code build fdtdec: Add compatible id and string for Intel Quark MRC dt-bindings: Add Intel Quark MRC bindings x86: quark: Call MRC in dram_init() arch/x86/Kconfig | 40 +- arch/x86/cpu/quark/Kconfig | 5 + arch/x86/cpu/quark/Makefile | 1 + arch/x86/cpu/quark/dram.c | 97 +- arch/x86/cpu/quark/hte.c | 398 +++++ arch/x86/cpu/quark/hte.h | 44 + arch/x86/cpu/quark/mrc.c | 206 +++ arch/x86/cpu/quark/mrc_util.c | 1499 ++++++++++++++++++ arch/x86/cpu/quark/mrc_util.h | 153 ++ arch/x86/cpu/quark/smc.c | 2764 +++++++++++++++++++++++++++++++++ arch/x86/cpu/quark/smc.h | 446 ++++++ arch/x86/dts/galileo.dts | 25 + arch/x86/include/asm/arch-quark/mrc.h | 189 +++ include/dt-bindings/mrc/quark.h | 83 + include/fdtdec.h | 1 + lib/fdtdec.c | 1 + 16 files changed, 5930 insertions(+), 22 deletions(-) create mode 100644 arch/x86/cpu/quark/hte.c create mode 100644 arch/x86/cpu/quark/hte.h create mode 100644 arch/x86/cpu/quark/mrc.c create mode 100644 arch/x86/cpu/quark/mrc_util.c create mode 100644 arch/x86/cpu/quark/mrc_util.h create mode 100644 arch/x86/cpu/quark/smc.c create mode 100644 arch/x86/cpu/quark/smc.h create mode 100644 arch/x86/include/asm/arch-quark/mrc.h create mode 100644 include/dt-bindings/mrc/quark.h -- 1.8.2.1

3 28

[U-Boot] [RFC PATCH v3 0/7] x86: New Intel Quark SoC support
by Bin Meng 06 Feb '15

06 Feb '15

This series adds the first step of bare support for the Intel Quark SoC support which can be validated on Intel Galileo board. Intel Quark is a line of 32-bit x86 SoCs by Intel, designed for small size and low power consumption, and targeted at new markets including wearable devices. They are smaller and slower than Atom processors and consume less power. They lack support for SIMD instruction sets (such as MMX and SSE) and only support embedded operating systems. Quark powers the Intel Galileo developer microcontroller board. The CPU instruction set is the same as Pentium (P54C/i586) CPU. Intel decided to completely publish Quark's hardware specification to software developers, which includes an SoC datasheet, a UEFI Firmware Writer's Guide, and a complete reference source code for the UEFI BIOS which is pre-flahsed on the Galileo board. As of today, the only BIOS for Galileo is the Intel one with UEFI inteface only. There is no CSM support yet in that BIOS, neither any 3rd party BIOS vendor provides support to Quark SoC. Only one binary blob (exactly 8KiB) is needed which is rmu.bin for Remote Management Unit. Not like FSP, U-Boot will not call into the binary. The binary is needed by the Quark SoC itself. Note there are two generation of Galileo boards, aka gen1 and gen2. Currently the development work is on gen2, but once we get it boot, we can easily add the gen1 board (old version). With this patch series, the generated u-boot.rom could boot the Intel Galileo board up to fdt relocate, where U-Boot hangs because the DRAM is not initializaed yet. A follow up patch series will be sent soon to add support for Memory Reference Code (MRC). Changes in v3: - Add several macros for message bus port and registers - Use lower case hex - New patch to define macros for pci configuration space access - Use macros from <asm/pci.h> and <asm/arch/quark.h> - Add simple help for ACPI PM1, PBLK and GEP0 Changes in v2: - Rebase to u-boot-86/master - Add msg_port_setup() and remove MCR_FILL - Add MSG_BYTE_ENABLE define - Wrap function declaraion with __ASSEMBLY__ - Replace upper case register names (EAX etc.) with lower case - Use some macros from <asm/arch/msg_port.h> and <asm/arch/quark.h> - Use machine-specific - Move vairous components' base addresses within Quark SoC to Kconfig - Use Arduino-certified Bin Meng (7): x86: Add header files for Intel Quark SoC defines x86: quark: Add routines to access message bus registers x86: Define macros for pci configuration space access x86: quark: Add Cache-As-RAM initialization x86: Add basic Intel Quark processor support x86: Add basic Intel Galileo board support x86: Enable the Intel quark/galileo build arch/x86/Kconfig | 17 ++++ arch/x86/cpu/Makefile | 1 + arch/x86/cpu/quark/Kconfig | 121 +++++++++++++++++++++++++++++ arch/x86/cpu/quark/Makefile | 8 ++ arch/x86/cpu/quark/car.S | 105 +++++++++++++++++++++++++ arch/x86/cpu/quark/dram.c | 39 ++++++++++ arch/x86/cpu/quark/msg_port.c | 77 ++++++++++++++++++ arch/x86/cpu/quark/pci.c | 70 +++++++++++++++++ arch/x86/cpu/quark/quark.c | 44 +++++++++++ arch/x86/dts/Makefile | 1 + arch/x86/dts/galileo.dts | 43 ++++++++++ arch/x86/include/asm/arch-quark/device.h | 28 +++++++ arch/x86/include/asm/arch-quark/gpio.h | 13 ++++ arch/x86/include/asm/arch-quark/msg_port.h | 106 +++++++++++++++++++++++++ arch/x86/include/asm/arch-quark/quark.h | 40 ++++++++++ arch/x86/include/asm/pci.h | 13 +++- arch/x86/lib/pci_type1.c | 7 +- board/intel/galileo/Kconfig | 21 +++++ board/intel/galileo/MAINTAINERS | 6 ++ board/intel/galileo/Makefile | 7 ++ board/intel/galileo/galileo.c | 19 +++++ board/intel/galileo/start.S | 9 +++ configs/galileo_defconfig | 6 ++ include/configs/galileo.h | 53 +++++++++++++ 24 files changed, 847 insertions(+), 7 deletions(-) create mode 100644 arch/x86/cpu/quark/Kconfig create mode 100644 arch/x86/cpu/quark/Makefile create mode 100644 arch/x86/cpu/quark/car.S create mode 100644 arch/x86/cpu/quark/dram.c create mode 100644 arch/x86/cpu/quark/msg_port.c create mode 100644 arch/x86/cpu/quark/pci.c create mode 100644 arch/x86/cpu/quark/quark.c create mode 100644 arch/x86/dts/galileo.dts create mode 100644 arch/x86/include/asm/arch-quark/device.h create mode 100644 arch/x86/include/asm/arch-quark/gpio.h create mode 100644 arch/x86/include/asm/arch-quark/msg_port.h create mode 100644 arch/x86/include/asm/arch-quark/quark.h create mode 100644 board/intel/galileo/Kconfig create mode 100644 board/intel/galileo/MAINTAINERS create mode 100644 board/intel/galileo/Makefile create mode 100644 board/intel/galileo/galileo.c create mode 100644 board/intel/galileo/start.S create mode 100644 configs/galileo_defconfig create mode 100644 include/configs/galileo.h -- 1.8.2.1

2 18

[U-Boot] [PATCH] image: Convert to use fdt_for_each_subnode macro
by Axel Lin 06 Feb '15

06 Feb '15

Signed-off-by: Axel Lin <axel.lin(a)ingics.com> --- common/image-fit.c | 4 +--- common/image-sig.c | 16 ++++------------ 2 files changed, 5 insertions(+), 15 deletions(-) diff --git a/common/image-fit.c b/common/image-fit.c index b47d110..778d2a1 100644 --- a/common/image-fit.c +++ b/common/image-fit.c @@ -1010,9 +1010,7 @@ int fit_image_verify(const void *fit, int image_noffset) } /* Process all hash subnodes of the component image node */ - for (noffset = fdt_first_subnode(fit, image_noffset); - noffset >= 0; - noffset = fdt_next_subnode(fit, noffset)) { + fdt_for_each_subnode(fit, noffset, image_noffset) { const char *name = fit_get_name(fit, noffset, NULL); /* diff --git a/common/image-sig.c b/common/image-sig.c index 2c9f0cd..eda5e13 100644 --- a/common/image-sig.c +++ b/common/image-sig.c @@ -212,9 +212,7 @@ static int fit_image_verify_sig(const void *fit, int image_noffset, int ret; /* Process all hash subnodes of the component image node */ - for (noffset = fdt_first_subnode(fit, image_noffset); - noffset >= 0; - noffset = fdt_next_subnode(fit, noffset)) { + fdt_for_each_subnode(fit, noffset, image_noffset) { const char *name = fit_get_name(fit, noffset, NULL); if (!strncmp(name, FIT_SIG_NODENAME, @@ -262,9 +260,7 @@ int fit_image_verify_required_sigs(const void *fit, int image_noffset, return 0; } - for (noffset = fdt_first_subnode(sig_blob, sig_node); - noffset >= 0; - noffset = fdt_next_subnode(sig_blob, noffset)) { + fdt_for_each_subnode(sig_blob, noffset, sig_node) { const char *required; int ret; @@ -397,9 +393,7 @@ static int fit_config_verify_sig(const void *fit, int conf_noffset, int ret; /* Process all hash subnodes of the component conf node */ - for (noffset = fdt_first_subnode(fit, conf_noffset); - noffset >= 0; - noffset = fdt_next_subnode(fit, noffset)) { + fdt_for_each_subnode(fit, noffset, conf_noffset) { const char *name = fit_get_name(fit, noffset, NULL); if (!strncmp(name, FIT_SIG_NODENAME, @@ -444,9 +438,7 @@ int fit_config_verify_required_sigs(const void *fit, int conf_noffset, return 0; } - for (noffset = fdt_first_subnode(sig_blob, sig_node); - noffset >= 0; - noffset = fdt_next_subnode(sig_blob, noffset)) { + fdt_for_each_subnode(sig_blob, noffset, sig_node) { const char *required; int ret; -- 1.9.1

2 1

[U-Boot] U-Boot uptime
by Andrew Wozniak 06 Feb '15

06 Feb '15

Hi everyone, It has a quite a while since my last post here. Our new project is running U-Boot on a custom Beaglebone board. While running several overnight user-space applications, the board reset and stopped at the U-Boot prompt. We do not yet have any logging but I could monitor and record the console output to see when this reset happened. A simpler approach could employ an "uptime" clock at the U-Boot level. Does U-Boot have such a timer? -Andrew

1 0

[U-Boot] [PATCH 0/2] ARM: UniPhier: refactor pinmon command
by Masahiro Yamada 06 Feb '15

06 Feb '15

Masahiro Yamada (2): ARM: UniPhier: refactor pinmon command ARM: UniPhier: leave the last element of boot_device_table empty arch/arm/cpu/armv7/uniphier/cmd_pinmon.c | 15 ++++++--------- arch/arm/cpu/armv7/uniphier/ph1-pro4/boot-mode.c | 6 +++--- arch/arm/include/asm/arch-uniphier/boot-device.h | 2 +- 3 files changed, 10 insertions(+), 13 deletions(-) -- 1.9.1

2 3