July 2011 - U-Boot

[U-Boot] [PATCH] powerpc/corenet_ds: Fix RCW overriding for RDIMM
by York Sun 11 Jul '11

11 Jul '11

Allow overriding RCW for all RDIMM, not only quad-rank ones. Signed-off-by: York Sun <yorksun(a)freescale.com> --- board/freescale/corenet_ds/ddr.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/board/freescale/corenet_ds/ddr.c b/board/freescale/corenet_ds/ddr.c index 98024c7..f2b716d 100644 --- a/board/freescale/corenet_ds/ddr.c +++ b/board/freescale/corenet_ds/ddr.c @@ -219,7 +219,7 @@ void fsl_ddr_board_options(memctl_options_t *popts, popts->ddr_cdr1 = DDR_CDR1_DHC_EN; /* override SPD values. rcw_2 should vary at differnt speed */ - if (pdimm[0].n_ranks == 4) { + if (pdimm[0].registered_dimm == 1) { popts->rcw_override = 1; popts->rcw_1 = 0x000a5a00; if (ddr_freq <= 800) -- 1.7.0.4

2 1

[U-Boot] [PATCH] powerpc/mpc85xx: Display a warning for unsupported DDR data rates
by York Sun 11 Jul '11

11 Jul '11

If DDR initialziation uses a speed table and the speed is not matched, print a warning message instead of silently ignoring. Signed-off-by: York Sun <yorksun(a)freescale.com> --- board/freescale/corenet_ds/ddr.c | 6 ++++++ board/freescale/mpc8572ds/ddr.c | 8 ++++---- board/freescale/mpc8641hpcn/ddr.c | 5 +++++ board/freescale/p2020ds/ddr.c | 6 ++++++ board/xes/xpedite550x/ddr.c | 6 ++++++ 5 files changed, 27 insertions(+), 4 deletions(-) diff --git a/board/freescale/corenet_ds/ddr.c b/board/freescale/corenet_ds/ddr.c index f2b716d..a184592 100644 --- a/board/freescale/corenet_ds/ddr.c +++ b/board/freescale/corenet_ds/ddr.c @@ -192,10 +192,16 @@ void fsl_ddr_board_options(memctl_options_t *popts, popts->clk_adjust = pbsp->clk_adjust; popts->wrlvl_start = pbsp->wrlvl_start; popts->twoT_en = pbsp->force_2T; + break; } pbsp++; } + if (i == num_params) { + printf("Warning: board specific timing not found " + "for data rate %lu MT/s!\n", ddr_freq); + } + /* * Factors to consider for half-strength driver enable: * - number of DIMMs installed diff --git a/board/freescale/mpc8572ds/ddr.c b/board/freescale/mpc8572ds/ddr.c index ab471af..adcbd58 100644 --- a/board/freescale/mpc8572ds/ddr.c +++ b/board/freescale/mpc8572ds/ddr.c @@ -104,7 +104,6 @@ void fsl_ddr_board_options(memctl_options_t *popts, u32 num_params; u32 i; ulong ddr_freq; - int matched = 0; if (!pdimm->n_ranks) return; @@ -151,14 +150,15 @@ void fsl_ddr_board_options(memctl_options_t *popts, popts->cpo_override = pbsp->cpo; popts->write_data_delay = pbsp->write_data_delay; popts->twoT_en = pbsp->force_2T; - matched = 1; break; } pbsp++; } - if (!matched) - printf("Warning: board specific timing not found!\n"); + if (i == num_params) { + printf("Warning: board specific timing not found " + "for data rate %lu MT/s!\n", ddr_freq); + } /* * Factors to consider for half-strength driver enable: diff --git a/board/freescale/mpc8641hpcn/ddr.c b/board/freescale/mpc8641hpcn/ddr.c index bd0b299..4f2e853 100644 --- a/board/freescale/mpc8641hpcn/ddr.c +++ b/board/freescale/mpc8641hpcn/ddr.c @@ -127,6 +127,11 @@ void fsl_ddr_board_options(memctl_options_t *popts, } } + if (i == num_params) { + printf("Warning: board specific timing not found " + "for data rate %lu MT/s!\n", ddr_freq); + } + /* 2T timing enable */ popts->twoT_en = 1; } diff --git a/board/freescale/p2020ds/ddr.c b/board/freescale/p2020ds/ddr.c index 9bf7d2f..926fd19 100644 --- a/board/freescale/p2020ds/ddr.c +++ b/board/freescale/p2020ds/ddr.c @@ -83,10 +83,16 @@ void fsl_ddr_board_options(memctl_options_t *popts, popts->cpo_override = pbsp->cpo; popts->write_data_delay = pbsp->write_data_delay; popts->twoT_en = pbsp->force_2T; + break; } pbsp++; } + if (i == num_params) { + printf("Warning: board specific timing not found " + "for data rate %lu MT/s!\n", ddr_freq); + } + /* * Factors to consider for half-strength driver enable: * - number of DIMMs installed diff --git a/board/xes/xpedite550x/ddr.c b/board/xes/xpedite550x/ddr.c index 3b6e08b..8031a34 100644 --- a/board/xes/xpedite550x/ddr.c +++ b/board/xes/xpedite550x/ddr.c @@ -125,10 +125,16 @@ void fsl_ddr_board_options(memctl_options_t *popts, popts->clk_adjust = pbsp->clk_adjust; popts->cpo_override = pbsp->cpo; popts->twoT_en = 0; + break; } pbsp++; } + if (i == num_params) { + printf("Warning: board specific timing not found " + "for data rate %lu MT/s!\n", ddr_freq); + } + /* * Factors to consider for half-strength driver enable: * - number of DIMMs installed -- 1.7.0.4

2 1

[U-Boot] [PATCH] powerpc/mpc8xxx: fix DDR data width checking
by York Sun 11 Jul '11

11 Jul '11

Checking width before setting DDR controller. SPD for DDR1 and DDR2 has data width and primary sdram width. The latter one has different meaning for DDR3. Signed-off-by: York Sun <yorksun(a)freescale.com> --- arch/powerpc/cpu/mpc8xxx/ddr/options.c | 35 ++++++++++++++++++++++++------- 1 files changed, 27 insertions(+), 8 deletions(-) diff --git a/arch/powerpc/cpu/mpc8xxx/ddr/options.c b/arch/powerpc/cpu/mpc8xxx/ddr/options.c index 02efe58..bd9c466 100644 --- a/arch/powerpc/cpu/mpc8xxx/ddr/options.c +++ b/arch/powerpc/cpu/mpc8xxx/ddr/options.c @@ -423,14 +423,33 @@ unsigned int populate_memctl_options(int all_DIMMs_registered, * presuming all dimms are similar * 0 = 64-bit, 1 = 32-bit, 2 = 16-bit */ - if (pdimm[0].primary_sdram_width == 64) - popts->data_bus_width = 0; - else if (pdimm[0].primary_sdram_width == 32) - popts->data_bus_width = 1; - else if (pdimm[0].primary_sdram_width == 16) - popts->data_bus_width = 2; - else - panic("Error: invalid primary sdram width!\n"); +#if defined(CONFIG_FSL_DDR1) || defined(CONFIG_FSL_DDR2) + if (pdimm[0].n_ranks != 0) { + if ((pdimm[0].data_width >= 64) && \ + (pdimm[0].data_width <= 72)) + popts->data_bus_width = 0; + else if ((pdimm[0].data_width >= 32) || \ + (pdimm[0].data_width <= 40)) + popts->data_bus_width = 1; + else { + panic("Error: data width %u is invalid!\n", + pdimm[0].data_width); + } + } +#else + if (pdimm[0].n_ranks != 0) { + if (pdimm[0].primary_sdram_width == 64) + popts->data_bus_width = 0; + else if (pdimm[0].primary_sdram_width == 32) + popts->data_bus_width = 1; + else if (pdimm[0].primary_sdram_width == 16) + popts->data_bus_width = 2; + else { + panic("Error: primary sdram width %u is invalid!\n", + pdimm[0].primary_sdram_width); + } + } +#endif /* Choose burst length. */ #if defined(CONFIG_FSL_DDR3) -- 1.7.0.4

2 1

[U-Boot] Refrence Numbers: 86147516
by MONEY GRAM MALAYSIA 11 Jul '11

11 Jul '11

My associate has helped me to send your first payment of $5000 USD to you as instructed by the Malaysian Government and Mr. David Cameron the United Kingdom prime minister after the last G20 meeting that was held in Malaysia, making you one of the beneficiaries.Here is the information below. Refrence Numbers: 86147516 Sender Name Is = Patrick Lee Chun I told him to keep sending you $5000 USD twice a week until the FULL payment of ($820000.00 United State Dollars) is completed. A certificate will be made to change the Receivers Name to your name as stated by the Malaysian Government,reconfirm your {1}Full Names {2}address {3}Mobile Number via Email to:money_gram_transfer@ozledim.net Allan Davis to proceed. Note: You cannot pickup the money until the certificate is obtained by you. Regards Mr. Allan Davis. Tel: +(60)163544376. For more info: www.g20.org

1 0

[U-Boot] How to build symbols into EFF file?
by ed.collins＠computer.org 11 Jul '11

11 Jul '11

Hello All, I am using Uboot with a Lauterbach emulator. I am trying to figure out how to get the symbols into the ELF output file so I can use symbolic debugginhg. Can someone tell me how to get the symbols into the output file? thanks, Ed

2 1

[U-Boot] [PATCH] powerpc/corenet_ds: add back buffer write for NOR flash
by York Sun 11 Jul '11

11 Jul '11

Enable buffer write for better performance. This platform uses a NOR flash chip which supports write buffer programming. CFI driver can query the buffer size and use it to program the flash for best performance. Signed-off-by: York Sun <yorksun(a)freescale.com> --- include/configs/corenet_ds.h | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/configs/corenet_ds.h b/include/configs/corenet_ds.h index f649147..28f8785 100644 --- a/include/configs/corenet_ds.h +++ b/include/configs/corenet_ds.h @@ -73,6 +73,7 @@ #else #define CONFIG_FLASH_CFI_DRIVER #define CONFIG_SYS_FLASH_CFI +#define CONFIG_SYS_FLASH_USE_BUFFER_WRITE #endif #if defined(CONFIG_SPIFLASH) -- 1.7.0.4

2 1

[U-Boot] New to u-boot
by Rakesh Modi 11 Jul '11

11 Jul '11

Hello Guys, I am new to u-boot. I want to understand the flow of u-boot. I have tried to go through start.s file, but I stop after arm_boot function call. I did not understand that how board gets configured? in older version of u-boot i can see <board name>_config option in makefile, but in newer version it is not available in Makefile. So where it is? I also want to know that during compilation how specific board files links with each other? -- Thanks & Regards Rock

3 2

[U-Boot] [PATCH] powerpc/mpc8xxx: Allow override DDR read-to-write turnaround time
by York Sun 11 Jul '11

11 Jul '11

Add this option to allow boards to override the default read-to-write turnaround time for better performance. Signed-off-by: York Sun <yorksun(a)freescale.com> --- arch/powerpc/cpu/mpc8xxx/ddr/ctrl_regs.c | 3 +++ arch/powerpc/include/asm/fsl_ddr_sdram.h | 3 +++ 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/arch/powerpc/cpu/mpc8xxx/ddr/ctrl_regs.c b/arch/powerpc/cpu/mpc8xxx/ddr/ctrl_regs.c index 02d069c..3824aad 100644 --- a/arch/powerpc/cpu/mpc8xxx/ddr/ctrl_regs.c +++ b/arch/powerpc/cpu/mpc8xxx/ddr/ctrl_regs.c @@ -267,6 +267,9 @@ static void set_timing_cfg_0(fsl_ddr_cfg_regs_t *ddr, tmrd_mclk = 2; #endif + if (popts->trwt_override) + trwt_mclk = popts->trwt; + ddr->timing_cfg_0 = (0 | ((trwt_mclk & 0x3) << 30) /* RWT */ | ((twrt_mclk & 0x3) << 28) /* WRT */ diff --git a/arch/powerpc/include/asm/fsl_ddr_sdram.h b/arch/powerpc/include/asm/fsl_ddr_sdram.h index 1778cc5..bc063ea 100644 --- a/arch/powerpc/include/asm/fsl_ddr_sdram.h +++ b/arch/powerpc/include/asm/fsl_ddr_sdram.h @@ -271,6 +271,9 @@ typedef struct memctl_options_s { unsigned int rcw_2; /* control register 1 */ unsigned int ddr_cdr1; + + unsigned int trwt_override; + unsigned int trwt; /* read-to-write turnaround */ } memctl_options_t; extern phys_size_t fsl_ddr_sdram(void); -- 1.7.0.4

2 1

[U-Boot] cpu/arm926ejs/start.S question
by Andre Renaud 11 Jul '11

11 Jul '11

Hello, I am working on an i.MX25 board, and would like to know the recommended mechanism for putting code in before the first instruction in the executable, but outside the *_spl system. Basically, the i.MX25 has a smart boot rom in the CPU, which will extract the first block, and interpret it (as data, rather than instructions). However, if I just use the linker script to put this block before start.S, then U-Boot relocation gets messed up, as _start is now not the beginning of the image, and a lot of the calculated offsets are wrong. At the moment I have this working with the following change in start.S: --- cpu/arm926ejs/start.S (revision 36) +++ cpu/arm926ejs/start.S (working copy) @@ -53,6 +53,9 @@ .globl _start _start: +#ifdef CONFIG_PRE_START_INCLUDE +#include CONFIG_PRE_START_INCLUDE +#endif b reset #ifdef CONFIG_PRELOADER /* No exception handlers in preloader */ and I then #define CONFIG_PRE_START_INCLUDE to be the assembler for the i.MX25 specific boot code. Is there a nicer way to go about this? Regards, Andre

4 9

Re: [U-Boot] [PATCH 0/2] usb:gadget: Linux USB Gadget framework
by 馬克泡 11 Jul '11

11 Jul '11

Hi Lukasz, 2011/7/11 Lukasz Majewski <l.majewski(a)samsung.com> > On Tue, 05 Jul 2011 22:16:22 +0800 > 馬克泡 <macpaul(a)gmail.com> wrote: > Please keep all the discussions are CC-ed to related persons (included the u-boot's mailing list address), unless you have private stuff to talk. Hence every people can learn the experience from others. [deleted some messages] > > struct s3c_otg { > u32 s3c_udc_otg_gotgctl; > u32 s3c_udc_otg_gotgint; > u32 s3c_udc_otg_gahbcfg; > }; > > We have some coding style in consensus especially for u-boot (mostly are from Linux). Yes, please rewrite all of them into structure format. If all of your codes are written in C, please use C structure only. Both u-boot and Linux are project wrote in C. If your define will be used both in assembly and in C, please use asm-offset techniques to manage them. > I didn't used the asm-offsets.h approach. Those files has been edited > manually. > > As fair as I've looked into the code - it looks that both above > approaches are widely used in u-boot - e.g. > include/asm/arch-pxa/pxa-regs.h vs. include/asm/arch-s5pc2xx/gpio.h > > Both u-boot and Linux kernel are old open source projects. Hence there are some (and lots of them) the old codes in the project which are hard to be maintained. If we have time (both u-boot and LInux kernel maintainers) will do fix the old coding style which leads problems. For the structures, you have to be ware of writing them in nested formats, like, struct aaa { int bbb; struct ccc { }; }; Please do un-nest the structures! For example, struct aaa { int bbb; struct ccc ccc1; }; struct ccc { }; These are more easier to read and to debug. Using checkpatch.pl will help you to fix about 85% to 95% coding style problems. Also saving everyone's time to review all the patches. If you are kind and have times, please do help clean up the old coding style. Please add the prefix "cosmetic:" to each of the clean up patches. > > However, it's better to rewrite it into structure form whihc is easier > > to read and maintain > > both in u-boot and in Linux. > > Please correct me if I'm wrong, but I've assumed that you are thinking > about the second presented approach (struct s3c_otg). > > Can you give me a more detailed explanation about yours preferred > approach? Let me quote a part of the discussion between Wolfgang and I before. Me: "> Please take a look at the similar driver "ftmac100.c", > Some coding patterns in "ftgmac100.c" are followed as "ftmac100.c". Wolfgang: "Oh. Thanks for pointing out. So this other driver needs to be fixed, too." Those wrong coding style have been fixed after this discussion by other people. :-) > -- > Best regards, > > Lukasz Majewski > > Samsung Poland R&D Center > Platform Group > Thanks! -- Best regards, Macpaul Lin

1 0