February 2009 - U-Boot

[U-Boot] using more that 2gig of Memory.
by hamoshame Lamoteku 04 Feb '09

04 Feb '09

I have search through the archives, and didn't find anything. Has anyone setup u-boot to configure more than 2gig of main memory? Where does u-boot go in the 36 bit world. is it possible to configure 2gig on each DDR controller of the MPC8572 and have u-boot run right out of the box? I know u-boot load itself way out at the end of memory, but in this case, that would be 0x1-fff8-xxxx

2 1

[U-Boot] [PATCH 0/7] Blackfin updates for 2009.03 (part 3)
by Mike Frysinger 04 Feb '09

04 Feb '09

These are mostly updates to the startup code to fix misc bugs and get it working with recent parts and some newer bootrom features. Mike Frysinger (7): Blackfin: update anomaly lists Blackfin: use on-chip syscontrol() rom function when available Blackfin: set default voltage levels for BF538/BF539 parts Blackfin: check for reserved settings in DDR MMRs Blackfin: add support for fast SPI reads with Boot ROM Blackfin: dynamically update UART speed when initializing Blackfin: move default boot SPI CS to common code board/bf537-stamp/spi_flash.c | 8 +- cpu/blackfin/initcode.c | 155 +++++++++++++++----------- cpu/blackfin/serial.h | 72 +++--------- include/asm-blackfin/blackfin-config-pre.h | 9 ++ include/asm-blackfin/mach-bf527/anomaly.h | 166 ++++++++++++++++++++-------- include/asm-blackfin/mach-bf533/anomaly.h | 55 ++++++---- include/asm-blackfin/mach-bf537/anomaly.h | 14 ++- include/asm-blackfin/mach-bf548/anomaly.h | 45 +++++--- include/asm-blackfin/mach-bf561/anomaly.h | 17 +++- 9 files changed, 330 insertions(+), 211 deletions(-)

1 7

[U-Boot] [GIT PULL] Please pull mpc5xxx tree
by John Rigby 03 Feb '09

03 Feb '09

Wolfgang, The following changes since commit 92c20fbd3a7788c1a154f50a3f44f28a7763f99a: John Rigby (1): ADS5121 DIU Make inclusion of FSL logo optional are available in the git repository at: http://git.denx.de/u-boot-mpc5xxx.git master John Rigby (3): ADS5121 DIU Add diu_bmp_addr env ADS5121 Fix rev2 silicon pci iopad config ADS5121 Add IC Ident Module (IIM) support Ralph Kondziella (1): ADS5121 Add PATA support board/ads5121/ads5121.c | 120 +++++++++++++- board/ads5121/ads5121_diu.c | 28 +++- common/cmd_ide.c | 4 + cpu/mpc512x/Makefile | 3 + cpu/mpc512x/iim.c | 394 ++++++++++++++++++++++++++++++++++++++++++ include/asm-ppc/immap_512x.h | 49 +++++- include/configs/ads5121.h | 58 ++++++ include/mpc512x.h | 25 +++ 8 files changed, 676 insertions(+), 5 deletions(-) create mode 100644 cpu/mpc512x/iim.c

2 2

[U-Boot] [PATCH 1/1] pxa: move mmc drivers to drivers/mmc
by Jean-Christophe PLAGNIOL-VILLARD 03 Feb '09

03 Feb '09

introduce new macro CONFIG_PXA_MMC to activate it Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj(a)jcrosoft.com> --- cpu/pxa/Makefile | 2 +- drivers/mmc/Makefile | 1 + cpu/pxa/mmc.c => drivers/mmc/pxa_mmc.c | 4 ---- include/configs/delta.h | 7 +++++-- include/configs/lubbock.h | 7 +++++-- include/configs/pleb2.h | 5 +++++ include/configs/pxa255_idp.h | 5 ++++- include/configs/trizepsiv.h | 5 ++++- include/configs/xsengine.h | 8 ++++++-- include/configs/zylonite.h | 8 ++++++-- 10 files changed, 37 insertions(+), 15 deletions(-) rename cpu/pxa/mmc.c => drivers/mmc/pxa_mmc.c (99%) diff --git a/cpu/pxa/Makefile b/cpu/pxa/Makefile index 8b4367e..42903b2 100644 --- a/cpu/pxa/Makefile +++ b/cpu/pxa/Makefile @@ -26,7 +26,7 @@ include $(TOPDIR)/config.mk LIB = $(obj)lib$(CPU).a START = start.o -COBJS = serial.o interrupts.o cpu.o i2c.o pxafb.o mmc.o usb.o +COBJS = serial.o interrupts.o cpu.o i2c.o pxafb.o usb.o SRCS := $(START:.o=.S) $(SOBJS:.o=.S) $(COBJS:.o=.c) OBJS := $(addprefix $(obj),$(SOBJS) $(COBJS)) diff --git a/drivers/mmc/Makefile b/drivers/mmc/Makefile index bb0d52e..b5f1b20 100644 --- a/drivers/mmc/Makefile +++ b/drivers/mmc/Makefile @@ -27,6 +27,7 @@ LIB := $(obj)libmmc.a COBJS-$(CONFIG_ATMEL_MCI) += atmel_mci.o COBJS-$(CONFIG_OMAP3_MMC) += omap3_mmc.o +COBJS-$(CONFIG_PXA_MMC) += pxa_mmc.o COBJS := $(COBJS-y) SRCS := $(COBJS:.o=.c) diff --git a/cpu/pxa/mmc.c b/drivers/mmc/pxa_mmc.c similarity index 99% rename from cpu/pxa/mmc.c rename to drivers/mmc/pxa_mmc.c index d735c8d..c7fa1ca 100644 --- a/cpu/pxa/mmc.c +++ b/drivers/mmc/pxa_mmc.c @@ -28,8 +28,6 @@ #include <asm/arch/hardware.h> #include <part.h> -#ifdef CONFIG_MMC - extern int fat_register_device(block_dev_desc_t * dev_desc, int part_no); static block_dev_desc_t mmc_dev; @@ -658,5 +656,3 @@ int mmc2info(ulong addr) } return 0; } - -#endif /* CONFIG_MMC */ diff --git a/include/configs/delta.h b/include/configs/delta.h index abb2676..1ee9712 100644 --- a/include/configs/delta.h +++ b/include/configs/delta.h @@ -34,7 +34,6 @@ #ifdef CONFIG_LCD #define CONFIG_SHARP_LM8V31 #endif -/* #define CONFIG_MMC 1 */ #define BOARD_LATE_INIT 1 #undef CONFIG_SKIP_RELOCATE_UBOOT @@ -181,7 +180,11 @@ /* valid baudrates */ #define CONFIG_SYS_BAUDRATE_TABLE { 9600, 19200, 38400, 57600, 115200 } -/* #define CONFIG_SYS_MMC_BASE 0xF0000000 */ +#ifdef CONFIG_MMC +#define CONFIG_PXA_MMC +#define CONFIG_CMD_MMC +#define CONFIG_SYS_MMC_BASE 0xF0000000 +#endif /* * Stack sizes diff --git a/include/configs/lubbock.h b/include/configs/lubbock.h index 208910e..ef16b02 100644 --- a/include/configs/lubbock.h +++ b/include/configs/lubbock.h @@ -40,7 +40,7 @@ #ifdef CONFIG_LCD #define CONFIG_SHARP_LM8V31 #endif -#define CONFIG_MMC 1 +#define CONFIG_MMC #define BOARD_LATE_INIT 1 #define CONFIG_DOS_PARTITION @@ -83,7 +83,6 @@ */ #include <config_cmd_default.h> -#define CONFIG_CMD_MMC #define CONFIG_CMD_FAT @@ -133,7 +132,11 @@ /* valid baudrates */ #define CONFIG_SYS_BAUDRATE_TABLE { 9600, 19200, 38400, 57600, 115200 } +#ifdef CONFIG_MMC +#define CONFIG_PXA_MMC +#define CONFIG_CMD_MMC #define CONFIG_SYS_MMC_BASE 0xF0000000 +#endif /* * Stack sizes diff --git a/include/configs/pleb2.h b/include/configs/pleb2.h index 14f8917..59dffb7 100644 --- a/include/configs/pleb2.h +++ b/include/configs/pleb2.h @@ -132,6 +132,11 @@ /* valid baudrates */ #define CONFIG_SYS_BAUDRATE_TABLE { 9600, 19200, 38400, 57600, 115200 } +#ifdef CONFIG_MMC +#define CONFIG_PXA_MMC +#define CONFIG_CMD_MMC +#endif + /* * Stack sizes * diff --git a/include/configs/pxa255_idp.h b/include/configs/pxa255_idp.h index f81103b..2deee02 100644 --- a/include/configs/pxa255_idp.h +++ b/include/configs/pxa255_idp.h @@ -119,7 +119,6 @@ */ #include <config_cmd_default.h> -#define CONFIG_CMD_MMC #define CONFIG_CMD_FAT #define CONFIG_CMD_DHCP @@ -249,7 +248,11 @@ /* valid baudrates */ #define CONFIG_SYS_BAUDRATE_TABLE { 9600, 19200, 38400, 57600, 115200 } +#ifdef CONFIG_MMC +#define CONFIG_PXA_MMC +#define CONFIG_CMD_MMC #define CONFIG_SYS_MMC_BASE 0xF0000000 +#endif /* * Stack sizes diff --git a/include/configs/trizepsiv.h b/include/configs/trizepsiv.h index 0a8e994..784a09f 100644 --- a/include/configs/trizepsiv.h +++ b/include/configs/trizepsiv.h @@ -79,7 +79,6 @@ */ #include <config_cmd_default.h> -#define CONFIG_CMD_MMC #define CONFIG_CMD_FAT #define CONFIG_CMD_IMLS #define CONFIG_CMD_PING @@ -174,7 +173,11 @@ /* valid baudrates */ #define CONFIG_SYS_BAUDRATE_TABLE { 9600, 19200, 38400, 57600, 115200 } +#ifdef CONFIG_MMC +#define CONFIG_PXA_MMC +#define CONFIG_CMD_MMC #define CONFIG_SYS_MMC_BASE 0xF0000000 +#endif /* * Stack sizes diff --git a/include/configs/xsengine.h b/include/configs/xsengine.h index b727413..341c741 100644 --- a/include/configs/xsengine.h +++ b/include/configs/xsengine.h @@ -118,7 +118,6 @@ */ #include <config_cmd_default.h> -#define CONFIG_CMD_MMC #define CONFIG_CMD_FAT #define CONFIG_CMD_PING #define CONFIG_CMD_JFFS2 @@ -145,9 +144,14 @@ #define CONFIG_SYS_MEMTEST_END 0xA0800000 /* 4 ... 8 MB in DRAM */ #undef CONFIG_SYS_CLKS_IN_HZ /* everything, incl board info, in Hz */ #define CONFIG_SYS_BAUDRATE_TABLE { 9600, 19200, 38400, 57600, 115200 } /* valid baudrates */ -#define CONFIG_SYS_MMC_BASE 0xF0000000 #define CONFIG_SYS_LOAD_ADDR 0xA0000000 /* load kernel to this address */ +#ifdef CONFIG_MMC +#define CONFIG_PXA_MMC +#define CONFIG_CMD_MMC +#define CONFIG_SYS_MMC_BASE 0xF0000000 +#endif + /* Stack sizes - The stack sizes are set up in start.S using the settings below */ #define CONFIG_STACKSIZE (128*1024) /* regular stack */ #ifdef CONFIG_USE_IRQ diff --git a/include/configs/zylonite.h b/include/configs/zylonite.h index f30eca1..4e55aec 100644 --- a/include/configs/zylonite.h +++ b/include/configs/zylonite.h @@ -41,7 +41,7 @@ #ifdef CONFIG_LCD #define CONFIG_SHARP_LM8V31 #endif -/* #define CONFIG_MMC 1 */ +#undef CONFIG_MMC #define BOARD_LATE_INIT 1 #undef CONFIG_SKIP_RELOCATE_UBOOT @@ -152,7 +152,11 @@ /* valid baudrates */ #define CONFIG_SYS_BAUDRATE_TABLE { 9600, 19200, 38400, 57600, 115200 } -/* #define CONFIG_SYS_MMC_BASE 0xF0000000 */ +#ifdef CONFIG_MMC +#define CONFIG_PXA_MMC +#define CONFIG_CMD_MMC +#define CONFIG_SYS_MMC_BASE 0xF0000000 +#endif /* * Stack sizes -- 1.5.6.5

1 1

[U-Boot] Pull request: u-boot-usb
by Remy Bohmer 03 Feb '09

03 Feb '09

The following changes since commit 6c6e042ab3bbfb5428e4cdeb38fa27728c63afdd: Wolfgang Denk (1): Merge branch 'master' of git://git.denx.de/u-boot-arm are available in the git repository at: git://git.denx.de/u-boot-usb.git master Remy Bohmer (1): Compile warning fix in onenand_uboot.h Stefan Roese (1): USB: Add EHCI support for VCT EHCI controller (really with driver now) drivers/usb/usb_ehci_vct.c | 58 ++++++++++++++++++++++++++++++++++++++++++++ include/onenand_uboot.h | 2 + 2 files changed, 60 insertions(+), 0 deletions(-) create mode 100644 drivers/usb/usb_ehci_vct.c

2 1

[U-Boot] Pull request u-boot-blackfin.git
by Mike Frysinger 03 Feb '09

03 Feb '09

(note that the on-going enetaddr patch has been dropped) The following changes since commit 6c6e042ab3bbfb5428e4cdeb38fa27728c63afdd: Wolfgang Denk (1): Merge branch 'master' of git://git.denx.de/u-boot-arm are available in the git repository at: git://www.denx.de/git/u-boot-blackfin.git master Cliff Cai (1): Blackfin: add driver for on-chip MMC/SD controller Mike Frysinger (24): Blackfin: bfin_mac: set MDCDIV based on SCLK Blackfin: bfin_mac: cleanup MII/PHY functions Blackfin: bfin_mac: respect CONFIG_PHY_{ADDR,CLOCK_FREQ} Blackfin: bfin_mac: use common debug() Blackfin: bfin_mac: convert CONFIG_BFIN_MAC_RMII to CONFIG_RMII Blackfin: bfin_mac: cleanup pointer/casts for aliasing issues Blackfin: only build post code when CONFIG_POST Blackfin: add driver for on-chip SPI controller Blackfin: dont check baud if it wont actually get used Blackfin: enable --gc-sections Blackfin: cache core/system clock values Blackfin: setup bi_enetaddr for single nets Blackfin: rewrite cache handling functions Blackfin: dma_memcpy(): fix random failures Blackfin: only flag L1 instruction for DMA memcpy Blackfin: use 8/16/32 bit transfer widths in dma_memcpy() Blackfin: fix up EBIU defines Blackfin: build with -mno-fdpic Blackfin: add driver for on-chip NAND controller Blackfin: add port I bits Blackfin: update asm-blackfin/posix_types.h to latest Linux version Blackfin: set default CONFIG_ENV_SPI_CS based on bootrom Blackfin: output booting source when booting Blackfin: add port muxing for BF51x SPI Sonic Zhang (1): Blackfin: add driver for on-chip ATAPI controller blackfin_config.mk | 5 +- board/bf537-stamp/spi_flash.c | 20 +- cpu/blackfin/Makefile | 1 + cpu/blackfin/cache.S | 118 ++- cpu/blackfin/initcode.c | 6 +- drivers/block/Makefile | 1 + drivers/block/pata_bfin.c | 1201 ++++++++++++++++++++++++++ drivers/block/pata_bfin.h | 173 ++++ drivers/mmc/Makefile | 1 + drivers/mmc/bfin_sdh.c | 546 ++++++++++++ drivers/mmc/bfin_sdh.h | 59 ++ drivers/mtd/nand/Makefile | 1 + drivers/mtd/nand/bfin_nand.c | 385 +++++++++ drivers/net/bfin_mac.c | 380 ++++----- drivers/net/bfin_mac.h | 31 +- drivers/spi/Makefile | 1 + drivers/spi/bfin_spi.c | 343 ++++++++ include/asm-blackfin/blackfin-config-post.h | 5 + include/asm-blackfin/blackfin-config-pre.h | 22 + include/asm-blackfin/blackfin_local.h | 20 +- include/asm-blackfin/mach-bf548/ports.h | 20 +- include/asm-blackfin/mach-common/bits/ebiu.h | 4 +- include/asm-blackfin/mach-common/bits/pata.h | 220 +++++ include/asm-blackfin/mach-common/bits/sdh.h | 122 +++ include/asm-blackfin/mmc.h | 1 + include/asm-blackfin/posix_types.h | 20 +- lib_blackfin/Makefile | 4 +- lib_blackfin/board.c | 61 +- lib_blackfin/cache.c | 18 +- lib_blackfin/clocks.c | 77 ++ lib_blackfin/post.c | 4 - lib_blackfin/string.c | 38 +- lib_blackfin/tests.c | 3 - 33 files changed, 3528 insertions(+), 383 deletions(-) create mode 100644 drivers/block/pata_bfin.c create mode 100644 drivers/block/pata_bfin.h create mode 100644 drivers/mmc/bfin_sdh.c create mode 100644 drivers/mmc/bfin_sdh.h create mode 100644 drivers/mtd/nand/bfin_nand.c create mode 100644 drivers/spi/bfin_spi.c create mode 100644 include/asm-blackfin/mach-common/bits/pata.h create mode 100644 include/asm-blackfin/mach-common/bits/sdh.h create mode 100644 include/asm-blackfin/mmc.h create mode 100644 lib_blackfin/clocks.c

2 1

[U-Boot] [PATCH] Add support for setting environment variable from RAM.
by Eric Nelson (Boundary Devices) 03 Feb '09

03 Feb '09

This is useful for allowing scripts to read environment variables from file, among other things. This is a slightly modified version of what Alessandro submitted to the mailing list last July: http://www.mail-archive.com/u-boot-users@lists.sourceforge.net/msg07932.html I changed the name from 'setenvram' to 'ramenv' to prevent breakage of scripts that use the abbreviation 'set' (which my handss have the habit of doing). Signed-off-by: Eric Nelson <eric.nelson(a)boundarydevices.com> --- common/cmd_nvedit.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 46 insertions(+), 0 deletions(-) diff --git a/common/cmd_nvedit.c b/common/cmd_nvedit.c index 1fcb4c9..bcb6d9f 100644 --- a/common/cmd_nvedit.c +++ b/common/cmd_nvedit.c @@ -494,6 +494,44 @@ int do_askenv ( cmd_tbl_t *cmdtp, int flag, int argc, char *argv[]) #endif /************************************************************************ + * Set a new environment variable from RAM. + * Requires three arguments: the variable name, a memory address and a length. + * + * Deletes the environment variable if the length is zero. + */ +int do_ramenv(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[]) +{ + unsigned long len, i; + char *addr; + + if (argc != 4) { + cmd_usage(cmdtp); + return 1; + } + addr = (char *)simple_strtol(argv[2], NULL, 16); + len = simple_strtol(argv[3], NULL, 16); + if (!addr || !len) { + cmd_usage(cmdtp); + return 1; + } + addr[len] = '\0'; + for (i = 0; i < len; i++) { + /* turn newlines into semicolon */ + if (addr[i] == '\n') + addr[i] = ';'; /* ignore dos-style newlines */ + if (addr[i] == '\r') + addr[i] = ' '; /* accept sh-comments and discard them */ + if (addr[i] == '#') { + while (addr[i] && addr[i] != '\n') + addr[i++] = ' '; + i--; + } + } + setenv(argv[1], addr); + return 0; +} + +/************************************************************************ * Look up variable from environment, * return address of storage for that variable, * or NULL if not found @@ -605,6 +643,14 @@ U_BOOT_CMD( " - delete environment variable 'name'\n" ); +U_BOOT_CMD( + ramenv, 4, 0, do_ramenv, + "ramenv - get environment variable from ram\n", + "name addr maxlen\n" + " - set environment variable 'name' from addr 'addr'\n" + " - delete environment variable if maxlen is 0\n" +); + #if defined(CONFIG_CMD_ASKENV) U_BOOT_CMD( -- 1.5.5.1.382.g182fb

4 5

[U-Boot] [PATCH v3] Added usbtty_configured() check. Fixed attribute(packed) warnings.
by Atin Malaviya 03 Feb '09

03 Feb '09

V3: Fixed line-wrap problem due to user error in mail! Added usb_configured() checks in usbtty_puts() and usbtty_putc() to get around a hang when usb is not connected and the user has set up multi-io (setenv stdout serial,usbtty etc). Got rid of redundant __attribute__((packed)) directives that were causing warnings from gcc. Signed-off-by: Atin Malaviya <atin.malaviya(a)gmail.com> --- This makes the previous v2 patch in http://lists.denx.de/pipermail/u-boot/2009-February/046716.html obsolete. This patch is against the mainline u-boot next branch. drivers/serial/usbtty.c | 18 +++++++++++------- 1 files changed, 11 insertions(+), 7 deletions(-) diff --git a/drivers/serial/usbtty.c b/drivers/serial/usbtty.c index 7eba470..2624e6f 100644 --- a/drivers/serial/usbtty.c +++ b/drivers/serial/usbtty.c @@ -150,8 +150,7 @@ struct acm_config_desc { /* Slave Interface */ struct usb_interface_descriptor data_class_interface; - struct usb_endpoint_descriptor - data_endpoints[NUM_ENDPOINTS-1] __attribute__((packed)); + struct usb_endpoint_descriptor data_endpoints[NUM_ENDPOINTS-1]; } __attribute__((packed)); static struct acm_config_desc acm_configuration_descriptors[NUM_CONFIGS] = { @@ -280,10 +279,8 @@ static struct rs232_emu rs232_desc={ struct gserial_config_desc { struct usb_configuration_descriptor configuration_desc; - struct usb_interface_descriptor - interface_desc[NUM_GSERIAL_INTERFACES] __attribute__((packed)); - struct usb_endpoint_descriptor - data_endpoints[NUM_ENDPOINTS] __attribute__((packed)); + struct usb_interface_descriptor interface_desc[NUM_GSERIAL_INTERFACES]; + struct usb_endpoint_descriptor data_endpoints[NUM_ENDPOINTS]; } __attribute__((packed)); @@ -433,6 +430,9 @@ int usbtty_getc (void) */ void usbtty_putc (const char c) { + if (!usbtty_configured ()) + return; + buf_push (&usbtty_output, &c, 1); /* If \n, also do \r */ if (c == '\n') @@ -486,8 +486,12 @@ static void __usbtty_puts (const char *str, int len) void usbtty_puts (const char *str) { int n; - int len = strlen (str); + int len; + + if (!usbtty_configured ()) + return; + len = strlen (str); /* add '\r' for each '\n' */ while (len > 0) { n = next_nl_pos (str); -- 1.5.6.3

1 0

[U-Boot] [PATCH] integratorap: fix PCI support
by Jean-Christophe PLAGNIOL-VILLARD 03 Feb '09

03 Feb '09

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj(a)jcrosoft.com> --- include/configs/integratorap.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/configs/integratorap.h b/include/configs/integratorap.h index 6ce3b4d..d7f617f 100644 --- a/include/configs/integratorap.h +++ b/include/configs/integratorap.h @@ -143,7 +143,7 @@ * PCI definitions */ -/*#define CONFIG_PCI /--* include pci support */ +#ifdef CONFIG_PCI /* pci support */ #undef CONFIG_PCI_PNP #define CONFIG_PCI_SCAN_SHOW 1 /* show pci devices on startup */ #define DEBUG @@ -151,7 +151,6 @@ #define CONFIG_EEPRO100 #define CONFIG_SYS_RX_ETH_BUFFER 8 /* use 8 rx buffer on eepro100 */ - #define INTEGRATOR_BOOT_ROM_BASE 0x20000000 #define INTEGRATOR_HDR0_SDRAM_BASE 0x80000000 @@ -279,6 +278,7 @@ #define INTEGRATOR_SC_PCIENABLE \ (INTEGRATOR_SC_BASE + INTEGRATOR_SC_PCIENABLE_OFFSET) +#endif /* CONFIG_PCI */ /*----------------------------------------------------------------------- * There are various dependencies on the core module (CM) fitted * Users should refer to their CM user guide -- 1.5.6.5

1 0

[U-Boot] lcd_putc bug?
by Derek Ou 03 Feb '09

03 Feb '09

In the lcd_putc() of common/lcd.c, line 189 handles tab '\t'. And the following lines: console_col |= 8; console_col &= ~7; seems to have problems. If console_col is 9, it will become 8 after the above two lines, which means instead of tab of 8 spaces, it goes back 1. Is this intentional or a bug? I think it should be console_col += 8; instead of console_col |= 8; Derek

2 1