[U-Boot] [PATCH 1/2] GCC47: Fix warning in cmd_nand.c
cmd_nand.c: In function ‘arg_off_size’: cmd_nand.c:216:5: warning: ‘maxsize’ may be used uninitialized in this function [-Wmaybe-uninitialized]
Signed-off-by: Marek Vasut marex@denx.de Cc: Scott Wood scottwood@freescale.com --- common/cmd_nand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/cmd_nand.c b/common/cmd_nand.c index bae630d..0fd3a6c 100644 --- a/common/cmd_nand.c +++ b/common/cmd_nand.c @@ -191,7 +191,7 @@ static int arg_off_size(int argc, char *const argv[], int *idx, loff_t *off, loff_t *size) { int ret; - loff_t maxsize; + loff_t maxsize = 0;
if (argc == 0) { *off = 0;
md5.c: In function ‘MD5Final’: md5.c:156:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] md5.c:157:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
Signed-off-by: Marek Vasut marex@denx.de Cc: Wolfgang Denk wd@denx.de --- include/u-boot/md5.h | 5 ++++- lib/md5.c | 4 ++-- 2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/include/u-boot/md5.h b/include/u-boot/md5.h index 08924cc..e09c16a 100644 --- a/include/u-boot/md5.h +++ b/include/u-boot/md5.h @@ -11,7 +11,10 @@ struct MD5Context { __u32 buf[4]; __u32 bits[2]; - unsigned char in[64]; + union { + unsigned char in[64]; + __u32 in32[16]; + }; };
/* diff --git a/lib/md5.c b/lib/md5.c index 81a09e3..2ae4a06 100644 --- a/lib/md5.c +++ b/lib/md5.c @@ -153,8 +153,8 @@ MD5Final(unsigned char digest[16], struct MD5Context *ctx) byteReverse(ctx->in, 14);
/* Append length in bits and transform */ - ((__u32 *) ctx->in)[14] = ctx->bits[0]; - ((__u32 *) ctx->in)[15] = ctx->bits[1]; + ctx->in32[14] = ctx->bits[0]; + ctx->in32[15] = ctx->bits[1];
MD5Transform(ctx->buf, (__u32 *) ctx->in); byteReverse((unsigned char *) ctx->buf, 4);
Dear Marek Vasut,
cmd_nand.c: In function âarg_off_sizeâ: cmd_nand.c:216:5: warning: âmaxsizeâ may be used uninitialized in this function [-Wmaybe-uninitialized]
AW CRAP ... ignore this, damn encoding problem.
Signed-off-by: Marek Vasut marex@denx.de Cc: Scott Wood scottwood@freescale.com
common/cmd_nand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/cmd_nand.c b/common/cmd_nand.c index bae630d..0fd3a6c 100644 --- a/common/cmd_nand.c +++ b/common/cmd_nand.c @@ -191,7 +191,7 @@ static int arg_off_size(int argc, char *const argv[], int *idx, loff_t *off, loff_t *size) { int ret;
- loff_t maxsize;
loff_t maxsize = 0;
if (argc == 0) { *off = 0;
Best regards, Marek Vasut
participants (1)
-
Marek Vasut