[U-Boot] [PATCH] spl: mmc: fix build without CONFIG_SPL_LIBCOMMON_SUPPORT
When CONFIG_SPL_LIBCOMMON_SUPPORT is disabled, the last case statement is missing a proper statement, which makes the compiler whine.
Signed-off-by: "Yann E. MORIN" yann.morin.1998@free.fr Cc: Pantelis Antoniou panto@antoniou-consulting.com --- common/spl/spl_mmc.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/common/spl/spl_mmc.c b/common/spl/spl_mmc.c index c674e61..cc81d19 100644 --- a/common/spl/spl_mmc.c +++ b/common/spl/spl_mmc.c @@ -343,6 +343,7 @@ static int spl_mmc_load_image(struct spl_image_info *spl_image,
break; case MMCSD_MODE_UNDEFINED: + ; #ifdef CONFIG_SPL_LIBCOMMON_SUPPORT default: puts("spl: mmc: wrong boot mode\n");
On Sun, Nov 13, 2016 at 10:46:19PM +0100, Yann E. MORIN wrote:
When CONFIG_SPL_LIBCOMMON_SUPPORT is disabled, the last case statement is missing a proper statement, which makes the compiler whine.
Signed-off-by: "Yann E. MORIN" yann.morin.1998@free.fr Cc: Pantelis Antoniou panto@antoniou-consulting.com
common/spl/spl_mmc.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/common/spl/spl_mmc.c b/common/spl/spl_mmc.c index c674e61..cc81d19 100644 --- a/common/spl/spl_mmc.c +++ b/common/spl/spl_mmc.c @@ -343,6 +343,7 @@ static int spl_mmc_load_image(struct spl_image_info *spl_image,
break;case MMCSD_MODE_UNDEFINED:
;#ifdef CONFIG_SPL_LIBCOMMON_SUPPORT default: puts("spl: mmc: wrong boot mode\n");
I thought we had applied https://patchwork.ozlabs.org/patch/689910/ already but I see it hasn't. I do prefer that patch however.
Hi,
On 11/14/2016 06:46 AM, Yann E. MORIN wrote:
When CONFIG_SPL_LIBCOMMON_SUPPORT is disabled, the last case statement is missing a proper statement, which makes the compiler whine.
Signed-off-by: "Yann E. MORIN" yann.morin.1998@free.fr Cc: Pantelis Antoniou panto@antoniou-consulting.com
common/spl/spl_mmc.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/common/spl/spl_mmc.c b/common/spl/spl_mmc.c index c674e61..cc81d19 100644 --- a/common/spl/spl_mmc.c +++ b/common/spl/spl_mmc.c @@ -343,6 +343,7 @@ static int spl_mmc_load_image(struct spl_image_info *spl_image,
break;case MMCSD_MODE_UNDEFINED:
;#ifdef CONFIG_SPL_LIBCOMMON_SUPPORT default: puts("spl: mmc: wrong boot mode\n");
case MMCSD_MODE_UNDEFINED: ... #ifdef CONFIG_.... default: put() #endif break;
How about adding "break"?
Best Regards, Jaehoon Chung
Jaehoon, All,
On 2016-11-17 17:09 +0900, Jaehoon Chung spake thusly:
On 11/14/2016 06:46 AM, Yann E. MORIN wrote:
When CONFIG_SPL_LIBCOMMON_SUPPORT is disabled, the last case statement is missing a proper statement, which makes the compiler whine.
Signed-off-by: "Yann E. MORIN" yann.morin.1998@free.fr Cc: Pantelis Antoniou panto@antoniou-consulting.com
common/spl/spl_mmc.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/common/spl/spl_mmc.c b/common/spl/spl_mmc.c index c674e61..cc81d19 100644 --- a/common/spl/spl_mmc.c +++ b/common/spl/spl_mmc.c @@ -343,6 +343,7 @@ static int spl_mmc_load_image(struct spl_image_info *spl_image,
break;case MMCSD_MODE_UNDEFINED:
;#ifdef CONFIG_SPL_LIBCOMMON_SUPPORT default: puts("spl: mmc: wrong boot mode\n");
case MMCSD_MODE_UNDEFINED: ... #ifdef CONFIG_.... default: put() #endif break;
How about adding "break"?
From what I understood, Tom Rini has another patch he preferred:
https://patchwork.ozlabs.org/patch/694196/ in which he pointed to: https://patchwork.ozlabs.org/patch/689910/
Regards, Yann E. MORIN.
participants (3)
-
Jaehoon Chung -
Tom Rini -
Yann E. MORIN