[PATCH v2] sandbox: sdl: Add stub sandbox_sdl_remove_display()
Building the sandbox with NO_SDL=1 resulted in an undefined reference to 'sandbox_sdl_remove_display'. Resolve this by adding a stub implementation to match the stubs of the other similar functions.
Signed-off-by: Andrew Scull ascull@google.com Cc: Simon Glass sjg@chromium.org Cc: Anatolij Gustschin agust@denx.de Reviewed-by: Simon Glass sjg@chromium.org --- arch/sandbox/include/asm/sdl.h | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/arch/sandbox/include/asm/sdl.h b/arch/sandbox/include/asm/sdl.h index e271a849af..56dcb84803 100644 --- a/arch/sandbox/include/asm/sdl.h +++ b/arch/sandbox/include/asm/sdl.h @@ -94,6 +94,11 @@ static inline int sandbox_sdl_init_display(int width, int height, int log2_bpp, return -ENODEV; }
+static inline int sandbox_sdl_remove_display(void) +{ + return -ENODEV; +} + static inline int sandbox_sdl_sync(void *lcd_base) { return -ENODEV;
Friendly ping on this patch as I've seen a few others being accepted recently and wanted to make sure this fix hasn't fallen by the wayside.
On Wed, 23 Mar 2022 at 20:20, Andrew Scull ascull@google.com wrote:
Building the sandbox with NO_SDL=1 resulted in an undefined reference to 'sandbox_sdl_remove_display'. Resolve this by adding a stub implementation to match the stubs of the other similar functions.
Signed-off-by: Andrew Scull ascull@google.com Cc: Simon Glass sjg@chromium.org Cc: Anatolij Gustschin agust@denx.de Reviewed-by: Simon Glass sjg@chromium.org
arch/sandbox/include/asm/sdl.h | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/arch/sandbox/include/asm/sdl.h b/arch/sandbox/include/asm/sdl.h index e271a849af..56dcb84803 100644 --- a/arch/sandbox/include/asm/sdl.h +++ b/arch/sandbox/include/asm/sdl.h @@ -94,6 +94,11 @@ static inline int sandbox_sdl_init_display(int width, int height, int log2_bpp, return -ENODEV; }
+static inline int sandbox_sdl_remove_display(void) +{
return -ENODEV;+}
static inline int sandbox_sdl_sync(void *lcd_base) { return -ENODEV; -- 2.35.1.894.gb6a874cedc-goog
It's been a while, so pinging again.
On Sun, 15 May 2022 at 19:55, Andrew Scull ascull@google.com wrote:
Friendly ping on this patch as I've seen a few others being accepted recently and wanted to make sure this fix hasn't fallen by the wayside.
On Wed, 23 Mar 2022 at 20:20, Andrew Scull ascull@google.com wrote:
Building the sandbox with NO_SDL=1 resulted in an undefined reference to 'sandbox_sdl_remove_display'. Resolve this by adding a stub implementation to match the stubs of the other similar functions.
Signed-off-by: Andrew Scull ascull@google.com Cc: Simon Glass sjg@chromium.org Cc: Anatolij Gustschin agust@denx.de Reviewed-by: Simon Glass sjg@chromium.org
arch/sandbox/include/asm/sdl.h | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/arch/sandbox/include/asm/sdl.h
b/arch/sandbox/include/asm/sdl.h
index e271a849af..56dcb84803 100644 --- a/arch/sandbox/include/asm/sdl.h +++ b/arch/sandbox/include/asm/sdl.h @@ -94,6 +94,11 @@ static inline int sandbox_sdl_init_display(int width,
int height, int log2_bpp,
return -ENODEV;}
+static inline int sandbox_sdl_remove_display(void) +{
return -ENODEV;+}
static inline int sandbox_sdl_sync(void *lcd_base) { return -ENODEV; -- 2.35.1.894.gb6a874cedc-goog
On Wed, 23 Mar 2022 20:20:37 +0000 Andrew Scull ascull@google.com wrote:
Building the sandbox with NO_SDL=1 resulted in an undefined reference to 'sandbox_sdl_remove_display'. Resolve this by adding a stub implementation to match the stubs of the other similar functions.
Signed-off-by: Andrew Scull ascull@google.com Cc: Simon Glass sjg@chromium.org Cc: Anatolij Gustschin agust@denx.de Reviewed-by: Simon Glass sjg@chromium.org
arch/sandbox/include/asm/sdl.h | 5 +++++ 1 file changed, 5 insertions(+)
applied to u-boot-video/master, thanks!
-- Anatolij
participants (2)
-
Anatolij Gustschin -
Andrew Scull