[U-Boot-Users] U-Boot v1.3.2-rc2 released
Hi everybody,
the second (and hopefully last) release candidate for U-Boot v1.3.2 has been released and is available form both the git repository and the FTP server.
A lot of bugs have been fixed since -rc1, but there are still build issues (many, many warnings; some errors) when using recent toolchain versions (like gcc-4.2.2 / binutils 2.17 as used in ELDK 4.2 [see ftp://ftp.denx.de/pub/eldk/4.2-rc1]), for example:
post/drivers/memory.c:
memory.c: In function 'memory_post_dataline': memory.c:236: warning: passing argument 1 of 'move64' discards qualifiers from pointer target type memory.c:241: warning: passing argument 1 of 'move64' discards qualifiers from pointer target type
drivers/usb/usb_ohci.c, cpu/mpc5xxx/usb_ohci.c:
usb_ohci.c: In function 'roothub_a': usb_ohci.c:119: warning: dereferencing type-punned pointer will break strict-aliasing rules usb_ohci.c:119: warning: dereferencing type-punned pointer will break strict-aliasing rules usb_ohci.c: In function 'roothub_b': usb_ohci.c:121: warning: dereferencing type-punned pointer will break strict-aliasing rules usb_ohci.c: In function 'roothub_status': usb_ohci.c:123: warning: dereferencing type-punned pointer will break strict-aliasing rules usb_ohci.c: In function 'ep_link': usb_ohci.c:503: warning: dereferencing type-punned pointer will break strict-aliasing rules usb_ohci.c:511: warning: dereferencing type-punned pointer will break strict-aliasing rules usb_ohci.c:519: warning: dereferencing type-punned pointer will break strict-aliasing rules usb_ohci.c:527: warning: dereferencing type-punned pointer will break strict-aliasing rules usb_ohci.c: In function 'ep_unlink': usb_ohci.c:553: warning: dereferencing type-punned pointer will break strict-aliasing rules usb_ohci.c:555: warning: dereferencing type-punned pointer will break strict-aliasing rules usb_ohci.c:570: warning: dereferencing type-punned pointer will break strict-aliasing rules usb_ohci.c:572: warning: dereferencing type-punned pointer will break strict-aliasing rules usb_ohci.c: In function 'td_submit_job': usb_ohci.c:724: warning: dereferencing type-punned pointer will break strict-aliasing rules usb_ohci.c:740: warning: dereferencing type-punned pointer will break strict-aliasing rules usb_ohci.c: In function 'ohci_submit_rh_msg': usb_ohci.c:1072: warning: dereferencing type-punned pointer will break strict-aliasing rules usb_ohci.c:1191: warning: dereferencing type-punned pointer will break strict-aliasing rules usb_ohci.c: In function 'hc_reset': usb_ohci.c:1379: warning: dereferencing type-punned pointer will break strict-aliasing rules usb_ohci.c:1380: warning: dereferencing type-punned pointer will break strict-aliasing rules usb_ohci.c:1382: warning: dereferencing type-punned pointer will break strict-aliasing rules usb_ohci.c:1392: warning: dereferencing type-punned pointer will break strict-aliasing rules usb_ohci.c:1400: warning: dereferencing type-punned pointer will break strict-aliasing rules usb_ohci.c:1403: warning: dereferencing type-punned pointer will break strict-aliasing rules usb_ohci.c:1404: warning: dereferencing type-punned pointer will break strict-aliasing rules usb_ohci.c: In function 'hc_start': usb_ohci.c:1430: warning: dereferencing type-punned pointer will break strict-aliasing rules usb_ohci.c:1431: warning: dereferencing type-punned pointer will break strict-aliasing rules usb_ohci.c:1433: warning: dereferencing type-punned pointer will break strict-aliasing rules usb_ohci.c:1436: warning: dereferencing type-punned pointer will break strict-aliasing rules usb_ohci.c:1438: warning: dereferencing type-punned pointer will break strict-aliasing rules usb_ohci.c:1439: warning: dereferencing type-punned pointer will break strict-aliasing rules usb_ohci.c:1444: warning: dereferencing type-punned pointer will break strict-aliasing rules usb_ohci.c:1450: warning: dereferencing type-punned pointer will break strict-aliasing rules usb_ohci.c:1453: warning: dereferencing type-punned pointer will break strict-aliasing rules usb_ohci.c:1456: warning: dereferencing type-punned pointer will break strict-aliasing rules usb_ohci.c:1460: warning: dereferencing type-punned pointer will break strict-aliasing rules usb_ohci.c:1462: warning: dereferencing type-punned pointer will break strict-aliasing rules usb_ohci.c: In function 'hc_interrupt': usb_ohci.c:1492: warning: dereferencing type-punned pointer will break strict-aliasing rules usb_ohci.c:1497: warning: dereferencing type-punned pointer will break strict-aliasing rules usb_ohci.c:1527: warning: dereferencing type-punned pointer will break strict-aliasing rules usb_ohci.c:1529: warning: dereferencing type-punned pointer will break strict-aliasing rules usb_ohci.c:1534: warning: dereferencing type-punned pointer will break strict-aliasing rules usb_ohci.c:1542: warning: dereferencing type-punned pointer will break strict-aliasing rules usb_ohci.c:1544: warning: dereferencing type-punned pointer will break strict-aliasing rules usb_ohci.c:1548: warning: dereferencing type-punned pointer will break strict-aliasing rules
Board specific build issues:
PPC: ====
CANBT: canbt.c: In function 'board_early_init_f': canbt.c:76: warning: passing argument 1 of 'fpga_boot' discards qualifiers from pointer target type ---------------- CPCI405: cpci405.c: In function 'board_early_init_f': cpci405.c:122: warning: passing argument 1 of 'fpga_boot' discards qualifiers from pointer target type ---------------- CPCIISER4: cpciiser4.c: In function 'board_early_init_f': cpciiser4.c:75: warning: passing argument 1 of 'fpga_boot' discards qualifiers from pointer target type ---------------- DU405: du405.c: In function 'board_early_init_f': du405.c:74: warning: passing argument 1 of 'fpga_boot' discards qualifiers from pointer target type ---------------- MPC8610HPCD: net.c: In function 'PingHandler': net.c:770: warning: passing argument 1 of 'NetReadIP' discards qualifiers from pointer target type net.c: In function 'NetSetIP': net.c:1694: warning: passing argument 1 of 'NetCopyIP' discards qualifiers from pointer target type net.c:1695: warning: passing argument 1 of 'NetCopyIP' discards qualifiers from pointer target type net.c: In function 'PingSend': net.c:736: warning: passing argument 1 of 'NetCopyIP' discards qualifiers from pointer target type net.c:737: warning: passing argument 1 of 'NetCopyIP' discards qualifiers from pointer target type ---------------- SCM: In file included from scm.c:28: scm.h:53: warning: 'packed' attribute ignored for field of type 'can_msg_t' scm.h:55: warning: 'packed' attribute ignored for field of type 'can_msg_t' scm.h:57: warning: 'packed' attribute ignored for field of type 'can_msg_t' scm.h:59: warning: 'packed' attribute ignored for field of type 'can_msg_t' scm.h:61: warning: 'packed' attribute ignored for field of type 'can_msg_t' scm.h:63: warning: 'packed' attribute ignored for field of type 'can_msg_t' scm.h:65: warning: 'packed' attribute ignored for field of type 'can_msg_t' scm.h:67: warning: 'packed' attribute ignored for field of type 'can_msg_t' scm.h:69: warning: 'packed' attribute ignored for field of type 'can_msg_t' scm.h:71: warning: 'packed' attribute ignored for field of type 'can_msg_t' scm.h:73: warning: 'packed' attribute ignored for field of type 'can_msg_t' scm.h:75: warning: 'packed' attribute ignored for field of type 'can_msg_t' scm.h:77: warning: 'packed' attribute ignored for field of type 'can_msg_t' scm.h:79: warning: 'packed' attribute ignored for field of type 'can_msg_t' scm.h:81: warning: 'packed' attribute ignored for field of type 'can_msg_t' ---------------- W7OLMC: In file included from w7o.c:26: w7o.h:35:1: warning: "CPC0_CR0" redefined In file included from /home/wd/git/u-boot/work/include/ppc4xx.h:28, from /home/wd/git/u-boot/work/include/common.h:98, from w7o.c:24: /home/wd/git/u-boot/work/include/ppc405.h:787:1: warning: this is the location of the previous definition In file included from fpga.c:27: w7o.h:35:1: warning: "CPC0_CR0" redefined In file included from /home/wd/git/u-boot/work/include/ppc4xx.h:28, from /home/wd/git/u-boot/work/include/common.h:98, from fpga.c:26: /home/wd/git/u-boot/work/include/ppc405.h:787:1: warning: this is the location of the previous definition ---------------- W7OLMG: In file included from w7o.c:26: w7o.h:35:1: warning: "CPC0_CR0" redefined In file included from /home/wd/git/u-boot/work/include/ppc4xx.h:28, from /home/wd/git/u-boot/work/include/common.h:98, from w7o.c:24: /home/wd/git/u-boot/work/include/ppc405.h:787:1: warning: this is the location of the previous definition In file included from fpga.c:27: w7o.h:35:1: warning: "CPC0_CR0" redefined In file included from /home/wd/git/u-boot/work/include/ppc4xx.h:28, from /home/wd/git/u-boot/work/include/common.h:98, from fpga.c:26: /home/wd/git/u-boot/work/include/ppc405.h:787:1: warning: this is the location of the previous definition ---------------- acadia_nand: ppc_8xx-ld: section .resetvec [f8004ffc -> f8004fff] overlaps section .data [f8004fc0 -> f8004fff] ppc_8xx-ld: /work/wd/tmp-ppc/nand_spl/u-boot-spl: section .resetvec lma 0xf8004ffc overlaps previous sections make[1]: *** [/work/wd/tmp-ppc/nand_spl/u-boot-spl] Error 1 make: *** [nand_spl] Error 2 ---------------- cogent_mpc8260: kgdb.c: In function 'handle_exception': kgdb.c:313: warning: dereferencing type-punned pointer will break strict-aliasing rules kgdb.c:327: warning: dereferencing type-punned pointer will break strict-aliasing rules kgdb.c:382: warning: dereferencing type-punned pointer will break strict-aliasing rules kgdb.c: In function 'kgdb_error': kgdb.c:535: warning: dereferencing type-punned pointer will break strict-aliasing rules ---------------- hymod: kgdb.c: In function 'handle_exception': kgdb.c:313: warning: dereferencing type-punned pointer will break strict-aliasing rules kgdb.c:327: warning: dereferencing type-punned pointer will break strict-aliasing rules kgdb.c:382: warning: dereferencing type-punned pointer will break strict-aliasing rules kgdb.c: In function 'kgdb_error': kgdb.c:535: warning: dereferencing type-punned pointer will break strict-aliasing rules ---------------- sbc8548: sbc8548.c: In function 'checkboard': sbc8548.c:61: warning: type defaults to 'int' in declaration of 'type name' sbc8548.c: In function 'ft_pci_setup': sbc8548.c:536: warning: unused variable 'path' cfi_flash.c:161: warning: excess elements in array initializer cfi_flash.c:161: warning: (near initialization for 'bank_base') ---------------- sbc8641d: sbc8641d.c: In function 'pci_init_board': sbc8641d.c:233: error: 'MPC86xx_PORDEVSR_IO_SEL' undeclared (first use in this function) sbc8641d.c:233: error: (Each undeclared identifier is reported only once sbc8641d.c:233: error: for each function it appears in.) make[1]: *** [/work/wd/tmp-ppc/board/sbc8641d/sbc8641d.o] Error 1 make: *** [/work/wd/tmp-ppc/board/sbc8641d/libsbc8641d.a] Error 2 ----------------
ARM: ====
----------------- actux1: actux1.c: In function 'checkboard': actux1.c:92: warning: unused variable 'revision' ----------------- actux2: actux2.c: In function 'checkboard': actux2.c:100: warning: unused variable 's' actux2.c:99: warning: unused variable 'revision' actux2.c: In function 'reset_phy': actux2.c:130: warning: unused variable 'i' ----------------- actux3: actux3.c: In function 'checkboard': actux3.c:114: warning: unused variable 'revision' ----------------- actux4: actux4.c: In function 'board_init': actux4.c:83: warning: left shift count >= width of type actux4.c:83: warning: left shift count >= width of type ----------------- adsvix: start.S:183:1: warning: "ICMR" redefined In file included from start.S:33: /work/wd/tmp-arm/include/asm/arch/pxa-regs.h:935:1: warning: this is the location of the previous definition start.S:187:1: warning: "RCSR" redefined /work/wd/tmp-arm/include/asm/arch/pxa-regs.h:1602:1: warning: this is the location of the previous definition start.S:191:1: warning: "OSMR3" redefined /work/wd/tmp-arm/include/asm/arch/pxa-regs.h:869:1: warning: this is the location of the previous definition start.S:192:1: warning: "OSCR" redefined /work/wd/tmp-arm/include/asm/arch/pxa-regs.h:870:1: warning: this is the location of the previous definition start.S:193:1: warning: "OWER" redefined /work/wd/tmp-arm/include/asm/arch/pxa-regs.h:872:1: warning: this is the location of the previous definition start.S:194:1: warning: "OIER" redefined /work/wd/tmp-arm/include/asm/arch/pxa-regs.h:873:1: warning: this is the location of the previous definition start.S:207:1: warning: "CCCR" redefined /work/wd/tmp-arm/include/asm/arch/pxa-regs.h:1770:1: warning: this is the location of the previous definition pcmcia.c:39:2: warning: #warning "Board will only supply 5V, wait for next HW spin for selectable power" pxa_pcmcia.c: In function 'pcmcia_on': pxa_pcmcia.c:39: warning: operation on 'i' may be undefined cmd_ide.c: In function '__ide_outb': cmd_ide.c:806: warning: implicit declaration of function 'outb' cmd_ide.c: In function '__ide_inb': cmd_ide.c:815: warning: implicit declaration of function 'inb' common/libcommon.a(cmd_ide.o): In function `__ide_outb': /home/wd/git/u-boot/work/common/cmd_ide.c:806: undefined reference to `outb' common/libcommon.a(cmd_ide.o): In function `__ide_inb': /home/wd/git/u-boot/work/common/cmd_ide.c:815: undefined reference to `inb' make: *** [/work/wd/tmp-arm/u-boot] Error 1 ----------------- apollon: System not configured - see README apollon: make: *** [all] Error 1 ----------------- m501sk: arm-linux-objdump: '/work/wd/tmp-arm/board/m501sk/libm501sk.a': No such file arm-linux-ld: board/m501sk/libm501sk.a: No such file: No such file or directory make: *** [/work/wd/tmp-arm/u-boot] Error 1 ----------------- mx1ads: mx1ads.c: In function 'board_init': mx1ads.c:106: error: invalid lvalue in assignment mx1ads.c:107: error: invalid lvalue in assignment make[1]: *** [/work/wd/tmp-arm/board/mx1ads/mx1ads.o] Error 1 make: *** [/work/wd/tmp-arm/board/mx1ads/libmx1ads.a] Error 2 ----------------- mx1fs2: mx1fs2.c: In function 'logo_init': mx1fs2.c:75: error: invalid lvalue in assignment make[1]: *** [/work/wd/tmp-arm/board/mx1fs2/mx1fs2.o] Error 1 make: *** [/work/wd/tmp-arm/board/mx1fs2/libmx1fs2.a] Error 2 ----------------- scb9328: flash.c:85: warning: type qualifiers ignored on function return type generic.c: In function 'imx_gpio_mode': generic.c:41: error: invalid lvalue in assignment generic.c:43: error: invalid lvalue in assignment generic.c:47: error: invalid lvalue in assignment generic.c:49: error: invalid lvalue in assignment generic.c:53: error: invalid lvalue in assignment generic.c:55: error: invalid lvalue in assignment generic.c:59: error: invalid lvalue in assignment generic.c:61: error: invalid lvalue in assignment generic.c:71: error: invalid lvalue in assignment generic.c:74: error: invalid lvalue in assignment generic.c:76: error: invalid lvalue in assignment generic.c:81: error: invalid lvalue in assignment generic.c:84: error: invalid lvalue in assignment generic.c:86: error: invalid lvalue in assignment make[1]: *** [/work/wd/tmp-arm/cpu/arm920t/imx/generic.o] Error 1 make: *** [/work/wd/tmp-arm/cpu/arm920t/imx/libimx.a] Error 2 -----------------
Board maintainers - please test and post patches ASAP!
The plan is to have a -rc3 (if needed) not later than March 03, and the v1.3.2 not later than March 10. If possible, I would like to do without -rc3 and release earlier.
Best regards,
Wolfgang Denk
sbc8548: sbc8548.c: In function 'checkboard': sbc8548.c:61: warning: type defaults to 'int' in declaration of 'type name' sbc8548.c: In function 'ft_pci_setup': sbc8548.c:536: warning: unused variable 'path' cfi_flash.c:161: warning: excess elements in array initializer cfi_flash.c:161: warning: (near initialization for 'bank_base')
Wolfgang, I apologize: I've applied patches that fix this problem, but I have not yet pushed them out and requested that you pull them in. I'm currently trying to track down what is causing an exception on the 8548CDS (and, possibly, other 85xx boards), and I wanted to get that into my tree before I did a pull request. I've identified what appears to be a fix, but I want to understand it before I push it out. :) As the fix is to put things back the way they were, I will make sure to do so before you release 1.3.2-final.
Dear Andy,
in message 2acbd3e40802241031w3815189u6fc8b71b47b0a373@mail.gmail.com you wrote:
Wolfgang, I apologize: I've applied patches that fix this problem, but I have not yet pushed them out and requested that you pull them
No need to apologize; this *is* bug fixing time. We all have thigns to fix in our queues. That's normal.
I'm just trying to push everybody a bit :-)
:) As the fix is to put things back the way they were, I will make sure to do so before you release 1.3.2-final.
Great. Thanks!
Best regards,
Wolfgang Denk
On 16:24 Sun 24 Feb , Wolfgang Denk wrote:
Hi everybody,
the second (and hopefully last) release candidate for U-Boot v1.3.2 has been released and is available form both the git repository and the FTP server.
A lot of bugs have been fixed since -rc1, but there are still build issues (many, many warnings; some errors) when using recent toolchain versions (like gcc-4.2.2 / binutils 2.17 as used in ELDK 4.2 [see ftp://ftp.denx.de/pub/eldk/4.2-rc1]), for example:
ARM:
actux1: actux1.c: In function 'checkboard': actux1.c:92: warning: unused variable 'revision'
Fixed
actux2: actux2.c: In function 'checkboard': actux2.c:100: warning: unused variable 's' actux2.c:99: warning: unused variable 'revision' actux2.c: In function 'reset_phy': actux2.c:130: warning: unused variable 'i'
Fixed
actux3: actux3.c: In function 'checkboard': actux3.c:114: warning: unused variable 'revision'
Fixed
apollon: System not configured - see README apollon: make: *** [all] Error 1
Compile fine
m501sk: arm-linux-objdump: '/work/wd/tmp-arm/board/m501sk/libm501sk.a': No such file arm-linux-ld: board/m501sk/libm501sk.a: No such file: No such file or directory make: *** [/work/wd/tmp-arm/u-boot] Error 1
Fixed
mx1ads: mx1ads.c: In function 'board_init': mx1ads.c:106: error: invalid lvalue in assignment mx1ads.c:107: error: invalid lvalue in assignment make[1]: *** [/work/wd/tmp-arm/board/mx1ads/mx1ads.o] Error 1 make: *** [/work/wd/tmp-arm/board/mx1ads/libmx1ads.a] Error 2
Fixed
mx1fs2: mx1fs2.c: In function 'logo_init': mx1fs2.c:75: error: invalid lvalue in assignment make[1]: *** [/work/wd/tmp-arm/board/mx1fs2/mx1fs2.o] Error 1 make: *** [/work/wd/tmp-arm/board/mx1fs2/libmx1fs2.a] Error 2
Fixed
scb9328: flash.c:85: warning: type qualifiers ignored on function return type generic.c: In function 'imx_gpio_mode': generic.c:41: error: invalid lvalue in assignment generic.c:43: error: invalid lvalue in assignment generic.c:47: error: invalid lvalue in assignment generic.c:49: error: invalid lvalue in assignment generic.c:53: error: invalid lvalue in assignment generic.c:55: error: invalid lvalue in assignment generic.c:59: error: invalid lvalue in assignment generic.c:61: error: invalid lvalue in assignment generic.c:71: error: invalid lvalue in assignment generic.c:74: error: invalid lvalue in assignment generic.c:76: error: invalid lvalue in assignment generic.c:81: error: invalid lvalue in assignment generic.c:84: error: invalid lvalue in assignment generic.c:86: error: invalid lvalue in assignment make[1]: *** [/work/wd/tmp-arm/cpu/arm920t/imx/generic.o] Error 1 make: *** [/work/wd/tmp-arm/cpu/arm920t/imx/libimx.a] Error 2
Fixed
Best Regards, J.
On Mon, Feb 25, 2008 at 12:02:24AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
actux1: actux1.c: In function 'checkboard': actux1.c:92: warning: unused variable 'revision'
Fixed
actux2: actux2.c: In function 'checkboard': actux2.c:100: warning: unused variable 's' actux2.c:99: warning: unused variable 'revision' actux2.c: In function 'reset_phy': actux2.c:130: warning: unused variable 'i'
Fixed
actux3: actux3.c: In function 'checkboard': actux3.c:114: warning: unused variable 'revision'
Fixed
Thanks!
The warning in actux4.c is more interesting: it looks like IXP42x GPIO_INT_ACT_LOW_SET can't handle interrupt lines above GPIO8 at all - these are set in IXP425_GPIO_GPIT2R instead of IXP425_GPIO_GPIT1R. For a quick fix, removing the set for the interrupt line should be OK, since the board does not use PCI in u-boot (yet):
Signed-off-by: Michael Schwingen michael@schwingen.org
diff --git a/board/actux4/actux4.c b/board/actux4/actux4.c index 84037fa..260b6f7 100644 --- a/board/actux4/actux4.c +++ b/board/actux4/actux4.c @@ -80,7 +80,6 @@ int board_init (void) GPIO_INT_ACT_LOW_SET (CFG_GPIO_USBINTB); GPIO_INT_ACT_LOW_SET (CFG_GPIO_USBINTC); GPIO_INT_ACT_LOW_SET (CFG_GPIO_RTCINT); - GPIO_INT_ACT_LOW_SET (CFG_GPIO_PCI_INTA); GPIO_INT_ACT_LOW_SET (CFG_GPIO_PCI_INTB);
/* Setup GPIO's for 33MHz clock output */
For the next release, GPIO_INT_ACT_LOW_SET should be fixed, but I don't yet know how exactly - my attempts to switch between IXP425_GPIO_GPIT1R and IXP425_GPIO_GPIT2R in the macro caused warnings in *all* cases.
cu Michael
On 15:12 Wed 27 Feb , Michael Schwingen wrote:
On Mon, Feb 25, 2008 at 12:02:24AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
actux1: actux1.c: In function 'checkboard': actux1.c:92: warning: unused variable 'revision'
Fixed
actux2: actux2.c: In function 'checkboard': actux2.c:100: warning: unused variable 's' actux2.c:99: warning: unused variable 'revision' actux2.c: In function 'reset_phy': actux2.c:130: warning: unused variable 'i'
Fixed
actux3: actux3.c: In function 'checkboard': actux3.c:114: warning: unused variable 'revision'
Fixed
Thanks!
The warning in actux4.c is more interesting: it looks like IXP42x GPIO_INT_ACT_LOW_SET can't handle interrupt lines above GPIO8 at all - these are set in IXP425_GPIO_GPIT2R instead of IXP425_GPIO_GPIT1R. For a quick fix, removing the set for the interrupt line should be OK, since the board does not use PCI in u-boot (yet):
Signed-off-by: Michael Schwingen michael@schwingen.org
diff --git a/board/actux4/actux4.c b/board/actux4/actux4.c index 84037fa..260b6f7 100644 --- a/board/actux4/actux4.c +++ b/board/actux4/actux4.c @@ -80,7 +80,6 @@ int board_init (void) GPIO_INT_ACT_LOW_SET (CFG_GPIO_USBINTB); GPIO_INT_ACT_LOW_SET (CFG_GPIO_USBINTC); GPIO_INT_ACT_LOW_SET (CFG_GPIO_RTCINT);
GPIO_INT_ACT_LOW_SET (CFG_GPIO_PCI_INTA); GPIO_INT_ACT_LOW_SET (CFG_GPIO_PCI_INTB); /* Setup GPIO's for 33MHz clock output */For the next release, GPIO_INT_ACT_LOW_SET should be fixed, but I don't yet know how exactly - my attempts to switch between IXP425_GPIO_GPIT1R and IXP425_GPIO_GPIT2R in the macro caused warnings in *all* cases.
I will prefer that you fix GPIO_INT_ACT_LOW_SET.
Best Regards, J.
On 15:15 Wed 27 Feb , Jean-Christophe PLAGNIOL-VILLARD wrote:
On 15:12 Wed 27 Feb , Michael Schwingen wrote:
On Mon, Feb 25, 2008 at 12:02:24AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
actux1: actux1.c: In function 'checkboard': actux1.c:92: warning: unused variable 'revision'
Fixed
actux2: actux2.c: In function 'checkboard': actux2.c:100: warning: unused variable 's' actux2.c:99: warning: unused variable 'revision' actux2.c: In function 'reset_phy': actux2.c:130: warning: unused variable 'i'
Fixed
actux3: actux3.c: In function 'checkboard': actux3.c:114: warning: unused variable 'revision'
Fixed
Thanks!
The warning in actux4.c is more interesting: it looks like IXP42x GPIO_INT_ACT_LOW_SET can't handle interrupt lines above GPIO8 at all - these are set in IXP425_GPIO_GPIT2R instead of IXP425_GPIO_GPIT1R. For a quick fix, removing the set for the interrupt line should be OK, since the board does not use PCI in u-boot (yet):
Signed-off-by: Michael Schwingen michael@schwingen.org
diff --git a/board/actux4/actux4.c b/board/actux4/actux4.c index 84037fa..260b6f7 100644 --- a/board/actux4/actux4.c +++ b/board/actux4/actux4.c @@ -80,7 +80,6 @@ int board_init (void) GPIO_INT_ACT_LOW_SET (CFG_GPIO_USBINTB); GPIO_INT_ACT_LOW_SET (CFG_GPIO_USBINTC); GPIO_INT_ACT_LOW_SET (CFG_GPIO_RTCINT);
GPIO_INT_ACT_LOW_SET (CFG_GPIO_PCI_INTA); GPIO_INT_ACT_LOW_SET (CFG_GPIO_PCI_INTB); /* Setup GPIO's for 33MHz clock output */For the next release, GPIO_INT_ACT_LOW_SET should be fixed, but I don't yet know how exactly - my attempts to switch between IXP425_GPIO_GPIT1R and IXP425_GPIO_GPIT2R in the macro caused warnings in *all* cases.
I will prefer that you fix GPIO_INT_ACT_LOW_SET.
I've found I will fix this
Best Regards, J.
On Sun, 2008-02-24 at 09:24, Wolfgang Denk wrote:
MPC8610HPCD: net.c: In function 'PingHandler': net.c:770: warning: passing argument 1 of 'NetReadIP' discards qualifiers from pointer target type net.c: In function 'NetSetIP': net.c:1694: warning: passing argument 1 of 'NetCopyIP' discards qualifiers from pointer target type net.c:1695: warning: passing argument 1 of 'NetCopyIP' discards qualifiers from pointer target type net.c: In function 'PingSend': net.c:736: warning: passing argument 1 of 'NetCopyIP' discards qualifiers from pointer target type net.c:737: warning: passing argument 1 of 'NetCopyIP' discards qualifiers from pointer target type
Hi Wolfgang,,
I've not been able to reproduce the above warnings using either a gcc 3.43 or a gcc 4.2.0 compiler. That is some very odd code, and I'm curious to know if it is only on the MPC8610HPCD board that you see this behavior, or is it also on some other board too? Can anyone else duplicate those warnings?
sbc8641d: sbc8641d.c: In function 'pci_init_board': sbc8641d.c:233: error: 'MPC86xx_PORDEVSR_IO_SEL' undeclared (first use in this function) sbc8641d.c:233: error: (Each undeclared identifier is reported only once sbc8641d.c:233: error: for each function it appears in.) make[1]: *** [/work/wd/tmp-ppc/board/sbc8641d/sbc8641d.o] Error 1 make: *** [/work/wd/tmp-ppc/board/sbc8641d/libsbc8641d.a] Error 2
I posted a patch to fix this brain-damage of mine. Left hand, meet right hand.... You know. Sorry.
Board maintainers - please test and post patches ASAP!
A pull of u-boot-86xx will clean up the sbc8641d build.
Thanks, jdl
In message 1203973080.30238.11.camel@ld0161-tx32 you wrote:
Board maintainers - please test and post patches ASAP!
A pull of u-boot-86xx will clean up the sbc8641d build.
Pulled, thanks.
Best regards,
Wolfgang Denk
On Sun, Feb 24, 2008 at 04:24:21PM +0100, Wolfgang Denk wrote:
Hi everybody,
the second (and hopefully last) release candidate for U-Boot v1.3.2 has been released and is available form both the git repository and the FTP server.
It seems I missed one patch for the AcTux boards - the one which adds CONFIG_MII_ETHSWITCH support for boards without a directly attached PHY. I know I submitted it, but looking at the mail archive, I am not quite sure if it was supposed to be included or not.
This is no fatal problem - network access works after the autonegotiation timeout, so this might wait for the next release - I do not think this warrants any release delays.
Here is the current version of the fix - I would like to get this (or some reworked version) included, even if it will be obsoleted by the phy library when it finally arrives.
From 23ce4f89cae10202ee5632608b115859774aaa7b Mon Sep 17 00:00:00 2001
From: Michael Schwingen michael@schwingen.org Date: Fri, 29 Feb 2008 20:48:02 +0100 Subject: [PATCH] add CONFIG_MII_ETHSWITCH support to IXP42x npe driver
Signed-off-by: Michael Schwingen michael@schwingen.org --- cpu/ixp/npe/npe.c | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/cpu/ixp/npe/npe.c b/cpu/ixp/npe/npe.c index a33b956..2bb784e 100644 --- a/cpu/ixp/npe/npe.c +++ b/cpu/ixp/npe/npe.c @@ -361,6 +361,12 @@ static int npe_init(struct eth_device *dev, bd_t * bis)
debug("%s: 1\n", __FUNCTION__);
+#ifdef CONFIG_MII_ETHSWITCH + speed = _100BASET; + duplex = FULL; + (void) i; + (void) reg_short; +#else miiphy_read (dev->name, p_npe->phy_no, PHY_BMSR, ®_short);
/* @@ -390,7 +396,7 @@ static int npe_init(struct eth_device *dev, bd_t * bis)
speed = miiphy_speed (dev->name, p_npe->phy_no); duplex = miiphy_duplex (dev->name, p_npe->phy_no); - +#endif if (p_npe->print_speed) { p_npe->print_speed = 0; printf ("ENET Speed is %d Mbps - %s duplex connection\n",
HI Michael,
Michael Schwingen wrote:
On Sun, Feb 24, 2008 at 04:24:21PM +0100, Wolfgang Denk wrote:
Hi everybody,
the second (and hopefully last) release candidate for U-Boot v1.3.2 has been released and is available form both the git repository and the FTP server.
It seems I missed one patch for the AcTux boards - the one which adds CONFIG_MII_ETHSWITCH support for boards without a directly attached PHY. I know I submitted it, but looking at the mail archive, I am not quite sure if it was supposed to be included or not.
I didn't pull this in and apologize for not communicating very well. While it scratches your particular itch, there have been so many submissions and requests for fixed PHY support that it doesn't make sense to be putting in ones like this that are architecture-specific.
I'll keep this patch, though, and if the PHY library drags out for too long it will go in.
thanks, Ben
Hi everybody,
the third (and hopefully last) release candidate for U-Boot v1.3.2 has been released and is available form both the git repository and the FTP server.
Board maintainers - please test and post patches ASAP!
The plan is to have a final release of v1.3.2 not later than March 10.
Best regards,
Wolfgang Denk
participants (6)
-
Andy Fleming -
Ben Warren -
Jean-Christophe PLAGNIOL-VILLARD -
Jon Loeliger -
Michael Schwingen -
Wolfgang Denk