ChangeLog:
* Patch by Robert Schwebel, 14 May 2004: use config.h (which is needed in serial.c for CFG_HZ)
Robert
In message 20040515150855.GO27774@pengutronix.de you wrote:
- Patch by Robert Schwebel, 14 May 2004: use config.h (which is needed in serial.c for CFG_HZ)
What makes you think this is needed? The code compiles fine as is...
#include <common.h> +#include <config.h> #include <clps7111.h>
And actually this _IS_ redundand, since "include/common.h" already includes <config.h>.
Which problem are you tring to fix? I can't see any...
Rejected.
Wolfgang Denk
On Sat, May 15, 2004 at 07:10:55PM +0200, Wolfgang Denk wrote:
- Patch by Robert Schwebel, 14 May 2004: use config.h (which is needed in serial.c for CFG_HZ)
What makes you think this is needed? The code compiles fine as is...
#include <common.h> +#include <config.h> #include <clps7111.h>
And actually this _IS_ redundand, since "include/common.h" already includes <config.h>.
It's normally good coding practise to include the files which have the stuff you actually need, instead of relying on other include files including other includefiles and wondering why things break if somebody changes something in the other file. But the decision is surely up to you.
Robert
In message 20040516095806.GU27774@pengutronix.de you wrote:
It's normally good coding practise to include the files which have the stuff you actually need, instead of relying on other include files including other includefiles and wondering why things break if somebody
Actually config.h is needed more or less everywhere so I think it makes more sense to have it included once (in common.h) instead of adding it in more than 500 other files.
changes something in the other file. But the decision is surely up to you.
Nothing is broken, so I see no need to fix anything.
Best regards,
Wolfgang Denk
participants (3)
-
Robert Schwebel -
Robert Schwebel -
Wolfgang Denk