[PATCH] dm: Add a debug message when devices are skipped pre-reloc

This adds a message to lists_bind_fdt when it skips initializing a device pre-relocation. I've had a couple errors where a device didn't initialize properly because one of its dependencies was missing.
Signed-off-by: Sean Anderson seanga2@gmail.com --- drivers/core/lists.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/core/lists.c b/drivers/core/lists.c index 4681b3e5dd..68204c303f 100644 --- a/drivers/core/lists.c +++ b/drivers/core/lists.c @@ -176,8 +176,10 @@ int lists_bind_fdt(struct udevice *parent, ofnode node, struct udevice **devp,
if (pre_reloc_only) { if (!dm_ofnode_pre_reloc(node) && - !(entry->flags & DM_FLAG_PRE_RELOC)) + !(entry->flags & DM_FLAG_PRE_RELOC)) { + log_debug("Skipping device pre-relocation\n"); return 0; + } }
log_debug(" - found match at '%s': '%s' matches '%s'\n",

On Wed, Dec 25, 2019 at 12:52 PM Sean Anderson seanga2@gmail.com wrote:
This adds a message to lists_bind_fdt when it skips initializing a device pre-relocation. I've had a couple errors where a device didn't initialize properly because one of its dependencies was missing.
Signed-off-by: Sean Anderson seanga2@gmail.com
drivers/core/lists.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Bin Meng bmeng.cn@gmail.com

On Tue, 24 Dec 2019 at 21:52, Sean Anderson seanga2@gmail.com wrote:
This adds a message to lists_bind_fdt when it skips initializing a device pre-relocation. I've had a couple errors where a device didn't initialize properly because one of its dependencies was missing.
Signed-off-by: Sean Anderson seanga2@gmail.com
drivers/core/lists.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Simon Glass sjg@chromium.org

On Tue, 24 Dec 2019 at 21:52, Sean Anderson seanga2@gmail.com wrote:
This adds a message to lists_bind_fdt when it skips initializing a device pre-relocation. I've had a couple errors where a device didn't initialize properly because one of its dependencies was missing.
Signed-off-by: Sean Anderson seanga2@gmail.com
drivers/core/lists.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Simon Glass sjg@chromium.org
Applied to u-boot-dm, thanks!
participants (4)
-
Bin Meng
-
Sean Anderson
-
Simon Glass
-
sjg@google.com