[U-Boot] [PATCH] ARM: add IDE init to lib_arm/board.c Part 1/1
[PATCH] ARM: add IDE init to lib_arm/board.c
This patch adds ide_init() to the arm boot process.
The patch is against "latest" u-boot git-repository
Please (still) be patient if style of submission or patches are offending.
Signed-off-by: Stefan Althoefer stefan.althoefer@web.de ----
diff -uprN u-boot-orig//lib_arm/board.c u-boot/lib_arm/board.c --- u-boot-orig//lib_arm/board.c 2008-12-02 17:25:32.000000000 +0100 +++ u-boot/lib_arm/board.c 2008-12-02 23:29:36.000000000 +0100 @@ -441,6 +441,11 @@ extern void davinci_eth_set_mac_addr (co } #endif
+#if defined(CONFIG_CMD_IDE) + puts("IDE: "); + ide_init(); +#endif /* CONFIG_CMD_IDE */ + #ifdef BOARD_LATE_INIT board_late_init (); #endif
On 22:08 Thu 04 Dec , Stefan Althoefer wrote:
[PATCH] ARM: add IDE init to lib_arm/board.c
This patch adds ide_init() to the arm boot process.
The patch is against "latest" u-boot git-repository
Please (still) be patient if style of submission or patches are offending.
Signed-off-by: Stefan Althoefer stefan.althoefer@web.de
diff -uprN u-boot-orig//lib_arm/board.c u-boot/lib_arm/board.c --- u-boot-orig//lib_arm/board.c 2008-12-02 17:25:32.000000000 +0100 +++ u-boot/lib_arm/board.c 2008-12-02 23:29:36.000000000 +0100 @@ -441,6 +441,11 @@ extern void davinci_eth_set_mac_addr (co } #endif
+#if defined(CONFIG_CMD_IDE)
puts("IDE: ");ide_init();+#endif /* CONFIG_CMD_IDE */
are you sure it will work?
Best Regards, J.
Jean-Christophe PLAGNIOL-VILLARD schrieb:
diff -uprN u-boot-orig//lib_arm/board.c u-boot/lib_arm/board.c --- u-boot-orig//lib_arm/board.c 2008-12-02 17:25:32.000000000 +0100 +++ u-boot/lib_arm/board.c 2008-12-02 23:29:36.000000000 +0100 @@ -441,6 +441,11 @@ extern void davinci_eth_set_mac_addr (co } #endif
+#if defined(CONFIG_CMD_IDE)
puts("IDE: ");ide_init();+#endif /* CONFIG_CMD_IDE */
are you sure it will work?
Best Regards, J.
On my board (Janz emPC-A400 with IXP425) it does. With some more patches to add IDE to this board.
What is your doubt?
If you see problems, drop this. I can also add IDE to board_late_init().
-- Stefan
Stefan Althoefer wrote:
Jean-Christophe PLAGNIOL-VILLARD schrieb:
diff -uprN u-boot-orig//lib_arm/board.c u-boot/lib_arm/board.c --- u-boot-orig//lib_arm/board.c 2008-12-02 17:25:32.000000000 +0100 +++ u-boot/lib_arm/board.c 2008-12-02 23:29:36.000000000 +0100 @@ -441,6 +441,11 @@ extern void davinci_eth_set_mac_addr (co } #endif
+#if defined(CONFIG_CMD_IDE)
puts("IDE: ");ide_init();+#endif /* CONFIG_CMD_IDE */
are you sure it will work?
Best Regards, J.
On my board (Janz emPC-A400 with IXP425) it does. With some more patches to add IDE to this board.
What is your doubt?
If you see problems, drop this. I can also add IDE to board_late_init().
I don't sure if the outsw/insw are implemented in arm.
Regards Michael
michael wrote:
Stefan Althoefer wrote:
Jean-Christophe PLAGNIOL-VILLARD schrieb:
diff -uprN u-boot-orig//lib_arm/board.c u-boot/lib_arm/board.c --- u-boot-orig//lib_arm/board.c 2008-12-02 17:25:32.000000000 +0100 +++ u-boot/lib_arm/board.c 2008-12-02 23:29:36.000000000 +0100 @@ -441,6 +441,11 @@ extern void davinci_eth_set_mac_addr (co } #endif
+#if defined(CONFIG_CMD_IDE)
puts("IDE: ");ide_init();+#endif /* CONFIG_CMD_IDE */
are you sure it will work?
Best Regards, J.
On my board (Janz emPC-A400 with IXP425) it does. With some more patches to add IDE to this board.
What is your doubt?
If you see problems, drop this. I can also add IDE to board_late_init().
I don't sure if the outsw/insw are implemented in arm.
Regards Michael _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Well, I'm not sure :( if the outsw/insw are implemented in arm.
Regards Michael
On 14:10 Wed 17 Dec , michael wrote:
michael wrote:
Stefan Althoefer wrote:
Jean-Christophe PLAGNIOL-VILLARD schrieb:
diff -uprN u-boot-orig//lib_arm/board.c u-boot/lib_arm/board.c --- u-boot-orig//lib_arm/board.c 2008-12-02 17:25:32.000000000 +0100 +++ u-boot/lib_arm/board.c 2008-12-02 23:29:36.000000000 +0100 @@ -441,6 +441,11 @@ extern void davinci_eth_set_mac_addr (co } #endif
+#if defined(CONFIG_CMD_IDE)
puts("IDE: ");ide_init();+#endif /* CONFIG_CMD_IDE */
are you sure it will work?
Best Regards, J.
On my board (Janz emPC-A400 with IXP425) it does. With some more patches to add IDE to this board.
What is your doubt?
If you see problems, drop this. I can also add IDE to board_late_init().
I don't sure if the outsw/insw are implemented in arm.
Regards Michael _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Well, I'm not sure :( if the outsw/insw are implemented in arm.
IIRC they are not. I'll check but in u-boot we do not have the asm implementtion.
Best Regards, J.
Jean-Christophe PLAGNIOL-VILLARD schrieb:
On 14:10 Wed 17 Dec , michael wrote:
michael wrote:
Stefan Althoefer wrote:
Jean-Christophe PLAGNIOL-VILLARD schrieb:
diff -uprN u-boot-orig//lib_arm/board.c u-boot/lib_arm/board.c --- u-boot-orig//lib_arm/board.c 2008-12-02 17:25:32.000000000 +0100 +++ u-boot/lib_arm/board.c 2008-12-02 23:29:36.000000000 +0100 @@ -441,6 +441,11 @@ extern void davinci_eth_set_mac_addr (co } #endif
+#if defined(CONFIG_CMD_IDE)
puts("IDE: ");ide_init();+#endif /* CONFIG_CMD_IDE */
are you sure it will work?
Best Regards, J.
On my board (Janz emPC-A400 with IXP425) it does. With some more patches to add IDE to this board.
What is your doubt?
If you see problems, drop this. I can also add IDE to board_late_init().
I don't sure if the outsw/insw are implemented in arm.
Regards Michael _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Well, I'm not sure :( if the outsw/insw are implemented in arm.
IIRC they are not. I'll check but in u-boot we do not have the asm implementtion.
Best Regards, J.
Indeed, I have patched ide.c so it does not use insw/outsw if compiled for my board. Refer to patch with msg-id 49384735.e5PYiIdAjpxLwq8V%stefan.althoefer@web.de to see what I did.
-- Stefan
Jean-Christophe PLAGNIOL-VILLARD wrote:
On 22:08 Thu 04 Dec , Stefan Althoefer wrote:
[PATCH] ARM: add IDE init to lib_arm/board.c
This patch adds ide_init() to the arm boot process.
The patch is against "latest" u-boot git-repository
Please (still) be patient if style of submission or patches are offending.
Signed-off-by: Stefan Althoefer stefan.althoefer@web.de
diff -uprN u-boot-orig//lib_arm/board.c u-boot/lib_arm/board.c --- u-boot-orig//lib_arm/board.c 2008-12-02 17:25:32.000000000 +0100 +++ u-boot/lib_arm/board.c 2008-12-02 23:29:36.000000000 +0100 @@ -441,6 +441,11 @@ extern void davinci_eth_set_mac_addr (co } #endif
+#if defined(CONFIG_CMD_IDE)
puts("IDE: ");ide_init();+#endif /* CONFIG_CMD_IDE */
are you sure it will work?
Best Regards, J. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
I submit a patch series for ide support in ARM. I don't think that it will work
Michael
participants (3)
-
Jean-Christophe PLAGNIOL-VILLARD -
michael -
Stefan Althoefer