[U-Boot] PPC4xx without CONFIG_NET_MULTI
Hi Stefan (and anybody else that can answer),
I'm trying to understand why some 4xx boards use CONFIG_NET_MULTI and a few don't. Is there a technical reason why these few can't (limited storage or something else) or are they just older? There are 47 boards in-tree that use CONFIG_PPC4xx_EMAC and the following 18 use the older net API. ---
bwarren@bwarren-bldsrv:~/src/u-boot-net/include/configs$ grep -l PPC4xx_EMAC * | xargs grep -L CONFIG_NET_MULTI AR405.h CPCIISER4.h CRAYL1.h csb272.h csb472.h DP405.h ERIC.h EXBITGEN.h HUB405.h JSE.h MIP405.h OCRTC.h ORSG.h PIP405.h sbc405.h W7OLMC.h W7OLMG.h WUH405.h ---
I'd like to move all over to CONFIG_NET_MULTI, which in itself is trivial since the EMAC driver supports both APIs, but am wary of breaking something.
regards, Ben
Hi Ben,
On Tuesday 28 April 2009, Ben Warren wrote:
Hi Stefan (and anybody else that can answer),
I'm trying to understand why some 4xx boards use CONFIG_NET_MULTI and a few don't. Is there a technical reason why these few can't (limited storage or something else) or are they just older?
Yes, they are just older. Nobody found the time to clear this up till now.
There are 47 boards in-tree that use CONFIG_PPC4xx_EMAC and the following 18 use the older net API.
bwarren@bwarren-bldsrv:~/src/u-boot-net/include/configs$ grep -l PPC4xx_EMAC *
| xargs grep -L CONFIG_NET_MULTI
AR405.h CPCIISER4.h CRAYL1.h csb272.h csb472.h DP405.h ERIC.h EXBITGEN.h HUB405.h JSE.h MIP405.h OCRTC.h ORSG.h PIP405.h sbc405.h W7OLMC.h W7OLMG.h WUH405.h
I'd like to move all over to CONFIG_NET_MULTI,
That would be great. I thought about this as well but didn't find the time yet to do so.
which in itself is trivial since the EMAC driver supports both APIs, but am wary of breaking something.
The reason for this (as far as I overlook things) is simply historical. Nobody found the time to clear this up till now. Chances are good that such a transitions doesn't break anything. I can't test though, since I don't have access to any of those boards. I added Matthias to cc, he is maintaining some of those boards. Maybe he could test if you provided a patch for this?
Thanks.
Best regards, Stefan
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de =====================================================================
On Tuesday 28 April 2009, Matthias Fuchs wrote:
I will prepare a patch for these boards on thursday:
AR405.h CPCIISER4.h HUB405.h OCRTC.h ORSG.h WUH405.h
I have a cleanup patch ready for DP405 by today :-)
DP405.h
Thanks. :)
Best regards, Stefan
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de =====================================================================
Hi Matthias,
Matthias Fuchs wrote:
Hi Ben, Hi Stefan,
I will prepare a patch for these boards on thursday:
AR405.h CPCIISER4.h HUB405.h OCRTC.h ORSG.h WUH405.h
I have a cleanup patch ready for DP405 by today :-)
DP405.h
Matthias
I appreciate your help here! As you'll see, I've put together some naive patches to take care of all the boards. I expect I'm missing some things that you'll notice.
thanks again, Ben
Hi Matthias,
Matthias Fuchs wrote:
Hi Ben, Hi Stefan,
I will prepare a patch for these boards on thursday:
AR405.h CPCIISER4.h HUB405.h OCRTC.h ORSG.h WUH405.h
I have a cleanup patch ready for DP405 by today :-)
DP405.h
Matthias
I appreciate your help here! As you'll see, I've put together some naive patches to take care of all the boards. I expect I'm missing some things that you'll notice.
Thanks. Seems to be fine. I expect that Stefan will complain about our patches touching the same boards. Perhaps he will fix it ;-)
Matthias
On Thursday 30 April 2009, Matthias Fuchs wrote:
I appreciate your help here! As you'll see, I've put together some naive patches to take care of all the boards. I expect I'm missing some things that you'll notice.
Thanks. Seems to be fine. I expect that Stefan will complain about our patches touching the same boards. Perhaps he will fix it ;-)
Yep. I just got a merge conflict here. And resolved it.
Ben, I suggest that I push your 4xx/CONFIG_NET_MULTI patches via my ppc4xx/next repo into mainline because of these problems. Is this ok with you?
Best regards, Stefan
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de =====================================================================
On Mon, May 4, 2009 at 1:23 AM, Stefan Roese sr@denx.de wrote:
On Thursday 30 April 2009, Matthias Fuchs wrote:
I appreciate your help here! As you'll see, I've put together some naive patches to take care of all the boards. I expect I'm missing
some
things that you'll notice.
Thanks. Seems to be fine. I expect that Stefan will complain about our patches touching the same boards. Perhaps he will fix it ;-)
Yep. I just got a merge conflict here. And resolved it.
Ben, I suggest that I push your 4xx/CONFIG_NET_MULTI patches via my ppc4xx/next repo into mainline because of these problems. Is this ok with you?
Sure. Thanks!
Ben
participants (4)
-
Ben Warren -
Matthias Fuchs -
Matthias Fuchs -
Stefan Roese