[PATCH v2] arm: Remove redundant loading of image copy start offse

From: Liya Huang 1425075683@qq.com
Because the beginning is already computed
Signed-off-by: Liya Huang 1425075683@qq.com ---
Changes in v2: - Due to an error, the patch was resubmitted, leaving the code unchanged - Sorry for the trouble; Due to the lack of understanding of the process, the previous patch information was Reviewed-by. Please refer to this patch
arch/arm/lib/relocate.S | 2 -- 1 file changed, 2 deletions(-)
diff --git a/arch/arm/lib/relocate.S b/arch/arm/lib/relocate.S index 345e282e3e..bffadfecba 100644 --- a/arch/arm/lib/relocate.S +++ b/arch/arm/lib/relocate.S @@ -83,8 +83,6 @@ relocate_base: add r1, r3 /* r1 <- Run &__image_copy_start */ subs r4, r0, r1 /* r4 <- Run to copy offset */ beq relocate_done /* skip relocation */ - ldr r1, _image_copy_start_ofs - add r1, r3 /* r1 <- Run &__image_copy_start */ ldr r2, _image_copy_end_ofs add r2, r3 /* r2 <- Run &__image_copy_end */ copy_loop:

On Sat, 18 Jan 2025 at 18:05, 1425075683@qq.com wrote:
From: Liya Huang 1425075683@qq.com
Because the beginning is already computed
Signed-off-by: Liya Huang 1425075683@qq.com
Changes in v2:
- Due to an error, the patch was resubmitted, leaving the code unchanged
- Sorry for the trouble; Due to the lack of understanding of the process,
the previous patch information was Reviewed-by. Please refer to this patch
arch/arm/lib/relocate.S | 2 -- 1 file changed, 2 deletions(-)
Reviewed-by: Simon Glass sjg@chromium.org
diff --git a/arch/arm/lib/relocate.S b/arch/arm/lib/relocate.S index 345e282e3e..bffadfecba 100644 --- a/arch/arm/lib/relocate.S +++ b/arch/arm/lib/relocate.S @@ -83,8 +83,6 @@ relocate_base: add r1, r3 /* r1 <- Run &__image_copy_start */ subs r4, r0, r1 /* r4 <- Run to copy offset */ beq relocate_done /* skip relocation */
ldr r1, _image_copy_start_ofs
add r1, r3 /* r1 <- Run &__image_copy_start */ ldr r2, _image_copy_end_ofs add r2, r3 /* r2 <- Run &__image_copy_end */
copy_loop:
2.25.1
participants (2)
-
1425075683@qq.com
-
Simon Glass