Hi,

Just noticed a few more things which need a minor tweak, so looks like we're going to need a v5, sorry.

On 15-03-16 10:46, Stefan Roese wrote:

This patch changes the USB port scanning procedure and timeout handling in the following ways:

a) The power-on delay in usb_hub_power_on() is now reduced to a value of max(100ms, "hub->desc.bPwrOn2PwrGood * 2"). The code does not wait using mdelay, instead usb_hub_power_on() will wait before querying the device in the scanning loop later. The total timeout for this hub, which is 1 second + "hub->desc.bPwrOn2PwrGood * 2" is calculated and will be used in the following per-port scanning loop as the timeout to detect active USB devices on this hub.

b) Don't delay the minimum delay (for power to stabilize) in usb_hub_power_on(). Instead skip querying these devices in the scannig loop until the delay time is reached.

c) The ports are now scanned in a quasi parallel way. The current code did wait for each (unconnected) port to reach its timeout and only then continue with the next port. This patch now changes this to scan all ports of all USB hubs quasi simultaneously. For this, all ports are added to a scanning list. This list is scanned until all ports are ready by either a) reaching the connection timeout (calculated earlier), or by b) detecting a USB device. This results in a faster USB scan time as the recursive scanning of USB hubs connected to the hub that's currently being scanned will start earlier.

Without this patch: starting USB... USB0: USB EHCI 1.00 scanning bus 0 for devices... 9 USB Device(s) found

time: 20.163 seconds

With this patch: starting USB... USB0: USB EHCI 1.00 scanning bus 0 for devices... 9 USB Device(s) found

time: 1.822 seconds

So ~18.3 seconds of USB scanning time reduction.

Signed-off-by: Stefan Roese sr@denx.de Acked-by: Hans de Goede hdegoede@redhat.com Tested-by: Stephen Warren swarren@nvidia.com

---

Changes in v4:

• Moved check for query_delay into usb_scan_port() as suggested by Hans
• Correct list handling (drop INIT_LIST_HEAD)
• Added some missing free() calls
• Changed connect_timeout calculation as suggested by Stephen
• Moved usb_scan_list to other globals to be cleaned up in a later patch
• Added timeout check for non-functional ports (usb_get_port_status return error
• Reverted if logic in loop to remove an indentation level
• Moved debug() output
• Removed unnecessary if when already connected
• Added Hans's Acked-by
• Added Stephen's Tested-by
• Minor rewording / fixes of the commit text

Changes in v3:

• Introduced scanning list containing all USB devices of one USB controller that need to get scanned
• Don't delay in usb_hub_power_on(). Instead skip querying these devices until the delay time is reached.

Changes in v2:

• Remove static USB port configuration patch (for now)

  common/usb_hub.c | 293 ++++++++++++++++++++++++++++++++++++++----------------- include/usb.h | 3 + 2 files changed, 204 insertions(+), 92 deletions(-)

diff --git a/common/usb_hub.c b/common/usb_hub.c index d621f50..e8cfc7e 100644 --- a/common/usb_hub.c +++ b/common/usb_hub.c @@ -30,6 +30,7 @@ #include <asm/processor.h> #include <asm/unaligned.h> #include <linux/ctype.h> +#include <linux/list.h> #include <asm/byteorder.h> #ifdef CONFIG_SANDBOX #include <asm/state.h> @@ -49,9 +50,17 @@ DECLARE_GLOBAL_DATA_PTR; #define HUB_SHORT_RESET_TIME 20 #define HUB_LONG_RESET_TIME 200

+struct usb_device_scan {

• struct usb_device *dev; /* USB hub device to scan */
• struct usb_hub_device *hub; /* USB hub struct */
• int port; /* USB port to scan */
• struct list_head list;

+};

• /* TODO(sjg@chromium.org): Remove this when CONFIG_DM_USB is defined */ static struct usb_hub_device hub_dev[USB_MAX_HUB]; static int usb_hub_index;

+static LIST_HEAD(usb_scan_list);

__weak void usb_hub_reset_devices(int port) { @@ -120,7 +129,22 @@ static void usb_hub_power_on(struct usb_hub_device *hub) pgood_delay = max(pgood_delay, (unsigned)simple_strtol(env, NULL, 0)); debug("pgood_delay=%dms\n", pgood_delay);

• mdelay(pgood_delay + 1000);

• /*

• * Do a minimum delay of the larger value of 100ms or pgood_delay
  

• * so that the power can stablize before the devices are queried
  

• */
  

• dev->query_delay = get_timer(0) + max(100, (int)pgood_delay);

• /*

• * Record the power-on timeout here. The max. delay (timeout)
  

• * will be done based on this value in the USB port loop in
  

• * usb_hub_configure() later.
  

• */
  

• dev->connect_timeout = dev->query_delay + 1000;

• debug("devnum=%d poweron: query_delay=%d connect_timeout=%d\n",

•      dev->devnum, max(100, (int)pgood_delay),
  

•      max(100, (int)pgood_delay) + 1000);
  

  }

  void usb_hub_reset(void)

@@ -332,6 +356,157 @@ int usb_hub_port_connect_change(struct usb_device *dev, int port) return ret; }

+static int usb_scan_port(struct usb_device_scan *usb_scan) +{

• ALLOC_CACHE_ALIGN_BUFFER(struct usb_port_status, portsts, 1);
• unsigned short portstatus;
• unsigned short portchange;
• struct usb_device *dev;
• struct usb_hub_device *hub;
• int ret = 0;
• int i;
• dev = usb_scan->dev;
• hub = usb_scan->hub;
• i = usb_scan->port;
• /*

• * Don't talk to the device before the query delay is expired.
  

• * This is needed for voltages to stabalize.
  

• */
  

• if (get_timer(0) < dev->query_delay)

• return 0;
  

+#ifdef CONFIG_DM_USB

• debug("\n\nScanning '%s' port %d\n", dev->dev->name, i + 1);

+#else

• debug("\n\nScanning port %d\n", i + 1);

+#endif

We may now end up printing this a lot of times when debug printing is enabled, probably best to remove it (less is more :)

• ret = usb_get_port_status(dev, i + 1, portsts);
• if (ret < 0) {

• debug("get_port_status failed\n");
  

• if (get_timer(0) >= dev->connect_timeout) {
  

• 	debug("devnum=%d port=%d: timeout\n",
  

• 	      dev->devnum, i + 1);
  

• 	/* Remove this device from scanning list */
  

• 	list_del(&usb_scan->list);
  

• 	free(usb_scan);
  

• 	return 0;
  

• }
  

• }
• portstatus = le16_to_cpu(portsts->wPortStatus);
• portchange = le16_to_cpu(portsts->wPortChange);
• debug("Port %d Status %X Change %X\n", i + 1, portstatus, portchange);
• /* No connection change happened, wait a bit more. */
• if (!(portchange & USB_PORT_STAT_C_CONNECTION)) {

• if (get_timer(0) >= dev->connect_timeout) {
  

• 	debug("devnum=%d port=%d: timeout\n",
  

• 	      dev->devnum, i + 1);
  

• 	/* Remove this device from scanning list */
  

• 	list_del(&usb_scan->list);
  

• 	free(usb_scan);
  

• 	return 0;
  

• }
  

• return 0;
  

• }
• /* Test if the connection came up, and if not exit */
• if (!(portstatus & USB_PORT_STAT_CONNECTION))

• return 0;
  

• /* A new USB device is ready at this point */
• debug("devnum=%d port=%d: USB dev found\n", dev->devnum, i + 1);

Just printing this in debug mode should be enough.

• /* Remove this device from scanning list */
• list_del(&usb_scan->list);
• free(usb_scan);
• usb_hub_port_connect_change(dev, i);
• if (portchange & USB_PORT_STAT_C_ENABLE) {

• debug("port %d enable change, status %x\n", i + 1, portstatus);
  

• usb_clear_port_feature(dev, i + 1, USB_PORT_FEAT_C_ENABLE);
  

• /*
  

•  * The following hack causes a ghost device problem
  

•  * to Faraday EHCI
  

•  */
  

+#ifndef CONFIG_USB_EHCI_FARADAY

• /*
  

•  * EM interference sometimes causes bad shielded USB
  

•  * devices to be shutdown by the hub, this hack enables
  

•  * them again. Works at least with mouse driver
  

•  */
  

• if (!(portstatus & USB_PORT_STAT_ENABLE) &&
  

•     (portstatus & USB_PORT_STAT_CONNECTION) &&
  

•     usb_device_has_child_on_port(dev, i)) {
  

• 	debug("already running port %i disabled by hub (EMI?), re-enabling...\n",
  

• 	      i + 1);
  

• 	usb_hub_port_connect_change(dev, i);
  

• }
  

+#endif

• }
• if (portstatus & USB_PORT_STAT_SUSPEND) {

• debug("port %d suspend change\n", i + 1);
  

• usb_clear_port_feature(dev, i + 1, USB_PORT_FEAT_SUSPEND);
  

• }
• if (portchange & USB_PORT_STAT_C_OVERCURRENT) {

• debug("port %d over-current change\n", i + 1);
  

• usb_clear_port_feature(dev, i + 1,
  

• 		       USB_PORT_FEAT_C_OVER_CURRENT);
  

• usb_hub_power_on(hub);
  

This is the one why we need a v5, so usb_hub_power_on(hub) will reset the timeouts! That by-itself is fine, if the over-current was caused by a spike, but if the over-current is permanent, we will just get an overcurrent report again after powering on the port again, rinse repeat -> never ending loop.

So there are 2 options:

1) On overcurrent remove the device from the list of devices to scan, the old code did the power-on after the loop with the delay, so it would actually not rescan the device after an overcurrent condition. Doing the power_on as the old code does seems useless in this case, we should probably still do it though, to reduce the amount of behavior changes and then remove it in a separate patch.

2) Do not reset the timeouts, do the power_on as the old code did and try to enumerate the device again.

3) reset the timeouts, but keep a per hub (or per port?) over-current counter and if it reaches say 3 then quit powering the port back on, and remove the port from the list of devices to scan instead.

1. keeps us closest to the original code behavior, but IMHO 3. is better. I think we can be lazy and just make the over-current counter a per hub thing rather then per port. Note that the current code does:

usb_set_port_feature(dev, i + 1, USB_PORT_FEAT_POWER);

On all ports on over-current, that is something which we may want to fix too, but I believe that belongs in a separate follow-up patch.

• }
• if (portchange & USB_PORT_STAT_C_RESET) {

• debug("port %d reset change\n", i + 1);
  

• usb_clear_port_feature(dev, i + 1, USB_PORT_FEAT_C_RESET);
  

• }
• return 0;

+}

+static int usb_device_list_scan(void) +{

• struct usb_device_scan *usb_scan;
• struct usb_device_scan *tmp;
• static int running;
• int ret = 0;
• /* Only run this loop once for each controller */
• if (running)

• return 0;
  

• running = 1;
• while (1) {

• /* We're done, once the list is empty again */
  

• if (list_empty(&usb_scan_list))
  

• 	goto out;
  

• list_for_each_entry_safe(usb_scan, tmp, &usb_scan_list, list) {
  

• 	int ret;
  

• 	/* Scan this port */
  

• 	ret = usb_scan_port(usb_scan);
  

• 	if (ret)
  

• 		goto out;
  

• }
  

• }

+out:

• /*

• * This USB controller has has finished scanning all its connected
  

• * USB devices. Set "running" back to 0, so that other USB controllers
  

• * will scan their devices too.
  

• */
  

• running = 0;
• return ret;

+}

static int usb_hub_configure(struct usb_device *dev) { @@ -466,104 +641,38 @@ static int usb_hub_configure(struct usb_device *dev) for (i = 0; i < dev->maxchild; i++) usb_hub_reset_devices(i + 1);

• for (i = 0; i < dev->maxchild; i++) {

• ALLOC_CACHE_ALIGN_BUFFER(struct usb_port_status, portsts, 1);
  

• unsigned short portstatus, portchange;
  

• int ret;
  

• ulong start = get_timer(0);
  

• uint delay = CONFIG_SYS_HZ;
  

• #ifdef CONFIG_SANDBOX

• if (state_get_skip_delays())
  

• 	delay = 0;
  

-#endif -#ifdef CONFIG_DM_USB

• debug("\n\nScanning '%s' port %d\n", dev->dev->name, i + 1);
  

-#else

• debug("\n\nScanning port %d\n", i + 1);
  

• if (state_get_skip_delays())

• dev->poweron_timeout = 0;
  

1) poweron_timeout does not exist, looks like you did not do a test sandbox build

2) You should clear both connect_timeout and query_delay here, or better simply put:

if (state_get_skip_delays()) return;

In usb_hub_power_on() before setting these (this assumes that usb_device gets kzalloc-ed).

#endif

• /*
  

•  * Wait for (whichever finishes first)
  

•  *  - A maximum of 10 seconds
  

•  *    This is a purely observational value driven by connecting
  

•  *    a few broken pen drives and taking the max * 1.5 approach
  

•  *  - connection_change and connection state to report same
  

•  *    state
  

•  */
  

• do {
  

• 	ret = usb_get_port_status(dev, i + 1, portsts);
  

• 	if (ret < 0) {
  

• 		debug("get_port_status failed\n");
  

• 		break;
  

• 	}
  

• 	portstatus = le16_to_cpu(portsts->wPortStatus);
  

• 	portchange = le16_to_cpu(portsts->wPortChange);
  

• 	/* No connection change happened, wait a bit more. */
  

• 	if (!(portchange & USB_PORT_STAT_C_CONNECTION))
  

• 		continue;
  

• 	/* Test if the connection came up, and if so, exit. */
  

• 	if (portstatus & USB_PORT_STAT_CONNECTION)
  

• 		break;
  
  

• } while (get_timer(start) < delay);
  

• if (ret < 0)
  

• 	continue;
  

• debug("Port %d Status %X Change %X\n",
  

•       i + 1, portstatus, portchange);
  

• if (portchange & USB_PORT_STAT_C_CONNECTION) {
  

• 	debug("port %d connection change\n", i + 1);
  

• 	usb_hub_port_connect_change(dev, i);
  

• }
  

• if (portchange & USB_PORT_STAT_C_ENABLE) {
  

• 	debug("port %d enable change, status %x\n",
  

• 	      i + 1, portstatus);
  

• 	usb_clear_port_feature(dev, i + 1,
  

• 				USB_PORT_FEAT_C_ENABLE);
  

• 	/*
  

• 	 * The following hack causes a ghost device problem
  

• 	 * to Faraday EHCI
  

• 	 */
  

-#ifndef CONFIG_USB_EHCI_FARADAY

• 	/* EM interference sometimes causes bad shielded USB
  

• 	 * devices to be shutdown by the hub, this hack enables
  

• 	 * them again. Works at least with mouse driver */
  

• 	if (!(portstatus & USB_PORT_STAT_ENABLE) &&
  

• 	     (portstatus & USB_PORT_STAT_CONNECTION) &&
  

• 	     usb_device_has_child_on_port(dev, i)) {
  

• 		debug("already running port %i "  \
  

• 		      "disabled by hub (EMI?), " \
  

• 		      "re-enabling...\n", i + 1);
  

• 		      usb_hub_port_connect_change(dev, i);
  

• 	}
  

-#endif

• }
  

• if (portstatus & USB_PORT_STAT_SUSPEND) {
  

• 	debug("port %d suspend change\n", i + 1);
  

• 	usb_clear_port_feature(dev, i + 1,
  

• 				USB_PORT_FEAT_SUSPEND);
  

• }
  

• /*

• * Only add the connected USB devices, including potential hubs,
  

• * to a scanning list. This list will get scanned and devices that
  

• * are detected (either via port connected or via port timeout)
  

• * will get removed from this list. Scanning of the devices on this
  

• * list will continue until all devices are removed.
  

• */
  

• for (i = 0; i < dev->maxchild; i++) {

• struct usb_device_scan *usb_scan;
  
  

• if (portchange & USB_PORT_STAT_C_OVERCURRENT) {
  

• 	debug("port %d over-current change\n", i + 1);
  

• 	usb_clear_port_feature(dev, i + 1,
  

• 				USB_PORT_FEAT_C_OVER_CURRENT);
  

• 	usb_hub_power_on(hub);
  

• usb_scan = calloc(1, sizeof(*usb_scan));
  

• if (!usb_scan) {
  

• 	printf("Can't allocate memory for USB device!\n");
  

• 	return -ENOMEM;
  

  }

• usb_scan->dev = dev;
  

• usb_scan->hub = hub;
  

• usb_scan->port = i;
  

• list_add_tail(&usb_scan->list, &usb_scan_list);
  

• }

• if (portchange & USB_PORT_STAT_C_RESET) {
  

• 	debug("port %d reset change\n", i + 1);
  

• 	usb_clear_port_feature(dev, i + 1,
  

• 				USB_PORT_FEAT_C_RESET);
  

• }
  

• } /* end for i all ports */

• /*

• * And now call the scanning code which loops over the generated list
  

• */
  

• ret = usb_device_list_scan();

• return 0;

• return ret; }

  static int usb_hub_check(struct usb_device *dev, int ifnum)

diff --git a/include/usb.h b/include/usb.h index 0b410b6..0b57093 100644 --- a/include/usb.h +++ b/include/usb.h @@ -153,6 +153,9 @@ struct usb_device { struct udevice *dev; /* Pointer to associated device */ struct udevice *controller_dev; /* Pointer to associated controller */ #endif

• ulong connect_timeout; /* Device connection timeout in ms */

• ulong query_delay; /* Device query delay in ms */ };

  struct int_queue;

I just realized: wouldn't it be better to put these 2 in struct usb_hub_device? you are tracking them per hub not per port, so they seem to belong there.

Regards,

Hans

Hi,

On 15-03-16 12:29, Stefan Roese wrote:

Hi Hans,

On 15.03.2016 11:44, Hans de Goede wrote:

...

Just noticed a few more things which need a minor tweak, so looks like we're going to need a v5, sorry.

On 15-03-16 10:46, Stefan Roese wrote:

...

This patch changes the USB port scanning procedure and timeout handling in the following ways:

a) The power-on delay in usb_hub_power_on() is now reduced to a value of max(100ms, "hub->desc.bPwrOn2PwrGood * 2"). The code does not wait using mdelay, instead usb_hub_power_on() will wait before querying the device in the scanning loop later. The total timeout for this hub, which is 1 second + "hub->desc.bPwrOn2PwrGood * 2" is calculated and will be used in the following per-port scanning loop as the timeout to detect active USB devices on this hub.

b) Don't delay the minimum delay (for power to stabilize) in usb_hub_power_on(). Instead skip querying these devices in the scannig loop until the delay time is reached.

c) The ports are now scanned in a quasi parallel way. The current code did wait for each (unconnected) port to reach its timeout and only then continue with the next port. This patch now changes this to scan all ports of all USB hubs quasi simultaneously. For this, all ports are added to a scanning list. This list is scanned until all ports are ready by either a) reaching the connection timeout (calculated earlier), or by b) detecting a USB device. This results in a faster USB scan time as the recursive scanning of USB hubs connected to the hub that's currently being scanned will start earlier.

Without this patch: starting USB... USB0: USB EHCI 1.00 scanning bus 0 for devices... 9 USB Device(s) found

time: 20.163 seconds

With this patch: starting USB... USB0: USB EHCI 1.00 scanning bus 0 for devices... 9 USB Device(s) found

time: 1.822 seconds

So ~18.3 seconds of USB scanning time reduction.

Signed-off-by: Stefan Roese sr@denx.de Acked-by: Hans de Goede hdegoede@redhat.com Tested-by: Stephen Warren swarren@nvidia.com

---

Changes in v4:

• Moved check for query_delay into usb_scan_port() as suggested by Hans
• Correct list handling (drop INIT_LIST_HEAD)
• Added some missing free() calls
• Changed connect_timeout calculation as suggested by Stephen
• Moved usb_scan_list to other globals to be cleaned up in a later patch
• Added timeout check for non-functional ports (usb_get_port_status return error
• Reverted if logic in loop to remove an indentation level
• Moved debug() output
• Removed unnecessary if when already connected
• Added Hans's Acked-by
• Added Stephen's Tested-by
• Minor rewording / fixes of the commit text

Changes in v3:

• Introduced scanning list containing all USB devices of one USB controller that need to get scanned
• Don't delay in usb_hub_power_on(). Instead skip querying these devices until the delay time is reached.

Changes in v2:

• Remove static USB port configuration patch (for now)

  common/usb_hub.c | 293

++++++++++++++++++++++++++++++++++++++----------------- include/usb.h | 3 + 2 files changed, 204 insertions(+), 92 deletions(-)

diff --git a/common/usb_hub.c b/common/usb_hub.c index d621f50..e8cfc7e 100644 --- a/common/usb_hub.c +++ b/common/usb_hub.c @@ -30,6 +30,7 @@ #include <asm/processor.h> #include <asm/unaligned.h> #include <linux/ctype.h> +#include <linux/list.h> #include <asm/byteorder.h> #ifdef CONFIG_SANDBOX #include <asm/state.h> @@ -49,9 +50,17 @@ DECLARE_GLOBAL_DATA_PTR; #define HUB_SHORT_RESET_TIME 20 #define HUB_LONG_RESET_TIME 200

+struct usb_device_scan {

• struct usb_device *dev; /* USB hub device to scan */
• struct usb_hub_device *hub; /* USB hub struct */
• int port; /* USB port to scan */
• struct list_head list;

+};

• /* TODO(sjg@chromium.org): Remove this when CONFIG_DM_USB is defined */ static struct usb_hub_device hub_dev[USB_MAX_HUB]; static int usb_hub_index;

+static LIST_HEAD(usb_scan_list);

__weak void usb_hub_reset_devices(int port) { @@ -120,7 +129,22 @@ static void usb_hub_power_on(struct usb_hub_device *hub) pgood_delay = max(pgood_delay, (unsigned)simple_strtol(env, NULL, 0)); debug("pgood_delay=%dms\n", pgood_delay);

• mdelay(pgood_delay + 1000);

• /*

• * Do a minimum delay of the larger value of 100ms or pgood_delay
  

• * so that the power can stablize before the devices are queried
  

• */
  

• dev->query_delay = get_timer(0) + max(100, (int)pgood_delay);

• /*

• * Record the power-on timeout here. The max. delay (timeout)
  

• * will be done based on this value in the USB port loop in
  

• * usb_hub_configure() later.
  

• */
  

• dev->connect_timeout = dev->query_delay + 1000;

• debug("devnum=%d poweron: query_delay=%d connect_timeout=%d\n",

•      dev->devnum, max(100, (int)pgood_delay),
  

•      max(100, (int)pgood_delay) + 1000);
  

  }

  void usb_hub_reset(void)

@@ -332,6 +356,157 @@ int usb_hub_port_connect_change(struct usb_device *dev, int port) return ret; }

+static int usb_scan_port(struct usb_device_scan *usb_scan) +{

• ALLOC_CACHE_ALIGN_BUFFER(struct usb_port_status, portsts, 1);
• unsigned short portstatus;
• unsigned short portchange;
• struct usb_device *dev;
• struct usb_hub_device *hub;
• int ret = 0;
• int i;
• dev = usb_scan->dev;
• hub = usb_scan->hub;
• i = usb_scan->port;
• /*

• * Don't talk to the device before the query delay is expired.
  

• * This is needed for voltages to stabalize.
  

• */
  

• if (get_timer(0) < dev->query_delay)

•    return 0;
  

+#ifdef CONFIG_DM_USB

• debug("\n\nScanning '%s' port %d\n", dev->dev->name, i + 1);

+#else

• debug("\n\nScanning port %d\n", i + 1);

+#endif

We may now end up printing this a lot of times when debug printing is enabled, probably best to remove it (less is more :)

I already thought about it but wasn't brave enough. ;)

...

...

• ret = usb_get_port_status(dev, i + 1, portsts);
• if (ret < 0) {

•    debug("get_port_status failed\n");
  

•    if (get_timer(0) >= dev->connect_timeout) {
  

•        debug("devnum=%d port=%d: timeout\n",
  

•              dev->devnum, i + 1);
  

•        /* Remove this device from scanning list */
  

•        list_del(&usb_scan->list);
  

•        free(usb_scan);
  

•        return 0;
  

•    }
  

• }
• portstatus = le16_to_cpu(portsts->wPortStatus);
• portchange = le16_to_cpu(portsts->wPortChange);
• debug("Port %d Status %X Change %X\n", i + 1, portstatus,

portchange);

• /* No connection change happened, wait a bit more. */
• if (!(portchange & USB_PORT_STAT_C_CONNECTION)) {

•    if (get_timer(0) >= dev->connect_timeout) {
  

•        debug("devnum=%d port=%d: timeout\n",
  

•              dev->devnum, i + 1);
  

•        /* Remove this device from scanning list */
  

•        list_del(&usb_scan->list);
  

•        free(usb_scan);
  

•        return 0;
  

•    }
  

•    return 0;
  

• }
• /* Test if the connection came up, and if not exit */
• if (!(portstatus & USB_PORT_STAT_CONNECTION))

•    return 0;
  

• /* A new USB device is ready at this point */
• debug("devnum=%d port=%d: USB dev found\n", dev->devnum, i + 1);

Just printing this in debug mode should be enough.

Yes. I've removed the 1st debug above in v5.

...

...

• /* Remove this device from scanning list */
• list_del(&usb_scan->list);
• free(usb_scan);
• usb_hub_port_connect_change(dev, i);
• if (portchange & USB_PORT_STAT_C_ENABLE) {

•    debug("port %d enable change, status %x\n", i + 1, portstatus);
  

•    usb_clear_port_feature(dev, i + 1, USB_PORT_FEAT_C_ENABLE);
  

•    /*
  

•     * The following hack causes a ghost device problem
  

•     * to Faraday EHCI
  

•     */
  

+#ifndef CONFIG_USB_EHCI_FARADAY

•    /*
  

•     * EM interference sometimes causes bad shielded USB
  

•     * devices to be shutdown by the hub, this hack enables
  

•     * them again. Works at least with mouse driver
  

•     */
  

•    if (!(portstatus & USB_PORT_STAT_ENABLE) &&
  

•        (portstatus & USB_PORT_STAT_CONNECTION) &&
  

•        usb_device_has_child_on_port(dev, i)) {
  

•        debug("already running port %i disabled by hub (EMI?),
  

re-enabling...\n",

•              i + 1);
  

•        usb_hub_port_connect_change(dev, i);
  

•    }
  

+#endif

• }
• if (portstatus & USB_PORT_STAT_SUSPEND) {

•    debug("port %d suspend change\n", i + 1);
  

•    usb_clear_port_feature(dev, i + 1, USB_PORT_FEAT_SUSPEND);
  

• }
• if (portchange & USB_PORT_STAT_C_OVERCURRENT) {

•    debug("port %d over-current change\n", i + 1);
  

•    usb_clear_port_feature(dev, i + 1,
  

•                   USB_PORT_FEAT_C_OVER_CURRENT);
  

•    usb_hub_power_on(hub);
  

This is the one why we need a v5, so usb_hub_power_on(hub) will reset the timeouts!

Good catch, thx.

...

That by-itself is fine, if the over-current was caused by a spike, but if the over-current is permanent, we will just get an overcurrent report again after powering on the port again, rinse repeat -> never ending loop.

Not quite. Looking at the code, the device is already removed from the list when this code patch is reached. So it would not be scanned a 2nd time at all. Instead the scanning time for the other devices connected to this hub (and not yet detected) are reset, which is not quite what we want to achieve.

Oh, right, so other then resetting the timeouts the current code is behaving as the old one did on case of overcurrent.

I would replace the usb_hub_power_on(hub), with:

usb_set_port_feature(dev, i + 1, USB_PORT_FEAT_POWER);

That way you avoid resetting the timeout, and you fix the needlessly re-setting of USB_PORT_FEAT_POWER on the other ports, and then the code will behave just as before.

I should probably move the list_del()/free() call to the end of the loop. This makes things clearer and more flexible. What do you think?

Ack for moving the list_del to the end of the loop.

...

So there are 2 options:

1. On overcurrent remove the device from the list of devices to scan,

the old code did the power-on after the loop with the delay, so it would actually not rescan the device after an overcurrent condition. Doing the power_on as the old code does seems useless in this case, we should probably still do it though, to reduce the amount of behavior changes and then remove it in a separate patch.

So thats what we should have with v4 already, right?

Right, I missed that.

...

2. Do not reset the timeouts, do the power_on as the old code did and

try to enumerate the device again.

3. reset the timeouts, but keep a per hub (or per port?) over-current

counter and if it reaches say 3 then quit powering the port back on, and remove the port from the list of devices to scan instead.

1. keeps us closest to the original code behavior, but IMHO 3. is better.

I think we can be lazy and just make the over-current counter a per hub thing rather then per port.

Once I move list_del() to the end of the loop, this should be easy to implement.

I agree that it should be easy to implement, but since we only get in this code-path when a device has actually already been detected, there is no reason to re-probe I guess, so I would just replace the usb_hub_power_on(hub), with:

usb_set_port_feature(dev, i + 1, USB_PORT_FEAT_POWER);

As I suggested above and be done with it. Esp. since we have no way to test this.

Should I aim for 3 with the per-hub counter?

If you we're to implement some rescan then yes, but I would not bother.

...

Note that the current code does:

             usb_set_port_feature(dev, i + 1, USB_PORT_FEAT_POWER);

On all ports on over-current, that is something which we may want to fix too, but I believe that belongs in a separate follow-up patch.

Yes, it makes sense to do this not in this patchset.

Except that doing it in this patch-set fixes the problem of usb_hub_power_on() resetting the timeouts, so I vote for doing it (and probably mention it in the commit msg).

An added advantage of just replacing the usb_hub_power_on() call is that it does not invalidate all testing done with this patch-set before now, whereas other fixes would require some more re-testing.

...

...

• }
• if (portchange & USB_PORT_STAT_C_RESET) {

•    debug("port %d reset change\n", i + 1);
  

•    usb_clear_port_feature(dev, i + 1, USB_PORT_FEAT_C_RESET);
  

• }
• return 0;

+}

+static int usb_device_list_scan(void) +{

• struct usb_device_scan *usb_scan;
• struct usb_device_scan *tmp;
• static int running;
• int ret = 0;
• /* Only run this loop once for each controller */
• if (running)

•    return 0;
  

• running = 1;
• while (1) {

•    /* We're done, once the list is empty again */
  

•    if (list_empty(&usb_scan_list))
  

•        goto out;
  

•    list_for_each_entry_safe(usb_scan, tmp, &usb_scan_list, list) {
  

•        int ret;
  

•        /* Scan this port */
  

•        ret = usb_scan_port(usb_scan);
  

•        if (ret)
  

•            goto out;
  

•    }
  

• }

+out:

• /*

• * This USB controller has has finished scanning all its connected
  

• * USB devices. Set "running" back to 0, so that other USB
  

controllers

• * will scan their devices too.
  

• */
  

• running = 0;
• return ret;

+}

static int usb_hub_configure(struct usb_device *dev) { @@ -466,104 +641,38 @@ static int usb_hub_configure(struct usb_device *dev) for (i = 0; i < dev->maxchild; i++) usb_hub_reset_devices(i + 1);

• for (i = 0; i < dev->maxchild; i++) {

•    ALLOC_CACHE_ALIGN_BUFFER(struct usb_port_status, portsts, 1);
  

•    unsigned short portstatus, portchange;
  

•    int ret;
  

•    ulong start = get_timer(0);
  

•    uint delay = CONFIG_SYS_HZ;
  

• #ifdef CONFIG_SANDBOX

•    if (state_get_skip_delays())
  

•        delay = 0;
  

-#endif -#ifdef CONFIG_DM_USB

•    debug("\n\nScanning '%s' port %d\n", dev->dev->name, i + 1);
  

-#else

•    debug("\n\nScanning port %d\n", i + 1);
  

• if (state_get_skip_delays())

•    dev->poweron_timeout = 0;
  

1. poweron_timeout does not exist, looks like you did not do a test

sandbox build

No, I missed this.

...

2. You should clear both connect_timeout and query_delay here, or better

simply put:

 if (state_get_skip_delays())
     return;

In usb_hub_power_on() before setting these (this assumes that usb_device gets kzalloc-ed).

Okay, will do.

Please double-check that usb_device gets kzalloc-ed, or ...

...

...

#endif

•    /*
  

•     * Wait for (whichever finishes first)
  

•     *  - A maximum of 10 seconds
  

•     *    This is a purely observational value driven by connecting
  

•     *    a few broken pen drives and taking the max * 1.5 approach
  

•     *  - connection_change and connection state to report same
  

•     *    state
  

•     */
  

•    do {
  

•        ret = usb_get_port_status(dev, i + 1, portsts);
  

•        if (ret < 0) {
  

•            debug("get_port_status failed\n");
  

•            break;
  

•        }
  

•        portstatus = le16_to_cpu(portsts->wPortStatus);
  

•        portchange = le16_to_cpu(portsts->wPortChange);
  

•        /* No connection change happened, wait a bit more. */
  

•        if (!(portchange & USB_PORT_STAT_C_CONNECTION))
  

•            continue;
  

•        /* Test if the connection came up, and if so, exit. */
  

•        if (portstatus & USB_PORT_STAT_CONNECTION)
  

•            break;
  
  

•    } while (get_timer(start) < delay);
  

•    if (ret < 0)
  

•        continue;
  

•    debug("Port %d Status %X Change %X\n",
  

•          i + 1, portstatus, portchange);
  

•    if (portchange & USB_PORT_STAT_C_CONNECTION) {
  

•        debug("port %d connection change\n", i + 1);
  

•        usb_hub_port_connect_change(dev, i);
  

•    }
  

•    if (portchange & USB_PORT_STAT_C_ENABLE) {
  

•        debug("port %d enable change, status %x\n",
  

•              i + 1, portstatus);
  

•        usb_clear_port_feature(dev, i + 1,
  

•                    USB_PORT_FEAT_C_ENABLE);
  

•        /*
  

•         * The following hack causes a ghost device problem
  

•         * to Faraday EHCI
  

•         */
  

-#ifndef CONFIG_USB_EHCI_FARADAY

•        /* EM interference sometimes causes bad shielded USB
  

•         * devices to be shutdown by the hub, this hack enables
  

•         * them again. Works at least with mouse driver */
  

•        if (!(portstatus & USB_PORT_STAT_ENABLE) &&
  

•             (portstatus & USB_PORT_STAT_CONNECTION) &&
  

•             usb_device_has_child_on_port(dev, i)) {
  

•            debug("already running port %i "  \
  

•                  "disabled by hub (EMI?), " \
  

•                  "re-enabling...\n", i + 1);
  

•                  usb_hub_port_connect_change(dev, i);
  

•        }
  

-#endif

•    }
  

•    if (portstatus & USB_PORT_STAT_SUSPEND) {
  

•        debug("port %d suspend change\n", i + 1);
  

•        usb_clear_port_feature(dev, i + 1,
  

•                    USB_PORT_FEAT_SUSPEND);
  

•    }
  

• /*

• * Only add the connected USB devices, including potential hubs,
  

• * to a scanning list. This list will get scanned and devices that
  

• * are detected (either via port connected or via port timeout)
  

• * will get removed from this list. Scanning of the devices on this
  

• * list will continue until all devices are removed.
  

• */
  

• for (i = 0; i < dev->maxchild; i++) {

•    struct usb_device_scan *usb_scan;
  
  

•    if (portchange & USB_PORT_STAT_C_OVERCURRENT) {
  

•        debug("port %d over-current change\n", i + 1);
  

•        usb_clear_port_feature(dev, i + 1,
  

•                    USB_PORT_FEAT_C_OVER_CURRENT);
  

•        usb_hub_power_on(hub);
  

•    usb_scan = calloc(1, sizeof(*usb_scan));
  

•    if (!usb_scan) {
  

•        printf("Can't allocate memory for USB device!\n");
  

•        return -ENOMEM;
      }
  

•    usb_scan->dev = dev;
  

•    usb_scan->hub = hub;
  

•    usb_scan->port = i;
  

•    list_add_tail(&usb_scan->list, &usb_scan_list);
  

• }

•    if (portchange & USB_PORT_STAT_C_RESET) {
  

•        debug("port %d reset change\n", i + 1);
  

•        usb_clear_port_feature(dev, i + 1,
  

•                    USB_PORT_FEAT_C_RESET);
  

•    }
  

• } /* end for i all ports */

• /*

• * And now call the scanning code which loops over the generated
  

list

• */
  

• ret = usb_device_list_scan();

• return 0;

• return ret; }

  static int usb_hub_check(struct usb_device *dev, int ifnum)

diff --git a/include/usb.h b/include/usb.h index 0b410b6..0b57093 100644 --- a/include/usb.h +++ b/include/usb.h @@ -153,6 +153,9 @@ struct usb_device { struct udevice *dev; /* Pointer to associated device */ struct udevice *controller_dev; /* Pointer to associated controller */ #endif

• ulong connect_timeout; /* Device connection timeout in ms */

• ulong query_delay; /* Device query delay in ms */ };

  struct int_queue;

I just realized: wouldn't it be better to put these 2 in struct usb_hub_device? you are tracking them per hub not per port, so they seem to belong there.

Good idea. Moved to hub in v5.

In that case you need to make sure that usb_hub_device gets zero-ed somewhere explicitly (in case an array entry gets re-used on e.g. a "usb reset") or that the timeouts always get set, even in the state_get_skip_delays() case.

Probably better to just zero it somewhere as that may avoid other surprises too, usb_hub_reset() seems like a good candidate to just zero the entire array.

Regards,

Hans