[U-Boot] [PATCH 1/3] m28evk: use same notation to alloc the 128kB stack
Signed-off-by: Otavio Salvador otavio@ossystems.com.br Cc: Marek Vasut marex@denx.de Cc: Stefano Babic sbabic@denx.de Cc: Wolfgang Denk wd@denx.de --- include/configs/m28evk.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/configs/m28evk.h b/include/configs/m28evk.h index 68e46b7..a076aa5 100644 --- a/include/configs/m28evk.h +++ b/include/configs/m28evk.h @@ -88,7 +88,7 @@ #define CONFIG_NR_DRAM_BANKS 1 /* 1 bank of DRAM */ #define PHYS_SDRAM_1 0x40000000 /* Base address */ #define PHYS_SDRAM_1_SIZE 0x20000000 /* Max 512 MB RAM */ -#define CONFIG_STACKSIZE 0x00010000 /* 128 KB stack */ +#define CONFIG_STACKSIZE (128 * 1024) /* 128 KB stack */ #define CONFIG_SYS_MALLOC_LEN 0x00400000 /* 4 MB for malloc */ #define CONFIG_SYS_GBL_DATA_SIZE 128 /* Initial data */ #define CONFIG_SYS_MEMTEST_START 0x40000000 /* Memtest start adr */
Signed-off-by: Otavio Salvador otavio@ossystems.com.br Cc: Marek Vasut marex@denx.de Cc: Stefano Babic sbabic@denx.de Cc: Wolfgang Denk wd@denx.de --- include/configs/m28evk.h | 2 -- 1 file changed, 2 deletions(-)
diff --git a/include/configs/m28evk.h b/include/configs/m28evk.h index a076aa5..29ea8eb 100644 --- a/include/configs/m28evk.h +++ b/include/configs/m28evk.h @@ -43,8 +43,6 @@ #define CONFIG_ARCH_CPU_INIT #define CONFIG_ARCH_MISC_INIT
-#define CONFIG_OF_LIBFDT - /* * SPL */
Dear Otavio Salvador,
Signed-off-by: Otavio Salvador otavio@ossystems.com.br Cc: Marek Vasut marex@denx.de Cc: Stefano Babic sbabic@denx.de Cc: Wolfgang Denk wd@denx.de
Please drop the other one, so this is the same as mx28evk.h and we can easily unify it. btw how did you find this?
include/configs/m28evk.h | 2 -- 1 file changed, 2 deletions(-)
diff --git a/include/configs/m28evk.h b/include/configs/m28evk.h index a076aa5..29ea8eb 100644 --- a/include/configs/m28evk.h +++ b/include/configs/m28evk.h @@ -43,8 +43,6 @@ #define CONFIG_ARCH_CPU_INIT #define CONFIG_ARCH_MISC_INIT
-#define CONFIG_OF_LIBFDT
/*
- SPL
*/
Best regards, Marek Vasut
On Tue, May 15, 2012 at 6:14 PM, Marek Vasut marex@denx.de wrote:
Please drop the other one, so this is the same as mx28evk.h and we can easily unify it. btw how did you find this?
Good; will check it.
I found it when looking about common stuff in boad configs; I am still willing to try to have a common header file for both but I am first interested in move i.MX23 further.
Dear Otavio Salvador,
On Tue, May 15, 2012 at 6:14 PM, Marek Vasut marex@denx.de wrote:
Please drop the other one, so this is the same as mx28evk.h and we can easily unify it. btw how did you find this?
Good; will check it.
I found it when looking about common stuff in boad configs; I am still willing to try to have a common header file for both but I am first interested in move i.MX23 further.
Ok, so let's do it this way:
You submit your MX23 stuff, let's get that in. Then we can start with this consolidation. Is it OK?
Best regards, Marek Vasut
On Tue, May 15, 2012 at 7:05 PM, Marek Vasut marex@denx.de wrote:
You submit your MX23 stuff, let's get that in. Then we can start with this consolidation. Is it OK?
This works but wouldn't be better to avoid a duplication before it? It doesn't matter for me but I'd prefer it fixed.
Dear Otavio Salvador,
On Tue, May 15, 2012 at 7:05 PM, Marek Vasut marex@denx.de wrote:
You submit your MX23 stuff, let's get that in. Then we can start with this consolidation. Is it OK?
This works but wouldn't be better to avoid a duplication before it? It doesn't matter for me but I'd prefer it fixed.
I'm all for applying this 2/3, the rest should be discussed more thoroughly.
Best regards, Marek Vasut
On Tue, May 15, 2012 at 8:18 PM, Marek Vasut marex@denx.de wrote:
This works but wouldn't be better to avoid a duplication before it? It doesn't matter for me but I'd prefer it fixed.
I'm all for applying this 2/3, the rest should be discussed more thoroughly.
I checked mx28evk and m28evk config and both are setting CONFIG_OF_LIBFDT at same place now. It seems this patch is the way to go. Please take a look and confirm it.
Dear Otavio Salvador,
On Tue, May 15, 2012 at 8:18 PM, Marek Vasut marex@denx.de wrote:
This works but wouldn't be better to avoid a duplication before it? It doesn't matter for me but I'd prefer it fixed.
I'm all for applying this 2/3, the rest should be discussed more thoroughly.
I checked mx28evk and m28evk config and both are setting CONFIG_OF_LIBFDT at same place now. It seems this patch is the way to go. Please take a look and confirm it.
Ok good
Acked-by: Marek Vasut marex@denx.de
Best regards, Marek Vasut
On 15/05/2012 22:59, Otavio Salvador wrote:
Signed-off-by: Otavio Salvador otavio@ossystems.com.br Cc: Marek Vasut marex@denx.de Cc: Stefano Babic sbabic@denx.de Cc: Wolfgang Denk wd@denx.de
Applied to u-boot-imx, thanks.
Best regards, Stefano Babic
The environment has been based on mx53loco and m28evk but keeping the possibility to easy change the default console device as Freescale and mainline kernels differ on the device name.
Signed-off-by: Otavio Salvador otavio@ossystems.com.br Cc: Marek Vasut marex@denx.de Cc: Stefano Babic sbabic@denx.de Cc: Wolfgang Denk wd@denx.de Cc: Fabio Estevam fabio.estevam@freescale.com --- include/configs/mx28evk.h | 83 ++++++++++++++++++++++++++++++++++++++++----- 1 file changed, 75 insertions(+), 8 deletions(-)
diff --git a/include/configs/mx28evk.h b/include/configs/mx28evk.h index e98a746..6c2bf5f 100644 --- a/include/configs/mx28evk.h +++ b/include/configs/mx28evk.h @@ -234,7 +234,6 @@ #define CONFIG_SETUP_MEMORY_TAGS #define CONFIG_BOOTDELAY 3 #define CONFIG_BOOTFILE "uImage" -#define CONFIG_BOOTCOMMAND "run bootcmd_net" #define CONFIG_LOADADDR 0x42000000 #define CONFIG_SYS_LOAD_ADDR CONFIG_LOADADDR #define CONFIG_OF_LIBFDT @@ -243,13 +242,81 @@ * Extra Environments */ #define CONFIG_EXTRA_ENV_SETTINGS \ - "console_fsl=console=ttyAM0" \ - "console_mainline=console=ttyAMA0" \ - "netargs=setenv bootargs console=${console_mainline}" \ + "update_nand_full_filename=u-boot.nand\0" \ + "update_nand_firmware_filename=u-boot.sb\0" \ + "update_sd_firmware_filename=u-boot.sd\0" \ + "update_nand_firmware_maxsz=0x100000\0" \ + "update_nand_stride=0x40\0" /* MX28 datasheet ch. 12.12 */ \ + "update_nand_count=0x4\0" /* MX28 datasheet ch. 12.12 */ \ + "update_nand_get_fcb_size=" /* Get size of FCB blocks */ \ + "nand device 0 ; " \ + "nand info ; " \ + "setexpr fcb_sz ${update_nand_stride} * ${update_nand_count};" \ + "setexpr update_nand_fcb ${fcb_sz} * ${nand_writesize}\0" \ + "update_nand_full=" /* Update FCB, DBBT and FW */ \ + "if tftp ${update_nand_full_filename} ; then " \ + "run update_nand_get_fcb_size ; " \ + "nand scrub -y 0x0 ${filesize} ; " \ + "nand write.raw ${loadaddr} 0x0 ${update_nand_fcb} ; " \ + "setexpr update_off ${loadaddr} + ${update_nand_fcb} ; " \ + "setexpr update_sz ${filesize} - ${update_nand_fcb} ; " \ + "nand write ${update_off} ${update_nand_fcb} ${update_sz} ; " \ + "fi\0" \ + "update_nand_firmware=" /* Update only firmware */ \ + "if tftp ${update_nand_firmware_filename} ; then " \ + "run update_nand_get_fcb_size ; " \ + "setexpr fcb_sz ${update_nand_fcb} * 2 ; " /* FCB + DBBT */ \ + "setexpr fw_sz ${update_nand_firmware_maxsz} * 2 ; " \ + "setexpr fw_off ${fcb_sz} + ${update_nand_firmware_maxsz};" \ + "nand erase ${fcb_sz} ${fw_sz} ; " \ + "nand write ${loadaddr} ${fcb_sz} ${filesize} ; " \ + "nand write ${loadaddr} ${fw_off} ${filesize} ; " \ + "fi\0" \ + "update_sd_firmware=" /* Update the SD firmware partition */ \ + "if mmc rescan ; then " \ + "if tftp ${update_sd_firmware_filename} ; then " \ + "setexpr fw_sz ${filesize} / 0x200 ; " /* SD block size */ \ + "setexpr fw_sz ${fw_sz} + 1 ; " \ + "mmc write ${loadaddr} 0x800 ${fw_sz} ; " \ + "fi ; " \ + "fi\0" \ + "script=boot.scr\0" \ + "uimage=uImage\0" \ + "console_fsl=ttyAM0\0" \ + "console_mainline=ttyAMA0\0" \ + "console=${console_mainline}\0" \ + "mmcdev=0\0" \ + "mmcpart=2\0" \ + "mmcroot=/dev/mmcblk0p3 rw\0" \ + "mmcrootfstype=ext3 rootwait\0" \ + "mmcargs=setenv bootargs console=${console},${baudrate} " \ + "root=${mmcroot} " \ + "rootfstype=${mmcrootfstype}\0" \ + "loadbootscript=" \ + "fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \ + "bootscript=echo Running bootscript from mmc ...; " \ + "source\0" \ + "loaduimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${uimage}\0" \ + "mmcboot=echo Booting from mmc ...; " \ + "run mmcargs; " \ + "bootm\0" \ + "netargs=setenv bootargs console=ttymxc0,${baudrate} " \ "root=/dev/nfs " \ - "ip=dhcp nfsroot=${serverip}:${nfsroot}\0" \ - "bootcmd_net=echo Booting from net ...; " \ - "run netargs; " \ - "dhcp ${uimage}; bootm\0" \ + "ip=dhcp nfsroot=${serverip}:${nfsroot},v3,tcp\0" \ + "netboot=echo Booting from net ...; " \ + "run netargs; " \ + "dhcp ${uimage}; bootm\0" + +#define CONFIG_BOOTCOMMAND \ + "if mmc rescan ${mmcdev}; then " \ + "if run loadbootscript; then " \ + "run bootscript; " \ + "else " \ + "if run loaduimage; then " \ + "run mmcboot; " \ + "else run netboot; " \ + "fi; " \ + "fi; " \ + "else run netboot; fi"
#endif /* __MX28EVK_CONFIG_H__ */
On Tue, May 15, 2012 at 5:59 PM, Otavio Salvador otavio@ossystems.com.br wrote:
- "loaduimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${uimage}\0" \
- "mmcboot=echo Booting from mmc ...; " \
- "run mmcargs; " \
- "bootm\0" \
- "netargs=setenv bootargs console=ttymxc0,${baudrate} " \
No, ttymxc0 is wrong for mx28. You should use console=${console}.
On Tue, May 15, 2012 at 6:08 PM, Fabio Estevam festevam@gmail.com wrote:
On Tue, May 15, 2012 at 5:59 PM, Otavio Salvador otavio@ossystems.com.br wrote:
- "loaduimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${uimage}\0" \
- "mmcboot=echo Booting from mmc ...; " \
- "run mmcargs; " \
- "bootm\0" \
- "netargs=setenv bootargs console=ttymxc0,${baudrate} " \
No, ttymxc0 is wrong for mx28. You should use console=${console}.
My fault; when I redone it I forgot to fix it once again.
The environment has been based on mx53loco and m28evk but keeping the possibility to easy change the default console device as Freescale and mainline kernels differ on the device name.
Signed-off-by: Otavio Salvador otavio@ossystems.com.br Cc: Marek Vasut marex@denx.de Cc: Stefano Babic sbabic@denx.de Cc: Wolfgang Denk wd@denx.de Cc: Fabio Estevam fabio.estevam@freescale.com --- include/configs/mx28evk.h | 83 ++++++++++++++++++++++++++++++++++++++++----- 1 file changed, 75 insertions(+), 8 deletions(-)
diff --git a/include/configs/mx28evk.h b/include/configs/mx28evk.h index e98a746..889d58a 100644 --- a/include/configs/mx28evk.h +++ b/include/configs/mx28evk.h @@ -234,7 +234,6 @@ #define CONFIG_SETUP_MEMORY_TAGS #define CONFIG_BOOTDELAY 3 #define CONFIG_BOOTFILE "uImage" -#define CONFIG_BOOTCOMMAND "run bootcmd_net" #define CONFIG_LOADADDR 0x42000000 #define CONFIG_SYS_LOAD_ADDR CONFIG_LOADADDR #define CONFIG_OF_LIBFDT @@ -243,13 +242,81 @@ * Extra Environments */ #define CONFIG_EXTRA_ENV_SETTINGS \ - "console_fsl=console=ttyAM0" \ - "console_mainline=console=ttyAMA0" \ - "netargs=setenv bootargs console=${console_mainline}" \ + "update_nand_full_filename=u-boot.nand\0" \ + "update_nand_firmware_filename=u-boot.sb\0" \ + "update_sd_firmware_filename=u-boot.sd\0" \ + "update_nand_firmware_maxsz=0x100000\0" \ + "update_nand_stride=0x40\0" /* MX28 datasheet ch. 12.12 */ \ + "update_nand_count=0x4\0" /* MX28 datasheet ch. 12.12 */ \ + "update_nand_get_fcb_size=" /* Get size of FCB blocks */ \ + "nand device 0 ; " \ + "nand info ; " \ + "setexpr fcb_sz ${update_nand_stride} * ${update_nand_count};" \ + "setexpr update_nand_fcb ${fcb_sz} * ${nand_writesize}\0" \ + "update_nand_full=" /* Update FCB, DBBT and FW */ \ + "if tftp ${update_nand_full_filename} ; then " \ + "run update_nand_get_fcb_size ; " \ + "nand scrub -y 0x0 ${filesize} ; " \ + "nand write.raw ${loadaddr} 0x0 ${update_nand_fcb} ; " \ + "setexpr update_off ${loadaddr} + ${update_nand_fcb} ; " \ + "setexpr update_sz ${filesize} - ${update_nand_fcb} ; " \ + "nand write ${update_off} ${update_nand_fcb} ${update_sz} ; " \ + "fi\0" \ + "update_nand_firmware=" /* Update only firmware */ \ + "if tftp ${update_nand_firmware_filename} ; then " \ + "run update_nand_get_fcb_size ; " \ + "setexpr fcb_sz ${update_nand_fcb} * 2 ; " /* FCB + DBBT */ \ + "setexpr fw_sz ${update_nand_firmware_maxsz} * 2 ; " \ + "setexpr fw_off ${fcb_sz} + ${update_nand_firmware_maxsz};" \ + "nand erase ${fcb_sz} ${fw_sz} ; " \ + "nand write ${loadaddr} ${fcb_sz} ${filesize} ; " \ + "nand write ${loadaddr} ${fw_off} ${filesize} ; " \ + "fi\0" \ + "update_sd_firmware=" /* Update the SD firmware partition */ \ + "if mmc rescan ; then " \ + "if tftp ${update_sd_firmware_filename} ; then " \ + "setexpr fw_sz ${filesize} / 0x200 ; " /* SD block size */ \ + "setexpr fw_sz ${fw_sz} + 1 ; " \ + "mmc write ${loadaddr} 0x800 ${fw_sz} ; " \ + "fi ; " \ + "fi\0" \ + "script=boot.scr\0" \ + "uimage=uImage\0" \ + "console_fsl=ttyAM0\0" \ + "console_mainline=ttyAMA0\0" \ + "console=${console_mainline}\0" \ + "mmcdev=0\0" \ + "mmcpart=2\0" \ + "mmcroot=/dev/mmcblk0p3 rw\0" \ + "mmcrootfstype=ext3 rootwait\0" \ + "mmcargs=setenv bootargs console=${console},${baudrate} " \ + "root=${mmcroot} " \ + "rootfstype=${mmcrootfstype}\0" \ + "loadbootscript=" \ + "fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \ + "bootscript=echo Running bootscript from mmc ...; " \ + "source\0" \ + "loaduimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${uimage}\0" \ + "mmcboot=echo Booting from mmc ...; " \ + "run mmcargs; " \ + "bootm\0" \ + "netargs=setenv bootargs console=${console},${baudrate} " \ "root=/dev/nfs " \ - "ip=dhcp nfsroot=${serverip}:${nfsroot}\0" \ - "bootcmd_net=echo Booting from net ...; " \ - "run netargs; " \ - "dhcp ${uimage}; bootm\0" \ + "ip=dhcp nfsroot=${serverip}:${nfsroot},v3,tcp\0" \ + "netboot=echo Booting from net ...; " \ + "run netargs; " \ + "dhcp ${uimage}; bootm\0" + +#define CONFIG_BOOTCOMMAND \ + "if mmc rescan ${mmcdev}; then " \ + "if run loadbootscript; then " \ + "run bootscript; " \ + "else " \ + "if run loaduimage; then " \ + "run mmcboot; " \ + "else run netboot; " \ + "fi; " \ + "fi; " \ + "else run netboot; fi"
#endif /* __MX28EVK_CONFIG_H__ */
Dear Otavio Salvador,
In message 1337117472-15907-1-git-send-email-otavio@ossystems.com.br you wrote:
The environment has been based on mx53loco and m28evk but keeping the possibility to easy change the default console device as Freescale and mainline kernels differ on the device name.
Signed-off-by: Otavio Salvador otavio@ossystems.com.br Cc: Marek Vasut marex@denx.de Cc: Stefano Babic sbabic@denx.de Cc: Wolfgang Denk wd@denx.de Cc: Fabio Estevam fabio.estevam@freescale.com
include/configs/mx28evk.h | 83 ++++++++++++++++++++++++++++++++++++++++----- 1 file changed, 75 insertions(+), 8 deletions(-)
Starting by now, I will NAK all these patches that get posted and reposted and reposted again continuously ignoring the rules for patch submissions.
Please read http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions and stick to the documented rules.
I suggest we invalidate _all_ previously posted patcehs, you add the required changes and resubmit.
Thanks.
Best regards,
Wolfgang Denk
On Tue, May 29, 2012 at 5:57 PM, Wolfgang Denk wd@denx.de wrote:
Starting by now, I will NAK all these patches that get posted and reposted and reposted again continuously ignoring the rules for patch submissions.
I sent the last version of the patch changing only the Freescable board.
As I said, I am working on MX23 and will rebase and resend all this patches once it is OK. If possible, give access to the patchwork so I remove the patches that has been deprecated and I am the author so it doesn't bother there.
Dear Otavio Salvador,
The environment has been based on mx53loco and m28evk but keeping the possibility to easy change the default console device as Freescale and mainline kernels differ on the device name.
FSL kernel is dumb :-(
But I like this patch. On the other hand, can't this be made even more generic so everyone can use such a nice unified env?
Signed-off-by: Otavio Salvador otavio@ossystems.com.br Cc: Marek Vasut marex@denx.de Cc: Stefano Babic sbabic@denx.de Cc: Wolfgang Denk wd@denx.de Cc: Fabio Estevam fabio.estevam@freescale.com
include/configs/mx28evk.h | 83 ++++++++++++++++++++++++++++++++++++++++----- 1 file changed, 75 insertions(+), 8 deletions(-)
diff --git a/include/configs/mx28evk.h b/include/configs/mx28evk.h index e98a746..6c2bf5f 100644 --- a/include/configs/mx28evk.h +++ b/include/configs/mx28evk.h @@ -234,7 +234,6 @@ #define CONFIG_SETUP_MEMORY_TAGS #define CONFIG_BOOTDELAY 3 #define CONFIG_BOOTFILE "uImage" -#define CONFIG_BOOTCOMMAND "run bootcmd_net" #define CONFIG_LOADADDR 0x42000000 #define CONFIG_SYS_LOAD_ADDR CONFIG_LOADADDR #define CONFIG_OF_LIBFDT @@ -243,13 +242,81 @@
- Extra Environments
*/ #define CONFIG_EXTRA_ENV_SETTINGS \
- "console_fsl=console=ttyAM0" \
- "console_mainline=console=ttyAMA0" \
- "netargs=setenv bootargs console=${console_mainline}" \
- "update_nand_full_filename=u-boot.nand\0" \
- "update_nand_firmware_filename=u-boot.sb\0" \
- "update_sd_firmware_filename=u-boot.sd\0" \
- "update_nand_firmware_maxsz=0x100000\0" \
- "update_nand_stride=0x40\0" /* MX28 datasheet ch. 12.12 */ \
- "update_nand_count=0x4\0" /* MX28 datasheet ch. 12.12 */ \
- "update_nand_get_fcb_size=" /* Get size of FCB blocks */ \
"nand device 0 ; " \"nand info ; " \"setexpr fcb_sz ${update_nand_stride} * ${update_nand_count};" \"setexpr update_nand_fcb ${fcb_sz} * ${nand_writesize}\0" \- "update_nand_full=" /* Update FCB, DBBT and FW */ \
"if tftp ${update_nand_full_filename} ; then " \"run update_nand_get_fcb_size ; " \"nand scrub -y 0x0 ${filesize} ; " \"nand write.raw ${loadaddr} 0x0 ${update_nand_fcb} ; " \"setexpr update_off ${loadaddr} + ${update_nand_fcb} ; " \"setexpr update_sz ${filesize} - ${update_nand_fcb} ; " \"nand write ${update_off} ${update_nand_fcb} ${update_sz} ; " \"fi\0" \- "update_nand_firmware=" /* Update only firmware */ \
"if tftp ${update_nand_firmware_filename} ; then " \"run update_nand_get_fcb_size ; " \"setexpr fcb_sz ${update_nand_fcb} * 2 ; " /* FCB + DBBT */ \"setexpr fw_sz ${update_nand_firmware_maxsz} * 2 ; " \"setexpr fw_off ${fcb_sz} + ${update_nand_firmware_maxsz};" \"nand erase ${fcb_sz} ${fw_sz} ; " \"nand write ${loadaddr} ${fcb_sz} ${filesize} ; " \"nand write ${loadaddr} ${fw_off} ${filesize} ; " \"fi\0" \- "update_sd_firmware=" /* Update the SD firmware partition */ \
"if mmc rescan ; then " \"if tftp ${update_sd_firmware_filename} ; then " \"setexpr fw_sz ${filesize} / 0x200 ; " /* SD block size */ \"setexpr fw_sz ${fw_sz} + 1 ; " \"mmc write ${loadaddr} 0x800 ${fw_sz} ; " \"fi ; " \"fi\0" \- "script=boot.scr\0" \
- "uimage=uImage\0" \
- "console_fsl=ttyAM0\0" \
- "console_mainline=ttyAMA0\0" \
- "console=${console_mainline}\0" \
- "mmcdev=0\0" \
- "mmcpart=2\0" \
- "mmcroot=/dev/mmcblk0p3 rw\0" \
- "mmcrootfstype=ext3 rootwait\0" \
- "mmcargs=setenv bootargs console=${console},${baudrate} " \
"root=${mmcroot} " \"rootfstype=${mmcrootfstype}\0" \- "loadbootscript=" \
"fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \- "bootscript=echo Running bootscript from mmc ...; " \
"source\0" \- "loaduimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${uimage}\0" \
- "mmcboot=echo Booting from mmc ...; " \
"run mmcargs; " \"bootm\0" \- "netargs=setenv bootargs console=ttymxc0,${baudrate} " \ "root=/dev/nfs " \
"ip=dhcp nfsroot=${serverip}:${nfsroot}\0" \- "bootcmd_net=echo Booting from net ...; " \
"run netargs; " \"dhcp ${uimage}; bootm\0" \
"ip=dhcp nfsroot=${serverip}:${nfsroot},v3,tcp\0" \- "netboot=echo Booting from net ...; " \
"run netargs; " \"dhcp ${uimage}; bootm\0"+#define CONFIG_BOOTCOMMAND \
- "if mmc rescan ${mmcdev}; then " \
"if run loadbootscript; then " \"run bootscript; " \"else " \"if run loaduimage; then " \"run mmcboot; " \"else run netboot; " \"fi; " \"fi; " \- "else run netboot; fi"
#endif /* __MX28EVK_CONFIG_H__ */
Best regards, Marek Vasut
Dear Otavio Salvador,
In message 1337115571-14115-3-git-send-email-otavio@ossystems.com.br you wrote:
The environment has been based on mx53loco and m28evk but keeping the possibility to easy change the default console device as Freescale and mainline kernels differ on the device name.
NAK.
I will not acceept this.
Please accept that the configuration of the Freescale boards was done by Freescale and is maintained by freescale, but it is not generally considered to be the best of all possible solutions.
Freescale may use it on their boards if they like. You may use it on your boards if you like.
But I don't want to see this on any boards in my responsibility, because I dislike it.
Please allow that we maintain the M28EVK configuration as we like it.
Thanks.
Best regards,
Wolfgang Denk
Dear Otavio Salvador,
Signed-off-by: Otavio Salvador otavio@ossystems.com.br Cc: Marek Vasut marex@denx.de Cc: Stefano Babic sbabic@denx.de Cc: Wolfgang Denk wd@denx.de
Is this really necessary? I think it's a matter of personal taste, isn't it?
include/configs/m28evk.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/configs/m28evk.h b/include/configs/m28evk.h index 68e46b7..a076aa5 100644 --- a/include/configs/m28evk.h +++ b/include/configs/m28evk.h @@ -88,7 +88,7 @@ #define CONFIG_NR_DRAM_BANKS 1 /* 1 bank of
DRAM */
#define PHYS_SDRAM_1 0x40000000 /* Base address
*/
#define PHYS_SDRAM_1_SIZE 0x20000000 /* Max 512 MB
RAM */
-#define CONFIG_STACKSIZE 0x00010000 /* 128 KB stack
*/
+#define CONFIG_STACKSIZE (128 * 1024) /* 128 KB stack
*/
#define CONFIG_SYS_MALLOC_LEN 0x00400000 /* 4 MB for
malloc */
#define CONFIG_SYS_GBL_DATA_SIZE 128 /* Initial data
*/
#define CONFIG_SYS_MEMTEST_START 0x40000000 /* Memtest start
adr */
Best regards, Marek Vasut
On Tue, May 15, 2012 at 6:14 PM, Marek Vasut marex@denx.de wrote:
Is this really necessary? I think it's a matter of personal taste, isn't it?
It is but you does this kind of style in other part of file so seemed logical to use the same. Since I was looking at the code it seemed good to send it as a style improvement and consolidation.
participants (5)
-
Fabio Estevam -
Marek Vasut -
Otavio Salvador -
Stefano Babic -
Wolfgang Denk