[U-Boot-Users] [PATCH] LOGO: Allow define "LOGO_BMP" to be globally defined.
This allow developers to define per board logo file into main configuration file as follow:
wwpc1100_config : unconfig @$(MKCONFIG) $(@:_config=) arm pxa wwpc1100 @echo "LOGO_BMP = wwpc1100.bmp" >> include/config.mk
Signed-off-by: Rodolfo Giometti giometti@linux.it --- Makefile | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile index 093df4e..c819afb 100644 --- a/Makefile +++ b/Makefile @@ -115,7 +115,7 @@ ifeq ($(OBJTREE)/include/config.mk,$(wildcard $(OBJTREE)/include/config.mk))
# load ARCH, BOARD, and CPU configuration include $(OBJTREE)/include/config.mk -export ARCH CPU BOARD VENDOR SOC +export ARCH CPU BOARD VENDOR SOC LOGO_BMP
ifndef CROSS_COMPILE ifeq ($(HOSTARCH),ppc) @@ -125,7 +125,7 @@ ifeq ($(ARCH),ppc) CROSS_COMPILE = powerpc-linux- endif ifeq ($(ARCH),arm) -CROSS_COMPILE = arm-eurotech-linux- +CROSS_COMPILE = arm-linux- endif ifeq ($(ARCH),i386) ifeq ($(HOSTARCH),i386)
In message 20070525142054.GE4199@enneenne.com you wrote:
This allow developers to define per board logo file into main configuration file as follow:
wwpc1100_config : unconfig @$(MKCONFIG) $(@:_config=) arm pxa wwpc1100 @echo "LOGO_BMP = wwpc1100.bmp" >> include/config.mk
I don't like this. This adds configuration information into Makefile, where it does not belong.
Please don't do this.
--- a/Makefile +++ b/Makefile @@ -115,7 +115,7 @@ ifeq ($(OBJTREE)/include/config.mk,$(wildcard $(OBJTREE)/include/config.mk))
...
@@ -125,7 +125,7 @@ ifeq ($(ARCH),ppc) CROSS_COMPILE = powerpc-linux- endif ifeq ($(ARCH),arm) -CROSS_COMPILE = arm-eurotech-linux-
^^^^^^^^^^^^^^^^^^^ What's that?
+CROSS_COMPILE = arm-linux-
Also, this patch does not apply.
Best regards,
Wolfgang Denk
On Fri, May 25, 2007 at 04:29:13PM +0200, Wolfgang Denk wrote:
In message 20070525142054.GE4199@enneenne.com you wrote:
This allow developers to define per board logo file into main configuration file as follow:
wwpc1100_config : unconfig @$(MKCONFIG) $(@:_config=) arm pxa wwpc1100 @echo "LOGO_BMP = wwpc1100.bmp" >> include/config.mk
I don't like this. This adds configuration information into Makefile, where it does not belong.
Please don't do this.
So where should I add this info?
--- a/Makefile +++ b/Makefile @@ -115,7 +115,7 @@ ifeq ($(OBJTREE)/include/config.mk,$(wildcard $(OBJTREE)/include/config.mk))
...
@@ -125,7 +125,7 @@ ifeq ($(ARCH),ppc) CROSS_COMPILE = powerpc-linux- endif ifeq ($(ARCH),arm) -CROSS_COMPILE = arm-eurotech-linux-
^^^^^^^^^^^^^^^^^^^ What's that?+CROSS_COMPILE = arm-linux-
Also, this patch does not apply.
Ooops! Sorry, that was my fault... :'(
Ciao,
Rodolfo
In message 20070525145413.GG21180@enneenne.com you wrote:
I don't like this. This adds configuration information into Makefile, where it does not belong.
Please don't do this.
So where should I add this info?
In your board config file?
Best regards,
Wolfgang Denk
On Fri, May 25, 2007 at 05:43:49PM +0200, Wolfgang Denk wrote:
In your board config file?
Do you mean "board/*/config.mk" files?
Ciao,
Rodolfo
In message 20070525161545.GJ21180@enneenne.com you wrote:
In your board config file?
Do you mean "board/*/config.mk" files?
No, I mean include/configs/<board>.h
Best regards,
Wolfgang Denk
On Fri, May 25, 2007 at 06:48:29PM +0200, Wolfgang Denk wrote:
In message 20070525161545.GJ21180@enneenne.com you wrote:
In your board config file?
Do you mean "board/*/config.mk" files?
No, I mean include/configs/<board>.h
How I can do that? =:-o
Define LOGO_BMP is used into tools/Makefile to generate file include/bmp_logo.h as follow:
$(LOGO_H): $(obj)bmp_logo $(LOGO_BMP) $(obj)./bmp_logo $(LOGO_BMP) >$@
How I can use it if it must be defined into include/configs/<board>.h?
Ciao,
Rodolfo
participants (3)
-
Rodolfo Giometti -
Rodolfo Giometti -
Wolfgang Denk