[U-Boot-Users] [PATCH v4 0/9] SATA framework and Freescale SATA controller support
Dear Wolfgang,
According to your suggestion, I re-spinned the patch series. The ata_piix driver is only used by x86 sc520_cdp board, I have not the board, so I can not test it. but building/compiling it is passed!
I hope it meet your requirement now. please apply it.
Very thanks, Dave
The following changes since commit 18e69a35efbb078403db0c0063986470dad7d082: Anton Vorontsov (1): 83xx/fdt_support: let user specifiy FSL USB Dual-Role controller role
are available in the git repository at:
git://git.ap.freescale.net/scm/u-boot.git develop
Dave Liu (11): ata: merge the ata_piix driver ata: merge the header of ata_piix driver ata: add the support for SATA framework ata: make the ata_piix driver using new SATA framework ata: add the libata support ata: add the fis struct for SATA ata: enable the sata initialize on boot up ata: add the readme for SATA command line mpc83xx: initialize serdes for MPC837xEMDS boards mpc83xx: enable the SATA interface on mpc837xemds board drivers: add the support for Freescale SATA controller
board/freescale/mpc837xemds/mpc837xemds.c | 33 + common/Makefile | 2 +- common/cmd_sata.c | 766 +++ +-------------------- disk/part.c | 14 + disk/part_dos.c | 2 + disk/part_iso.c | 2 + disk/part_mac.c | 1 + doc/README.sata | 69 +++ drivers/block/Makefile | 2 + drivers/block/ata_piix.c | 572 ++++++++++++++++++- drivers/block/ata_piix.h | 90 +++ drivers/block/fsl_sata.c | 916 ++++++++++++++++++++++ +++++++ drivers/block/fsl_sata.h | 374 ++++++++++++ drivers/block/libata.c | 158 +++++ include/configs/MPC837XEMDS.h | 28 + include/configs/sc520_cdp.h | 27 +- include/fis.h | 156 +++++ include/libata.h | 205 +++++++ include/part.h | 3 + include/sata.h | 112 +---- lib_ppc/board.c | 8 + 21 files changed, 2751 insertions(+), 789 deletions(-) create mode 100644 doc/README.sata create mode 100644 drivers/block/ata_piix.h create mode 100644 drivers/block/fsl_sata.c create mode 100644 drivers/block/fsl_sata.h create mode 100644 drivers/block/libata.c create mode 100644 include/fis.h create mode 100644 include/libata.h
Dear Dave,
in message 1206542761.3662.51.camel@localhost.localdomain you wrote:
According to your suggestion, I re-spinned the patch series. The ata_piix driver is only used by x86 sc520_cdp board, I have not the board, so I can not test it. but building/compiling it is passed!
Understood.
I hope it meet your requirement now. please apply it.
I will apply it so we make some progress, but please see comments below.
Dave Liu (11): ata: merge the ata_piix driver ata: merge the header of ata_piix driver ata: add the support for SATA framework ata: make the ata_piix driver using new SATA framework ata: add the libata support ata: add the fis struct for SATA ata: enable the sata initialize on boot up ata: add the readme for SATA command line mpc83xx: initialize serdes for MPC837xEMDS boards mpc83xx: enable the SATA interface on mpc837xemds board drivers: add the support for Freescale SATA controller
Applied, but please provide new (incremental) patches to fix the following remaining issues:
doc/README.sata:
Please apply Jerry Van Baren's "proposed English polishing."
drivers/block/ata_piix.h:
Please add a file header which contains appropriate copyright and license information.
Also, please make the file idempotent.
Also, please change format strings like "49==0x%04x" into "49=0x%04x" or "49 = 0x%04x" or (IMHO best) "49 = %04X". Please do this globally (some other files, too).
drivers/block/fsl_sata.c:
Generic S-ATA code like ata_low_level_rw_lba48(), ata_low_level_rw_lba28(), sata_read(), sata_write(), or scan_sata() is in no way FSL-specific and thus has no place in fsl_sata.c; please move this into a separate file.
I think it would be kind of funny if the sc520 board will only compile when fsl_sata.c is included.
Thanks!
Best regards,
Wolfgang Denk
Dear Wolfgang,
I have to use the stupid webmail now, sorry for that.
<snip>
Applied, but please provide new (incremental) patches to fix the following remaining issues:
[dave] Thank you very much, I will do that.
drivers/block/ata_piix.h:
Please add a file header which contains appropriate copyright and license information.
[dave] The original include/sata.h has *not* any copyright and license info in it. so I don't know how to handle it. can I copy the ata_piix.c's copyright to ata_piix.h?
Thanks, Dave
Applied, but please provide new (incremental) patches to fix the following remaining issues:
doc/README.sata:
Please apply Jerry Van Baren's "proposed English polishing."
done.
drivers/block/ata_piix.h:
Please add a file header which contains appropriate copyright and license information.
The original include/sata.h have *not* any copyright and license information, I think it is better to keep the original state. so, I don't add the copyright/license info to ata_piix.h
Also, please make the file idempotent. Also, please change format strings like "49==0x%04x" into "49=0x%04x" or "49 = 0x%04x" or (IMHO best) "49 = %04X". Please do this globally (some other files, too).
done.
drivers/block/fsl_sata.c:
Generic S-ATA code like ata_low_level_rw_lba48(), ata_low_level_rw_lba28(), sata_read(), sata_write(), or scan_sata() is in no way FSL-specific and thus has no place in fsl_sata.c; please move this into a separate file.
I will do it in next day.
Thanks, Dave
participants (3)
-
Dave Liu -
Liu Dave -
Wolfgang Denk