On Thu, 2006-12-07 at 23:08 +0100, Joakim Tjernlund wrote:

...

-----Original Message----- From: u-boot-users-bounces@lists.sourceforge.net [mailto:u-boot-users-bounces@lists.sourceforge.net] On Behalf Of Ben Warren Sent: den 7 december 2006 22:56 To: uboot Subject: [U-Boot-Users] MPC83xx SPI driver

Hello,

I'm ready to re-submit a hard SPI driver for some members of the MPC83xx family of CPUs, but am unsure where to put it. While designed for the MPC834x chips, it should also work with the upcoming MPC8313, if the online datasheet is accurate. The other 83xx chips handle SPI with a CPM, so this driver won't work there. Should I put it in cpu/mpc83xx/, drivers/, or somewhere else? And given the unusual chip compatibilities, what should the file be called?

Suggestions?

Does it work on a 8321 in QUICC mode? If so then cpu/mpc83xx/qe_spi.c perhaps?

Jocke

Doubtful, since the 834x and 8313 don't have QUICC engines. While the control registers appear to be common among all 83xx chips, on these ones transmit and receive are handled by dedicated 32-bit registers rather than the RAM-based descriptor types found in CPMs.

regards, Ben

On Thu, 7 Dec 2006 16:24:48 -0600 Kumar Gala galak@kernel.crashing.org wrote:

On Dec 7, 2006, at 4:08 PM, Joakim Tjernlund wrote:

...

...

cpu/mpc83xx/, drivers/, or somewhere else? And given the unusual chip compatibilities, what should the file be called?

Suggestions?

Does it work on a 8321 in QUICC mode? If so then cpu/mpc83xx/ qe_spi.c perhaps?

QE drivers should be drivers/ as well since QE will be on 83xx and 85xx.

• k

to be specific, the qe driver should belong in drivers/qe/spi.c, and the non-qe driver should be something like drivers/fsl_spi.c.

Kim