[PATCH 1/2] mmc: sdhci: Use debug for not supported SDMA info message
From: Matthias Brugger mbrugger@suse.com
If CONFIG_MMC_SDHCI_SDMA is enabled but the HW could not support it, we no longer error out. Instead we do not enable it in the host. Change the output from printf to debug as this isn't an error but only additional information now.
Signed-off-by: Matthias Brugger mbrugger@suse.com ---
drivers/mmc/sdhci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c index 6e8f6e3d17..8bb4393ce1 100644 --- a/drivers/mmc/sdhci.c +++ b/drivers/mmc/sdhci.c @@ -744,8 +744,8 @@ int sdhci_setup_cfg(struct mmc_config *cfg, struct sdhci_host *host, if ((caps & SDHCI_CAN_DO_SDMA)) { host->flags |= USE_SDMA; } else { - printf("%s: Your controller doesn't support SDMA!!\n", - __func__); + debug("%s: Your controller doesn't support SDMA!!\n", + __func__); } #endif #if CONFIG_IS_ENABLED(MMC_SDHCI_ADMA)
From: Matthias Brugger mbrugger@suse.com
RPi4 supports SDMA on it's SDHCI controller. Enable to option for the combine RPi3/4 config.
Signed-off-by: Matthias Brugger mbrugger@suse.com
---
configs/rpi_arm64_defconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/configs/rpi_arm64_defconfig b/configs/rpi_arm64_defconfig index b9bb083a1d..66c4a5368c 100644 --- a/configs/rpi_arm64_defconfig +++ b/configs/rpi_arm64_defconfig @@ -23,6 +23,7 @@ CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y CONFIG_DM_KEYBOARD=y CONFIG_DM_MMC=y CONFIG_MMC_SDHCI=y +CONFIG_MMC_SDHCI_SDMA=y CONFIG_MMC_SDHCI_BCM2835=y CONFIG_DM_ETH=y CONFIG_BCMGENET=y
Subject: [PATCH 2/2] configs: rpi_arm64: enable SDHCI SDMA support
From: Matthias Brugger mbrugger@suse.com
RPi4 supports SDMA on it's SDHCI controller. Enable to option for the combine RPi3/4 config.
Signed-off-by: Matthias Brugger mbrugger@suse.com
configs/rpi_arm64_defconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/configs/rpi_arm64_defconfig b/configs/rpi_arm64_defconfig index b9bb083a1d..66c4a5368c 100644 --- a/configs/rpi_arm64_defconfig +++ b/configs/rpi_arm64_defconfig @@ -23,6 +23,7 @@ CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y CONFIG_DM_KEYBOARD=y CONFIG_DM_MMC=y CONFIG_MMC_SDHCI=y +CONFIG_MMC_SDHCI_SDMA=y CONFIG_MMC_SDHCI_BCM2835=y CONFIG_DM_ETH=y CONFIG_BCMGENET=y
Reviewed-by: Peng Fan peng.fan@nxp.com
On 12/05/2020 12:02, matthias.bgg@kernel.org wrote:
From: Matthias Brugger mbrugger@suse.com
RPi4 supports SDMA on it's SDHCI controller. Enable to option for the combine RPi3/4 config.
Signed-off-by: Matthias Brugger mbrugger@suse.com
Queued for rpi-next
configs/rpi_arm64_defconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/configs/rpi_arm64_defconfig b/configs/rpi_arm64_defconfig index b9bb083a1d..66c4a5368c 100644 --- a/configs/rpi_arm64_defconfig +++ b/configs/rpi_arm64_defconfig @@ -23,6 +23,7 @@ CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y CONFIG_DM_KEYBOARD=y CONFIG_DM_MMC=y CONFIG_MMC_SDHCI=y +CONFIG_MMC_SDHCI_SDMA=y CONFIG_MMC_SDHCI_BCM2835=y CONFIG_DM_ETH=y CONFIG_BCMGENET=y
Subject: [PATCH 1/2] mmc: sdhci: Use debug for not supported SDMA info message
From: Matthias Brugger mbrugger@suse.com
If CONFIG_MMC_SDHCI_SDMA is enabled but the HW could not support it, we no longer error out. Instead we do not enable it in the host. Change the output from printf to debug as this isn't an error but only additional information now.
Signed-off-by: Matthias Brugger mbrugger@suse.com
drivers/mmc/sdhci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c index 6e8f6e3d17..8bb4393ce1 100644 --- a/drivers/mmc/sdhci.c +++ b/drivers/mmc/sdhci.c @@ -744,8 +744,8 @@ int sdhci_setup_cfg(struct mmc_config *cfg, struct sdhci_host *host, if ((caps & SDHCI_CAN_DO_SDMA)) { host->flags |= USE_SDMA; } else {
printf("%s: Your controller doesn't support SDMA!!\n",__func__);
debug("%s: Your controller doesn't support SDMA!!\n",__func__);#endif
#if CONFIG_IS_ENABLED(MMC_SDHCI_ADMA)
Reviewed-by: Peng Fan peng.fan@nxp.com
On 12/05/2020 12:02, matthias.bgg@kernel.org wrote:
From: Matthias Brugger mbrugger@suse.com
If CONFIG_MMC_SDHCI_SDMA is enabled but the HW could not support it, we no longer error out. Instead we do not enable it in the host. Change the output from printf to debug as this isn't an error but only additional information now.
Signed-off-by: Matthias Brugger mbrugger@suse.com
Queued for rpi-next
drivers/mmc/sdhci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c index 6e8f6e3d17..8bb4393ce1 100644 --- a/drivers/mmc/sdhci.c +++ b/drivers/mmc/sdhci.c @@ -744,8 +744,8 @@ int sdhci_setup_cfg(struct mmc_config *cfg, struct sdhci_host *host, if ((caps & SDHCI_CAN_DO_SDMA)) { host->flags |= USE_SDMA; } else {
printf("%s: Your controller doesn't support SDMA!!\n",__func__);
debug("%s: Your controller doesn't support SDMA!!\n",__func__);#endif #if CONFIG_IS_ENABLED(MMC_SDHCI_ADMA)
participants (3)
-
Matthias Brugger -
matthias.bgg＠kernel.org -
Peng Fan