[U-Boot] [PATCH v1] x86: acpi: Remove redundant Offset (0x00)
New ACPI assembler issues a warning:
board/intel/edison/dsdt.asl.tmp 13: Offset (0x00), Remark 2158 - ^ Unnecessary/redundant use of Offset operator
Indeed, in the OperationRegion the offset is 0x00 by default.
Thus, drop unneeded Offset() use as suggested by ACPI assembler.
Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com --- arch/x86/include/asm/arch-baytrail/acpi/global_nvs.asl | 1 - arch/x86/include/asm/arch-quark/acpi/global_nvs.asl | 1 - arch/x86/include/asm/arch-tangier/acpi/global_nvs.asl | 1 - 3 files changed, 3 deletions(-)
diff --git a/arch/x86/include/asm/arch-baytrail/acpi/global_nvs.asl b/arch/x86/include/asm/arch-baytrail/acpi/global_nvs.asl index 9b8d1895ee..aaf87f4735 100644 --- a/arch/x86/include/asm/arch-baytrail/acpi/global_nvs.asl +++ b/arch/x86/include/asm/arch-baytrail/acpi/global_nvs.asl @@ -8,7 +8,6 @@ OperationRegion(GNVS, SystemMemory, ACPI_GNVS_ADDR, ACPI_GNVS_SIZE) Field(GNVS, ByteAcc, NoLock, Preserve) { - Offset (0x00), PCNT, 8, /* processor count */ IURE, 8, /* internal UART enabled */ } diff --git a/arch/x86/include/asm/arch-quark/acpi/global_nvs.asl b/arch/x86/include/asm/arch-quark/acpi/global_nvs.asl index 44b9f12c7c..61602173f8 100644 --- a/arch/x86/include/asm/arch-quark/acpi/global_nvs.asl +++ b/arch/x86/include/asm/arch-quark/acpi/global_nvs.asl @@ -8,6 +8,5 @@ OperationRegion(GNVS, SystemMemory, ACPI_GNVS_ADDR, ACPI_GNVS_SIZE) Field(GNVS, ByteAcc, NoLock, Preserve) { - Offset (0x00), PCNT, 8, /* processor count */ } diff --git a/arch/x86/include/asm/arch-tangier/acpi/global_nvs.asl b/arch/x86/include/asm/arch-tangier/acpi/global_nvs.asl index a6296c2cb6..895b807e96 100644 --- a/arch/x86/include/asm/arch-tangier/acpi/global_nvs.asl +++ b/arch/x86/include/asm/arch-tangier/acpi/global_nvs.asl @@ -10,6 +10,5 @@ OperationRegion(GNVS, SystemMemory, ACPI_GNVS_ADDR, ACPI_GNVS_SIZE) Field(GNVS, ByteAcc, NoLock, Preserve) { - Offset (0x00), PCNT, 8, /* processor count */ }
On Wed, Oct 31, 2018 at 7:14 PM Andy Shevchenko andriy.shevchenko@linux.intel.com wrote:
New ACPI assembler issues a warning:
board/intel/edison/dsdt.asl.tmp 13: Offset (0x00), Remark 2158 - ^ Unnecessary/redundant use of Offset operator
Indeed, in the OperationRegion the offset is 0x00 by default.
Thus, drop unneeded Offset() use as suggested by ACPI assembler.
Would be nice to have this in the release, since till now it produces the only warning at least in my case.
Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com
arch/x86/include/asm/arch-baytrail/acpi/global_nvs.asl | 1 - arch/x86/include/asm/arch-quark/acpi/global_nvs.asl | 1 - arch/x86/include/asm/arch-tangier/acpi/global_nvs.asl | 1 - 3 files changed, 3 deletions(-)
diff --git a/arch/x86/include/asm/arch-baytrail/acpi/global_nvs.asl b/arch/x86/include/asm/arch-baytrail/acpi/global_nvs.asl index 9b8d1895ee..aaf87f4735 100644 --- a/arch/x86/include/asm/arch-baytrail/acpi/global_nvs.asl +++ b/arch/x86/include/asm/arch-baytrail/acpi/global_nvs.asl @@ -8,7 +8,6 @@ OperationRegion(GNVS, SystemMemory, ACPI_GNVS_ADDR, ACPI_GNVS_SIZE) Field(GNVS, ByteAcc, NoLock, Preserve) {
Offset (0x00), PCNT, 8, /* processor count */ IURE, 8, /* internal UART enabled */} diff --git a/arch/x86/include/asm/arch-quark/acpi/global_nvs.asl b/arch/x86/include/asm/arch-quark/acpi/global_nvs.asl index 44b9f12c7c..61602173f8 100644 --- a/arch/x86/include/asm/arch-quark/acpi/global_nvs.asl +++ b/arch/x86/include/asm/arch-quark/acpi/global_nvs.asl @@ -8,6 +8,5 @@ OperationRegion(GNVS, SystemMemory, ACPI_GNVS_ADDR, ACPI_GNVS_SIZE) Field(GNVS, ByteAcc, NoLock, Preserve) {
Offset (0x00), PCNT, 8, /* processor count */} diff --git a/arch/x86/include/asm/arch-tangier/acpi/global_nvs.asl b/arch/x86/include/asm/arch-tangier/acpi/global_nvs.asl index a6296c2cb6..895b807e96 100644 --- a/arch/x86/include/asm/arch-tangier/acpi/global_nvs.asl +++ b/arch/x86/include/asm/arch-tangier/acpi/global_nvs.asl @@ -10,6 +10,5 @@ OperationRegion(GNVS, SystemMemory, ACPI_GNVS_ADDR, ACPI_GNVS_SIZE) Field(GNVS, ByteAcc, NoLock, Preserve) {
- Offset (0x00), PCNT, 8, /* processor count */
}
2.19.1
U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
On Thu, Nov 1, 2018 at 1:14 AM Andy Shevchenko andriy.shevchenko@linux.intel.com wrote:
New ACPI assembler issues a warning:
board/intel/edison/dsdt.asl.tmp 13: Offset (0x00), Remark 2158 - ^ Unnecessary/redundant use of Offset operator
Indeed, in the OperationRegion the offset is 0x00 by default.
Thus, drop unneeded Offset() use as suggested by ACPI assembler.
Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com
arch/x86/include/asm/arch-baytrail/acpi/global_nvs.asl | 1 - arch/x86/include/asm/arch-quark/acpi/global_nvs.asl | 1 - arch/x86/include/asm/arch-tangier/acpi/global_nvs.asl | 1 - 3 files changed, 3 deletions(-)
Reviewed-by: Bin Meng bmeng.cn@gmail.com
On Tue, Nov 6, 2018 at 1:33 PM Bin Meng bmeng.cn@gmail.com wrote:
On Thu, Nov 1, 2018 at 1:14 AM Andy Shevchenko andriy.shevchenko@linux.intel.com wrote:
New ACPI assembler issues a warning:
board/intel/edison/dsdt.asl.tmp 13: Offset (0x00), Remark 2158 - ^ Unnecessary/redundant use of Offset operator
Indeed, in the OperationRegion the offset is 0x00 by default.
Thus, drop unneeded Offset() use as suggested by ACPI assembler.
Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com
arch/x86/include/asm/arch-baytrail/acpi/global_nvs.asl | 1 - arch/x86/include/asm/arch-quark/acpi/global_nvs.asl | 1 - arch/x86/include/asm/arch-tangier/acpi/global_nvs.asl | 1 - 3 files changed, 3 deletions(-)
Reviewed-by: Bin Meng bmeng.cn@gmail.com
applied to u-boot-x86, thanks!
participants (3)
-
Andy Shevchenko -
Andy Shevchenko -
Bin Meng