[U-Boot] how to create patches for mailing

Hi!
I want to add a new board support to u-boot. So I did the following:
1) git clone git://git.denx.de/u-boot.git u-boot-dev 2) modified existing files, added new 3) built the tree for my board, beagle and overo - OK 4) git format-patch - nothing happens
are there any step by step instructions how to create and submit patches to u-boot mail-list? Reading this http://www.denx.de/wiki/view/U-Boot/Patchesdoes not give sufficient comprehension how to do it..
I appreciate any comments..

On Thu, Jan 24, 2013 at 13:10:56, Maxim Podbereznyy wrote:
Hi!
I want to add a new board support to u-boot. So I did the following:
- git clone git://git.denx.de/u-boot.git u-boot-dev
- modified existing files, added new
Use "git commit" to commit your changes to tree
- built the tree for my board, beagle and overo - OK
- git format-patch - nothing happens
git-format-patch -M --signoff --stat -p --raw -n -3 --cover-letter
-3 == generate patches for 1st 3 patch -n = use n/n style --cover-letter == Generate Cover letter (0/n patch)
are there any step by step instructions how to create and submit patches to u-boot mail-list?
Use git-send-email to send patches
git-send-email --to ' u-boot@lists.denx.de' --cc 'maintainers@email.id' --cc 'related_developer@email.id' --cc 'self_for_reference@email.id' --suppress-cc=all <required-patches>
Reading this http://www.denx.de/wiki/view/U-Boot/Patchesdoes not give sufficient comprehension how to do it..
I appreciate any comments..
Regards, Gururaja

Hi Gururaja!
Your instructions are exceptional! However I have a few questions: 1) why should I generate patches for 1st 3 patch, because I have only one? 2) if there are 3 patches (only 1 is mine) + a cover which exactly <required-patches> should I send?
thanks!
2013/1/24 Hebbar, Gururaja gururaja.hebbar@ti.com
On Thu, Jan 24, 2013 at 13:10:56, Maxim Podbereznyy wrote:
Hi!
I want to add a new board support to u-boot. So I did the following:
- git clone git://git.denx.de/u-boot.git u-boot-dev
- modified existing files, added new
Use "git commit" to commit your changes to tree
- built the tree for my board, beagle and overo - OK
- git format-patch - nothing happens
git-format-patch -M --signoff --stat -p --raw -n -3 --cover-letter
-3 == generate patches for 1st 3 patch -n = use n/n style --cover-letter == Generate Cover letter (0/n patch)
are there any step by step instructions how to create and submit patches
to
u-boot mail-list?
Use git-send-email to send patches
git-send-email --to ' u-boot@lists.denx.de' --cc 'maintainers@email.id' --cc 'related_developer@email.id' --cc 'self_for_reference@email.id' --suppress-cc=all <required-patches>
Reading this http://www.denx.de/wiki/view/U-Boot/Patchesdoes not give sufficient comprehension how to do it..
I appreciate any comments..
Regards, Gururaja

On Thu, Jan 24, 2013 at 13:51:30, Maxim Podbereznyy wrote:
Hi Gururaja!
1st don’t top-most. It breaks the flow.
Your instructions are exceptional! However I have a few questions:
- why should I generate patches for 1st 3 patch, because I have only
one?
That was just an example.
- if there are 3 patches (only 1 is mine) + a cover which exactly
<required-patches> should I send?
If you have one patch, then only 1 patch should be sent. Cover-letter normally is for new feature addition/improvement which involves lots of files & platforms.
Normal fix/correction doesn’t require a cover-letter.
thanks!
2013/1/24 Hebbar, Gururaja gururaja.hebbar@ti.com
On Thu, Jan 24, 2013 at 13:10:56, Maxim Podbereznyy wrote:
Hi!
I want to add a new board support to u-boot. So I did the
following:
- git clone git://git.denx.de/u-boot.git u-boot-dev
- modified existing files, added new
Use "git commit" to commit your changes to tree
- built the tree for my board, beagle and overo - OK
- git format-patch - nothing happens
git-format-patch -M --signoff --stat -p --raw -n -3 --cover-letter
-3 == generate patches for 1st 3 patch -n = use n/n style --cover-letter == Generate Cover letter (0/n patch)
are there any step by step instructions how to create and
submit patches to
u-boot mail-list?
Use git-send-email to send patches
git-send-email --to ' u-boot@lists.denx.de' --cc 'maintainers@email.id' --cc 'related_developer@email.id' --cc 'self_for_reference@email.id' --suppress-cc=all <required-patches>
Reading this http://www.denx.de/wiki/view/U-Boot/Patchesdoes not give
sufficient
comprehension how to do it..
I appreciate any comments..
Regards, Gururaja
Regards, Gururaja

Hi Maxim,
Le Thu, 24 Jan 2013 12:21:30 +0400, Maxim Podbereznyy lisarden@gmail.com a écrit :
Your instructions are exceptional! However I have a few questions:
- why should I generate patches for 1st 3 patch, because I have only one?
- if there are 3 patches (only 1 is mine) + a cover which exactly
<required-patches> should I send?
you have more details here : http://www.denx.de/wiki/U-Boot/Patches
Eric
participants (3)
-
Eric Bénard
-
Hebbar, Gururaja
-
Maxim Podbereznyy