[U-Boot] [PATCH 0/2] socfpga/spl: Cleanup

Cleanups for SPL/socfpga.
Cc: Dinh Nguyen dinguyen@altera.com
Vikram Narayanan (2): arm/socfpga: Remove timer_init from spl_board_init socfpga/spl: Remove malloc.h
arch/arm/cpu/armv7/socfpga/spl.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-)

Timer is initialized already in board_init_r function in (common/spl/spl.c) No need to initialize it again
Signed-off-by: Vikram Narayanan vikram186@gmail.com Cc: Dinh Nguyen dinguyen@altera.com --- arch/arm/cpu/armv7/socfpga/spl.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/arch/arm/cpu/armv7/socfpga/spl.c b/arch/arm/cpu/armv7/socfpga/spl.c index 944238b..23053fd 100644 --- a/arch/arm/cpu/armv7/socfpga/spl.c +++ b/arch/arm/cpu/armv7/socfpga/spl.c @@ -37,9 +37,6 @@ u32 spl_boot_device(void) */ void spl_board_init(void) { - /* init timer for enabling delay function */ - timer_init(); - /* de-assert reset for peripherals and bridges based on handoff */ reset_deassert_peripherals_handoff();

Hi Vikram,
On Tue, 23 Oct 2012 15:51:16 +0530, Vikram Narayanan vikram186@gmail.com wrote:
Timer is initialized already in board_init_r function in (common/spl/spl.c) No need to initialize it again
Signed-off-by: Vikram Narayanan vikram186@gmail.com Cc: Dinh Nguyen dinguyen@altera.com
arch/arm/cpu/armv7/socfpga/spl.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/arch/arm/cpu/armv7/socfpga/spl.c b/arch/arm/cpu/armv7/socfpga/spl.c index 944238b..23053fd 100644 --- a/arch/arm/cpu/armv7/socfpga/spl.c +++ b/arch/arm/cpu/armv7/socfpga/spl.c @@ -37,9 +37,6 @@ u32 spl_boot_device(void) */ void spl_board_init(void) {
- /* init timer for enabling delay function */
- timer_init();
- /* de-assert reset for peripherals and bridges based on handoff */ reset_deassert_peripherals_handoff();
Applied to u-boot-arm/master, thanks!
Amicalement,

Remove unused header
Signed-off-by: Vikram Narayanan vikram186@gmail.com --- arch/arm/cpu/armv7/socfpga/spl.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/arm/cpu/armv7/socfpga/spl.c b/arch/arm/cpu/armv7/socfpga/spl.c index 23053fd..84216eb 100644 --- a/arch/arm/cpu/armv7/socfpga/spl.c +++ b/arch/arm/cpu/armv7/socfpga/spl.c @@ -21,7 +21,6 @@ #include <asm/utils.h> #include <version.h> #include <image.h> -#include <malloc.h> #include <asm/arch/reset_manager.h> #include <spl.h>

Hi Vikram,
On Tue, 23 Oct 2012 15:52:53 +0530, Vikram Narayanan vikram186@gmail.com wrote:
Remove unused header
Signed-off-by: Vikram Narayanan vikram186@gmail.com
arch/arm/cpu/armv7/socfpga/spl.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/arm/cpu/armv7/socfpga/spl.c b/arch/arm/cpu/armv7/socfpga/spl.c index 23053fd..84216eb 100644 --- a/arch/arm/cpu/armv7/socfpga/spl.c +++ b/arch/arm/cpu/armv7/socfpga/spl.c @@ -21,7 +21,6 @@ #include <asm/utils.h> #include <version.h> #include <image.h> -#include <malloc.h> #include <asm/arch/reset_manager.h> #include <spl.h>
Note: this was applied to u-boot-arm/master along with 1/2.
Amicalement,

Hi Vikram,
On Tue, 2012-10-23 at 15:49 +0530, Vikram Narayanan wrote:
Cleanups for SPL/socfpga.
Cc: Dinh Nguyen dinguyen@altera.com
Vikram Narayanan (2): arm/socfpga: Remove timer_init from spl_board_init socfpga/spl: Remove malloc.h
Do you need to split up the patches? Otherwise,
Acked-by: Dinh Nguyen dinguyen@altera.com
Dinh
arch/arm/cpu/armv7/socfpga/spl.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-)

On Tue 2012-10-23 10:27:41, Dinh Nguyen wrote:
Hi Vikram,
On Tue, 2012-10-23 at 15:49 +0530, Vikram Narayanan wrote:
Cleanups for SPL/socfpga.
Cc: Dinh Nguyen dinguyen@altera.com
Vikram Narayanan (2): arm/socfpga: Remove timer_init from spl_board_init socfpga/spl: Remove malloc.h
Do you need to split up the patches? Otherwise,
Acked-by: Dinh Nguyen dinguyen@altera.com
The patches are single-(functional)-line each, I think they are split up pretty perfectly.
Acked-by: Pavel Machek pavel@denx.de Pavel
participants (4)
-
Albert ARIBAUD
-
Dinh Nguyen
-
Pavel Machek
-
Vikram Narayanan