Alex BASTOS wrote:

Thanks Alex,

Txema,

...

Does anybody test the cfi flash driver (cfi_flash.c) with a x8/x16 flash configured in x8 mode ? I'm trying to port U-Boot for a Lite5200B with a S29GL128N flash (CFI compliant) using the cfi flash driver. U-Boot detects the flash correctly but It's unable to erase or write the flash. In my case the following patch fix the bug but I'm not completly sure If It's only a bug with my configuration. Any suggestions? Could anybody test the patch in other architecture?

I think your topic is very similar to this recent one:

http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/19970

OK, I've checked it.

and previous similar patches have been submited and are still pending (but it seems they are coming, read the whole thread)

But not the patch that Wolfgang proposed, isn'it?

So, yes, til now cfi_flash didn't support x8 mode for AMD chips, but it will.

Best regards,

Alex BASTOS

I think the patch that Wolfgang proposed could be like that. I've tested it with a S29GL128N x8/x16 in x8 mode. It works fine. But I have no idea what would happen in x16 mode or others modes. I haven't the hardware to check it.

--- ../tmp/u-boot/drivers/cfi_flash.c 2006-01-12 12:22:08.000000000 +0100 +++ drivers/cfi_flash.c 2006-01-12 17:21:19.000000000 +0100 @@ -107,9 +107,10 @@

#define AMD_STATUS_TOGGLE 0x40 #define AMD_STATUS_ERROR 0x20 -#define AMD_ADDR_ERASE_START 0x555 -#define AMD_ADDR_START 0x555 -#define AMD_ADDR_ACK 0x2AA + +#define AMD_ADDR_ERASE_START (0xAAA >> (info->portwidth-1)) +#define AMD_ADDR_START (0xAAA >> (info->portwidth-1)) +#define AMD_ADDR_ACK (0x555 >> (info->portwidth-1))

#define FLASH_OFFSET_CFI 0x55 #define FLASH_OFFSET_CFI_RESP 0x10

Best regards, Jose Maria Lopez.