[U-Boot] [PATCH] universal_c210: check the NULL pointer when get the PMIC

PMIC 2.0 require to test return pointer from pmic_get()
Signed-off-by: Minkyu Kang mk7.kang@samsung.com Cc: Lukasz Majewski l.majewski@samsung.com Cc: Wolfgang Denk wd@denx.de --- board/samsung/universal_c210/universal.c | 6 ++++++ 1 file changed, 6 insertions(+)
diff --git a/board/samsung/universal_c210/universal.c b/board/samsung/universal_c210/universal.c index 4869798..ae24469 100644 --- a/board/samsung/universal_c210/universal.c +++ b/board/samsung/universal_c210/universal.c @@ -343,6 +343,9 @@ static void init_pmic_lcd(void)
struct pmic *p = pmic_get("MAX8998_PMIC");
+ if (!p) + return -ENODEV; + if (pmic_probe(p)) return;
@@ -434,6 +437,9 @@ static void lcd_power_on(void) { struct pmic *p = pmic_get("MAX8998_PMIC");
+ if (!p) + return -ENODEV; + if (pmic_probe(p)) return;

PMIC 2.0 require to test return pointer from pmic_get()
Signed-off-by: Minkyu Kang mk7.kang@samsung.com Cc: Lukasz Majewski l.majewski@samsung.com Cc: Wolfgang Denk wd@denx.de --- Changes in V2: - Since functions are void type, remove the return value.
board/samsung/universal_c210/universal.c | 6 ++++++ 1 file changed, 6 insertions(+)
diff --git a/board/samsung/universal_c210/universal.c b/board/samsung/universal_c210/universal.c index 4869798..e742707 100644 --- a/board/samsung/universal_c210/universal.c +++ b/board/samsung/universal_c210/universal.c @@ -343,6 +343,9 @@ static void init_pmic_lcd(void)
struct pmic *p = pmic_get("MAX8998_PMIC");
+ if (!p) + return; + if (pmic_probe(p)) return;
@@ -434,6 +437,9 @@ static void lcd_power_on(void) { struct pmic *p = pmic_get("MAX8998_PMIC");
+ if (!p) + return; + if (pmic_probe(p)) return;

Hi Minkyu,
PMIC 2.0 require to test return pointer from pmic_get()
Signed-off-by: Minkyu Kang mk7.kang@samsung.com Cc: Lukasz Majewski l.majewski@samsung.com Cc: Wolfgang Denk wd@denx.de
Changes in V2:
- Since functions are void type, remove the return value.
board/samsung/universal_c210/universal.c | 6 ++++++ 1 file changed, 6 insertions(+)
diff --git a/board/samsung/universal_c210/universal.c b/board/samsung/universal_c210/universal.c index 4869798..e742707 100644 --- a/board/samsung/universal_c210/universal.c +++ b/board/samsung/universal_c210/universal.c @@ -343,6 +343,9 @@ static void init_pmic_lcd(void)
struct pmic *p = pmic_get("MAX8998_PMIC");
- if (!p)
return;
- if (pmic_probe(p)) return;
@@ -434,6 +437,9 @@ static void lcd_power_on(void) { struct pmic *p = pmic_get("MAX8998_PMIC");
- if (!p)
return;
- if (pmic_probe(p)) return;
Acked-by: Lukasz Majewski l.majewski@samsung.com

On 11/12/12 16:57, Lukasz Majewski wrote:
Hi Minkyu,
PMIC 2.0 require to test return pointer from pmic_get()
Signed-off-by: Minkyu Kang mk7.kang@samsung.com Cc: Lukasz Majewski l.majewski@samsung.com Cc: Wolfgang Denk wd@denx.de
Changes in V2:
- Since functions are void type, remove the return value.
board/samsung/universal_c210/universal.c | 6 ++++++ 1 file changed, 6 insertions(+)
applied to u-boot-samsung/resolve.
Thanks. Minkyu Kang.
participants (2)
-
Lukasz Majewski
-
Minkyu Kang