[U-Boot] [PULL] u-boot-usb/master

The following changes since commit fa8883a1e39a20e72aaa5093af0c80062cb95757:
Merge branch 'master' of git://git.denx.de/u-boot-i2c (2015-11-27 08:41:03 -0500)
are available in the git repository at:
git://git.denx.de/u-boot-usb.git
for you to fetch changes up to b5c6f21bf9761f12b43dfc652e5635ab8ec0d7c2:
drivers:usb:fsl: Add T4080 as affected soc for Erratum A007792 sw workaround (2015-11-30 13:33:22 +0100)
---------------------------------------------------------------- Alexey Brodkin (1): usb: add support for generic EHCI devices
Felipe Balbi (2): usb: host: xhci-omap: fix build break usb: dwc3: fix build warnings
Rajesh Bhagat (1): drivers:usb:fsl: Add T4080 as affected soc for Erratum A007792 sw workaround
Siva Durga Prasad Paladugu (2): usb: zynqmp: Add XHCI driver support usb: zynqmp: Enable USB XHCI support
drivers/usb/dwc3/core.c | 2 +- drivers/usb/dwc3/dwc3-omap.c | 2 +- drivers/usb/host/Kconfig | 7 +++++ drivers/usb/host/Makefile | 2 ++ drivers/usb/host/ehci-generic.c | 51 +++++++++++++++++++++++++++++++++++++ drivers/usb/host/xhci-omap.c | 2 +- drivers/usb/host/xhci-zynqmp.c | 143 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ include/configs/xilinx_zynqmp.h | 8 ++++++ include/configs/xilinx_zynqmp_ep.h | 2 ++ include/fsl_usb.h | 1 + 10 files changed, 217 insertions(+), 3 deletions(-) create mode 100644 drivers/usb/host/ehci-generic.c create mode 100644 drivers/usb/host/xhci-zynqmp.c

On Mon, Nov 30, 2015 at 01:33:56PM +0100, Marek Vasut wrote:
The following changes since commit fa8883a1e39a20e72aaa5093af0c80062cb95757:
Merge branch 'master' of git://git.denx.de/u-boot-i2c (2015-11-27 08:41:03 -0500)
are available in the git repository at:
git://git.denx.de/u-boot-usb.git
for you to fetch changes up to b5c6f21bf9761f12b43dfc652e5635ab8ec0d7c2:
drivers:usb:fsl: Add T4080 as affected soc for Erratum A007792 sw workaround (2015-11-30 13:33:22 +0100)
NAK: +(CSQ_CS908,Linksprite_pcDuino,Cubieboard,Lamobo_R1,Mele_A1000,Mele_A1000G_quad,i12-tvbo x,mk802_a10s,Wobo_i5,Auxtek-T004,Auxtek-T003,mk802,Linksprite_pcDuino3_Nano,A10-OLinuXin o-Lime,Hummingbird_A31,Linksprite_pcDuino3,A20-OLinuXino_MICRO,A20-OLinuXino-Lime,r7-tv- dongle,ga10h_v1_1,MK808C,mixtile_loftq,sunxi_Gemei_G9,Cubieboard2,Mele_M3,Mele_M5,Mele_M 9,A13-OLinuXino,A10s-OLinuXino-M,Bananapro,mk802ii,Marsboard_A10,ba10_tv_box,Wits_Pro_A2 0_DKT,Sinovoip_BPI_M2,Mele_I7,A20-Olimex-SOM-EVB,Cubietruck,Colombus,Orangepi,Wexler_TAB 7200,inet1,jesurun_q5,Orangepi_mini,A20-OLinuXino-Lime2,Bananapi,Mini-X,A13-OLinuXinoM) drivers/usb/host/ehci-sunxi.o:(.u_boot_list_2_driver_2_usb_ehci+0x0): multiple definition of `_u_boot_list_2_driver_2_usb_ehci' ... +(ph1_sld8,ph1_sld3,ph1_ld4) build/../drivers/usb/host/ehci-generic.c:33: undefined reference to `ehci_deregister' ... w+(xilinx_zynqmp_ep) ../drivers/usb/host/xhci-zynqmp.c:142:2: warning: 'return' with a value, in function returning void

On Monday, November 30, 2015 at 05:40:11 PM, Tom Rini wrote:
On Mon, Nov 30, 2015 at 01:33:56PM +0100, Marek Vasut wrote:
The following changes since commit fa8883a1e39a20e72aaa5093af0c80062cb95757: Merge branch 'master' of git://git.denx.de/u-boot-i2c (2015-11-27 08:41:03
-0500)
are available in the git repository at: git://git.denx.de/u-boot-usb.git
for you to fetch changes up to b5c6f21bf9761f12b43dfc652e5635ab8ec0d7c2: drivers:usb:fsl: Add T4080 as affected soc for Erratum A007792 sw workaround
(2015-11-30 13:33:22 +0100)
NAK: +(CSQ_CS908,Linksprite_pcDuino,Cubieboard,Lamobo_R1,Mele_A1000,Mele_A1000G_ quad,i12-tvbo x,mk802_a10s,Wobo_i5,Auxtek-T004,Auxtek-T003,mk802,Linksprite_pcDuino3_Nan o,A10-OLinuXin o-Lime,Hummingbird_A31,Linksprite_pcDuino3,A20-OLinuXino_MICRO,A20-OLinuXi no-Lime,r7-tv- dongle,ga10h_v1_1,MK808C,mixtile_loftq,sunxi_Gemei_G9,Cubieboard2,Mele_M3, Mele_M5,Mele_M 9,A13-OLinuXino,A10s-OLinuXino-M,Bananapro,mk802ii,Marsboard_A10,ba10_tv_b ox,Wits_Pro_A2 0_DKT,Sinovoip_BPI_M2,Mele_I7,A20-Olimex-SOM-EVB,Cubietruck,Colombus,Orang epi,Wexler_TAB 7200,inet1,jesurun_q5,Orangepi_mini,A20-OLinuXino-Lime2,Bananapi,Mini-X,A1 3-OLinuXinoM) drivers/usb/host/ehci-sunxi.o:(.u_boot_list_2_driver_2_usb_ehci+0x0): multiple definition of `_u_boot_list_2_driver_2_usb_ehci' ... +(ph1_sld8,ph1_sld3,ph1_ld4) build/../drivers/usb/host/ehci-generic.c:33: undefined reference to `ehci_deregister' ... w+(xilinx_zynqmp_ep) ../drivers/usb/host/xhci-zynqmp.c:142:2: warning: 'return' with a value, in function returning void
Can you try dropping the ehci-generic patch ?
Best regards, Marek Vasut

On Mon, Nov 30, 2015 at 05:44:15PM +0100, Marek Vasut wrote:
On Monday, November 30, 2015 at 05:40:11 PM, Tom Rini wrote:
On Mon, Nov 30, 2015 at 01:33:56PM +0100, Marek Vasut wrote:
The following changes since commit fa8883a1e39a20e72aaa5093af0c80062cb95757: Merge branch 'master' of git://git.denx.de/u-boot-i2c (2015-11-27 08:41:03
-0500)
are available in the git repository at: git://git.denx.de/u-boot-usb.git
for you to fetch changes up to b5c6f21bf9761f12b43dfc652e5635ab8ec0d7c2: drivers:usb:fsl: Add T4080 as affected soc for Erratum A007792 sw workaround
(2015-11-30 13:33:22 +0100)
NAK: +(CSQ_CS908,Linksprite_pcDuino,Cubieboard,Lamobo_R1,Mele_A1000,Mele_A1000G_ quad,i12-tvbo x,mk802_a10s,Wobo_i5,Auxtek-T004,Auxtek-T003,mk802,Linksprite_pcDuino3_Nan o,A10-OLinuXin o-Lime,Hummingbird_A31,Linksprite_pcDuino3,A20-OLinuXino_MICRO,A20-OLinuXi no-Lime,r7-tv- dongle,ga10h_v1_1,MK808C,mixtile_loftq,sunxi_Gemei_G9,Cubieboard2,Mele_M3, Mele_M5,Mele_M 9,A13-OLinuXino,A10s-OLinuXino-M,Bananapro,mk802ii,Marsboard_A10,ba10_tv_b ox,Wits_Pro_A2 0_DKT,Sinovoip_BPI_M2,Mele_I7,A20-Olimex-SOM-EVB,Cubietruck,Colombus,Orang epi,Wexler_TAB 7200,inet1,jesurun_q5,Orangepi_mini,A20-OLinuXino-Lime2,Bananapi,Mini-X,A1 3-OLinuXinoM) drivers/usb/host/ehci-sunxi.o:(.u_boot_list_2_driver_2_usb_ehci+0x0): multiple definition of `_u_boot_list_2_driver_2_usb_ehci' ... +(ph1_sld8,ph1_sld3,ph1_ld4) build/../drivers/usb/host/ehci-generic.c:33: undefined reference to `ehci_deregister' ... w+(xilinx_zynqmp_ep) ../drivers/usb/host/xhci-zynqmp.c:142:2: warning: 'return' with a value, in function returning void
Can you try dropping the ehci-generic patch ?
I'm re-testing a number of other PRs right now. Please try it locally, thanks!

On Monday, November 30, 2015 at 05:40:11 PM, Tom Rini wrote:
On Mon, Nov 30, 2015 at 01:33:56PM +0100, Marek Vasut wrote:
The following changes since commit fa8883a1e39a20e72aaa5093af0c80062cb95757: Merge branch 'master' of git://git.denx.de/u-boot-i2c (2015-11-27 08:41:03
-0500)
are available in the git repository at: git://git.denx.de/u-boot-usb.git
for you to fetch changes up to b5c6f21bf9761f12b43dfc652e5635ab8ec0d7c2: drivers:usb:fsl: Add T4080 as affected soc for Erratum A007792 sw workaround
(2015-11-30 13:33:22 +0100)
NAK: +(CSQ_CS908,Linksprite_pcDuino,Cubieboard,Lamobo_R1,Mele_A1000,Mele_A1000G_ quad,i12-tvbo x,mk802_a10s,Wobo_i5,Auxtek-T004,Auxtek-T003,mk802,Linksprite_pcDuino3_Nan o,A10-OLinuXin o-Lime,Hummingbird_A31,Linksprite_pcDuino3,A20-OLinuXino_MICRO,A20-OLinuXi no-Lime,r7-tv- dongle,ga10h_v1_1,MK808C,mixtile_loftq,sunxi_Gemei_G9,Cubieboard2,Mele_M3, Mele_M5,Mele_M 9,A13-OLinuXino,A10s-OLinuXino-M,Bananapro,mk802ii,Marsboard_A10,ba10_tv_b ox,Wits_Pro_A2 0_DKT,Sinovoip_BPI_M2,Mele_I7,A20-Olimex-SOM-EVB,Cubietruck,Colombus,Orang epi,Wexler_TAB 7200,inet1,jesurun_q5,Orangepi_mini,A20-OLinuXino-Lime2,Bananapi,Mini-X,A1 3-OLinuXinoM) drivers/usb/host/ehci-sunxi.o:(.u_boot_list_2_driver_2_usb_ehci+0x0): multiple definition of `_u_boot_list_2_driver_2_usb_ehci'
Not my doing, but I can fix this.
+(ph1_sld8,ph1_sld3,ph1_ld4) build/../drivers/usb/host/ehci-generic.c:33: undefined reference to `ehci_deregister'
I'm dropping the ehci-generic for now.
... w+(xilinx_zynqmp_ep) ../drivers/usb/host/xhci-zynqmp.c:142:2: warning: 'return' with a value, in function returning void
OK, I fixed this one.
Best regards, Marek Vasut

Hi Tom,
On Mon, 2015-11-30 at 18:17 +0100, Marek Vasut wrote:
On Monday, November 30, 2015 at 05:40:11 PM, Tom Rini wrote:
On Mon, Nov 30, 2015 at 01:33:56PM +0100, Marek Vasut wrote:
T
+(ph1_sld8,ph1_sld3,ph1_ld4) build/../drivers/usb/host/ehci-generic.c:33: undefined reference to `ehci_deregister'
I'm wondering how may I reproduce this failure?
For me following (assuming ARC toolchain is in PATHs, see http://www.denx.de/wiki/U-Boot/ARCNotes) works flawlessly: ---------------------->8----------------------- make axs101_defconfig && make ---------------------->8-----------------------
-Alexey

On Monday, November 30, 2015 at 06:23:15 PM, Alexey Brodkin wrote:
Hi Tom,
On Mon, 2015-11-30 at 18:17 +0100, Marek Vasut wrote:
On Monday, November 30, 2015 at 05:40:11 PM, Tom Rini wrote:
On Mon, Nov 30, 2015 at 01:33:56PM +0100, Marek Vasut wrote:
T
+(ph1_sld8,ph1_sld3,ph1_ld4) build/../drivers/usb/host/ehci-generic.c:33: undefined reference to `ehci_deregister'
I'm wondering how may I reproduce this failure?
For me following (assuming ARC toolchain is in PATHs, see http://www.denx.de/wiki/U-Boot/ARCNotes) works flawlessly: ---------------------->8----------------------- make axs101_defconfig && make ---------------------->8-----------------------
Try compiling either of the machines -- ph1_sld8 or ph1_sld3 or ph1_ld4
Best regards, Marek Vasut

On Mon, Nov 30, 2015 at 05:23:15PM +0000, Alexey Brodkin wrote:
Hi Tom,
On Mon, 2015-11-30 at 18:17 +0100, Marek Vasut wrote:
On Monday, November 30, 2015 at 05:40:11 PM, Tom Rini wrote:
On Mon, Nov 30, 2015 at 01:33:56PM +0100, Marek Vasut wrote:
T
+(ph1_sld8,ph1_sld3,ph1_ld4) build/../drivers/usb/host/ehci-generic.c:33: undefined reference to `ehci_deregister'
I'm wondering how may I reproduce this failure?
For me following (assuming ARC toolchain is in PATHs, see http://www.denx.de/wiki/U-Boot/ARCNotes) works flawlessly: ---------------------->8----------------------- make axs101_defconfig && make ---------------------->8-----------------------
Build for ph1_sld8 or one of the other listed ARM boards :)

Hi Tom, Marek,
On Mon, 2015-11-30 at 12:26 -0500, Tom Rini wrote:
On Mon, Nov 30, 2015 at 05:23:15PM +0000, Alexey Brodkin wrote:
Hi Tom,
On Mon, 2015-11-30 at 18:17 +0100, Marek Vasut wrote:
On Monday, November 30, 2015 at 05:40:11 PM, Tom Rini wrote:
On Mon, Nov 30, 2015 at 01:33:56PM +0100, Marek Vasut wrote:
T
+(ph1_sld8,ph1_sld3,ph1_ld4) build/../drivers/usb/host/ehci-generic.c:33: undefined reference to `ehci_deregister'
I'm wondering how may I reproduce this failure?
For me following (assuming ARC toolchain is in PATHs, see http://www.denx.de/wiki/U-Boot/ARCNotes) works flawlessly: ---------------------->8----------------------- make axs101_defconfig && make ---------------------->8-----------------------
Build for ph1_sld8 or one of the other listed ARM boards :)
Obvious SNAFU - new driver enabled by default. All other EHCI drivers are also enabled by default but limited by either architecture or platforms.
v3 is on its way - I'm really sorry for that :(
-Alexey
participants (3)
-
Alexey Brodkin
-
Marek Vasut
-
Tom Rini