[PATCH 0/6] Add ESM Support for J7200
This series adds the required nodes in the devicetree, and enables the configs for the ESM and PMIC.
Test Logs AVS and ESM: https://gist.github.com/aniket-l/96b85a25733095b4fd87f48f730518bf
--- Aniket Limaye (2): arm: dts: k3-j7200-r5: Add the pmic node in R5 dt arm: dts: k3-j7200-r5: Fix indentation to use tabs
Gowtham Tammana (2): arm: dts: k3-j7200-r5-common: Hook buckb1 to vtm supply arm: dts: k3-j7200: Add ESM PMIC support for tps659413
Neha Malcom Francis (2): configs: j7200_evm_r5: Add ESM config for J7200 configs: j7200_evm_r5: Add ESM config for J7200
.../arm/dts/k3-j7200-r5-common-proc-board.dts | 23 +++++++++++++++---- configs/j7200_evm_r5_defconfig | 2 ++ 2 files changed, 21 insertions(+), 4 deletions(-)
Add bootph-pre-ram property to the buck node in the pmic needed for ESM error event handling.
Signed-off-by: Aniket Limaye a-limaye@ti.com --- arch/arm/dts/k3-j7200-r5-common-proc-board.dts | 9 +++++++++ 1 file changed, 9 insertions(+)
diff --git a/arch/arm/dts/k3-j7200-r5-common-proc-board.dts b/arch/arm/dts/k3-j7200-r5-common-proc-board.dts index fb7e2e50239..78d07ff4e70 100644 --- a/arch/arm/dts/k3-j7200-r5-common-proc-board.dts +++ b/arch/arm/dts/k3-j7200-r5-common-proc-board.dts @@ -96,3 +96,12 @@ &mcu_udmap { ti,sci = <&dm_tifs>; }; + +&tps659414 { + regulators { + bucka1: buck1 { + bootph-pre-ram; + }; + }; +}; +
On 5/31/2024 6:38 PM, Aniket Limaye wrote:
Add bootph-pre-ram property to the buck node in the pmic needed for ESM error event handling.
Signed-off-by: Aniket Limaye a-limaye@ti.com
arch/arm/dts/k3-j7200-r5-common-proc-board.dts | 9 +++++++++ 1 file changed, 9 insertions(+)
diff --git a/arch/arm/dts/k3-j7200-r5-common-proc-board.dts b/arch/arm/dts/k3-j7200-r5-common-proc-board.dts index fb7e2e50239..78d07ff4e70 100644 --- a/arch/arm/dts/k3-j7200-r5-common-proc-board.dts +++ b/arch/arm/dts/k3-j7200-r5-common-proc-board.dts @@ -96,3 +96,12 @@ &mcu_udmap { ti,sci = <&dm_tifs>; };
+&tps659414 {
- regulators {
bucka1: buck1 {bootph-pre-ram;};
why not to add this in kernel DT
- };
+};
On 5/31/2024 7:25 PM, Kumar, Udit wrote:
On 5/31/2024 6:38 PM, Aniket Limaye wrote:
Add bootph-pre-ram property to the buck node in the pmic needed for ESM error event handling.
Signed-off-by: Aniket Limaye a-limaye@ti.com
arch/arm/dts/k3-j7200-r5-common-proc-board.dts | 9 +++++++++ 1 file changed, 9 insertions(+)
diff --git a/arch/arm/dts/k3-j7200-r5-common-proc-board.dts b/arch/arm/dts/k3-j7200-r5-common-proc-board.dts index fb7e2e50239..78d07ff4e70 100644 --- a/arch/arm/dts/k3-j7200-r5-common-proc-board.dts +++ b/arch/arm/dts/k3-j7200-r5-common-proc-board.dts @@ -96,3 +96,12 @@ &mcu_udmap { ti,sci = <&dm_tifs>; };
+&tps659414 { + regulators { + bucka1: buck1 { + bootph-pre-ram; + };
why not to add this in kernel DT
Manorit has already posted a series to kernel to add bootph- properties across platforms... Specifically the patch here [0] addresses this.
Once that is merged, and goes through the rebasing tree in u-boot we will need to send patches to remove the bootph properties from the -u-boot and -r5 files. Until then we need this patch for the ESM to work. Else we can wait till the kernel dt patches make it through to u-boot for me to roll out a v2.
[0]: https://lore.kernel.org/all/20240507-b4-upstream-bootph-all-v1-5-c6d52651856...
+ }; +};
On Fri, May 31, 2024 at 10:24:30PM +0530, Limaye, Aniket wrote:
On 5/31/2024 7:25 PM, Kumar, Udit wrote:
On 5/31/2024 6:38 PM, Aniket Limaye wrote:
Add bootph-pre-ram property to the buck node in the pmic needed for ESM error event handling.
Signed-off-by: Aniket Limaye a-limaye@ti.com
arch/arm/dts/k3-j7200-r5-common-proc-board.dts | 9 +++++++++ 1 file changed, 9 insertions(+)
diff --git a/arch/arm/dts/k3-j7200-r5-common-proc-board.dts b/arch/arm/dts/k3-j7200-r5-common-proc-board.dts index fb7e2e50239..78d07ff4e70 100644 --- a/arch/arm/dts/k3-j7200-r5-common-proc-board.dts +++ b/arch/arm/dts/k3-j7200-r5-common-proc-board.dts @@ -96,3 +96,12 @@ &mcu_udmap { ti,sci = <&dm_tifs>; };
+&tps659414 { + regulators { + bucka1: buck1 { + bootph-pre-ram; + };
why not to add this in kernel DT
Manorit has already posted a series to kernel to add bootph- properties across platforms... Specifically the patch here [0] addresses this.
Once that is merged, and goes through the rebasing tree in u-boot we will need to send patches to remove the bootph properties from the -u-boot and -r5 files. Until then we need this patch for the ESM to work. Else we can wait till the kernel dt patches make it through to u-boot for me to roll out a v2.
Yes, we'll wait until we can get this all in via OF_UPSTREAM.
On 6/14/2024 8:25 PM, Tom Rini wrote:
On Fri, May 31, 2024 at 10:24:30PM +0530, Limaye, Aniket wrote:
On 5/31/2024 7:25 PM, Kumar, Udit wrote:
On 5/31/2024 6:38 PM, Aniket Limaye wrote:
Add bootph-pre-ram property to the buck node in the pmic needed for ESM error event handling.
Signed-off-by: Aniket Limaye a-limaye@ti.com
arch/arm/dts/k3-j7200-r5-common-proc-board.dts | 9 +++++++++ 1 file changed, 9 insertions(+)
diff --git a/arch/arm/dts/k3-j7200-r5-common-proc-board.dts b/arch/arm/dts/k3-j7200-r5-common-proc-board.dts index fb7e2e50239..78d07ff4e70 100644 --- a/arch/arm/dts/k3-j7200-r5-common-proc-board.dts +++ b/arch/arm/dts/k3-j7200-r5-common-proc-board.dts @@ -96,3 +96,12 @@ &mcu_udmap { ti,sci = <&dm_tifs>; };
+&tps659414 { + regulators { + bucka1: buck1 { + bootph-pre-ram; + };
why not to add this in kernel DT
Manorit has already posted a series to kernel to add bootph- properties across platforms... Specifically the patch here [0] addresses this.
Once that is merged, and goes through the rebasing tree in u-boot we will need to send patches to remove the bootph properties from the -u-boot and -r5 files. Until then we need this patch for the ESM to work. Else we can wait till the kernel dt patches make it through to u-boot for me to roll out a v2.
Yes, we'll wait until we can get this all in via OF_UPSTREAM.
Tom, Udit,
The patch in Kernel DT here [0] seems to be taking longer to go through. In the meantime, does it make sense for me to send this current series in u-boot with the bootph patch above, to unblock ESM support for j7200-evm?
When the Kernel DT patch is merged and taken through OF_UPSTREAM, I will anyway send a patch to remove all of the bootph from the u-boot DT files. With that, I can take care of removing the above bootph property too.
Let me know what you think, and I'll rebase this series and resend it then.
[0]: https://lore.kernel.org/all/20240814-b4-upstream-bootph-all-v4-0-f2b462000f2...
Thanks, Aniket
On 14:02-20240829, Limaye, Aniket wrote:
On 6/14/2024 8:25 PM, Tom Rini wrote:
On Fri, May 31, 2024 at 10:24:30PM +0530, Limaye, Aniket wrote:
On 5/31/2024 7:25 PM, Kumar, Udit wrote:
On 5/31/2024 6:38 PM, Aniket Limaye wrote:
Add bootph-pre-ram property to the buck node in the pmic needed for ESM error event handling.
Signed-off-by: Aniket Limaye a-limaye@ti.com
arch/arm/dts/k3-j7200-r5-common-proc-board.dts | 9 +++++++++ 1 file changed, 9 insertions(+)
diff --git a/arch/arm/dts/k3-j7200-r5-common-proc-board.dts b/arch/arm/dts/k3-j7200-r5-common-proc-board.dts index fb7e2e50239..78d07ff4e70 100644 --- a/arch/arm/dts/k3-j7200-r5-common-proc-board.dts +++ b/arch/arm/dts/k3-j7200-r5-common-proc-board.dts @@ -96,3 +96,12 @@ &mcu_udmap { ti,sci = <&dm_tifs>; };
+&tps659414 { + regulators { + bucka1: buck1 { + bootph-pre-ram; + };
why not to add this in kernel DT
Manorit has already posted a series to kernel to add bootph- properties across platforms... Specifically the patch here [0] addresses this.
Once that is merged, and goes through the rebasing tree in u-boot we will need to send patches to remove the bootph properties from the -u-boot and -r5 files. Until then we need this patch for the ESM to work. Else we can wait till the kernel dt patches make it through to u-boot for me to roll out a v2.
Yes, we'll wait until we can get this all in via OF_UPSTREAM.
Tom, Udit,
The patch in Kernel DT here [0] seems to be taking longer to go through. In the meantime, does it make sense for me to send this current series in u-boot with the bootph patch above, to unblock ESM support for j7200-evm?
NAK! This is why there is a review process in upstream. Lack of ESM survived in j7200 for years now - there is no urgency to carry that stuff and then have someone to start tracking and cleaning up behind. Please DO NOT. The only exception we have permitted now is for you to add patches in dts/ which *have* been upstreamed and accepted by maintainers but it is a couple of months away for OF_UPSTREAM to sync (aka for the next rebase, those changes will be dropped).
This policy has been asserted over and over again on these platforms. Please focus instead on helping getting kernel changes upstream by helping support engineers in that effort.
When the Kernel DT patch is merged and taken through OF_UPSTREAM, I will anyway send a patch to remove all of the bootph from the u-boot DT files. With that, I can take care of removing the above bootph property too.
Let me know what you think, and I'll rebase this series and resend it then.
Thanks, Aniket
To avoid whitespace diff, use tabs throughout the file for indent
Signed-off-by: Aniket Limaye a-limaye@ti.com --- arch/arm/dts/k3-j7200-r5-common-proc-board.dts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/dts/k3-j7200-r5-common-proc-board.dts b/arch/arm/dts/k3-j7200-r5-common-proc-board.dts index 78d07ff4e70..c7086791ef8 100644 --- a/arch/arm/dts/k3-j7200-r5-common-proc-board.dts +++ b/arch/arm/dts/k3-j7200-r5-common-proc-board.dts @@ -85,16 +85,16 @@ };
&ospi0 { - reg = <0x0 0x47040000 0x0 0x100>, - <0x0 0x50000000 0x0 0x8000000>; + reg = <0x0 0x47040000 0x0 0x100>, + <0x0 0x50000000 0x0 0x8000000>; };
&mcu_ringacc { - ti,sci = <&dm_tifs>; + ti,sci = <&dm_tifs>; };
&mcu_udmap { - ti,sci = <&dm_tifs>; + ti,sci = <&dm_tifs>; };
&tps659414 {
On 5/31/2024 6:38 PM, Aniket Limaye wrote:
To avoid whitespace diff, use tabs throughout the file for indent
Signed-off-by: Aniket Limaye a-limaye@ti.com
arch/arm/dts/k3-j7200-r5-common-proc-board.dts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/dts/k3-j7200-r5-common-proc-board.dts b/arch/arm/dts/k3-j7200-r5-common-proc-board.dts index 78d07ff4e70..c7086791ef8 100644 --- a/arch/arm/dts/k3-j7200-r5-common-proc-board.dts +++ b/arch/arm/dts/k3-j7200-r5-common-proc-board.dts @@ -85,16 +85,16 @@ };
&ospi0 {
- reg = <0x0 0x47040000 0x0 0x100>,
<0x0 0x50000000 0x0 0x8000000>;
reg = <0x0 0x47040000 0x0 0x100>,
<0x0 0x50000000 0x0 0x8000000>;};
&mcu_ringacc {
- ti,sci = <&dm_tifs>;
ti,sci = <&dm_tifs>; };
&mcu_udmap {
- ti,sci = <&dm_tifs>;
- ti,sci = <&dm_tifs>; };
I think this is unrelated to this series ,
my suggestion will be post these changes in different patch
&tps659414 {
From: Gowtham Tammana g-tammana@ti.com
Hook buckb1 to vtm avs supply.
Signed-off-by: Gowtham Tammana g-tammana@ti.com Signed-off-by: Aniket Limaye a-limaye@ti.com --- arch/arm/dts/k3-j7200-r5-common-proc-board.dts | 1 + 1 file changed, 1 insertion(+)
diff --git a/arch/arm/dts/k3-j7200-r5-common-proc-board.dts b/arch/arm/dts/k3-j7200-r5-common-proc-board.dts index c7086791ef8..176cc0a0fbb 100644 --- a/arch/arm/dts/k3-j7200-r5-common-proc-board.dts +++ b/arch/arm/dts/k3-j7200-r5-common-proc-board.dts @@ -81,6 +81,7 @@ };
&wkup_vtm0 { + vdd-supply-2 = <&buckb1>; bootph-pre-ram; };
On 5/31/2024 6:38 PM, Aniket Limaye wrote:
From: Gowtham Tammana g-tammana@ti.com
Hook buckb1 to vtm avs supply.
Signed-off-by: Gowtham Tammana g-tammana@ti.com Signed-off-by: Aniket Limaye a-limaye@ti.com
arch/arm/dts/k3-j7200-r5-common-proc-board.dts | 1 + 1 file changed, 1 insertion(+)
diff --git a/arch/arm/dts/k3-j7200-r5-common-proc-board.dts b/arch/arm/dts/k3-j7200-r5-common-proc-board.dts index c7086791ef8..176cc0a0fbb 100644 --- a/arch/arm/dts/k3-j7200-r5-common-proc-board.dts +++ b/arch/arm/dts/k3-j7200-r5-common-proc-board.dts @@ -81,6 +81,7 @@ };
&wkup_vtm0 {
- vdd-supply-2 = <&buckb1>;
Reviewed-by: Udit Kumar u-kumar1@ti.com
bootph-pre-ram; };
From: Neha Malcom Francis n-francis@ti.com
Add CONFIG_ESM_K3 to enable ESM initialization in J7200.
Signed-off-by: Neha Malcom Francis n-francis@ti.com Signed-off-by: Aniket Limaye a-limaye@ti.com --- configs/j7200_evm_r5_defconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/configs/j7200_evm_r5_defconfig b/configs/j7200_evm_r5_defconfig index e023af24674..c9f586a1695 100644 --- a/configs/j7200_evm_r5_defconfig +++ b/configs/j7200_evm_r5_defconfig @@ -101,6 +101,7 @@ CONFIG_DM_MAILBOX=y CONFIG_K3_SEC_PROXY=y CONFIG_FS_LOADER=y CONFIG_SPL_FS_LOADER=y +CONFIG_ESM_K3=y CONFIG_K3_AVS0=y CONFIG_SUPPORT_EMMC_BOOT=y CONFIG_SPL_MMC_HS400_SUPPORT=y
From: Gowtham Tammana g-tammana@ti.com
On J7200 processor board MCU_SAFETY_ERROR signal is routed to PMIC for ESM error handling. The PMIC resets the board on receipt of the signal. Enable the support for the board by adding ESM PMIC node.
Signed-off-by: Gowtham Tammana g-tammana@ti.com Signed-off-by: Neha Malcom Francis n-francis@ti.com Signed-off-by: Aniket Limaye a-limaye@ti.com --- arch/arm/dts/k3-j7200-r5-common-proc-board.dts | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/arch/arm/dts/k3-j7200-r5-common-proc-board.dts b/arch/arm/dts/k3-j7200-r5-common-proc-board.dts index 176cc0a0fbb..9c83a629504 100644 --- a/arch/arm/dts/k3-j7200-r5-common-proc-board.dts +++ b/arch/arm/dts/k3-j7200-r5-common-proc-board.dts @@ -99,6 +99,11 @@ };
&tps659414 { + esm: esm { + compatible = "ti,tps659413-esm"; + bootph-pre-ram; + }; + regulators { bucka1: buck1 { bootph-pre-ram;
From: Neha Malcom Francis n-francis@ti.com
Add CONFIG_ESM_PMIC to enable PMIC initialization in J7200.
Signed-off-by: Neha Malcom Francis n-francis@ti.com Signed-off-by: Aniket Limaye a-limaye@ti.com --- configs/j7200_evm_r5_defconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/configs/j7200_evm_r5_defconfig b/configs/j7200_evm_r5_defconfig index c9f586a1695..7b2ff65fcee 100644 --- a/configs/j7200_evm_r5_defconfig +++ b/configs/j7200_evm_r5_defconfig @@ -103,6 +103,7 @@ CONFIG_FS_LOADER=y CONFIG_SPL_FS_LOADER=y CONFIG_ESM_K3=y CONFIG_K3_AVS0=y +CONFIG_ESM_PMIC=y CONFIG_SUPPORT_EMMC_BOOT=y CONFIG_SPL_MMC_HS400_SUPPORT=y CONFIG_MMC_SDHCI=y
On 5/31/2024 6:38 PM, Aniket Limaye wrote:
This series adds the required nodes in the devicetree, and enables the configs for the ESM and PMIC.
Test Logs AVS and ESM: https://gist.github.com/aniket-l/96b85a25733095b4fd87f48f730518bf
Forgot to add that this series depends on the patch [0] "arm: dts: k3-j7200: Move to OF_UPSTREAM"
[0]: https://lore.kernel.org/u-boot/20240521054842.2121479-1-a-limaye@ti.com/
Aniket Limaye (2): arm: dts: k3-j7200-r5: Add the pmic node in R5 dt arm: dts: k3-j7200-r5: Fix indentation to use tabs
Gowtham Tammana (2): arm: dts: k3-j7200-r5-common: Hook buckb1 to vtm supply arm: dts: k3-j7200: Add ESM PMIC support for tps659413
Neha Malcom Francis (2): configs: j7200_evm_r5: Add ESM config for J7200 configs: j7200_evm_r5: Add ESM config for J7200
.../arm/dts/k3-j7200-r5-common-proc-board.dts | 23 +++++++++++++++---- configs/j7200_evm_r5_defconfig | 2 ++ 2 files changed, 21 insertions(+), 4 deletions(-)
participants (5)
-
Aniket Limaye -
Kumar, Udit -
Limaye, Aniket
-
Nishanth Menon -
Tom Rini