On 12/14/2011 01:30 AM, Liu Shengzhou-B36685 wrote:

...

-----Original Message----- From: Wood Scott-B07421 Sent: Tuesday, December 13, 2011 4:14 AM To: Liu Shengzhou-B36685 Cc: u-boot@lists.denx.de; Gala Kumar-B11780; Liu Shuo-B35362 Subject: Re: [PATCH 5/5 v2] mtd/nand: workaround for Freescale FCM to support 4k pagesize Nand chip

I've asked you several times what you're planning on doing for bad block marker migration. I am not going to let you ignore this. NACK until you have a migration tool, and a scheme for marking the flash as having been migrated.

[Shengzhou] This is the first time that you asked me about bad block marker migration. You asked LiuShuo several times in Linux mail list, as I am not in that thread And not known about it until Liushuo told me. As LiuShuo will do it, so I am not planning on it.

Ah, sorry about that.

Still, I'd like to see it done, whoever does it, before this gets merged. I don't want people to be able to accidentally start using it without doing migration.

...

...

• 	nand->ecc.layout = (priv->fmr & FMR_ECCM) ?
  

• 	   &fsl_elbc_oob_lp_eccm1 : &fsl_elbc_oob_lp_eccm0;
  

• 	nand->badblock_pattern = &largepage_memorybased;
  

Those oob layouts won't be quite right for larger page sizes.

-Scott

[Shengzhou] It's the same with what Linux does. What's the right?

I think we need to explicitly define 4096 and 8192 variants, with the extra eccpos/oobfree. Or generate them programatically.

-Scott