[U-Boot] [PATCH][v2] driver: net: fsl-mc: Return from DPAA_exit if boot_status !=0

Return value of get_mc_boot_status() in case of failure is not necessary to be -1.
So update the error condition check.
Signed-off-by: Prabhakar Kushwaha prabhakar.kushwaha@nxp.com Reported-by: Yao Yuan yao.yuan@nxp.com --- Changes for v2: Incorporated York's comments - Added comments
drivers/net/fsl-mc/mc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/fsl-mc/mc.c b/drivers/net/fsl-mc/mc.c index 53c4966..f83bd0c 100644 --- a/drivers/net/fsl-mc/mc.c +++ b/drivers/net/fsl-mc/mc.c @@ -1147,7 +1147,8 @@ int fsl_mc_ldpaa_exit(bd_t *bd) { int err = 0;
- if (bd && get_mc_boot_status() == -1) + /* MC is not loaded intentionally, So return success. */ + if (bd && get_mc_boot_status() != 0) return 0;
if (bd && !get_mc_boot_status() && get_dpl_apply_status() == -1) {

On Mon, Mar 21, 2016 at 3:49 AM, Prabhakar Kushwaha prabhakar.kushwaha@nxp.com wrote:
Return value of get_mc_boot_status() in case of failure is not necessary to be -1.
So update the error condition check.
Signed-off-by: Prabhakar Kushwaha prabhakar.kushwaha@nxp.com Reported-by: Yao Yuan yao.yuan@nxp.com
Acked-by: Joe Hershberger joe.hershberger@ni.com

On 03/21/2016 01:50 AM, Prabhakar Kushwaha wrote:
Return value of get_mc_boot_status() in case of failure is not necessary to be -1.
So update the error condition check.
Signed-off-by: Prabhakar Kushwaha prabhakar.kushwaha@nxp.com Reported-by: Yao Yuan yao.yuan@nxp.com
Changes for v2: Incorporated York's comments
- Added comments
drivers/net/fsl-mc/mc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Applied to u-boot-fsl-qoriq, awaiting upstream.
Thanks.
York
participants (3)
-
Joe Hershberger
-
Prabhakar Kushwaha
-
york sun