[PATCH] mtd: spi-nor-core: Fixup SNOR_F_IO_MODE_EN_VOLATILE for MT35X
From: Vaishnav Achath vaishnav.a@ti.com
MT35XU512ABA has only BFPT and 4-Byte Address Instruction Table in SFDP. commit bebdc237507c ("mtd: spi-nor: Parse SFDP SCCR Map") added checks in spi_nor_octal_dtr_enable() to bail out if the 22nd DWORD in SCCR does not indicate DTR Octal Mode Enable, since MT35XU512ABA device supports octal DTR mode, add this property in SFDP fixup.
Signed-off-by: Vaishnav Achath vaishnav.a@ti.com Signed-off-by: Prasanth Babu Mantena p-mantena@ti.com ---
Test results : https://gist.github.com/PrasanthBabuMantena/678cbd7a230a4e2d19e22d20dfeb1235
drivers/mtd/spi/spi-nor-core.c | 6 ++++++ 1 file changed, 6 insertions(+)
diff --git a/drivers/mtd/spi/spi-nor-core.c b/drivers/mtd/spi/spi-nor-core.c index ec841fb13bd..6364d91fac0 100644 --- a/drivers/mtd/spi/spi-nor-core.c +++ b/drivers/mtd/spi/spi-nor-core.c @@ -4109,6 +4109,12 @@ static void mt35xu512aba_post_sfdp_fixup(struct spi_nor *nor, params->rdsr_dummy = 8; params->rdsr_addr_nbytes = 0;
+ /* + * SCCR Map 22nd DWORD does not indicate DTR Octal Mode Enable + * for MT35XU512ABA but is actually supported by device. + */ + nor->flags |= SNOR_F_IO_MODE_EN_VOLATILE; + /* * The BFPT quad enable field is set to a reserved value so the quad * enable function is ignored by spi_nor_parse_bfpt(). Make sure we
Thanks for fix
On 11/25/2024 4:19 PM, Prasanth Babu Mantena wrote:
From: Vaishnav Achath vaishnav.a@ti.com
MT35XU512ABA has only BFPT and 4-Byte Address Instruction Table in SFDP. commit bebdc237507c ("mtd: spi-nor: Parse SFDP SCCR Map") added checks in spi_nor_octal_dtr_enable() to bail out if the 22nd DWORD in SCCR does not indicate DTR Octal Mode Enable, since MT35XU512ABA device supports octal DTR mode, add this property in SFDP fixup.
Signed-off-by: Vaishnav Achath vaishnav.a@ti.com Signed-off-by: Prasanth Babu Mantena p-mantena@ti.com
Test results : https://gist.github.com/PrasanthBabuMantena/678cbd7a230a4e2d19e22d20dfeb1235
drivers/mtd/spi/spi-nor-core.c | 6 ++++++ 1 file changed, 6 insertions(+)
diff --git a/drivers/mtd/spi/spi-nor-core.c b/drivers/mtd/spi/spi-nor-core.c index ec841fb13bd..6364d91fac0 100644 --- a/drivers/mtd/spi/spi-nor-core.c +++ b/drivers/mtd/spi/spi-nor-core.c @@ -4109,6 +4109,12 @@ static void mt35xu512aba_post_sfdp_fixup(struct spi_nor *nor, params->rdsr_dummy = 8; params->rdsr_addr_nbytes = 0;
- /*
* SCCR Map 22nd DWORD does not indicate DTR Octal Mode Enable* for MT35XU512ABA but is actually supported by device.*/- nor->flags |= SNOR_F_IO_MODE_EN_VOLATILE;
Reviewed-by: Udit Kumar u-kumar1@ti.com
+ jagan@amarulasolutions.com, not sure, if this needs to go through SPI branch
/* * The BFPT quad enable field is set to a reserved value so the quad * enable function is ignored by spi_nor_parse_bfpt(). Make sure we
participants (2)
-
Kumar, Udit -
Prasanth Babu Mantena