[PATCH] tools: imx8image: Fix handle leak

The handle "fd" was created in imx8image.c:249 by calling the "fopen" function and is lost in imx8image.c:282. Should close the 'fd' file descriptor before exiting the parse_cfg_file(image_t *param_stack, char *name) function.
Fixes: a2b96ece5be1 ("tools: add i.MX8/8X image support") Signed-off-by: Mikhail Ilin ilin.mikhail.ol@gmail.com --- tools/imx8image.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/tools/imx8image.c b/tools/imx8image.c index 01e1486911..395d5c64bd 100644 --- a/tools/imx8image.c +++ b/tools/imx8image.c @@ -279,6 +279,7 @@ static uint32_t parse_cfg_file(image_t *param_stack, char *name) } }
+ fclose(fd); return 0; }

On Wed, 23 Nov 2022 at 04:00, Mikhail Ilin ilin.mikhail.ol@gmail.com wrote:
The handle "fd" was created in imx8image.c:249 by calling the "fopen" function and is lost in imx8image.c:282. Should close the 'fd' file descriptor before exiting the parse_cfg_file(image_t *param_stack, char *name) function.
Fixes: a2b96ece5be1 ("tools: add i.MX8/8X image support") Signed-off-by: Mikhail Ilin ilin.mikhail.ol@gmail.com
tools/imx8image.c | 1 + 1 file changed, 1 insertion(+)
Reviewed-by: Simon Glass sjg@chromium.org

The handle "fd" was created in imx8image.c:249 by calling the "fopen" function and is lost in imx8image.c:282. Should close the 'fd' file descriptor before exiting the parse_cfg_file(image_t *param_stack, char *name) function. Fixes: a2b96ece5be1 ("tools: add i.MX8/8X image support") Signed-off-by: Mikhail Ilin ilin.mikhail.ol@gmail.com Reviewed-by: Simon Glass sjg@chromium.org
Applied to u-boot-imx, master, thanks !
Best regards, Stefano Babic
participants (3)
-
Mikhail Ilin
-
sbabic@denx.de
-
Simon Glass