[U-Boot] [PATCH] Correct drv_usb_kbd_init function

The patch is that check if usb_get_dev_index() function return valid pointer. If valid, continue. Otherwise return -1.
Signed-off-by: Ryan Chen ryan.chen@st.com
--- common/usb_kbd.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/common/usb_kbd.c b/common/usb_kbd.c index c876495..880e616 100644 --- a/common/usb_kbd.c +++ b/common/usb_kbd.c @@ -164,6 +164,8 @@ int drv_usb_kbd_init(void) /* scan all USB Devices */ for(i=0;i<USB_MAX_DEVICE;i++) { dev=usb_get_dev_index(i); /* get device */ + if(dev == NULL) + return -1; if(dev->devnum!=-1) { if(usb_kbd_probe(dev,0)==1) { /* Ok, we found a keyboard */ /* check, if it is already registered */

while we're at it...
On Wed, Aug 20, 2008 at 01:00:17PM -0400, Ryan CHEN wrote:
The patch is that check if usb_get_dev_index() function return valid pointer. If valid, continue. Otherwise return -1.
Signed-off-by: Ryan Chen ryan.chen@st.com
Acked-by: Markus klotzbuecher mk@denx.de
Wolfgang, please apply!
Best regards Markus

Dear Markus =?iso-8859-1?Q?Klotzb=FCcher?=,
In message 20080909143531.GB11987@lisa you wrote:
while we're at it...
On Wed, Aug 20, 2008 at 01:00:17PM -0400, Ryan CHEN wrote:
The patch is that check if usb_get_dev_index() function return valid pointer. If valid, continue. Otherwise return -1.
Signed-off-by: Ryan Chen ryan.chen@st.com
Acked-by: Markus klotzbuecher mk@denx.de
Wolfgang, please apply!
Done, thanks!
Best regards,
Wolfgang Denk

Dear Ryan CHEN,
In message 1219251617-26166-1-git-send-email-ryan.chen@st.com you wrote:
The patch is that check if usb_get_dev_index() function return valid pointer. If valid, continue. Otherwise return -1.
Signed-off-by: Ryan Chen ryan.chen@st.com
common/usb_kbd.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
participants (3)
-
Markus Klotzbücher
-
Ryan CHEN
-
Wolfgang Denk