Re: [U-Boot] [PATCH v10 00/16] split tegra20 arm7 code into separate SPL
Hi Tom,
On Wed, 29 Aug 2012 14:10:19 -0700, Tom Warren TWarren@nvidia.com wrote:
Lucas,
-----Original Message----- From: Lucas Stach [mailto:dev@lynxeye.de] Sent: Wednesday, August 29, 2012 1:54 PM To: Tom Warren Cc: Allen Martin; swarren@wwwdotorg.org; sjg@chromium.org; thierry.reding@avionic-design.de; u-boot@lists.denx.de Subject: Re: [PATCH v10 00/16] split tegra20 arm7 code into separate SPL
Hello Tom,
Am Mittwoch, den 29.08.2012, 09:55 -0700 schrieb Tom Warren:
Allen/Albert,
-----Original Message----- From: Allen Martin [mailto:amartin@nvidia.com] Sent: Tuesday, August 28, 2012 5:08 PM To: Tom Warren; swarren@wwwdotorg.org; sjg@chromium.org; thierry.reding@avionic-design.de; dev@lynxeye.de Cc: u-boot@lists.denx.de; Allen Martin Subject: [PATCH v10 00/16] split tegra20 arm7 code into separate SPL
This patch series fixes a long standing problem with the tegra20 u-boot build. Tegra20 contains an ARM7TDMI boot processor and a Cortex A9 main processor. Prior to this patch series this was accomplished by #ifdefing out any armv7 code from the early boot sequence and creating a single binary that runs on both both the ARM7TDMI and A9. This was very fragile as changes to compiler options or any additions or rearranging of the early boot code could add additional armv7 specific code causing it to fail on the ARM7TDMI.
This patch series pulls all the armv4t code out into a separate SPL that does nothing more than initialize the A9 and transfer control to it. The resultint SPL and armv7 u-boot are concatenated together into a single image.
This patch series is also available from: git://github.com/arm000/u-boot.git branch: tegra-spl-v10
Changes: v10:
- added fix to MAKEALL script so that it correctly parses new
boards.cfg
I applied this to u-boot-tegra/master and pushed the new code upstream.
The pull request remains the same (except for the inclusion of the MAKEALL patch, of course). I can send a new one if required - please let me know.
Currently running a ./MAKEALL arm - I assume it'll complete w/o errors
(except for the ohci-hcd.c warnings I mentioned previously that are not due to this patch series).
Are you going to refresh the next branch anytime soon or are you planing on doing this once the master branch is merged to arm/master?
I can refresh u-boot-tegra/next with Allen's V10 SPL patches and re-push it, but if the pull of the SPL code from u-boot-tegra/master is going to go into ARM/master anytime soon, I'd rather wait and just do it one final time.
Albert - any idea of an ETA on pulling u-boot-tegra/master into ARM/master?
If I'm not mistaken, the current u-boot-tegra/master branch has issues with ./MAKEALL arm, not building everything it should. I'd rather not pull it unless Allen's fix is added (or even better, unless the master branch is force-updated to fix the original commit which introduced the issue, if you and Allen are willing to go this far).
Tom
Thanks, Lucas
Amicalement,
Albert,
-----Original Message----- From: Albert ARIBAUD [mailto:albert.u.boot@aribaud.net] Sent: Thursday, August 30, 2012 1:41 AM To: Tom Warren Cc: Lucas Stach; Allen Martin; swarren@wwwdotorg.org; sjg@chromium.org; thierry.reding@avionic-design.de; u-boot@lists.denx.de Subject: Re: [PATCH v10 00/16] split tegra20 arm7 code into separate SPL
Hi Tom,
On Wed, 29 Aug 2012 14:10:19 -0700, Tom Warren TWarren@nvidia.com wrote:
Lucas,
-----Original Message----- From: Lucas Stach [mailto:dev@lynxeye.de] Sent: Wednesday, August 29, 2012 1:54 PM To: Tom Warren Cc: Allen Martin; swarren@wwwdotorg.org; sjg@chromium.org; thierry.reding@avionic-design.de; u-boot@lists.denx.de Subject: Re: [PATCH v10 00/16] split tegra20 arm7 code into separate SPL
Hello Tom,
Am Mittwoch, den 29.08.2012, 09:55 -0700 schrieb Tom Warren:
Allen/Albert,
-----Original Message----- From: Allen Martin [mailto:amartin@nvidia.com] Sent: Tuesday, August 28, 2012 5:08 PM To: Tom Warren; swarren@wwwdotorg.org; sjg@chromium.org; thierry.reding@avionic-design.de; dev@lynxeye.de Cc: u-boot@lists.denx.de; Allen Martin Subject: [PATCH v10 00/16] split tegra20 arm7 code into separate SPL
This patch series fixes a long standing problem with the tegra20 u-boot build. Tegra20 contains an ARM7TDMI boot processor and a Cortex A9 main processor. Prior to this patch series this was accomplished by #ifdefing out any armv7 code from the early boot sequence and creating a single binary that runs on both both the ARM7TDMI and A9. This was very fragile as changes to compiler options or any additions or rearranging of the early boot code could add additional armv7 specific code causing it to fail on the ARM7TDMI.
This patch series pulls all the armv4t code out into a separate SPL that does nothing more than initialize the A9 and transfer control to it. The resultint SPL and armv7 u-boot are concatenated together into a single image.
This patch series is also available from: git://github.com/arm000/u-boot.git branch: tegra-spl-v10
Changes: v10:
- added fix to MAKEALL script so that it correctly parses new
boards.cfg
I applied this to u-boot-tegra/master and pushed the new code upstream.
The pull request remains the same (except for the inclusion of the MAKEALL patch, of course). I can send a new one if required - please let me know.
Currently running a ./MAKEALL arm - I assume it'll complete w/o errors
(except for the ohci-hcd.c warnings I mentioned previously that are not due to this patch series).
Are you going to refresh the next branch anytime soon or are you planing on doing this once the master branch is merged to arm/master?
I can refresh u-boot-tegra/next with Allen's V10 SPL patches and re-push it, but if the pull of the SPL code from u-boot-tegra/master is going to go into ARM/master anytime soon, I'd rather wait and just do it one final time.
Albert - any idea of an ETA on pulling u-boot-tegra/master into ARM/master?
If I'm not mistaken, the current u-boot-tegra/master branch has issues with ./MAKEALL arm, not building everything it should. I'd rather not pull it unless Allen's fix is added (or even better, unless the master branch is force-updated to fix the original commit which introduced the issue, if you and Allen are willing to go this far).
I stated above (although not directly to you) that I'd applied Allen's v10 SPL patchset, which includes a MAKEALL arm fix, and pushed to u-boot-tegra/master. I can generate a new pull request if necessary, although the only change will be the addition of the MAKEALL patch. Please let me know if you need a new pull request.
Allen has also done a separate patchset (v2) for MAKEALL to correct some problems it had for both ARM and powerpc with duplicated builds, etc. I don't think it's necessary for Tegra specifically - my run of ./MAKEALL arm on current u-boot-tegra/master completed w/316 boards built, include the tegra20 boards.
Tom
Tom
Thanks, Lucas
Amicalement,
Albert.
On Thu, Aug 30, 2012 at 01:41:02AM -0700, Albert ARIBAUD wrote:
Hi Tom,
On Wed, 29 Aug 2012 14:10:19 -0700, Tom Warren TWarren@nvidia.com wrote:
Lucas,
-----Original Message----- From: Lucas Stach [mailto:dev@lynxeye.de] Sent: Wednesday, August 29, 2012 1:54 PM To: Tom Warren Cc: Allen Martin; swarren@wwwdotorg.org; sjg@chromium.org; thierry.reding@avionic-design.de; u-boot@lists.denx.de Subject: Re: [PATCH v10 00/16] split tegra20 arm7 code into separate SPL
Hello Tom,
Am Mittwoch, den 29.08.2012, 09:55 -0700 schrieb Tom Warren:
Allen/Albert,
-----Original Message----- From: Allen Martin [mailto:amartin@nvidia.com] Sent: Tuesday, August 28, 2012 5:08 PM To: Tom Warren; swarren@wwwdotorg.org; sjg@chromium.org; thierry.reding@avionic-design.de; dev@lynxeye.de Cc: u-boot@lists.denx.de; Allen Martin Subject: [PATCH v10 00/16] split tegra20 arm7 code into separate SPL
This patch series fixes a long standing problem with the tegra20 u-boot build. Tegra20 contains an ARM7TDMI boot processor and a Cortex A9 main processor. Prior to this patch series this was accomplished by #ifdefing out any armv7 code from the early boot sequence and creating a single binary that runs on both both the ARM7TDMI and A9. This was very fragile as changes to compiler options or any additions or rearranging of the early boot code could add additional armv7 specific code causing it to fail on the ARM7TDMI.
This patch series pulls all the armv4t code out into a separate SPL that does nothing more than initialize the A9 and transfer control to it. The resultint SPL and armv7 u-boot are concatenated together into a single image.
This patch series is also available from: git://github.com/arm000/u-boot.git branch: tegra-spl-v10
Changes: v10:
- added fix to MAKEALL script so that it correctly parses new
boards.cfg
I applied this to u-boot-tegra/master and pushed the new code upstream.
The pull request remains the same (except for the inclusion of the MAKEALL patch, of course). I can send a new one if required - please let me know.
Currently running a ./MAKEALL arm - I assume it'll complete w/o errors
(except for the ohci-hcd.c warnings I mentioned previously that are not due to this patch series).
Are you going to refresh the next branch anytime soon or are you planing on doing this once the master branch is merged to arm/master?
I can refresh u-boot-tegra/next with Allen's V10 SPL patches and re-push it, but if the pull of the SPL code from u-boot-tegra/master is going to go into ARM/master anytime soon, I'd rather wait and just do it one final time.
Albert - any idea of an ETA on pulling u-boot-tegra/master into ARM/master?
If I'm not mistaken, the current u-boot-tegra/master branch has issues with ./MAKEALL arm, not building everything it should. I'd rather not pull it unless Allen's fix is added (or even better, unless the master branch is force-updated to fix the original commit which introduced the issue, if you and Allen are willing to go this far).
The issue was introduced in my SPL series with:
"tegra20: enable SPL for tegra20 boards"
In v10 of my SPL series I added:
"MAKEALL: update to work with new boards.cfg syntax"
prior to enabling SPL. Tom already re-applied v10 of the SPL patches to u-boot-tegra/master so you should be able to merge it now and it will be "git bisect" clean with no regressions to MAKEALL.
My other change to MAKEALL will fix the difference between "MAKEALL arm" and "MAKEALL -a arm" and has nothing to do with tegra or the SPL series. Until that gets applied just make sure you use "MAKEALL -a arm" as "MAKEALL arm" is buggy.
-Allen
participants (3)
-
Albert ARIBAUD -
Allen Martin -
Tom Warren