[U-Boot] [PATCH 1/1] board/ls2080ardb: Remove CONFIG_DISPLAY_BOARDINFO_LATE
CONFIG_DISPLAY_BOARDINFO_LATE config is used to delay the prints of boardinfo late in cycle during uboot boot. This feature is not required in case of QSPI_BOOT.
Signed-off-by: Santan Kumar santan.kumar@nxp.com Signed-off-by: Priyanka Jain priyanka.jain@nxp.com --- This patch is split version of another patch https://patchwork.ozlabs.org/patch/779931/
include/configs/ls2080ardb.h | 1 - 1 file changed, 1 deletion(-)
diff --git a/include/configs/ls2080ardb.h b/include/configs/ls2080ardb.h index 9b9a710..a5f7eea 100644 --- a/include/configs/ls2080ardb.h +++ b/include/configs/ls2080ardb.h @@ -18,7 +18,6 @@ #define CONFIG_QIXIS_I2C_ACCESS #endif #define CONFIG_SYS_I2C_EARLY_INIT -#define CONFIG_DISPLAY_BOARDINFO_LATE #endif
#define I2C_MUX_CH_VOL_MONITOR 0xa
As per updated board design, different QSPI flash is connected on boards, hence change QSPI flash type from Micron n25q512a device to spansion s25fs512s device in dts and config.
Signed-off-by: Santan Kumar santan.kumar@nxp.com Signed-off-by: Yogesh Gaur yogeshnarayan.gaur@nxp.com Signed-off-by: Priyanka Jain priyanka.jain@nxp.com --- This patch is split version of another patch https://patchwork.ozlabs.org/patch/779931/
arch/arm/dts/fsl-ls2081a-rdb.dts | 4 ++-- include/configs/ls2080ardb.h | 6 +----- 2 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/arch/arm/dts/fsl-ls2081a-rdb.dts b/arch/arm/dts/fsl-ls2081a-rdb.dts index 6489362..aa4aa68 100644 --- a/arch/arm/dts/fsl-ls2081a-rdb.dts +++ b/arch/arm/dts/fsl-ls2081a-rdb.dts @@ -41,7 +41,7 @@ bus-num = <0>; status = "okay";
- qflash0: n25q512a@0 { + qflash0: s25fs512s@0 { #address-cells = <1>; #size-cells = <1>; compatible = "spi-flash"; @@ -49,7 +49,7 @@ reg = <0>; };
- qflash1: n25q512a@1 { + qflash1: s25fs512s@1 { #address-cells = <1>; #size-cells = <1>; compatible = "spi-flash"; diff --git a/include/configs/ls2080ardb.h b/include/configs/ls2080ardb.h index 2dab065..9b9a710 100644 --- a/include/configs/ls2080ardb.h +++ b/include/configs/ls2080ardb.h @@ -293,19 +293,15 @@ unsigned long get_board_sys_clk(void); /* SPI */ #if defined(CONFIG_FSL_QSPI) || defined(CONFIG_FSL_DSPI) #define CONFIG_SPI_FLASH -#ifdef CONFIG_FSL_QSPI +#ifdef CONFIG_FSL_DSPI #define CONFIG_SPI_FLASH_STMICRO #endif #ifdef CONFIG_FSL_QSPI -#ifdef CONFIG_TARGET_LS2081ARDB -#define CONFIG_SPI_FLASH_STMICRO -#else #define CONFIG_SPI_FLASH_SPANSION #endif #define FSL_QSPI_FLASH_SIZE SZ_64M /* 64MB */ #define FSL_QSPI_FLASH_NUM 2 #endif -#endif
/* * RTC configuration
-----Original Message----- From: U-Boot [mailto:u-boot-bounces@lists.denx.de] On Behalf Of Santan Kumar Sent: Friday, August 18, 2017 3:21 PM To: u-boot@lists.denx.de; York Sun york.sun@nxp.com Cc: Priyanka Jain priyanka.jain@nxp.com Subject: [U-Boot] [PATCH 1/1] board/ls2081ardb: Update QSPI flash type from n25q512a to s25fs512s
As per updated board design, different QSPI flash is connected on boards, hence change QSPI flash type from Micron n25q512a device to spansion s25fs512s device in dts and config.
How backward compatibility with older boards being managed?
--prabhakar
-----Original Message----- From: Prabhakar Kushwaha Sent: Friday, August 18, 2017 3:52 PM To: Santan Kumar santan.kumar@nxp.com; u-boot@lists.denx.de; York Sun york.sun@nxp.com Cc: Priyanka Jain priyanka.jain@nxp.com Subject: RE: [U-Boot] [PATCH 1/1] board/ls2081ardb: Update QSPI flash type from n25q512a to s25fs512s
-----Original Message----- From: U-Boot [mailto:u-boot-bounces@lists.denx.de] On Behalf Of Santan Kumar Sent: Friday, August 18, 2017 3:21 PM To: u-boot@lists.denx.de; York Sun york.sun@nxp.com Cc: Priyanka Jain priyanka.jain@nxp.com Subject: [U-Boot] [PATCH 1/1] board/ls2081ardb: Update QSPI flash type from n25q512a to s25fs512s
As per updated board design, different QSPI flash is connected on boards, hence change QSPI flash type from Micron n25q512a device to spansion s25fs512s device in dts and config.
How backward compatibility with older boards being managed?
--prabhakar
[Santan] All older board are using Spansion flash. Initially Micron flash was planned to place in LS2081ARDB board but at last moment flash was changed.
On 08/18/2017 02:47 AM, Santan Kumar wrote:
As per updated board design, different QSPI flash is connected on boards, hence change QSPI flash type from Micron n25q512a device to spansion s25fs512s device in dts and config.
Signed-off-by: Santan Kumar santan.kumar@nxp.com Signed-off-by: Yogesh Gaur yogeshnarayan.gaur@nxp.com Signed-off-by: Priyanka Jain priyanka.jain@nxp.com
Applied to fsl-qoriq mater. Thanks.
York
This patch modifies checkboard() for below changes: -Remove Board Arch print Arch contains Qixis architecture version This field is more relevant for QDS boards. For RDB boards it is always constant as '1'. -Correct the QMAP information. QMAP controls hows QSPI_A chip-selects are connected to various peripherals. And this information are saved in rightmost three bits. Hence, need to use only these three bits. -Add print to display FPGA information.
Signed-off-by: Santan Kumar santan.kumar@nxp.com Signed-off-by: Priyanka Jain priyanka.jain@nxp.com --- This patch is split version of another patch https://patchwork.ozlabs.org/patch/779931/
board/freescale/ls2080ardb/ls2080ardb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/board/freescale/ls2080ardb/ls2080ardb.c b/board/freescale/ls2080ardb/ls2080ardb.c index 0017f60..bae4b6f 100644 --- a/board/freescale/ls2080ardb/ls2080ardb.c +++ b/board/freescale/ls2080ardb/ls2080ardb.c @@ -71,11 +71,10 @@ int checkboard(void) #ifdef CONFIG_TARGET_LS2081ARDB #ifdef CONFIG_FSL_QIXIS sw = QIXIS_READ(arch); - printf("Board Arch: V%d, ", sw >> 4); printf("Board version: %c, ", (sw & 0xf) + 'A');
sw = QIXIS_READ(brdcfg[0]); - sw = (sw & QIXIS_QMAP_MASK) >> QIXIS_QMAP_SHIFT; + sw = ((sw >> QIXIS_QMAP_SHIFT) & QIXIS_QMAP_MASK); switch (sw) { case 0: puts("boot from QSPI DEV#0\n"); @@ -101,6 +100,7 @@ int checkboard(void) printf("invalid setting of SW%u\n", sw); break; } + printf("FPGA: v%d.%d\n", QIXIS_READ(scver), QIXIS_READ(tagdata)); #endif puts("SERDES1 Reference : "); printf("Clock1 = 100MHz ");
-----Original Message----- From: U-Boot [mailto:u-boot-bounces@lists.denx.de] On Behalf Of Santan Kumar Sent: Friday, August 18, 2017 3:21 PM To: u-boot@lists.denx.de; York Sun york.sun@nxp.com Cc: Priyanka Jain priyanka.jain@nxp.com Subject: [U-Boot] [PATCH 1/1] board/ls2081ardb: Update display information during boot
Can we add more precise subject. It looks to be vague
This patch modifies checkboard() for below changes: -Remove Board Arch print Arch contains Qixis architecture version This field is more relevant for QDS boards. For RDB boards it is always constant as '1'. -Correct the QMAP information. QMAP controls hows QSPI_A chip-selects are connected to various peripherals. And this information are saved in rightmost three bits. Hence, need to use only these three bits. -Add print to display FPGA information.
Please avoid using bulleted description in patch. Try to use sentences.
-prabhakar
On 08/18/2017 03:21 AM, Prabhakar Kushwaha wrote:
-----Original Message----- From: U-Boot [mailto:u-boot-bounces@lists.denx.de] On Behalf Of Santan Kumar Sent: Friday, August 18, 2017 3:21 PM To: u-boot@lists.denx.de; York Sun york.sun@nxp.com Cc: Priyanka Jain priyanka.jain@nxp.com Subject: [U-Boot] [PATCH 1/1] board/ls2081ardb: Update display information during boot
Can we add more precise subject. It looks to be vague
This patch modifies checkboard() for below changes: -Remove Board Arch print Arch contains Qixis architecture version This field is more relevant for QDS boards. For RDB boards it is always constant as '1'. -Correct the QMAP information. QMAP controls hows QSPI_A chip-selects are connected to various peripherals. And this information are saved in rightmost three bits. Hence, need to use only these three bits. -Add print to display FPGA information.
Please avoid using bulleted description in patch. Try to use sentences.
Santa,
Please update this patch as discussed.
York
-----Original Message----- From: U-Boot [mailto:u-boot-bounces@lists.denx.de] On Behalf Of Santan Kumar Sent: Friday, August 18, 2017 3:21 PM To: u-boot@lists.denx.de; York Sun york.sun@nxp.com Cc: Priyanka Jain priyanka.jain@nxp.com Subject: [U-Boot] [PATCH 1/1] board/ls2080ardb: Remove CONFIG_DISPLAY_BOARDINFO_LATE
CONFIG_DISPLAY_BOARDINFO_LATE config is used to delay the prints of boardinfo late in cycle during uboot boot. This feature is not required in case of QSPI_BOOT.
Signed-off-by: Santan Kumar santan.kumar@nxp.com Signed-off-by: Priyanka Jain priyanka.jain@nxp.com
Reviewed-by : Prabhakar Kushwaha prabhakar.kushwaha@nxp.com
-----Original Message----- From: U-Boot [mailto:u-boot-bounces@lists.denx.de] On Behalf Of Prabhakar Kushwaha Sent: Friday, August 18, 2017 3:53 PM To: Santan Kumar santan.kumar@nxp.com; u-boot@lists.denx.de; York Sun york.sun@nxp.com Cc: Priyanka Jain priyanka.jain@nxp.com Subject: Re: [U-Boot] [PATCH 1/1] board/ls2080ardb: Remove CONFIG_DISPLAY_BOARDINFO_LATE
-----Original Message----- From: U-Boot [mailto:u-boot-bounces@lists.denx.de] On Behalf Of Santan Kumar Sent: Friday, August 18, 2017 3:21 PM To: u-boot@lists.denx.de; York Sun york.sun@nxp.com Cc: Priyanka Jain priyanka.jain@nxp.com Subject: [U-Boot] [PATCH 1/1] board/ls2080ardb: Remove CONFIG_DISPLAY_BOARDINFO_LATE
CONFIG_DISPLAY_BOARDINFO_LATE config is used to delay the prints of boardinfo late in cycle during uboot boot. This feature is not required in case of QSPI_BOOT.
I am not aware of the history of the change, but the patch description does not sufficiently describe why this change has been done. Why in case of QSPI Boot BOARD information is not required to be printed late.
Signed-off-by: Santan Kumar santan.kumar@nxp.com Signed-off-by: Priyanka Jain priyanka.jain@nxp.com
Reviewed-by : Prabhakar Kushwaha prabhakar.kushwaha@nxp.com _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
-----Original Message----- From: Poonam Aggrwal Sent: Friday, August 18, 2017 4:17 PM To: Prabhakar Kushwaha prabhakar.kushwaha@nxp.com; Santan Kumar santan.kumar@nxp.com; u-boot@lists.denx.de; York Sun york.sun@nxp.com Cc: Priyanka Jain priyanka.jain@nxp.com Subject: RE: [U-Boot] [PATCH 1/1] board/ls2080ardb: Remove CONFIG_DISPLAY_BOARDINFO_LATE
-----Original Message----- From: U-Boot [mailto:u-boot-bounces@lists.denx.de] On Behalf Of Prabhakar Kushwaha Sent: Friday, August 18, 2017 3:53 PM To: Santan Kumar santan.kumar@nxp.com; u-boot@lists.denx.de; York Sun york.sun@nxp.com Cc: Priyanka Jain priyanka.jain@nxp.com Subject: Re: [U-Boot] [PATCH 1/1] board/ls2080ardb: Remove CONFIG_DISPLAY_BOARDINFO_LATE
-----Original Message----- From: U-Boot [mailto:u-boot-bounces@lists.denx.de] On Behalf Of Santan Kumar Sent: Friday, August 18, 2017 3:21 PM To: u-boot@lists.denx.de; York Sun york.sun@nxp.com Cc: Priyanka Jain priyanka.jain@nxp.com Subject: [U-Boot] [PATCH 1/1] board/ls2080ardb: Remove CONFIG_DISPLAY_BOARDINFO_LATE
CONFIG_DISPLAY_BOARDINFO_LATE config is used to delay the prints of boardinfo late in cycle during uboot boot. This feature is not required in case of QSPI_BOOT.
I am not aware of the history of the change, but the patch description does not sufficiently describe why this change has been done. Why in case of QSPI Boot BOARD information is not required to be printed late.
[Santan] We can use any of one flag CONFIG_DISPLAY_BOARDINFO_LATE or CONFIG_DISPLAY_BOARDINFO to display board info during boot. Since we are using CONFIG_DISPLAY_BOARDINFO in case of QSPI boot that's why this flag is removed. In some specific cases in which information was not ready at start we can should use CONFIG_DISPLAY_BOARDINFO_LATE.
Signed-off-by: Santan Kumar santan.kumar@nxp.com Signed-off-by: Priyanka Jain priyanka.jain@nxp.com
Reviewed-by : Prabhakar Kushwaha prabhakar.kushwaha@nxp.com _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
On 08/18/2017 02:47 AM, Santan Kumar wrote:
CONFIG_DISPLAY_BOARDINFO_LATE config is used to delay the prints of boardinfo late in cycle during uboot boot. This feature is not required in case of QSPI_BOOT.
Signed-off-by: Santan Kumar santan.kumar@nxp.com Signed-off-by: Priyanka Jain priyanka.jain@nxp.com
Applied to fsl-qoriq mater. Thanks.
York
participants (4)
-
Poonam Aggrwal -
Prabhakar Kushwaha -
Santan Kumar -
York Sun