On 20. 04. 20 1:02, Simon Glass wrote:

At present if buildman reports an error, the travis build still succeeds.

This is because the travis script does not stop when it sees errors; nor does it automatically return the exit code. Also the current error checking never triggers since 'ret' is not set.

Fix this by setting 'ret' correctly.

Signed-off-by: Simon Glass sjg@chromium.org Reported-by: Michal Simek michal.simek@xilinx.com

---

Changes in v2:

• Fix missing ret=0

.travis.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/.travis.yml b/.travis.yml index b3253da13c..1dbc63cadf 100644 --- a/.travis.yml +++ b/.travis.yml @@ -208,7 +208,8 @@ script: # # Build a selection of boards if TEST_PY_BD is empty

• if [[ "${BUILDMAN}" != "" ]]; then

• tools/buildman/buildman -P -E -W ${BUILDMAN} ${OVERRIDE};
  

• ret=0
  

• tools/buildman/buildman -P -E -W ${BUILDMAN} ${OVERRIDE} || ret=$?;
  if [[ $ret -ne 0 ]]; then
    tools/buildman/buildman -seP ${BUILDMAN};
    exit $ret;
  
  

Acked-by: Michal Simek michal.simek@xilinx.com

Thanks, Michal