[U-Boot] [PATCH 1/1] evb-rk3399: avoid redefinition of CONFIG_ENV_OFFSET
CONFIG_ENV_OFFSET is already defined in include/configs/rockchip-common.h
For CONFIG_ROCKCHIP_BACK_TO_BROM=y we redefine CONFIG_ENV_OFFSET to an unsuitable value. We were lucky to get a compiler warning.
Remove the incorrect redefinition.
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de --- include/configs/evb_rk3399.h | 6 ------ 1 file changed, 6 deletions(-)
diff --git a/include/configs/evb_rk3399.h b/include/configs/evb_rk3399.h index 015f25a774..66ead6c117 100644 --- a/include/configs/evb_rk3399.h +++ b/include/configs/evb_rk3399.h @@ -10,12 +10,6 @@ #include <configs/rk3399_common.h>
#define CONFIG_SYS_MMC_ENV_DEV 1 -/* - * SPL @ 32k for ~36k - * ENV @ 96k - * u-boot @ 128K - */ -#define CONFIG_ENV_OFFSET (96 * 1024)
#define SDRAM_BANK_SIZE (2UL << 30)
CONFIG_ENV_OFFSET is already defined in include/configs/rockchip-common.h
For CONFIG_ROCKCHIP_BACK_TO_BROM=y we redefine CONFIG_ENV_OFFSET to an unsuitable value. We were lucky to get a compiler warning.
Remove the incorrect redefinition.
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de
include/configs/evb_rk3399.h | 6 ------ 1 file changed, 6 deletions(-)
Acked-by: Philipp Tomsich philipp.tomsich@theobroma-systems.com
CONFIG_ENV_OFFSET is already defined in include/configs/rockchip-common.h
For CONFIG_ROCKCHIP_BACK_TO_BROM=y we redefine CONFIG_ENV_OFFSET to an unsuitable value. We were lucky to get a compiler warning.
Remove the incorrect redefinition.
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de
include/configs/evb_rk3399.h | 6 ------ 1 file changed, 6 deletions(-)
Reviewed-by: Philipp Tomsich philipp.tomsich@theobroma-systems.com
CONFIG_ENV_OFFSET is already defined in include/configs/rockchip-common.h
For CONFIG_ROCKCHIP_BACK_TO_BROM=y we redefine CONFIG_ENV_OFFSET to an unsuitable value. We were lucky to get a compiler warning.
Remove the incorrect redefinition.
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de Acked-by: Philipp Tomsich philipp.tomsich@theobroma-systems.com Reviewed-by: Philipp Tomsich philipp.tomsich@theobroma-systems.com
include/configs/evb_rk3399.h | 6 ------ 1 file changed, 6 deletions(-)
Applied to u-boot-rockchip, thanks!
participants (2)
-
Heinrich Schuchardt -
Philipp Tomsich