On 05/27/2011 02:40 PM, Fabio Estevam wrote:

Hi Stefano,

Does this patch series look fine now?

Hi Fabio,

I see some warnings that must be dropped before putting your patches into the mainline:

Configuring for mx53ard - Board: mx53ard, Options: IMX_CONFIG=board/freescale/mx53ard/imximage_dd3.cfg soc.c: In function 'set_chipselect_size': soc.c:169: warning: initialization from incompatible pointer type

In fact:

struct iomuxc *iomuxc_regs = (struct weim *)IOMUXC_BASE_ADDR; ^-- this should be struct iomuxc

mx53ard.c:176: warning: function declaration isn't a prototype mx53ard.c:259: warning: function declaration isn't a prototype

due to static void weim_smc911x_iomux() instead of static void weim_smc911x_iomux(void).

Can you fix them ?

Best regards, Stefano Babic